42303 2010-07-14 16:46:11 -0700 Backfill DNS and connect times rather than exposing hard zeros 2010-07-15 08:16:13 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 30685 1 tonyg tonyg fishd pfeldman oldest_to_newest 251515 0 tonyg 2010-07-14 16:46:11 -0700 Backfill DNS and connect times rather than exposing hard zeros 251524 1 61583 tonyg 2010-07-14 17:04:21 -0700 Created attachment 61583 Patch 251704 2 61583 fishd 2010-07-14 23:50:34 -0700 Comment on attachment 61583 Patch WebCore/page/Timing.cpp:58 + static unsigned long long toIntegerMilliseconds(double milliseconds) nit: move to the top of the file so that the Timing methods are not interrupted by a non-Timing method. it isn't a real readability issue now, but once you add an interrupt like this, someone will add more, and pretty soon you'll get half of your class implemented in one section of the file and the other half in another :( R=me 251896 3 tonyg 2010-07-15 08:13:36 -0700 (In reply to comment #2) > (From update of attachment 61583 [details]) > WebCore/page/Timing.cpp:58 > + static unsigned long long toIntegerMilliseconds(double milliseconds) > nit: move to the top of the file so that the Timing methods are not interrupted > by a non-Timing method. it isn't a real readability issue now, but once you > add an interrupt like this, someone will add more, and pretty soon you'll get > half of your class implemented in one section of the file and the other half > in another :( > Make sense. Done. > > R=me 251897 4 tonyg 2010-07-15 08:16:13 -0700 Committed r63426: <http://trac.webkit.org/changeset/63426> 61583 2010-07-14 17:04:21 -0700 2010-07-14 23:50:34 -0700 Patch bug-42303-20100714170419.patch text/plain 6602 tonyg ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YTc0MTQwYzg5OTYwNTBhNTNlNWRiNjZlNjdiMThhZDk1OTdlYjVlNi4uYjI2MTg3MThiZWM2MjMz NWVhZDM3NzliZGE3MTcxMjZlMGI5NGQ0YSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyNyBAQAorMjAxMC0wNy0xNCAgVG9u eSBHZW50aWxjb3JlICA8dG9ueWdAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEJhY2tmaWxsIEROUyBhbmQgY29ubmVjdCB0aW1l cyByYXRoZXIgdGhhbiBleHBvc2luZyBoYXJkIHplcm9zCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MjMwMworCisgICAgICAgIFRoZXJlIGFyZSBzZXZl cmFsIGNhc2VzIHdoZXJlIGRvbWFpbiBsb29rdXAgaXMgbm90IHBlcmZvcm1lZCBhbmQvb3IgYSBu ZXcgY29ubmVjdGlvbiBpcyBub3QgZXN0YWJsaXNoZWQuIFByZXZpb3VzbHkgaW4gdGhlc2UgY2Fz ZXMsIHdlIGV4cG9zZWQgYSAiMCIgdG8gdGhlIEFQSS4gTm93LCB3ZSBpbnN0ZWFkICJiYWNrZmls bCIgd2l0aCB0aGUgbW9zdCByZWNlbnQgbWFyaydzIHRpbWUuCisKKyAgICAgICAgQWxzbywgcHJl dmlvdXNseSwgSSB3YXMgdXNpbmcgdGhlIFJlc291cmNlTG9hZFRpbWluZyBBUEkgaW5jb3JyZWN0 bHkuIEVhY2ggbWFyayBpcyBhbiBpbnRlZ2VyIHJlcHJlc2VudGluZyBvZmZzZXQgaW4gbWlsbGlz ZWNvbmRzIGZyb20gcmVxdWVzdFRpbWUuIFNvIGFsbCB2YWx1ZXMgbmVlZCB0byBiZSBhZGRlZCB0 byByZXF1ZXN0VGltZS4KKworICAgICAgICBObyBuZXcgdGVzdCBiZWNhdXNlIGV4aXN0aW5nIHRl c3QgZXhwZWN0YXRpb25zIGFyZSBzZXQgdG8gRkFJTCBiZWNhdXNlIGRpc2FibGUgZGlzYWJsZWQg YnkgZGVmYXVsdC4gVGhlIGV4cGVjdGVkIHJlc3VsdHMgb2YgZXhpc3RpbmdzIHRlc3RzIGNoYW5n ZSBhcyBleHBlY3RlZCB3aGVuIGVuYWJsZWQuCisKKyAgICAgICAgKiBwYWdlL1RpbWluZy5jcHA6 CisgICAgICAgIChXZWJDb3JlOjp0b0ludGVnZXJNaWxsaXNlY29uZHMpOiBNb3ZlIHRvIGZpbGUg c3RhdGljIGluc3RlYWQgb2YgY2xhc3Mgc3RhdGljIGJlY2F1c2UgaXQgbWlnaHQgZ2VuZXJhdGUg bW9yZSBvcHRpbWFsIGNvZGUuIEFsc28sIGluc3RlYWQgb2YgY29udmVydGluZyBuZWdhdGl2ZSBk b3VibGVzIHRvIHplcm8sIEFTU0VSVCB0aGF0IHRoZXkgYXJlID49IDAuIFRoaXMgaXMgYmVjYXVz ZSB3ZSBubyBsb25nZXIgZXhwb3NlIGhhcmQgemVyb3MgZm9yIEROUyBhbmQgY29ubmVjdCwgc28g d2Ugd2FudCB0byBiZSBzdXJlIHRoYXQgdGhlIC0xcyByZXR1cm5lZCBieSB0aGUgQVBJIGFyZSBw cm9wZXJseSBoYW5kbGVkLgorICAgICAgICAoV2ViQ29yZTo6VGltaW5nOjpkb21haW5Mb29rdXBT dGFydCk6CisgICAgICAgIChXZWJDb3JlOjpUaW1pbmc6OmRvbWFpbkxvb2t1cEVuZCk6CisgICAg ICAgIChXZWJDb3JlOjpUaW1pbmc6OmNvbm5lY3RTdGFydCk6CisgICAgICAgIChXZWJDb3JlOjpU aW1pbmc6OmNvbm5lY3RFbmQpOgorICAgICAgICAoV2ViQ29yZTo6VGltaW5nOjpyZXF1ZXN0U3Rh cnQpOgorICAgICAgICAoV2ViQ29yZTo6VGltaW5nOjpyZXF1ZXN0RW5kKToKKyAgICAgICAgKFdl YkNvcmU6OlRpbWluZzo6cmVzcG9uc2VTdGFydCk6CisgICAgICAgICogcGFnZS9UaW1pbmcuaDoK KwogMjAxMC0wNy0xNCAgU2FtIFdlaW5pZyAgPHNhbUB3ZWJraXQub3JnPgogCiAgICAgICAgIFJl dmlld2VkIGJ5IEJyYWR5IEVpZHNvbi4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGFnZS9UaW1pbmcu Y3BwIGIvV2ViQ29yZS9wYWdlL1RpbWluZy5jcHAKaW5kZXggNTRhNGNjOWE3ZTQyODg0MzUxYjVl MTAwOWQ2ZDZjMzcxYzAxYjE0Zi4uYzM2YTE2OTNjNGZhZDY3YTQ4MGJkYzBiYzUzNjRjMjIxMWEw ZjExZSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wYWdlL1RpbWluZy5jcHAKKysrIGIvV2ViQ29yZS9w YWdlL1RpbWluZy5jcHAKQEAgLTU1LDYgKzU1LDEyIEBAIHZvaWQgVGltaW5nOjpkaXNjb25uZWN0 RnJhbWUoKQogICAgIG1fZnJhbWUgPSAwOwogfQogCitzdGF0aWMgdW5zaWduZWQgbG9uZyBsb25n IHRvSW50ZWdlck1pbGxpc2Vjb25kcyhkb3VibGUgbWlsbGlzZWNvbmRzKQoreworICAgIEFTU0VS VChtaWxsaXNlY29uZHMgPj0gMCk7CisgICAgcmV0dXJuIHN0YXRpY19jYXN0PHVuc2lnbmVkIGxv bmcgbG9uZz4obWlsbGlzZWNvbmRzICogMTAwMC4wKTsKK30KKwogdW5zaWduZWQgbG9uZyBsb25n IFRpbWluZzo6bmF2aWdhdGlvblN0YXJ0KCkgY29uc3QKIHsKICAgICBpZiAoIW1fZnJhbWUpCkBA IC0xMDEsNyArMTA3LDEzIEBAIHVuc2lnbmVkIGxvbmcgbG9uZyBUaW1pbmc6OmRvbWFpbkxvb2t1 cFN0YXJ0KCkgY29uc3QKICAgICBpZiAoIXRpbWluZykKICAgICAgICAgcmV0dXJuIDA7CiAKLSAg ICByZXR1cm4gdG9JbnRlZ2VyTWlsbGlzZWNvbmRzKHRpbWluZy0+ZG5zU3RhcnQpOworICAgIC8v IFRoaXMgd2lsbCBiZSAtMSB3aGVuIGEgRE5TIHJlcXVlc3QgaXMgbm90IHBlcmZvcm1lZC4KKyAg ICAvLyBSYXRoZXIgdGhhbiBleHBvc2luZyBhIHNwZWNpYWwgdmFsdWUgdGhhdCBpbmRpY2F0ZXMg bm8gRE5TLCB3ZSAiYmFja2ZpbGwiIHdpdGggZmV0Y2hTdGFydC4KKyAgICBpbnQgZG5zU3RhcnQg PSB0aW1pbmctPmRuc1N0YXJ0OworICAgIGlmIChkbnNTdGFydCA8IDApCisgICAgICAgIHJldHVy biBmZXRjaFN0YXJ0KCk7CisKKyAgICByZXR1cm4gdG9JbnRlZ2VyTWlsbGlzZWNvbmRzKHRpbWlu Zy0+cmVxdWVzdFRpbWUgKyBkbnNTdGFydCk7CiB9CiAKIHVuc2lnbmVkIGxvbmcgbG9uZyBUaW1p bmc6OmRvbWFpbkxvb2t1cEVuZCgpIGNvbnN0CkBAIC0xMTAsNyArMTIyLDEzIEBAIHVuc2lnbmVk IGxvbmcgbG9uZyBUaW1pbmc6OmRvbWFpbkxvb2t1cEVuZCgpIGNvbnN0CiAgICAgaWYgKCF0aW1p bmcpCiAgICAgICAgIHJldHVybiAwOwogCi0gICAgcmV0dXJuIHRvSW50ZWdlck1pbGxpc2Vjb25k cyh0aW1pbmctPmRuc0VuZCk7CisgICAgLy8gVGhpcyB3aWxsIGJlIC0xIHdoZW4gYSBETlMgcmVx dWVzdCBpcyBub3QgcGVyZm9ybWVkLgorICAgIC8vIFJhdGhlciB0aGFuIGV4cG9zaW5nIGEgc3Bl Y2lhbCB2YWx1ZSB0aGF0IGluZGljYXRlcyBubyBETlMsIHdlICJiYWNrZmlsbCIgd2l0aCBkb21h aW5Mb29rdXBTdGFydC4KKyAgICBpbnQgZG5zRW5kID0gdGltaW5nLT5kbnNFbmQ7CisgICAgaWYg KGRuc0VuZCA8IDApCisgICAgICAgIHJldHVybiBkb21haW5Mb29rdXBTdGFydCgpOworCisgICAg cmV0dXJuIHRvSW50ZWdlck1pbGxpc2Vjb25kcyh0aW1pbmctPnJlcXVlc3RUaW1lICsgZG5zRW5k KTsKIH0KIAogdW5zaWduZWQgbG9uZyBsb25nIFRpbWluZzo6Y29ubmVjdFN0YXJ0KCkgY29uc3QK QEAgLTExOSw3ICsxMzcsMTMgQEAgdW5zaWduZWQgbG9uZyBsb25nIFRpbWluZzo6Y29ubmVjdFN0 YXJ0KCkgY29uc3QKICAgICBpZiAoIXRpbWluZykKICAgICAgICAgcmV0dXJuIDA7CiAKLSAgICBy ZXR1cm4gdG9JbnRlZ2VyTWlsbGlzZWNvbmRzKHRpbWluZy0+Y29ubmVjdFN0YXJ0KTsKKyAgICAv LyBUaGlzIHdpbGwgYmUgLTEgd2hlbiBhIG5ldyBjb25uZWN0aW9uIGlzIG5vdCBlc3RhYmxpc2hl ZC4KKyAgICAvLyBSYXRoZXIgdGhhbiBleHBvc2luZyBhIHNwZWNpYWwgdmFsdWUgdGhhdCBpbmRp Y2F0ZXMgbm8gbmV3IGNvbm5lY3Rpb24sIHdlICJiYWNrZmlsbCIgd2l0aCBkb21haW5Mb29rdXBF bmQuCisgICAgaW50IGNvbm5lY3RTdGFydCA9IHRpbWluZy0+Y29ubmVjdFN0YXJ0OworICAgIGlm IChjb25uZWN0U3RhcnQgPCAwKQorICAgICAgICByZXR1cm4gZG9tYWluTG9va3VwRW5kKCk7CisK KyAgICByZXR1cm4gdG9JbnRlZ2VyTWlsbGlzZWNvbmRzKHRpbWluZy0+cmVxdWVzdFRpbWUgKyBj b25uZWN0U3RhcnQpOwogfQogCiB1bnNpZ25lZCBsb25nIGxvbmcgVGltaW5nOjpjb25uZWN0RW5k KCkgY29uc3QKQEAgLTEyOCw3ICsxNTIsMTMgQEAgdW5zaWduZWQgbG9uZyBsb25nIFRpbWluZzo6 Y29ubmVjdEVuZCgpIGNvbnN0CiAgICAgaWYgKCF0aW1pbmcpCiAgICAgICAgIHJldHVybiAwOwog Ci0gICAgcmV0dXJuIHRvSW50ZWdlck1pbGxpc2Vjb25kcyh0aW1pbmctPmNvbm5lY3RFbmQpOwor ICAgIC8vIFRoaXMgd2lsbCBiZSAtMSB3aGVuIGEgbmV3IGNvbm5lY3Rpb24gaXMgbm90IGVzdGFi bGlzaGVkLgorICAgIC8vIFJhdGhlciB0aGFuIGV4cG9zaW5nIGEgc3BlY2lhbCB2YWx1ZSB0aGF0 IGluZGljYXRlcyBubyBuZXcgY29ubmVjdGlvbiwgd2UgImJhY2tmaWxsIiB3aXRoIGNvbm5lY3RT dGFydC4KKyAgICBpbnQgY29ubmVjdEVuZCA9IHRpbWluZy0+Y29ubmVjdEVuZDsKKyAgICBpZiAo Y29ubmVjdEVuZCA8IDApCisgICAgICAgIHJldHVybiBjb25uZWN0U3RhcnQoKTsKKworICAgIHJl dHVybiB0b0ludGVnZXJNaWxsaXNlY29uZHModGltaW5nLT5yZXF1ZXN0VGltZSArIGNvbm5lY3RF bmQpOwogfQogCiB1bnNpZ25lZCBsb25nIGxvbmcgVGltaW5nOjpyZXF1ZXN0U3RhcnQoKSBjb25z dApAQCAtMTM3LDcgKzE2Nyw4IEBAIHVuc2lnbmVkIGxvbmcgbG9uZyBUaW1pbmc6OnJlcXVlc3RT dGFydCgpIGNvbnN0CiAgICAgaWYgKCF0aW1pbmcpCiAgICAgICAgIHJldHVybiAwOwogCi0gICAg cmV0dXJuIHRvSW50ZWdlck1pbGxpc2Vjb25kcyh0aW1pbmctPnNlbmRTdGFydCk7CisgICAgQVNT RVJUKHRpbWluZy0+c2VuZFN0YXJ0ID49IDApOworICAgIHJldHVybiB0b0ludGVnZXJNaWxsaXNl Y29uZHModGltaW5nLT5yZXF1ZXN0VGltZSArIHRpbWluZy0+c2VuZFN0YXJ0KTsKIH0KIAogdW5z aWduZWQgbG9uZyBsb25nIFRpbWluZzo6cmVxdWVzdEVuZCgpIGNvbnN0CkBAIC0xNDYsNyArMTc3 LDggQEAgdW5zaWduZWQgbG9uZyBsb25nIFRpbWluZzo6cmVxdWVzdEVuZCgpIGNvbnN0CiAgICAg aWYgKCF0aW1pbmcpCiAgICAgICAgIHJldHVybiAwOwogCi0gICAgcmV0dXJuIHRvSW50ZWdlck1p bGxpc2Vjb25kcyh0aW1pbmctPnNlbmRFbmQpOworICAgIEFTU0VSVCh0aW1pbmctPnNlbmRFbmQg Pj0gMCk7CisgICAgcmV0dXJuIHRvSW50ZWdlck1pbGxpc2Vjb25kcyh0aW1pbmctPnJlcXVlc3RU aW1lICsgdGltaW5nLT5zZW5kRW5kKTsKIH0KIAogdW5zaWduZWQgbG9uZyBsb25nIFRpbWluZzo6 cmVzcG9uc2VTdGFydCgpIGNvbnN0CkBAIC0xNjEsNyArMTkzLDggQEAgdW5zaWduZWQgbG9uZyBs b25nIFRpbWluZzo6cmVzcG9uc2VTdGFydCgpIGNvbnN0CiAgICAgLy8gc2l6ZWQgY29va2llcywg dGhlIEhUVFAgaGVhZGVycyBmaXQgaW50byBhIHNpbmdsZSBwYWNrZXQgc28gdGhpcyB0aW1lCiAg ICAgLy8gaXMgYmFzaWNhbGx5IGVxdWl2YWxlbnQuIEJ1dCBmb3Igc29tZSByZXNwb25zZXMsIHBh cnRpY3VsYXJseSB0aG9zZSB3aXRoCiAgICAgLy8gaGVhZGVycyBsYXJnZXIgdGhhbiBhIHNpbmds ZSBwYWNrZXQsIHRoaXMgdGltZSB3aWxsIGJlIHRvbyBsYXRlLgotICAgIHJldHVybiB0b0ludGVn ZXJNaWxsaXNlY29uZHModGltaW5nLT5yZWNlaXZlSGVhZGVyc0VuZCk7CisgICAgQVNTRVJUKHRp bWluZy0+cmVjZWl2ZUhlYWRlcnNFbmQgPj0gMCk7CisgICAgcmV0dXJuIHRvSW50ZWdlck1pbGxp c2Vjb25kcyh0aW1pbmctPnJlcXVlc3RUaW1lICsgdGltaW5nLT5yZWNlaXZlSGVhZGVyc0VuZCk7 CiB9CiAKIHVuc2lnbmVkIGxvbmcgbG9uZyBUaW1pbmc6OnJlc3BvbnNlRW5kKCkgY29uc3QKQEAg LTE5NywxMyArMjMwLDYgQEAgUmVzb3VyY2VMb2FkVGltaW5nKiBUaW1pbmc6OnJlc291cmNlTG9h ZFRpbWluZygpIGNvbnN0CiAgICAgcmV0dXJuIGRvY3VtZW50TG9hZGVyLT5yZXNwb25zZSgpLnJl c291cmNlTG9hZFRpbWluZygpOwogfQogCi11bnNpZ25lZCBsb25nIGxvbmcgVGltaW5nOjp0b0lu dGVnZXJNaWxsaXNlY29uZHMoZG91YmxlIG1pbGxpc2Vjb25kcykKLXsKLSAgICBpZiAobWlsbGlz ZWNvbmRzIDw9IDApCi0gICAgICAgIHJldHVybiAwOwotICAgIHJldHVybiBzdGF0aWNfY2FzdDx1 bnNpZ25lZCBsb25nIGxvbmc+KG1pbGxpc2Vjb25kcyAqIDEwMDAuMCk7Ci19Ci0KIH0gLy8gbmFt ZXNwYWNlIFdlYkNvcmUKIAogI2VuZGlmIC8vIEVOQUJMRShXRUJfVElNSU5HKQpkaWZmIC0tZ2l0 IGEvV2ViQ29yZS9wYWdlL1RpbWluZy5oIGIvV2ViQ29yZS9wYWdlL1RpbWluZy5oCmluZGV4IDkz YTM4MDRhNzdkZmU3ODViNjJlZWRhOTBmZWIyNzA2MDllNmJmZTQuLmVhZWE2MzM3NWJmZDUxNDVi NWNlMTEwYTE5NzZiMjA4MmMwZjM5NmIgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGFnZS9UaW1pbmcu aAorKysgYi9XZWJDb3JlL3BhZ2UvVGltaW5nLmgKQEAgLTY5LDggKzY5LDYgQEAgcHJpdmF0ZToK IAogICAgIFJlc291cmNlTG9hZFRpbWluZyogcmVzb3VyY2VMb2FkVGltaW5nKCkgY29uc3Q7CiAK LSAgICBzdGF0aWMgdW5zaWduZWQgbG9uZyBsb25nIHRvSW50ZWdlck1pbGxpc2Vjb25kcyhkb3Vi bGUgbWlsbGlzZWNvbmRzKTsKLQogICAgIEZyYW1lKiBtX2ZyYW1lOwogfTsKIAo=