42300 2010-07-14 16:05:04 -0700 Canvas: Don't add shadow rect to dirty region when shadow alpha is 0 2010-07-14 16:28:16 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED Performance P2 Normal --- 1 kling webkit-unassigned oliver oldest_to_newest 251491 0 kling 2010-07-14 16:05:04 -0700 CanvasRenderingContext2D::willDraw() will always add the current shadow rect to the dirty region. We can skip this if the current shadow color has a zero alpha value. 251494 1 61578 kling 2010-07-14 16:06:14 -0700 Created attachment 61578 Proposed patch 251500 2 61578 darin 2010-07-14 16:14:27 -0700 Comment on attachment 61578 Proposed patch It’s unfortunate we have to construct a Color just to check the alpha channel. That’s going to cost some actual instructions and CPU time. Maybe we should have more functions that operate directly on RGBA32 values. 251503 3 kling 2010-07-14 16:25:22 -0700 (In reply to comment #2) > (From update of attachment 61578 [details]) > It’s unfortunate we have to construct a Color just to check the alpha channel. That’s going to cost some actual instructions and CPU time. Maybe we should have more functions that operate directly on RGBA32 values. Agreed. Coming soon in a separate patch. 251505 4 61578 kling 2010-07-14 16:28:06 -0700 Comment on attachment 61578 Proposed patch Clearing flags on attachment: 61578 Committed r63370: <http://trac.webkit.org/changeset/63370> 251506 5 kling 2010-07-14 16:28:16 -0700 All reviewed patches have been landed. Closing bug. 61578 2010-07-14 16:06:14 -0700 2010-07-14 16:28:06 -0700 Proposed patch bug-42300.diff text/plain 1254 kling ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YzlmNmMzMS4uODk2NGQwYiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0wNy0xNCAgQW5kcmVhcyBLbGlu ZyAgPGFuZHJlYXMua2xpbmdAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIENhbnZhczogRG9uJ3QgYWRkIHNoYWRvdyByZWN0IHRvIGRp cnR5IHJlZ2lvbiB3aGVuIHNoYWRvdyBhbHBoYSBpcyAwCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MjMwMAorCisgICAgICAgICogaHRtbC9jYW52YXMv Q2FudmFzUmVuZGVyaW5nQ29udGV4dDJELmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNhbnZhc1Jl bmRlcmluZ0NvbnRleHQyRDo6d2lsbERyYXcpOgorCiAyMDEwLTA3LTE0ICBEYXJpbiBBZGxlciAg PGRhcmluQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBTYW0gV2VpbmlnLgpkaWZm IC0tZ2l0IGEvV2ViQ29yZS9odG1sL2NhbnZhcy9DYW52YXNSZW5kZXJpbmdDb250ZXh0MkQuY3Bw IGIvV2ViQ29yZS9odG1sL2NhbnZhcy9DYW52YXNSZW5kZXJpbmdDb250ZXh0MkQuY3BwCmluZGV4 IDQ1MWRjNjIuLjk3NDhmZjUgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvaHRtbC9jYW52YXMvQ2FudmFz UmVuZGVyaW5nQ29udGV4dDJELmNwcAorKysgYi9XZWJDb3JlL2h0bWwvY2FudmFzL0NhbnZhc1Jl bmRlcmluZ0NvbnRleHQyRC5jcHAKQEAgLTEzNzUsNyArMTM3NSw3IEBAIHZvaWQgQ2FudmFzUmVu ZGVyaW5nQ29udGV4dDJEOjp3aWxsRHJhdyhjb25zdCBGbG9hdFJlY3QmIHIsIHVuc2lnbmVkIG9w dGlvbnMpCiAgICAgICAgIGRpcnR5UmVjdCA9IGN0bS5tYXBSZWN0KHIpOwogICAgIH0KICAgICAK LSAgICBpZiAob3B0aW9ucyAmIENhbnZhc1dpbGxEcmF3QXBwbHlTaGFkb3cpIHsKKyAgICBpZiAo b3B0aW9ucyAmIENhbnZhc1dpbGxEcmF3QXBwbHlTaGFkb3cgJiYgQ29sb3Ioc3RhdGUoKS5tX3No YWRvd0NvbG9yKS5hbHBoYSgpKSB7CiAgICAgICAgIC8vIFRoZSBzaGFkb3cgZ2V0cyBhcHBsaWVk IGFmdGVyIHRyYW5zZm9ybWF0aW9uCiAgICAgICAgIEZsb2F0UmVjdCBzaGFkb3dSZWN0KGRpcnR5 UmVjdCk7CiAgICAgICAgIHNoYWRvd1JlY3QubW92ZShzdGF0ZSgpLm1fc2hhZG93T2Zmc2V0KTsK