42290 2010-07-14 14:30:11 -0700 html5lib/runner.html fails after http://trac.webkit.org/changeset/63338/ 2010-08-10 22:28:09 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 ojan ojan abarth eric levin pkasting oldest_to_newest 251429 0 ojan 2010-07-14 14:30:11 -0700 html5lib/runner.html fails after http://trac.webkit.org/changeset/63338/ 251436 1 61569 ojan 2010-07-14 14:42:17 -0700 Created attachment 61569 Patch 251441 2 61569 abarth 2010-07-14 14:56:48 -0700 Comment on attachment 61569 Patch Sigh. Why are these different???? + * platform/chromium-mac/html5lib/runner-expected.txt: + * platform/chromium-win/html5lib/runner-expected.txt: 251442 3 61569 eric 2010-07-14 14:57:09 -0700 Comment on attachment 61569 Patch You don't need a review on this. Silly v8. 251446 4 ojan 2010-07-14 15:02:04 -0700 (In reply to comment #2) > (From update of attachment 61569 [details]) > Sigh. > > Why are these different???? > > + * platform/chromium-mac/html5lib/runner-expected.txt: > + * platform/chromium-win/html5lib/runner-expected.txt: I wondered the same thing. I'm not sure. I think it might be that someone didn't set the right EOL style on the windows one, so it's all CRLFed. But, I'm just trying to green the tree for now. If I find time, I'll try and resolve the difference later. 251448 5 pkasting 2010-07-14 15:03:56 -0700 (In reply to comment #3) > (From update of attachment 61569 [details]) > You don't need a review on this. Silly v8. Right, this can (and should) just go in without review (or even a bug) as "Update Chromium test expectations". Sadly, until we get V8/JSC to agree on their errors, we have to do this every time there's an html5 parser change :(. That issue is making slow progress elsewhere. (In reply to comment #2) > Why are these different???? > > + * platform/chromium-mac/html5lib/runner-expected.txt: > + * platform/chromium-win/html5lib/runner-expected.txt: They only differ in line endings. I'm 99.999% sure the chromium-mac expectation can be removed if the chromium-win one is converted to LF line endings (stamp it with an svn:eol-style to make sure it stays that way). 263012 6 abarth 2010-08-10 22:28:09 -0700 This patch was either landed or is infinitely out of date by now. 61569 2010-07-14 14:42:17 -0700 2010-07-14 14:57:09 -0700 Patch bug-42290-20100714144216.patch text/plain 4954 ojan ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA5MmMxZTA0YjQ1ZDU0MmJiYTdiNmEwMzNhZjk1YzI3ODFmNWJiNWExLi44MTI0YWM3 MmRkNTc1YjUzOWVmNDA2MTUyOWYwNjc3NTNhZjUyNzc4IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAK KzIwMTAtMDctMTQgIE9qYW4gVmFmYWkgIDxvamFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBodG1sNWxpYi9ydW5uZXIuaHRt bCBmYWlscyBhZnRlciBodHRwOi8vdHJhYy53ZWJraXQub3JnL2NoYW5nZXNldC82MzMzOC8KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQyMjkwCisKKyAg ICAgICAgKiBwbGF0Zm9ybS9jaHJvbWl1bS1tYWMvaHRtbDVsaWIvcnVubmVyLWV4cGVjdGVkLnR4 dDoKKyAgICAgICAgKiBwbGF0Zm9ybS9jaHJvbWl1bS13aW4vaHRtbDVsaWIvcnVubmVyLWV4cGVj dGVkLnR4dDoKKwogMjAxMC0wNy0xNCAgRXJpayBBcnZpZHNzb24gIDxhcnZAY2hyb21pdW0ub3Jn PgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgpkaWZmIC0tZ2l0IGEvTGF5b3V0 VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0tbWFjL2h0bWw1bGliL3J1bm5lci1leHBlY3RlZC50eHQg Yi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS1tYWMvaHRtbDVsaWIvcnVubmVyLWV4cGVj dGVkLnR4dAppbmRleCAzZjU0MDJhNjJiYzYzZDgwYjdmMDI1ZTQ1OWZmY2M5MGE1ZjJjMjY3Li4w ZDU0MjFlZWUzNDcxZjk3YWFiYmI3NDUyNjI1NDI1MDcyZDk4NzYxIDEwMDY0NAotLS0gYS9MYXlv dXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS1tYWMvaHRtbDVsaWIvcnVubmVyLWV4cGVjdGVkLnR4 dAorKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS1tYWMvaHRtbDVsaWIvcnVubmVy LWV4cGVjdGVkLnR4dApAQCAtNTAwMyw4ICs1MDAzLDkgQEAgcmVzb3VyY2VzL2Fkb3B0aW9uMDEu ZGF0OgogNwogOAogOQorMTEKIAotVGVzdCAxIG9mIDkgaW4gcmVzb3VyY2VzL2Fkb3B0aW9uMDEu ZGF0IGZhaWxlZC4gSW5wdXQ6CitUZXN0IDEgb2YgMTEgaW4gcmVzb3VyY2VzL2Fkb3B0aW9uMDEu ZGF0IGZhaWxlZC4gSW5wdXQ6CiA8YT48cD48L2E+PC9wPgogR290OgogfCA8aHRtbD4KQEAgLTUw MjAsNyArNTAyMSw3IEBAIEV4cGVjdGVkOgogfCAgICAgPHA+CiB8ICAgICAgIDxhPgogCi1UZXN0 IDYgb2YgOSBpbiByZXNvdXJjZXMvYWRvcHRpb24wMS5kYXQgZmFpbGVkLiBJbnB1dDoKK1Rlc3Qg NiBvZiAxMSBpbiByZXNvdXJjZXMvYWRvcHRpb24wMS5kYXQgZmFpbGVkLiBJbnB1dDoKIDx0YWJs ZT48YT4xPHA+MjwvYT4zPC9wPgogR290OgogfCA8aHRtbD4KQEAgLTUwNDUsNyArNTA0Niw3IEBA IEV4cGVjdGVkOgogfCAgICAgICAiMyIKIHwgICAgIDx0YWJsZT4KIAotVGVzdCA3IG9mIDkgaW4g cmVzb3VyY2VzL2Fkb3B0aW9uMDEuZGF0IGZhaWxlZC4gSW5wdXQ6CitUZXN0IDcgb2YgMTEgaW4g cmVzb3VyY2VzL2Fkb3B0aW9uMDEuZGF0IGZhaWxlZC4gSW5wdXQ6CiA8Yj48Yj48YT48cD48L2E+ CiBHb3Q6CiB8IDxodG1sPgpAQCAtNTA2NSw3ICs1MDY2LDcgQEAgRXhwZWN0ZWQ6CiB8ICAgICAg ICAgPHA+CiB8ICAgICAgICAgICA8YT4KIAotVGVzdCA4IG9mIDkgaW4gcmVzb3VyY2VzL2Fkb3B0 aW9uMDEuZGF0IGZhaWxlZC4gSW5wdXQ6CitUZXN0IDggb2YgMTEgaW4gcmVzb3VyY2VzL2Fkb3B0 aW9uMDEuZGF0IGZhaWxlZC4gSW5wdXQ6CiA8Yj48YT48Yj48cD48L2E+CiBHb3Q6CiB8IDxodG1s PgpAQCAtNTA4Nyw3ICs1MDg4LDcgQEAgRXhwZWN0ZWQ6CiB8ICAgICAgICAgPHA+CiB8ICAgICAg ICAgICA8YT4KIAotVGVzdCA5IG9mIDkgaW4gcmVzb3VyY2VzL2Fkb3B0aW9uMDEuZGF0IGZhaWxl ZC4gSW5wdXQ6CitUZXN0IDkgb2YgMTEgaW4gcmVzb3VyY2VzL2Fkb3B0aW9uMDEuZGF0IGZhaWxl ZC4gSW5wdXQ6CiA8YT48Yj48Yj48cD48L2E+CiBHb3Q6CiB8IDxodG1sPgpAQCAtNTExMCw2ICs1 MTExLDMzIEBAIEV4cGVjdGVkOgogfCAgICAgICA8Yj4KIHwgICAgICAgICA8cD4KIHwgICAgICAg ICAgIDxhPgorCitUZXN0IDExIG9mIDExIGluIHJlc291cmNlcy9hZG9wdGlvbjAxLmRhdCBmYWls ZWQuIElucHV0OgorPHA+PGIgaWQ9IkEiPjxzY3JpcHQ+ZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQo IkEiKS5pZCA9ICJCIjwvc2NyaXB0PjwvcD5URVhUPC9iPgorR290OgorfCA8aHRtbD4KK3wgICA8 aGVhZD4KK3wgICA8Ym9keT4KK3wgICAgIDxwPgorfCAgICAgICA8Yj4KK3wgICAgICAgICBpZD0i QiIKK3wgICAgICAgICA8c2NyaXB0PgorfCAgICAgICAgICAgImRvY3VtZW50LmdldEVsZW1lbnRC eUlkKCJBIikuaWQgPSAiQiIiCit8ICAgICA8Yj4KK3wgICAgICAgaWQ9IkIiCit8ICAgICAgICJU RVhUIgorRXhwZWN0ZWQ6Cit8IDxodG1sPgorfCAgIDxoZWFkPgorfCAgIDxib2R5PgorfCAgICAg PHA+Cit8ICAgICAgIDxiPgorfCAgICAgICAgIGlkPSJCIgorfCAgICAgICAgIDxzY3JpcHQ+Cit8 ICAgICAgICAgICAiZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoIkEiKS5pZCA9ICJCIiIKK3wgICAg IDxiPgorfCAgICAgICBpZD0iQSIKK3wgICAgICAgIlRFWFQiCiByZXNvdXJjZXMvaW5ib2R5MDEu ZGF0OiBQQVNTCiAKIHJlc291cmNlcy9pc2luZGV4LmRhdDoKZGlmZiAtLWdpdCBhL0xheW91dFRl c3RzL3BsYXRmb3JtL2Nocm9taXVtLXdpbi9odG1sNWxpYi9ydW5uZXItZXhwZWN0ZWQudHh0IGIv TGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0td2luL2h0bWw1bGliL3J1bm5lci1leHBlY3Rl ZC50eHQKaW5kZXggODFkZWM5MDQ3NzhmZGVlZGU1NDRkODU5YWZiZDg2YTZlOGI0OTk3ZC4uZTk3 NjJkMmFjMzk5MmM5ODk4YmFjNTc1ZjEzZDM2MGY2YWQ4ODY3ZSAxMDA2NDQKLS0tIGEvTGF5b3V0 VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0td2luL2h0bWw1bGliL3J1bm5lci1leHBlY3RlZC50eHQK KysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0td2luL2h0bWw1bGliL3J1bm5lci1l eHBlY3RlZC50eHQKQEAgLTUwMDMsOCArNTAwMyw5IEBAIHJlc291cmNlcy9hZG9wdGlvbjAxLmRh dDoKIDcNCiA4DQogOQ0KKzExDQogDQotVGVzdCAxIG9mIDkgaW4gcmVzb3VyY2VzL2Fkb3B0aW9u MDEuZGF0IGZhaWxlZC4gSW5wdXQ6DQorVGVzdCAxIG9mIDExIGluIHJlc291cmNlcy9hZG9wdGlv bjAxLmRhdCBmYWlsZWQuIElucHV0Og0KIDxhPjxwPjwvYT48L3A+DQogR290Og0KIHwgPGh0bWw+ DQpAQCAtNTAyMCw3ICs1MDIxLDcgQEAgRXhwZWN0ZWQ6CiB8ICAgICA8cD4NCiB8ICAgICAgIDxh Pg0KIA0KLVRlc3QgNiBvZiA5IGluIHJlc291cmNlcy9hZG9wdGlvbjAxLmRhdCBmYWlsZWQuIElu cHV0Og0KK1Rlc3QgNiBvZiAxMSBpbiByZXNvdXJjZXMvYWRvcHRpb24wMS5kYXQgZmFpbGVkLiBJ bnB1dDoNCiA8dGFibGU+PGE+MTxwPjI8L2E+MzwvcD4NCiBHb3Q6DQogfCA8aHRtbD4NCkBAIC01 MDQ1LDcgKzUwNDYsNyBAQCBFeHBlY3RlZDoKIHwgICAgICAgIjMiDQogfCAgICAgPHRhYmxlPg0K IA0KLVRlc3QgNyBvZiA5IGluIHJlc291cmNlcy9hZG9wdGlvbjAxLmRhdCBmYWlsZWQuIElucHV0 Og0KK1Rlc3QgNyBvZiAxMSBpbiByZXNvdXJjZXMvYWRvcHRpb24wMS5kYXQgZmFpbGVkLiBJbnB1 dDoNCiA8Yj48Yj48YT48cD48L2E+DQogR290Og0KIHwgPGh0bWw+DQpAQCAtNTA2NSw3ICs1MDY2 LDcgQEAgRXhwZWN0ZWQ6CiB8ICAgICAgICAgPHA+DQogfCAgICAgICAgICAgPGE+DQogDQotVGVz dCA4IG9mIDkgaW4gcmVzb3VyY2VzL2Fkb3B0aW9uMDEuZGF0IGZhaWxlZC4gSW5wdXQ6DQorVGVz dCA4IG9mIDExIGluIHJlc291cmNlcy9hZG9wdGlvbjAxLmRhdCBmYWlsZWQuIElucHV0Og0KIDxi PjxhPjxiPjxwPjwvYT4NCiBHb3Q6DQogfCA8aHRtbD4NCkBAIC01MDg3LDcgKzUwODgsNyBAQCBF eHBlY3RlZDoKIHwgICAgICAgICA8cD4NCiB8ICAgICAgICAgICA8YT4NCiANCi1UZXN0IDkgb2Yg OSBpbiByZXNvdXJjZXMvYWRvcHRpb24wMS5kYXQgZmFpbGVkLiBJbnB1dDoNCitUZXN0IDkgb2Yg MTEgaW4gcmVzb3VyY2VzL2Fkb3B0aW9uMDEuZGF0IGZhaWxlZC4gSW5wdXQ6DQogPGE+PGI+PGI+ PHA+PC9hPg0KIEdvdDoNCiB8IDxodG1sPg0KQEAgLTUxMTAsNiArNTExMSwzMyBAQCBFeHBlY3Rl ZDoKIHwgICAgICAgPGI+DQogfCAgICAgICAgIDxwPg0KIHwgICAgICAgICAgIDxhPg0KKw0KK1Rl c3QgMTEgb2YgMTEgaW4gcmVzb3VyY2VzL2Fkb3B0aW9uMDEuZGF0IGZhaWxlZC4gSW5wdXQ6DQor PHA+PGIgaWQ9IkEiPjxzY3JpcHQ+ZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoIkEiKS5pZCA9ICJC Ijwvc2NyaXB0PjwvcD5URVhUPC9iPg0KK0dvdDoNCit8IDxodG1sPg0KK3wgICA8aGVhZD4NCit8 ICAgPGJvZHk+DQorfCAgICAgPHA+DQorfCAgICAgICA8Yj4NCit8ICAgICAgICAgaWQ9IkIiDQor fCAgICAgICAgIDxzY3JpcHQ+DQorfCAgICAgICAgICAgImRvY3VtZW50LmdldEVsZW1lbnRCeUlk KCJBIikuaWQgPSAiQiIiDQorfCAgICAgPGI+DQorfCAgICAgICBpZD0iQiINCit8ICAgICAgICJU RVhUIg0KK0V4cGVjdGVkOg0KK3wgPGh0bWw+DQorfCAgIDxoZWFkPg0KK3wgICA8Ym9keT4NCit8 ICAgICA8cD4NCit8ICAgICAgIDxiPg0KK3wgICAgICAgICBpZD0iQiINCit8ICAgICAgICAgPHNj cmlwdD4NCit8ICAgICAgICAgICAiZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoIkEiKS5pZCA9ICJC IiINCit8ICAgICA8Yj4NCit8ICAgICAgIGlkPSJBIg0KK3wgICAgICAgIlRFWFQiDQogcmVzb3Vy Y2VzL2luYm9keTAxLmRhdDogUEFTUw0KIA0KIHJlc291cmNlcy9pc2luZGV4LmRhdDoNCg==