42287 2010-07-14 13:33:40 -0700 Add NetscapePlugin::NPP_ member functions for calling into the plug-in 2010-07-14 13:49:53 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 andersca andersca webkit.review.bot oldest_to_newest 251402 0 andersca 2010-07-14 13:33:40 -0700 Add NetscapePlugin::NPP_ member functions for calling into the plug-in 251403 1 61560 andersca 2010-07-14 13:34:40 -0700 Created attachment 61560 Patch 251405 2 webkit.review.bot 2010-07-14 13:36:50 -0700 Attachment 61560 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.h:55: NPP_New is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.h:56: NPP_Destroy is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.h:57: NPP_SetWindow is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.h:58: NPP_URLNotify is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.cpp:111: NetscapePlugin::NPP_New is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.cpp:116: NetscapePlugin::NPP_Destroy is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.cpp:121: NetscapePlugin::NPP_SetWindow is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.cpp:126: NetscapePlugin::NPP_URLNotify is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 8 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 251410 3 andersca 2010-07-14 13:49:53 -0700 Committed r63351: <http://trac.webkit.org/changeset/63351> 61560 2010-07-14 13:34:40 -0700 2010-07-14 13:36:14 -0700 Patch bug-42287-20100714133439.patch text/plain 4615 andersca ZGlmZiAtLWdpdCBhL1dlYktpdDIvQ2hhbmdlTG9nIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXgg NzQ1ODEwMWM1MWNhZGNjMWIzODM0MjY2NzUwYTg0MDUyNWZlMDcxYy4uZDU5OTExMDI4MTE1MGNm Mjk0NDQ2ZjAzMTAxYzIzZTBjNGM4MDliOCAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEsNSArMSwyMiBAQAogMjAxMC0wNy0xNCAgQW5k ZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBOZXRzY2FwZVBsdWdpbjo6TlBQXyBtZW1i ZXIgZnVuY3Rpb25zIGZvciBjYWxsaW5nIGludG8gdGhlIHBsdWctaW4KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQyMjg3CisKKyAgICAgICAgKiBXZWJQ cm9jZXNzL1BsdWdpbnMvTmV0c2NhcGUvTmV0c2NhcGVQbHVnaW4uY3BwOgorICAgICAgICAoV2Vi S2l0OjpOZXRzY2FwZVBsdWdpbjo6TlBQX05ldyk6CisgICAgICAgIChXZWJLaXQ6Ok5ldHNjYXBl UGx1Z2luOjpOUFBfRGVzdHJveSk6CisgICAgICAgIChXZWJLaXQ6Ok5ldHNjYXBlUGx1Z2luOjpO UFBfU2V0V2luZG93KToKKyAgICAgICAgKFdlYktpdDo6TmV0c2NhcGVQbHVnaW46Ok5QUF9VUkxO b3RpZnkpOgorICAgICAgICAoV2ViS2l0OjpOZXRzY2FwZVBsdWdpbjo6Y2FsbFNldFdpbmRvdyk6 CisgICAgICAgIChXZWJLaXQ6Ok5ldHNjYXBlUGx1Z2luOjppbml0aWFsaXplKToKKyAgICAgICAg KFdlYktpdDo6TmV0c2NhcGVQbHVnaW46OmRlc3Ryb3kpOgorICAgICAgICAqIFdlYlByb2Nlc3Mv UGx1Z2lucy9OZXRzY2FwZS9OZXRzY2FwZVBsdWdpbi5oOgorCisyMDEwLTA3LTE0ICBBbmRlcnMg Q2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisKICAgICAgICAgUmV2aWV3ZWQgYnkgU2Ft IFdlaW5pZy4KIAogICAgICAgICBTZW5kIEphdmFTY3JpcHQgdXJsIHJlcXVlc3QgcmVzdWx0cyBi YWNrIHRvIHRoZSBwbHVnLWluCmRpZmYgLS1naXQgYS9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lu cy9OZXRzY2FwZS9OZXRzY2FwZVBsdWdpbi5jcHAgYi9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lu cy9OZXRzY2FwZS9OZXRzY2FwZVBsdWdpbi5jcHAKaW5kZXggMzUwYzA1YzA3ZjJhYjYyYmY2ZGNj ZWI0MDAxNWY4MDMzMjdkOGUyZS4uY2I2YzY0MjUxZmRiMGEzNTc3ODUzZGM1MjZiM2Q3ZjYyM2E3 ZjgxZiAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvTmV0c2NhcGUvTmV0 c2NhcGVQbHVnaW4uY3BwCisrKyBiL1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL05ldHNjYXBl L05ldHNjYXBlUGx1Z2luLmNwcApAQCAtMTA4LDYgKzEwOCwyNiBAQCB2b2lkIE5ldHNjYXBlUGx1 Z2luOjpsb2FkVVJMKGNvbnN0IFN0cmluZyYgdXJsU3RyaW5nLCBjb25zdCBTdHJpbmcmIHRhcmdl dCwgYm9vbAogICAgIG1fcGx1Z2luQ29udHJvbGxlci0+bG9hZFVSTChyZXF1ZXN0SUQsIHVybFN0 cmluZywgdGFyZ2V0LCBhbGxvd1BvcHVwcyk7CiB9CiAKK05QRXJyb3IgTmV0c2NhcGVQbHVnaW46 Ok5QUF9OZXcoTlBNSU1FVHlwZSBwbHVnaW5UeXBlLCB1aW50MTZfdCBtb2RlLCBpbnQxNl90IGFy Z2MsIGNoYXIqIGFyZ25bXSwgY2hhciogYXJndltdLCBOUFNhdmVkRGF0YSogc2F2ZWREYXRhKQor eworICAgIHJldHVybiBtX3BsdWdpbk1vZHVsZS0+cGx1Z2luRnVuY3MoKS5uZXdwKHBsdWdpblR5 cGUsICZtX25wcCwgbW9kZSwgYXJnYywgYXJnbiwgYXJndiwgc2F2ZWREYXRhKTsKK30KKyAgICAK K05QRXJyb3IgTmV0c2NhcGVQbHVnaW46Ok5QUF9EZXN0cm95KE5QU2F2ZWREYXRhKiogc2F2ZWRE YXRhKQoreworICAgIHJldHVybiBtX3BsdWdpbk1vZHVsZS0+cGx1Z2luRnVuY3MoKS5kZXN0cm95 KCZtX25wcCwgc2F2ZWREYXRhKTsKK30KKworTlBFcnJvciBOZXRzY2FwZVBsdWdpbjo6TlBQX1Nl dFdpbmRvdyhOUFdpbmRvdyogbnBXaW5kb3cpCit7CisgICAgcmV0dXJuIG1fcGx1Z2luTW9kdWxl LT5wbHVnaW5GdW5jcygpLnNldHdpbmRvdygmbV9ucHAsIG5wV2luZG93KTsKK30KKwordm9pZCBO ZXRzY2FwZVBsdWdpbjo6TlBQX1VSTE5vdGlmeShjb25zdCBjaGFyKiB1cmwsIE5QUmVhc29uIHJl YXNvbiwgdm9pZCogbm90aWZ5RGF0YSkKK3sKKyAgICBtX3BsdWdpbk1vZHVsZS0+cGx1Z2luRnVu Y3MoKS51cmxub3RpZnkoJm1fbnBwLCB1cmwsIHJlYXNvbiwgbm90aWZ5RGF0YSk7Cit9CisKIHZv aWQgTmV0c2NhcGVQbHVnaW46OmNhbGxTZXRXaW5kb3coKQogewogICAgIG1fbnBXaW5kb3cueCA9 IG1fZnJhbWVSZWN0LngoKTsKQEAgLTExOSw3ICsxMzksNyBAQCB2b2lkIE5ldHNjYXBlUGx1Z2lu OjpjYWxsU2V0V2luZG93KCkKICAgICBtX25wV2luZG93LmNsaXBSZWN0LmJvdHRvbSA9IG1fY2xp cFJlY3QuYm90dG9tKCk7CiAgICAgbV9ucFdpbmRvdy5jbGlwUmVjdC5yaWdodCA9IG1fY2xpcFJl Y3QucmlnaHQoKTsKIAotICAgIG1fcGx1Z2luTW9kdWxlLT5wbHVnaW5GdW5jcygpLnNldHdpbmRv dygmbV9ucHAsICZtX25wV2luZG93KTsKKyAgICBOUFBfU2V0V2luZG93KCZtX25wV2luZG93KTsK IH0KIAogYm9vbCBOZXRzY2FwZVBsdWdpbjo6aW5pdGlhbGl6ZShQbHVnaW5Db250cm9sbGVyKiBw bHVnaW5Db250cm9sbGVyLCBjb25zdCBQYXJhbWV0ZXJzJiBwYXJhbWV0ZXJzKQpAQCAtMTUyLDgg KzE3Miw4IEBAIGJvb2wgTmV0c2NhcGVQbHVnaW46OmluaXRpYWxpemUoUGx1Z2luQ29udHJvbGxl ciogcGx1Z2luQ29udHJvbGxlciwgY29uc3QgUGFyYW1lCiAgICAgICAgIHZhbHVlcy5hcHBlbmQo cGFyYW1WYWx1ZXNbaV0uZGF0YSgpKTsKICAgICB9CiAgICAgCi0gICAgTlBFcnJvciBlcnJvciA9 IG1fcGx1Z2luTW9kdWxlLT5wbHVnaW5GdW5jcygpLm5ld3AoY29uc3RfY2FzdDxjaGFyKj4obWlt ZVR5cGVDU3RyaW5nLmRhdGEoKSksICZtX25wcCwgbW9kZSwgCi0gICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbmFtZXMuc2l6ZSgpLCBjb25zdF9j YXN0PGNoYXIqKj4obmFtZXMuZGF0YSgpKSwgY29uc3RfY2FzdDxjaGFyKio+KHZhbHVlcy5kYXRh KCkpLCAwKTsKKyAgICBOUEVycm9yIGVycm9yID0gTlBQX05ldyhjb25zdF9jYXN0PGNoYXIqPiht aW1lVHlwZUNTdHJpbmcuZGF0YSgpKSwgbW9kZSwgbmFtZXMuc2l6ZSgpLAorICAgICAgICAgICAg ICAgICAgICAgICAgICAgIGNvbnN0X2Nhc3Q8Y2hhcioqPihuYW1lcy5kYXRhKCkpLCBjb25zdF9j YXN0PGNoYXIqKj4odmFsdWVzLmRhdGEoKSksIDApOwogICAgIG1faW5OUFBOZXcgPSBmYWxzZTsK IAogICAgIGlmIChlcnJvciAhPSBOUEVSUl9OT19FUlJPUikKQEAgLTE3Niw3ICsxOTYsOCBAQCB2 b2lkIE5ldHNjYXBlUGx1Z2luOjpkZXN0cm95KCkKIHsKICAgICBBU1NFUlQobV9pc1N0YXJ0ZWQp OwogCi0gICAgbV9wbHVnaW5Nb2R1bGUtPnBsdWdpbkZ1bmNzKCkuZGVzdHJveSgmbV9ucHAsIDAp OworICAgIE5QUF9EZXN0cm95KDApOworCiAgICAgbV9pc1N0YXJ0ZWQgPSBmYWxzZTsKICAgICBt X3BsdWdpbkNvbnRyb2xsZXIgPSAwOwogfQpkaWZmIC0tZ2l0IGEvV2ViS2l0Mi9XZWJQcm9jZXNz L1BsdWdpbnMvTmV0c2NhcGUvTmV0c2NhcGVQbHVnaW4uaCBiL1dlYktpdDIvV2ViUHJvY2Vzcy9Q bHVnaW5zL05ldHNjYXBlL05ldHNjYXBlUGx1Z2luLmgKaW5kZXggNDQ1ZGVhMjM1ZTYwODliMmMz YWM2NmM5N2I4YzJmMGY1MjA0NDE0Mi4uMTZlZjEzZDNkZDRiNmY1NjE4Y2EyNTg2ZTBiOTM1ZjM2 ZWM2OTU1ZiAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvTmV0c2NhcGUv TmV0c2NhcGVQbHVnaW4uaAorKysgYi9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9OZXRzY2Fw ZS9OZXRzY2FwZVBsdWdpbi5oCkBAIC01MCw3ICs1MCwxMyBAQCBwdWJsaWM6CiAgICAgdm9pZCBp bnZhbGlkYXRlKGNvbnN0IE5QUmVjdCopOwogICAgIGNvbnN0IGNoYXIqIHVzZXJBZ2VudCgpOwog ICAgIHZvaWQgbG9hZFVSTChjb25zdCBXZWJDb3JlOjpTdHJpbmcmIHVybFN0cmluZywgY29uc3Qg V2ViQ29yZTo6U3RyaW5nJiB0YXJnZXQsIGJvb2wgc2VuZE5vdGlmaWNhdGlvbiwgdm9pZCogbm90 aWZpY2F0aW9uRGF0YSk7Ci0gICAgCisKKyAgICAvLyBNZW1iZXIgZnVuY3Rpb25zIGZvciBjYWxs aW5nIGludG8gdGhlIHBsdWctaW4uCisgICAgTlBFcnJvciBOUFBfTmV3KE5QTUlNRVR5cGUgcGx1 Z2luVHlwZSwgdWludDE2X3QgbW9kZSwgaW50MTZfdCBhcmdjLCBjaGFyKiBhcmduW10sIGNoYXIq IGFyZ3ZbXSwgTlBTYXZlZERhdGEqIHNhdmVkRGF0YSk7CisgICAgTlBFcnJvciBOUFBfRGVzdHJv eShOUFNhdmVkRGF0YSoqIHNhdmVkRGF0YSk7CisgICAgTlBFcnJvciBOUFBfU2V0V2luZG93KE5Q V2luZG93Kik7CisgICAgdm9pZCBOUFBfVVJMTm90aWZ5KGNvbnN0IGNoYXIqIHVybCwgTlBSZWFz b24gcmVhc29uLCB2b2lkKiBub3RpZnlEYXRhKTsKKwogcHJpdmF0ZToKICAgICBOZXRzY2FwZVBs dWdpbihQYXNzUmVmUHRyPE5ldHNjYXBlUGx1Z2luTW9kdWxlPiBwbHVnaW5Nb2R1bGUpOwogCg==