42284 2010-07-14 13:22:10 -0700 Canvas: Rename operator==(CanvasStyle,CanvasStyle) since it isn't a proper equality check 2010-07-19 07:52:56 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 kling webkit-unassigned kenneth oldest_to_newest 251391 0 kling 2010-07-14 13:22:10 -0700 It only compares if the CanvasStyle is an RGBA or CMYKA color. 251393 1 61557 kling 2010-07-14 13:25:09 -0700 Created attachment 61557 Renamed it to isColorAndEqualTo(CanvasStyle) 251537 2 kenneth 2010-07-14 17:25:44 -0700 What about the name: isEquivalentColor ? 252473 3 kling 2010-07-16 06:22:07 -0700 (In reply to comment #2) > What about the name: isEquivalentColor ? r=you for that name? :) 253166 4 61557 kenneth 2010-07-19 06:33:12 -0700 Comment on attachment 61557 Renamed it to isColorAndEqualTo(CanvasStyle) yes, r=me with that change. 253199 5 kling 2010-07-19 07:52:56 -0700 Committed r63659: <http://trac.webkit.org/changeset/63659> 61557 2010-07-14 13:25:09 -0700 2010-07-19 06:33:12 -0700 Renamed it to isColorAndEqualTo(CanvasStyle) bug-42284.diff text/plain 3793 kling ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZDAxZmFjZC4uY2NmNDFiNyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwyMSBAQAogMjAxMC0wNy0xNCAgQW5kcmVhcyBLbGlu ZyAgPGFuZHJlYXMua2xpbmdAbm9raWEuY29tPgogCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIENhbnZhczogUmVuYW1lIG9wZXJhdG9yPT0oQ2FudmFzU3R5 bGUsQ2FudmFzU3R5bGUpIHNpbmNlIGl0IGlzbid0IGEgcHJvcGVyIGVxdWFsaXR5IGNoZWNrCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MjI4NAorCisg ICAgICAgIE5ldyBuYW1lIGlzIGlzQ29sb3JBbmRFcXVhbFRvKENhbnZhc1N0eWxlKS4KKworICAg ICAgICAqIGh0bWwvY2FudmFzL0NhbnZhc1JlbmRlcmluZ0NvbnRleHQyRC5jcHA6CisgICAgICAg IChXZWJDb3JlOjpDYW52YXNSZW5kZXJpbmdDb250ZXh0MkQ6OnNldFN0cm9rZVN0eWxlKToKKyAg ICAgICAgKFdlYkNvcmU6OkNhbnZhc1JlbmRlcmluZ0NvbnRleHQyRDo6c2V0RmlsbFN0eWxlKToK KyAgICAgICAgKiBodG1sL2NhbnZhcy9DYW52YXNTdHlsZS5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpDYW52YXNTdHlsZTo6aXNDb2xvckFuZEVxdWFsVG8pOgorICAgICAgICAqIGh0bWwvY2FudmFz L0NhbnZhc1N0eWxlLmg6CisKKzIwMTAtMDctMTQgIEFuZHJlYXMgS2xpbmcgIDxhbmRyZWFzLmts aW5nQG5va2lhLmNvbT4KKwogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KIAogICAg ICAgICBDYW52YXM6IEZhc3QtcGF0aCBmb3IgYXNzaWduaW5nIHRoZSBzYW1lIGNvbG9yIHN0cmlu ZyBhcyBiZWZvcmUgdG8gZmlsbFN0eWxlIG9yIHN0cm9rZVN0eWxlCmRpZmYgLS1naXQgYS9XZWJD b3JlL2h0bWwvY2FudmFzL0NhbnZhc1JlbmRlcmluZ0NvbnRleHQyRC5jcHAgYi9XZWJDb3JlL2h0 bWwvY2FudmFzL0NhbnZhc1JlbmRlcmluZ0NvbnRleHQyRC5jcHAKaW5kZXggNDUxZGM2Mi4uMzEy ZTc5MyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9odG1sL2NhbnZhcy9DYW52YXNSZW5kZXJpbmdDb250 ZXh0MkQuY3BwCisrKyBiL1dlYkNvcmUvaHRtbC9jYW52YXMvQ2FudmFzUmVuZGVyaW5nQ29udGV4 dDJELmNwcApAQCAtMTcyLDcgKzE3Miw3IEBAIHZvaWQgQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJE OjpzZXRTdHJva2VTdHlsZShQYXNzUmVmUHRyPENhbnZhc1N0eWxlPiBzdHlsZSkKICAgICBpZiAo IXN0eWxlKQogICAgICAgICByZXR1cm47CiAKLSAgICBpZiAoc3RhdGUoKS5tX3N0cm9rZVN0eWxl ICYmICpzdHlsZSA9PSAqc3RhdGUoKS5tX3N0cm9rZVN0eWxlKQorICAgIGlmIChzdGF0ZSgpLm1f c3Ryb2tlU3R5bGUgJiYgc3RhdGUoKS5tX3N0cm9rZVN0eWxlLT5pc0NvbG9yQW5kRXF1YWxUbygq c3R5bGUpKQogICAgICAgICByZXR1cm47CiAKICAgICBpZiAoY2FudmFzKCktPm9yaWdpbkNsZWFu KCkpIHsKQEAgLTIwMCw3ICsyMDAsNyBAQCB2b2lkIENhbnZhc1JlbmRlcmluZ0NvbnRleHQyRDo6 c2V0RmlsbFN0eWxlKFBhc3NSZWZQdHI8Q2FudmFzU3R5bGU+IHN0eWxlKQogICAgIGlmICghc3R5 bGUpCiAgICAgICAgIHJldHVybjsKIAotICAgIGlmIChzdGF0ZSgpLm1fZmlsbFN0eWxlICYmICpz dHlsZSA9PSAqc3RhdGUoKS5tX2ZpbGxTdHlsZSkKKyAgICBpZiAoc3RhdGUoKS5tX2ZpbGxTdHls ZSAmJiBzdGF0ZSgpLm1fZmlsbFN0eWxlLT5pc0NvbG9yQW5kRXF1YWxUbygqc3R5bGUpKQogICAg ICAgICByZXR1cm47CiAgCiAgICAgaWYgKGNhbnZhcygpLT5vcmlnaW5DbGVhbigpKSB7CmRpZmYg LS1naXQgYS9XZWJDb3JlL2h0bWwvY2FudmFzL0NhbnZhc1N0eWxlLmNwcCBiL1dlYkNvcmUvaHRt bC9jYW52YXMvQ2FudmFzU3R5bGUuY3BwCmluZGV4IDQ3ODNhOTAuLjFmOTRiOTIgMTAwNjQ0Ci0t LSBhL1dlYkNvcmUvaHRtbC9jYW52YXMvQ2FudmFzU3R5bGUuY3BwCisrKyBiL1dlYkNvcmUvaHRt bC9jYW52YXMvQ2FudmFzU3R5bGUuY3BwCkBAIC0xMjEsMjQgKzEyMSwyMyBAQCBQYXNzUmVmUHRy PENhbnZhc1N0eWxlPiBDYW52YXNTdHlsZTo6Y3JlYXRlKFBhc3NSZWZQdHI8Q2FudmFzUGF0dGVy bj4gcGF0dGVybikKICAgICByZXR1cm4gYWRvcHRSZWYobmV3IENhbnZhc1N0eWxlKHBhdHRlcm4p KTsKIH0KIAotYm9vbCBvcGVyYXRvcj09KGNvbnN0IENhbnZhc1N0eWxlJiBzMSwgY29uc3QgQ2Fu dmFzU3R5bGUmIHMyKQorYm9vbCBDYW52YXNTdHlsZTo6aXNDb2xvckFuZEVxdWFsVG8oY29uc3Qg Q2FudmFzU3R5bGUmIG90aGVyKSBjb25zdAogewotICAgIGlmIChzMS5tX3R5cGUgIT0gczIubV90 eXBlKQorICAgIGlmIChtX3R5cGUgIT0gb3RoZXIubV90eXBlKQogICAgICAgICByZXR1cm4gZmFs c2U7CiAKLSAgICBzd2l0Y2ggKHMxLm1fdHlwZSkgeworICAgIHN3aXRjaCAobV90eXBlKSB7CiAg ICAgY2FzZSBDYW52YXNTdHlsZTo6UkdCQToKLSAgICAgICAgcmV0dXJuIHMxLm1fcmdiYSA9PSBz Mi5tX3JnYmE7CisgICAgICAgIHJldHVybiBtX3JnYmEgPT0gb3RoZXIubV9yZ2JhOworICAgIGNh c2UgQ2FudmFzU3R5bGU6OkNNWUtBOgorICAgICAgICByZXR1cm4gbV9jbXlrYS5jID09IG90aGVy Lm1fY215a2EuYworICAgICAgICAgICAgJiYgbV9jbXlrYS5tID09IG90aGVyLm1fY215a2EubQor ICAgICAgICAgICAgJiYgbV9jbXlrYS55ID09IG90aGVyLm1fY215a2EueQorICAgICAgICAgICAg JiYgbV9jbXlrYS5rID09IG90aGVyLm1fY215a2EuaworICAgICAgICAgICAgJiYgbV9jbXlrYS5h ID09IG90aGVyLm1fY215a2EuYTsKICAgICBjYXNlIENhbnZhc1N0eWxlOjpHcmFkaWVudDoKLSAg ICAgICAgcmV0dXJuIGZhbHNlOwogICAgIGNhc2UgQ2FudmFzU3R5bGU6OkltYWdlUGF0dGVybjoK ICAgICAgICAgcmV0dXJuIGZhbHNlOwotICAgIGNhc2UgQ2FudmFzU3R5bGU6OkNNWUtBOgotICAg ICAgICByZXR1cm4gczEubV9jbXlrYS5jID09IHMyLm1fY215a2EuYwotICAgICAgICAgICAgJiYg czEubV9jbXlrYS5tID09IHMyLm1fY215a2EubQotICAgICAgICAgICAgJiYgczEubV9jbXlrYS55 ID09IHMyLm1fY215a2EueQotICAgICAgICAgICAgJiYgczEubV9jbXlrYS5rID09IHMyLm1fY215 a2EuawotICAgICAgICAgICAgJiYgczEubV9jbXlrYS5hID09IHMyLm1fY215a2EuYTsKICAgICB9 CiAKICAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKZGlmZiAtLWdpdCBhL1dlYkNvcmUvaHRtbC9j YW52YXMvQ2FudmFzU3R5bGUuaCBiL1dlYkNvcmUvaHRtbC9jYW52YXMvQ2FudmFzU3R5bGUuaApp bmRleCA3N2VkZDE4Li4yOWYxYzhkIDEwMDY0NAotLS0gYS9XZWJDb3JlL2h0bWwvY2FudmFzL0Nh bnZhc1N0eWxlLmgKKysrIGIvV2ViQ29yZS9odG1sL2NhbnZhcy9DYW52YXNTdHlsZS5oCkBAIC01 NSw3ICs1NSw3IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICAgICAgdm9pZCBhcHBseUZpbGxD b2xvcihHcmFwaGljc0NvbnRleHQqKTsKICAgICAgICAgdm9pZCBhcHBseVN0cm9rZUNvbG9yKEdy YXBoaWNzQ29udGV4dCopOwogCi0gICAgICAgIGZyaWVuZCBib29sIG9wZXJhdG9yPT0oY29uc3Qg Q2FudmFzU3R5bGUmLCBjb25zdCBDYW52YXNTdHlsZSYpOworICAgICAgICBib29sIGlzQ29sb3JB bmRFcXVhbFRvKGNvbnN0IENhbnZhc1N0eWxlJikgY29uc3Q7CiAKICAgICBwcml2YXRlOgogICAg ICAgICBDYW52YXNTdHlsZShSR0JBMzIgcmdiYSk7Cg==