42283 2010-07-14 13:21:26 -0700 Define setPrivateBrowsingEnabled() 2010-08-06 20:37:53 -0700 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 41801 1 robert webkit-unassigned abarth tonikitoo oldest_to_newest 251390 0 robert 2010-07-14 13:21:26 -0700 'Private Browsing' actually doesn't have a formal definition in WebCore - at least not in the code. WebKit on the other hand is not short of possible definitions: \value PrivateBrowsingEnabled Private browsing prevents WebKit from recording visited pages in the history and storing web page icons. This is disabled by default. @abstract If private browsing is enabled, WebKit will not store information about sites the user visits. * Whether to enable private browsing mode. Private browsing mode prevents * WebKit from updating the global history and storing any session * information e.g., on-disk cache, as well as suppressing any messages * from being printed into the (javascript) console. Ports are at liberty to implement their own additional behaviour to private browsing, and clients even more. Define 'private browsing' in WebCore so that it is not subject to feature creep (such as protecting against remote tracking) and potential confusion (what clients brand 'private browsing' may not be within the scope of WebCore's definition of private browsing). 252436 1 61789 robert 2010-07-16 03:06:18 -0700 Created attachment 61789 Patch 252480 2 tonikitoo 2010-07-16 06:35:10 -0700 good stuff! 256562 3 61789 abarth 2010-07-27 07:15:55 -0700 Comment on attachment 61789 Patch WebCore/ChangeLog:6 + Please remove these extra spaces before landing. 261643 4 abarth 2010-08-06 20:37:53 -0700 Committed r64893: <http://trac.webkit.org/changeset/64893> 61789 2010-07-16 03:06:18 -0700 2010-07-27 07:15:55 -0700 Patch bug-42283-20100716110615.patch text/plain 1673 robert ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MWJjOWYyOWY0ZWQ1NWU3ZTU3YTEzMjQ4MWRlMzIzZTM4YzVjOTM2ZS4uZjY3Y2E3N2RjNzJmYjc1 MWFkZTI1MDhiYWMwZmFiNjFiMmViYjM1MSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMC0wNy0xNiAgUm9i ZXJ0IEhvZ2FuICA8cm9iZXJ0QHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgRGVmaW5lIHNldFByaXZhdGVCcm93c2luZ0VuYWJsZWQo KQorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MjI4 MworCisgICAgICAgIERlZmluZSB0aGUgc2NvcGUgb2YgJ3ByaXZhdGUgYnJvd3NpbmcnIGluIFdl YktpdAorCisgICAgICAgIFNlZSBhbHNvIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD00MTgwMQorCisgICAgICAgICogcGFnZS9TZXR0aW5ncy5oOgorCiAyMDEwLTA3LTE2 ICBOaWtvbGFzIFppbW1lcm1hbm4gIDxuemltbWVybWFubkByaW0uY29tPgogCiAgICAgICAgIFJl dmlld2VkIGJ5IERpcmsgU2NodWx6ZS4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGFnZS9TZXR0aW5n cy5oIGIvV2ViQ29yZS9wYWdlL1NldHRpbmdzLmgKaW5kZXggMmFjNWQyNzZmMjU1YmIzNjg2MjMz MmE0MjZiNDBlN2JmMTYyMTZjYy4uMTIxMTRkNDFhMmNjOWY5ZmZiZTQ1MGQ0ZDQxZWRkMTcxMmUy MjQ4NCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wYWdlL1NldHRpbmdzLmgKKysrIGIvV2ViQ29yZS9w YWdlL1NldHRpbmdzLmgKQEAgLTE0MCw2ICsxNDAsMTcgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewog ICAgICAgICB1bnNpZ25lZCBzZXNzaW9uU3RvcmFnZVF1b3RhKCkgY29uc3QgeyByZXR1cm4gbV9z ZXNzaW9uU3RvcmFnZVF1b3RhOyB9CiAjZW5kaWYKIAorICAgICAgICAvLyBXaGVuIHRoaXMgb3B0 aW9uIGlzIHNldCwgV2ViQ29yZSB3aWxsIGF2b2lkIHN0b3JpbmcgYW55IHJlY29yZCBvZiBicm93 c2luZyBhY3Rpdml0eQorICAgICAgICAvLyB0aGF0IG1heSBwZXJzaXN0IG9uIGRpc2sgb3IgcmVt YWluIGRpc3BsYXllZCB3aGVuIHRoZSBvcHRpb24gaXMgcmVzZXQuCisgICAgICAgIC8vIFRoaXMg b3B0aW9uIGRvZXMgbm90IGFmZmVjdCB0aGUgc3RvcmFnZSBvZiBzdWNoIGluZm9ybWF0aW9uIGlu IFJBTS4KKyAgICAgICAgLy8gVGhlIGZvbGxvd2luZyBmdW5jdGlvbnMgcmVzcGVjdCB0aGlzIHNl dHRpbmc6CisgICAgICAgIC8vICAtIEhUTUw1L0RPTSBTdG9yYWdlCisgICAgICAgIC8vICAtIElj b24gRGF0YWJhc2UKKyAgICAgICAgLy8gIC0gQ29uc29sZSBNZXNzYWdlcworICAgICAgICAvLyAg LSBDYWNoZQorICAgICAgICAvLyAgLSBBcHBsaWNhdGlvbiBDYWNoZQorICAgICAgICAvLyAgLSBC YWNrL0ZvcndhcmQgUGFnZSBIaXN0b3J5CisgICAgICAgIC8vICAtIFBhZ2UgU2VhcmNoIFJlc3Vs dHMKICAgICAgICAgdm9pZCBzZXRQcml2YXRlQnJvd3NpbmdFbmFibGVkKGJvb2wpOwogICAgICAg ICBib29sIHByaXZhdGVCcm93c2luZ0VuYWJsZWQoKSBjb25zdCB7IHJldHVybiBtX3ByaXZhdGVC cm93c2luZ0VuYWJsZWQ7IH0KIAo=