42271 2010-07-14 10:54:45 -0700 [chromium] PopupMenu labels are not very visible when selected 2010-07-15 18:39:38 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 0 jcivelli webkit-unassigned commit-queue dhollowa jhawkins zmo oldest_to_newest 251286 0 jcivelli 2010-07-14 10:54:45 -0700 - In Chromium, trigger the form autofill popup on a form - The label on the right of the text is displayed in gray. - Select the entry with the label. Expected: The text and label colors change so that they can be read with the selection background Actual: Only the text color changes, the label is still gray and is hard to read on the selection background 252188 1 61738 jcivelli 2010-07-15 15:51:07 -0700 Created attachment 61738 Initial patch 252189 2 jhawkins 2010-07-15 15:53:17 -0700 LGTM, thanks. 252190 3 61738 levin 2010-07-15 15:56:15 -0700 Comment on attachment 61738 Initial patch > Index: WebCore/ChangeLog > + (WebCore::PopupListBox::paintRow): A short comment here would be nice. > Index: WebCore/platform/chromium/PopupMenuChromium.cpp > + gc->setFillColor(textColor, DeviceColorSpace); labelColor (as discussed). 252192 4 dhollowa 2010-07-15 15:57:53 -0700 LGTM. 252232 5 61749 jcivelli 2010-07-15 17:06:10 -0700 Created attachment 61749 Applying Dave Levin's suggested changes. 252271 6 61749 commit-queue 2010-07-15 18:33:49 -0700 Comment on attachment 61749 Applying Dave Levin's suggested changes. Clearing flags on attachment: 61749 Committed r63504: <http://trac.webkit.org/changeset/63504> 252272 7 commit-queue 2010-07-15 18:33:55 -0700 All reviewed patches have been landed. Closing bug. 252275 8 zmo 2010-07-15 18:39:38 -0700 Committed r63505: <http://trac.webkit.org/changeset/63505> 61738 2010-07-15 15:51:07 -0700 2010-07-15 15:56:14 -0700 Initial patch popup_sel_label.patch text/plain 2152 jcivelli SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2MzQ3NykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMTAtMDctMTUgIEpheSBDaXZlbGxpICA8amNpdmVsbGlAY2hyb21p dW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFtjaHJvbWl1bV0gTWFraW5nIHRoZSBwb3B1cCBsYWJlbCBjb2xvciB2aXNpYmxlIHdoZW4gdGhl IGl0ZW0gaXMKKyAgICAgICAgc2VsZWN0ZWQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD00MjI3MQorCisgICAgICAgICogcGxhdGZvcm0vY2hyb21pdW0v UG9wdXBNZW51Q2hyb21pdW0uY3BwOgorICAgICAgICAoV2ViQ29yZTo6UG9wdXBMaXN0Qm94Ojpw YWludFJvdyk6CisKIDIwMTAtMDctMTUgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgog CiAgICAgICAgIFJldmlld2VkIGJ5IEFkYW0gQmFydGguCkluZGV4OiBXZWJDb3JlL3BsYXRmb3Jt L2Nocm9taXVtL1BvcHVwTWVudUNocm9taXVtLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3Bs YXRmb3JtL2Nocm9taXVtL1BvcHVwTWVudUNocm9taXVtLmNwcAkocmV2aXNpb24gNjM0MzkpCisr KyBXZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL1BvcHVwTWVudUNocm9taXVtLmNwcAkod29ya2lu ZyBjb3B5KQpAQCAtODc3LDEzICs4NzcsMTcgQEAgdm9pZCBQb3B1cExpc3RCb3g6OnBhaW50Um93 KEdyYXBoaWNzQ29udAogICAgIFBvcHVwTWVudVN0eWxlIHN0eWxlID0gbV9wb3B1cENsaWVudC0+ aXRlbVN0eWxlKHJvd0luZGV4KTsKIAogICAgIC8vIFBhaW50IGJhY2tncm91bmQKLSAgICBDb2xv ciBiYWNrQ29sb3IsIHRleHRDb2xvcjsKKyAgICBDb2xvciBiYWNrQ29sb3IsIHRleHRDb2xvciwg bGFiZWxDb2xvcjsKICAgICBpZiAocm93SW5kZXggPT0gbV9zZWxlY3RlZEluZGV4KSB7CiAgICAg ICAgIGJhY2tDb2xvciA9IFJlbmRlclRoZW1lOjpkZWZhdWx0VGhlbWUoKS0+YWN0aXZlTGlzdEJv eFNlbGVjdGlvbkJhY2tncm91bmRDb2xvcigpOwogICAgICAgICB0ZXh0Q29sb3IgPSBSZW5kZXJU aGVtZTo6ZGVmYXVsdFRoZW1lKCktPmFjdGl2ZUxpc3RCb3hTZWxlY3Rpb25Gb3JlZ3JvdW5kQ29s b3IoKTsKKyAgICAgICAgbGFiZWxDb2xvciA9IHRleHRDb2xvcjsKICAgICB9IGVsc2UgewogICAg ICAgICBiYWNrQ29sb3IgPSBzdHlsZS5iYWNrZ3JvdW5kQ29sb3IoKTsKICAgICAgICAgdGV4dENv bG9yID0gc3R5bGUuZm9yZWdyb3VuZENvbG9yKCk7CisgICAgICAgIC8vIEZJWE1FOiBmb3Igbm93 IHRoZSBsYWJlbCBjb2xvciBpcyBoYXJkLWNvZGVkLiBJdCBzaG91bGQgYmUgYWRkZWQgdG8KKyAg ICAgICAgLy8gdGhlIFBvcHVwTWVudVN0eWxlLgorICAgICAgICBsYWJlbENvbG9yID0gQ29sb3Io MTE1LCAxMTUsIDExNSk7CiAgICAgfQogCiAgICAgLy8gSWYgd2UgaGF2ZSBhIHRyYW5zcGFyZW50 IGJhY2tncm91bmQsIG1ha2Ugc3VyZSBpdCBoYXMgYSBjb2xvciB0byBibGVuZApAQCAtOTY4LDkg Kzk3Miw3IEBAIHZvaWQgUG9wdXBMaXN0Qm94OjpwYWludFJvdyhHcmFwaGljc0NvbnQKICAgICAg ICAgdGV4dFggPSByb3dSZWN0LndpZHRoKCkgLSByaWdodFBhZGRpbmcgLSBpdGVtRm9udC53aWR0 aChsYWJlbFRleHRSdW4pOwogICAgIH0KIAotICAgIC8vIEZJWE1FOiBmb3Igbm93IHRoZSBsYWJl bCBjb2xvciBpcyBoYXJkLWNvZGVkLiBJdCBzaG91bGQgYmUgYWRkZWQgdG8gdGhlCi0gICAgLy8g ICAgICAgIFBvcHVwTWVudVN0eWxlLgotICAgIGdjLT5zZXRGaWxsQ29sb3IoQ29sb3IoMTE1LCAx MTUsIDExNSksIERldmljZUNvbG9yU3BhY2UpOworICAgIGdjLT5zZXRGaWxsQ29sb3IodGV4dENv bG9yLCBEZXZpY2VDb2xvclNwYWNlKTsKICAgICBnYy0+ZHJhd0JpZGlUZXh0KGl0ZW1Gb250LCBs YWJlbFRleHRSdW4sIEludFBvaW50KHRleHRYLCB0ZXh0WSkpOwogfQogCg== 61749 2010-07-15 17:06:10 -0700 2010-07-15 18:33:49 -0700 Applying Dave Levin's suggested changes. popup_sel_label.patch text/plain 2228 jcivelli SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2MzQ3NykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTAtMDctMTUgIEpheSBDaXZlbGxpICA8amNpdmVsbGlAY2hyb21p dW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFtjaHJvbWl1bV0gTWFraW5nIHRoZSBwb3B1cCBsYWJlbCBjb2xvciB2aXNpYmxlIHdoZW4gdGhl IGl0ZW0gaXMKKyAgICAgICAgc2VsZWN0ZWQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD00MjI3MQorCisgICAgICAgICogcGxhdGZvcm0vY2hyb21pdW0v UG9wdXBNZW51Q2hyb21pdW0uY3BwOgorICAgICAgICAoV2ViQ29yZTo6UG9wdXBMaXN0Qm94Ojpw YWludFJvdyk6IHBhaW50IHRoZSBsYWJlbCB0ZXh0IHdpdGggYQorICAgICAgICBkaWZmZXJlbnQg Y29sb3Igd2hlbiBpdCBpcyBzZWxlY3RlZC4gCisKIDIwMTAtMDctMTUgIEVyaWMgU2VpZGVsICA8 ZXJpY0B3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFkYW0gQmFydGguCkluZGV4 OiBXZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL1BvcHVwTWVudUNocm9taXVtLmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL1BvcHVwTWVudUNocm9taXVtLmNwcAko cmV2aXNpb24gNjM0MzkpCisrKyBXZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL1BvcHVwTWVudUNo cm9taXVtLmNwcAkod29ya2luZyBjb3B5KQpAQCAtODc3LDEzICs4NzcsMTcgQEAgdm9pZCBQb3B1 cExpc3RCb3g6OnBhaW50Um93KEdyYXBoaWNzQ29udAogICAgIFBvcHVwTWVudVN0eWxlIHN0eWxl ID0gbV9wb3B1cENsaWVudC0+aXRlbVN0eWxlKHJvd0luZGV4KTsKIAogICAgIC8vIFBhaW50IGJh Y2tncm91bmQKLSAgICBDb2xvciBiYWNrQ29sb3IsIHRleHRDb2xvcjsKKyAgICBDb2xvciBiYWNr Q29sb3IsIHRleHRDb2xvciwgbGFiZWxDb2xvcjsKICAgICBpZiAocm93SW5kZXggPT0gbV9zZWxl Y3RlZEluZGV4KSB7CiAgICAgICAgIGJhY2tDb2xvciA9IFJlbmRlclRoZW1lOjpkZWZhdWx0VGhl bWUoKS0+YWN0aXZlTGlzdEJveFNlbGVjdGlvbkJhY2tncm91bmRDb2xvcigpOwogICAgICAgICB0 ZXh0Q29sb3IgPSBSZW5kZXJUaGVtZTo6ZGVmYXVsdFRoZW1lKCktPmFjdGl2ZUxpc3RCb3hTZWxl Y3Rpb25Gb3JlZ3JvdW5kQ29sb3IoKTsKKyAgICAgICAgbGFiZWxDb2xvciA9IHRleHRDb2xvcjsK ICAgICB9IGVsc2UgewogICAgICAgICBiYWNrQ29sb3IgPSBzdHlsZS5iYWNrZ3JvdW5kQ29sb3Io KTsKICAgICAgICAgdGV4dENvbG9yID0gc3R5bGUuZm9yZWdyb3VuZENvbG9yKCk7CisgICAgICAg IC8vIEZJWE1FOiBmb3Igbm93IHRoZSBsYWJlbCBjb2xvciBpcyBoYXJkLWNvZGVkLiBJdCBzaG91 bGQgYmUgYWRkZWQgdG8KKyAgICAgICAgLy8gdGhlIFBvcHVwTWVudVN0eWxlLgorICAgICAgICBs YWJlbENvbG9yID0gQ29sb3IoMTE1LCAxMTUsIDExNSk7CiAgICAgfQogCiAgICAgLy8gSWYgd2Ug aGF2ZSBhIHRyYW5zcGFyZW50IGJhY2tncm91bmQsIG1ha2Ugc3VyZSBpdCBoYXMgYSBjb2xvciB0 byBibGVuZApAQCAtOTY4LDkgKzk3Miw3IEBAIHZvaWQgUG9wdXBMaXN0Qm94OjpwYWludFJvdyhH cmFwaGljc0NvbnQKICAgICAgICAgdGV4dFggPSByb3dSZWN0LndpZHRoKCkgLSByaWdodFBhZGRp bmcgLSBpdGVtRm9udC53aWR0aChsYWJlbFRleHRSdW4pOwogICAgIH0KIAotICAgIC8vIEZJWE1F OiBmb3Igbm93IHRoZSBsYWJlbCBjb2xvciBpcyBoYXJkLWNvZGVkLiBJdCBzaG91bGQgYmUgYWRk ZWQgdG8gdGhlCi0gICAgLy8gICAgICAgIFBvcHVwTWVudVN0eWxlLgotICAgIGdjLT5zZXRGaWxs Q29sb3IoQ29sb3IoMTE1LCAxMTUsIDExNSksIERldmljZUNvbG9yU3BhY2UpOworICAgIGdjLT5z ZXRGaWxsQ29sb3IobGFiZWxDb2xvciwgRGV2aWNlQ29sb3JTcGFjZSk7CiAgICAgZ2MtPmRyYXdC aWRpVGV4dChpdGVtRm9udCwgbGFiZWxUZXh0UnVuLCBJbnRQb2ludCh0ZXh0WCwgdGV4dFkpKTsK IH0KIAo=