42266 2010-07-14 09:00:26 -0700 [GTK] autogen.sh not executed if build-webkit options change 2010-08-14 18:23:35 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 43866 1 pnormand webkit-unassigned abarth alex eric mrobinson webkit.review.bot oldest_to_newest 251216 0 pnormand 2010-07-14 09:00:26 -0700 If I build-webkit with --disable-video and later on if I want to rebuild with video support then build-webkit --enable-video should re-execute autogen.sh or configure. It's not the case currently I believe. One solution could be to make build-webkit save the options somewhere and for the GTK port when the options change compared to last build, re-run autogen.sh or configure. 263297 1 64129 mrobinson 2010-08-11 09:42:44 -0700 Created attachment 64129 Patch for this issue 263387 2 alex 2010-08-11 12:27:23 -0700 Tested the patch disabling and enabling a feature in the file and it works for me. I found an issue doing it not related with the patch (bug 43866) that could cause problems doing this kind of changes. 264674 3 64129 kenneth 2010-08-14 07:54:40 -0700 Comment on attachment 64129 Patch for this issue You probably want to skip the previous-autogen-arguments.txt in .gitignore 264778 4 64129 mrobinson 2010-08-14 17:52:38 -0700 Comment on attachment 64129 Patch for this issue Clearing flags on attachment: 64129 Committed r65377: <http://trac.webkit.org/changeset/65377> 264779 5 mrobinson 2010-08-14 17:52:44 -0700 All reviewed patches have been landed. Closing bug. 264780 6 webkit.review.bot 2010-08-14 18:23:35 -0700 http://trac.webkit.org/changeset/65377 might have broken GTK Linux 32-bit Release 64129 2010-08-11 09:42:44 -0700 2010-08-14 17:52:38 -0700 Patch for this issue bug-42266-20100811094243.patch text/plain 2529 mrobinson ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBmN2M1ODNjN2Q3OTE1Y2EzNWQ0MDU2Yzg0OTYwZWVmYTAxYTdjN2QxLi45NzdmMzgz ZGIzMDIyYjZjMDI5MTEzZTJkZDNlNTlhODdiODNlZDhmIDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAK KzIwMTAtMDgtMTEgIE1hcnRpbiBSb2JpbnNvbiAgPG1yb2JpbnNvbkBpZ2FsaWEuY29tPgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtHVEtdIGF1dG9n ZW4uc2ggbm90IGV4ZWN1dGVkIGlmIGJ1aWxkLXdlYmtpdCBvcHRpb25zIGNoYW5nZQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDIyNjYKKworICAgICAg ICBSZXJ1biBhdXRvZ2VuLnNoIGluIHNpdHVhdGlvbnMgd2hlcmUgdGhlIGFyZ3VtZW50cyB0byBi dWlsZC13ZWJraXQgaGF2ZQorICAgICAgICBjaGFuZ2VkIHNpbmNlIHRoZSBwcmV2aW91cyBidWls ZC4gVGhpcyB3aWxsIGZpeCBzb21lIGlzc3VlcyBvbiB0aGUgYm90cworICAgICAgICB3aGVyZSB0 aGUgYnVpbGQgZG9lcyBub3Qgbm90aWNlIGNoYW5nZXMgdG8gZGVmYXVsdCBidWlsZC13ZWJraXQg YXJndW1lbnRzLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRkaXJzLnBtOiBBZGQgc3BlY2lh bCBsb2dpYyBmb3IgZGV0ZWN0aW5nIGNoYW5nZXMgdG8gYnVpbGQtd2Via2l0IGFyZ3VtZW50cy4K KwogMjAxMC0wOC0xMSAgQW50b25pbyBHb21lcyAgPHRvbmlraXRvb0B3ZWJraXQub3JnPgogCiAg ICAgICAgIFJldmlld2VkIGJ5IFNpbW9uIEhhdXNtYW5uLgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9v bHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRkaXJz LnBtCmluZGV4IDAyOGQ2M2RmNTg0NGFiNWE3N2NkNWVmOGUwNDVmZWUwN2ZiODVhYzYuLjY1MzAy NDQ3YjMzMTJlNWIxMTdkZTRkNGZjYTY4MDQ2YzY0ZTFjYjYgMTAwNjQ0Ci0tLSBhL1dlYktpdFRv b2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQorKysgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtp dGRpcnMucG0KQEAgLTEzMDIsNiArMTMwMiwyMSBAQCBzdWIgYXV0b3Rvb2xzRmxhZygkJCkKICAg ICByZXR1cm4gJHByZWZpeCAuICctJyAuICRmZWF0dXJlOwogfQogCitzdWIgYXV0b2dlbkFyZ3Vt ZW50c0hhdmVDaGFuZ2VkKCRAKQoreworICAgIG15ICgkZmlsZW5hbWUsIEBjdXJyZW50QXJndW1l bnRzKSA9IEBfOworCisgICAgaWYgKCEgLWUgJGZpbGVuYW1lKSB7CisgICAgICAgIHJldHVybiAx OworICAgIH0KKworICAgIG9wZW4oQVVUT1RPT0xTX0FSR1VNRU5UUywgJGZpbGVuYW1lKTsKKyAg ICBjaG9tcChteSAkcHJldmlvdXNBcmd1bWVudHMgPSA8QVVUT1RPT0xTX0FSR1VNRU5UUz4pOwor ICAgIGNsb3NlKEFVVE9UT09MU19BUkdVTUVOVFMpOworCisgICAgcmV0dXJuICRwcmV2aW91c0Fy Z3VtZW50cyBuZSBqb2luKCIgIiwgQGN1cnJlbnRBcmd1bWVudHMpOworfQorCiBzdWIgYnVpbGRB dXRvdG9vbHNQcm9qZWN0KCRAKQogewogICAgIG15ICgkY2xlYW4sIEBidWlsZFBhcmFtcykgPSBA XzsKQEAgLTEzNTcsOCArMTM3MiwxNiBAQCBzdWIgYnVpbGRBdXRvdG9vbHNQcm9qZWN0KCRAKQog ICAgICMgSWYgR05VbWFrZWZpbGUgZXhpc3RzLCBkb24ndCBydW4gYXV0b2dlbi5zaC4gVGhlIG1h a2VmaWxlIHNob3VsZCBiZQogICAgICMgc21hcnQgZW5vdWdoIHRvIHRyYWNrIGF1dG90b29scyBk ZXBlbmRlbmNpZXMgYW5kIHJlLXJ1biBhdXRvZ2VuLnNoCiAgICAgIyB3aGVuIGJ1aWxkIGZpbGVz IGNoYW5nZS4KKyAgICBteSAkYXV0b2dlbkFyZ3VtZW50c0ZpbGUgPSAicHJldmlvdXMtYXV0b2dl bi1hcmd1bWVudHMudHh0IjsKICAgICBteSAkcmVzdWx0OwotICAgIGlmICghIC1lICJHTlVtYWtl ZmlsZSIpIHsKKyAgICBpZiAoISgtZSAiR05VbWFrZWZpbGUiKSBvciBhdXRvZ2VuQXJndW1lbnRz SGF2ZUNoYW5nZWQoJGF1dG9nZW5Bcmd1bWVudHNGaWxlLCBAYnVpbGRBcmdzKSkgeworCisgICAg ICAgICMgV3JpdGUgYXV0b2dlbi5zaCBhcmd1bWVudHMgdG8gYSBmaWxlIHNvIHRoYXQgd2UgY2Fu IGRldGVjdAorICAgICAgICAjIHdoZW4gdGhleSBjaGFuZ2UgYW5kIGF1dG9tYXRpY2FsbHkgcmUt cnVuIGl0LgorICAgICAgICBvcGVuKEFVVE9UT09MU19BUkdVTUVOVFMsICI+JGF1dG9nZW5Bcmd1 bWVudHNGaWxlIik7CisgICAgICAgIHByaW50IEFVVE9UT09MU19BUkdVTUVOVFMgIGpvaW4oIiAi LCBAYnVpbGRBcmdzKTsKKyAgICAgICAgY2xvc2UoQVVUT1RPT0xTX0FSR1VNRU5UUyk7CisKICAg ICAgICAgcHJpbnQgIkNhbGxpbmcgY29uZmlndXJlIGluICIgLiAkZGlyIC4gIlxuXG4iOwogICAg ICAgICBwcmludCAiSW5zdGFsbGF0aW9uIHByZWZpeCBkaXJlY3Rvcnk6ICRwcmVmaXhcbiIgaWYo ZGVmaW5lZCgkcHJlZml4KSk7CiAK