42243 2010-07-14 02:41:17 -0700 Web Inspector: use OwnPtr to manage ConsoleMessages in InspectorController 2010-07-14 03:06:40 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 yurys yurys bweinstein joepeck keishi pfeldman pmuellr rik timothy yurys oldest_to_newest 251069 0 yurys 2010-07-14 02:41:17 -0700 Web Inspector: use OwnPtr to manage ConsoleMessages in InspectorController 251071 1 61496 yurys 2010-07-14 02:46:05 -0700 Created attachment 61496 Patch 251079 2 61496 yurys 2010-07-14 03:06:30 -0700 Comment on attachment 61496 Patch Clearing flags on attachment: 61496 Committed r63303: <http://trac.webkit.org/changeset/63303> 251080 3 yurys 2010-07-14 03:06:40 -0700 All reviewed patches have been landed. Closing bug. 61496 2010-07-14 02:46:05 -0700 2010-07-14 03:06:30 -0700 Patch bug-42243-20100714134602.patch text/plain 4766 yurys ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg OGVmZDgzYjlhMzA4YjY3NjY2NGY4MWE0ZjEwNWNkNjI4N2U4MGIxNC4uZTkyZWRlYmYxZTZiZGM4 YTllZGRhOWUwNzAxYTdmMTc1OWU1MWQwOSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMC0wNy0xNCAgWXVy eSBTZW1pa2hhdHNreSAgPHl1cnlzQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiB1c2UgT3duUHRyIHRv IG1hbmFnZSBDb25zb2xlTWVzc2FnZXMgaW4gSW5zcGVjdG9yQ29udHJvbGxlcgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDIyNDMKKworICAgICAgICAq IGluc3BlY3Rvci9JbnNwZWN0b3JDb250cm9sbGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Oklu c3BlY3RvckNvbnRyb2xsZXI6On5JbnNwZWN0b3JDb250cm9sbGVyKToKKyAgICAgICAgKFdlYkNv cmU6Okluc3BlY3RvckNvbnRyb2xsZXI6OmFkZENvbnNvbGVNZXNzYWdlKToKKyAgICAgICAgKFdl YkNvcmU6Okluc3BlY3RvckNvbnRyb2xsZXI6OmNsZWFyQ29uc29sZU1lc3NhZ2VzKToKKyAgICAg ICAgKiBpbnNwZWN0b3IvSW5zcGVjdG9yQ29udHJvbGxlci5oOgorICAgICAgICAoV2ViQ29yZTo6 SW5zcGVjdG9yQ29udHJvbGxlcjo6Y29uc29sZU1lc3NhZ2VzKToKKwogMjAxMC0wNy0xNCAgS2Vu dCBUYW11cmEgIDx0a2VudEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFy aW4gRmlzaGVyLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yQ29udHJv bGxlci5jcHAgYi9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JDb250cm9sbGVyLmNwcAppbmRl eCA0ZmVmMzAyYWVlYjkyNmMxNWJhM2ZlMGRhMjBlMWQ3NmUxNDcwOTk3Li4wZTQ4OTAyOWYzYmU3 NjM3NWZkZDEyYjBjZjEzYWUyNjFkMDAwMWVhIDEwMDY0NAotLS0gYS9XZWJDb3JlL2luc3BlY3Rv ci9JbnNwZWN0b3JDb250cm9sbGVyLmNwcAorKysgYi9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0 b3JDb250cm9sbGVyLmNwcApAQCAtMjE2LDcgKzIxNiw2IEBAIEluc3BlY3RvckNvbnRyb2xsZXI6 On5JbnNwZWN0b3JDb250cm9sbGVyKCkKICAgICBBU1NFUlQoIW1faGlnaGxpZ2h0ZWROb2RlKTsK IAogICAgIGRlbGV0ZUFsbFZhbHVlcyhtX2ZyYW1lUmVzb3VyY2VzKTsKLSAgICBkZWxldGVBbGxW YWx1ZXMobV9jb25zb2xlTWVzc2FnZXMpOwogCiAgICAgQVNTRVJUKHNfaW5zcGVjdG9yQ29udHJv bGxlckNvdW50KTsKICAgICAtLXNfaW5zcGVjdG9yQ29udHJvbGxlckNvdW50OwpAQCAtMzQxLDE4 ICszNDAsMTcgQEAgdm9pZCBJbnNwZWN0b3JDb250cm9sbGVyOjphZGRNZXNzYWdlVG9Db25zb2xl KE1lc3NhZ2VTb3VyY2Ugc291cmNlLCBNZXNzYWdlVHlwZQogICAgIGFkZENvbnNvbGVNZXNzYWdl KDAsIG5ldyBDb25zb2xlTWVzc2FnZShzb3VyY2UsIHR5cGUsIGxldmVsLCBtZXNzYWdlLCBsaW5l TnVtYmVyLCBzb3VyY2VJRCwgbV9ncm91cExldmVsKSk7CiB9CiAKLXZvaWQgSW5zcGVjdG9yQ29u dHJvbGxlcjo6YWRkQ29uc29sZU1lc3NhZ2UoU2NyaXB0U3RhdGUqIHNjcmlwdFN0YXRlLCBDb25z b2xlTWVzc2FnZSogY29uc29sZU1lc3NhZ2UpCit2b2lkIEluc3BlY3RvckNvbnRyb2xsZXI6OmFk ZENvbnNvbGVNZXNzYWdlKFNjcmlwdFN0YXRlKiBzY3JpcHRTdGF0ZSwgUGFzc093blB0cjxDb25z b2xlTWVzc2FnZT4gY29uc29sZU1lc3NhZ2UpCiB7CiAgICAgQVNTRVJUKGVuYWJsZWQoKSk7CiAg ICAgQVNTRVJUX0FSRyhjb25zb2xlTWVzc2FnZSwgY29uc29sZU1lc3NhZ2UpOwogCi0gICAgaWYg KG1fcHJldmlvdXNNZXNzYWdlICYmIG1fcHJldmlvdXNNZXNzYWdlLT5pc0VxdWFsKHNjcmlwdFN0 YXRlLCBjb25zb2xlTWVzc2FnZSkpIHsKKyAgICBpZiAobV9wcmV2aW91c01lc3NhZ2UgJiYgbV9w cmV2aW91c01lc3NhZ2UtPmlzRXF1YWwoc2NyaXB0U3RhdGUsIGNvbnNvbGVNZXNzYWdlLmdldCgp KSkgewogICAgICAgICBtX3ByZXZpb3VzTWVzc2FnZS0+aW5jcmVtZW50Q291bnQoKTsKLSAgICAg ICAgZGVsZXRlIGNvbnNvbGVNZXNzYWdlOwogICAgICAgICBpZiAobV9mcm9udGVuZCkKICAgICAg ICAgICAgIG1fcHJldmlvdXNNZXNzYWdlLT51cGRhdGVSZXBlYXRDb3VudEluQ29uc29sZShtX2Zy b250ZW5kLmdldCgpKTsKICAgICB9IGVsc2UgewotICAgICAgICBtX3ByZXZpb3VzTWVzc2FnZSA9 IGNvbnNvbGVNZXNzYWdlOworICAgICAgICBtX3ByZXZpb3VzTWVzc2FnZSA9IGNvbnNvbGVNZXNz YWdlLmdldCgpOwogICAgICAgICBtX2NvbnNvbGVNZXNzYWdlcy5hcHBlbmQoY29uc29sZU1lc3Nh Z2UpOwogICAgICAgICBpZiAobV9mcm9udGVuZCkKICAgICAgICAgICAgIG1fcHJldmlvdXNNZXNz YWdlLT5hZGRUb0Zyb250ZW5kKG1fZnJvbnRlbmQuZ2V0KCksIG1faW5qZWN0ZWRTY3JpcHRIb3N0 LmdldCgpKTsKQEAgLTM2MCwxNSArMzU4LDEyIEBAIHZvaWQgSW5zcGVjdG9yQ29udHJvbGxlcjo6 YWRkQ29uc29sZU1lc3NhZ2UoU2NyaXB0U3RhdGUqIHNjcmlwdFN0YXRlLCBDb25zb2xlTWVzCiAK ICAgICBpZiAoIW1fZnJvbnRlbmQgJiYgbV9jb25zb2xlTWVzc2FnZXMuc2l6ZSgpID49IG1heGlt dW1Db25zb2xlTWVzc2FnZXMpIHsKICAgICAgICAgbV9leHBpcmVkQ29uc29sZU1lc3NhZ2VDb3Vu dCArPSBleHBpcmVDb25zb2xlTWVzc2FnZXNTdGVwOwotICAgICAgICBmb3IgKHNpemVfdCBpID0g MDsgaSA8IGV4cGlyZUNvbnNvbGVNZXNzYWdlc1N0ZXA7ICsraSkKLSAgICAgICAgICAgIGRlbGV0 ZSBtX2NvbnNvbGVNZXNzYWdlc1tpXTsKICAgICAgICAgbV9jb25zb2xlTWVzc2FnZXMucmVtb3Zl KDAsIGV4cGlyZUNvbnNvbGVNZXNzYWdlc1N0ZXApOwogICAgIH0KIH0KIAogdm9pZCBJbnNwZWN0 b3JDb250cm9sbGVyOjpjbGVhckNvbnNvbGVNZXNzYWdlcygpCiB7Ci0gICAgZGVsZXRlQWxsVmFs dWVzKG1fY29uc29sZU1lc3NhZ2VzKTsKICAgICBtX2NvbnNvbGVNZXNzYWdlcy5jbGVhcigpOwog ICAgIG1fZXhwaXJlZENvbnNvbGVNZXNzYWdlQ291bnQgPSAwOwogICAgIG1fcHJldmlvdXNNZXNz YWdlID0gMDsKZGlmZiAtLWdpdCBhL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckNvbnRyb2xs ZXIuaCBiL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckNvbnRyb2xsZXIuaAppbmRleCBlZTBj OWQ2NDU5ZWZkZTFmOWI0YTk3MWZlMzg0ZWQ0YzVmODY4ZDNlLi5jODdiYWViMzkzM2NjZGI5ZTY5 NWViMjdkZWQ2MDA0ZjNlNDk0OTJjIDEwMDY0NAotLS0gYS9XZWJDb3JlL2luc3BlY3Rvci9JbnNw ZWN0b3JDb250cm9sbGVyLmgKKysrIGIvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yQ29udHJv bGxlci5oCkBAIC0xNDksNyArMTQ5LDcgQEAgcHVibGljOgogICAgIHZvaWQgYWRkTWVzc2FnZVRv Q29uc29sZShNZXNzYWdlU291cmNlLCBNZXNzYWdlVHlwZSwgTWVzc2FnZUxldmVsLCBTY3JpcHRD YWxsU3RhY2sqKTsKICAgICB2b2lkIGFkZE1lc3NhZ2VUb0NvbnNvbGUoTWVzc2FnZVNvdXJjZSwg TWVzc2FnZVR5cGUsIE1lc3NhZ2VMZXZlbCwgY29uc3QgU3RyaW5nJiBtZXNzYWdlLCB1bnNpZ25l ZCBsaW5lTnVtYmVyLCBjb25zdCBTdHJpbmcmIHNvdXJjZUlEKTsKICAgICB2b2lkIGNsZWFyQ29u c29sZU1lc3NhZ2VzKCk7Ci0gICAgY29uc3QgVmVjdG9yPENvbnNvbGVNZXNzYWdlKj4mIGNvbnNv bGVNZXNzYWdlcygpIGNvbnN0IHsgcmV0dXJuIG1fY29uc29sZU1lc3NhZ2VzOyB9CisgICAgY29u c3QgVmVjdG9yPE93blB0cjxDb25zb2xlTWVzc2FnZT4gPiYgY29uc29sZU1lc3NhZ2VzKCkgY29u c3QgeyByZXR1cm4gbV9jb25zb2xlTWVzc2FnZXM7IH0KIAogICAgIGJvb2wgc2VhcmNoaW5nRm9y Tm9kZUluUGFnZSgpIGNvbnN0IHsgcmV0dXJuIG1fc2VhcmNoaW5nRm9yTm9kZTsgfQogICAgIHZv aWQgbW91c2VEaWRNb3ZlT3ZlckVsZW1lbnQoY29uc3QgSGl0VGVzdFJlc3VsdCYsIHVuc2lnbmVk IG1vZGlmaWVyRmxhZ3MpOwpAQCAtMzE5LDcgKzMxOSw3IEBAIHByaXZhdGU6CiAKICAgICB2b2lk IGZvY3VzTm9kZSgpOwogCi0gICAgdm9pZCBhZGRDb25zb2xlTWVzc2FnZShTY3JpcHRTdGF0ZSos IENvbnNvbGVNZXNzYWdlKik7CisgICAgdm9pZCBhZGRDb25zb2xlTWVzc2FnZShTY3JpcHRTdGF0 ZSosIFBhc3NPd25QdHI8Q29uc29sZU1lc3NhZ2U+KTsKIAogICAgIHZvaWQgYWRkUmVzb3VyY2Uo SW5zcGVjdG9yUmVzb3VyY2UqKTsKICAgICB2b2lkIHJlbW92ZVJlc291cmNlKEluc3BlY3RvclJl c291cmNlKik7CkBAIC0zNTksNyArMzU5LDcgQEAgcHJpdmF0ZToKICAgICBSZXNvdXJjZXNNYXAg bV9yZXNvdXJjZXM7CiAgICAgSGFzaFNldDxTdHJpbmc+IG1fa25vd25SZXNvdXJjZXM7CiAgICAg RnJhbWVSZXNvdXJjZXNNYXAgbV9mcmFtZVJlc291cmNlczsKLSAgICBWZWN0b3I8Q29uc29sZU1l c3NhZ2UqPiBtX2NvbnNvbGVNZXNzYWdlczsKKyAgICBWZWN0b3I8T3duUHRyPENvbnNvbGVNZXNz YWdlPiA+IG1fY29uc29sZU1lc3NhZ2VzOwogICAgIHVuc2lnbmVkIG1fZXhwaXJlZENvbnNvbGVN ZXNzYWdlQ291bnQ7CiAgICAgSGFzaE1hcDxTdHJpbmcsIGRvdWJsZT4gbV90aW1lczsKICAgICBI YXNoTWFwPFN0cmluZywgdW5zaWduZWQ+IG1fY291bnRzOwo=