42238 2010-07-14 00:15:20 -0700 Selection dumping code should not dump body's offset in the document 2010-07-14 12:57:20 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 41123 1 eric eric abarth ap eric hyatt webkit.review.bot oldest_to_newest 251004 0 eric 2010-07-14 00:15:20 -0700 Selection dumping code should not dump body's offset in the document 251005 1 61476 eric 2010-07-14 00:17:37 -0700 Created attachment 61476 Patch 251006 2 eric 2010-07-14 00:18:45 -0700 I'll probably need to write a little script to update all the layout test results. This will make our results stop being sensitive to whether or not we allow whitespace nodes between the <head> and the <body> elements. We have enough tests which are sensitive to that for other reasons already. 251012 3 eric 2010-07-14 01:02:08 -0700 I wrote a little script to update all the results: #!/usr/bin/python import fileinput import os.path import re # Use IGNORECASE because "BODY" will be "body" in xhtml. position_regexp = re.compile(r"child \d {BODY} .* of document", re.IGNORECASE) for (dirpath, dirnames, filenames) in os.walk("."): for name in filenames: if not name.endswith("-expected.txt"): continue full_path = os.path.join(dirpath, name) file_input = fileinput.input(full_path, inplace=True) for line in file_input: print position_regexp.sub("body", line), 251013 4 61476 zimmermann 2010-07-14 01:05:00 -0700 Comment on attachment 61476 Patch rs=me. Remember, that you probably have to update results on all platforms. 251047 5 eric 2010-07-14 02:08:31 -0700 I am having to land this in pieces due to SVN trouble. http://trac.webkit.org/changeset/63291 http://trac.webkit.org/changeset/63292 so far. 2 more to go. 251052 6 webkit.review.bot 2010-07-14 02:17:37 -0700 http://trac.webkit.org/changeset/63292 might have broken GTK Linux 32-bit Debug The following changes are on the blame list: http://trac.webkit.org/changeset/63292 http://trac.webkit.org/changeset/63293 251054 7 eric 2010-07-14 02:18:30 -0700 http://trac.webkit.org/changeset/63295 is part 3. :) 251055 8 webkit.review.bot 2010-07-14 02:19:01 -0700 http://trac.webkit.org/changeset/63291 might have broken GTK Linux 32-bit Release 251058 9 eric 2010-07-14 02:22:06 -0700 Committed r63296: <http://trac.webkit.org/changeset/63296> 251358 10 ap 2010-07-14 12:31:10 -0700 > Selection dumping code should not dump body's offset in the document Is that to avoid visual noise in test results? 251372 11 eric 2010-07-14 12:57:20 -0700 Basically. Caused redundant testing. HTML5 as currently spec'd allows whitespace nodes between </head> and <body>, thus changing the offset of <body> within <html>. That part of the spec is currently under some debate, but it's better to have 100 tests failing because of that change (instead of nearly 1000 which failed before this patch). 61476 2010-07-14 00:17:37 -0700 2010-07-14 01:06:36 -0700 Patch bug-42238-20100714001736.patch text/plain 1773 eric ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg N2QyNzA4NjM1YWY5MTgwODkzMmJlY2EwMzE1ZGM2ODdhYTA0Y2I4Ni4uNmI2MWRiOWI2MzUzYTJh MDgwMTJmNTQwOGU3NTI5MWVmMzIzODY5OSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMC0wNy0xNCAgRXJp YyBTZWlkZWwgIDxlcmljQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgU2VsZWN0aW9uIGR1bXBpbmcgY29kZSBzaG91bGQgbm90IGR1 bXAgYm9keSdzIG9mZnNldCBpbiB0aGUgZG9jdW1lbnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQyMjM4CisKKyAgICAgICAgVGhpcyByZXF1aXJlcyB1 cGRhdGluZyB0aGUgcmVzdWx0cyBvZiBtYW55IGxheW91dCB0ZXN0cywKKyAgICAgICAgYnV0IGhh cyBubyBmdW5jdGlvbmFsIGNoYW5nZS4KKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJUcmVl QXNUZXh0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Om5vZGVQb3NpdGlvbik6CisKIDIwMTAtMDct MTMgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVHJl ZUFzVGV4dC5jcHAgYi9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUcmVlQXNUZXh0LmNwcAppbmRl eCAyNmY0MGFiNTU1MDBjYThjYTUwZWZkZjViY2MyY2IyYWYwMjVmNmRiLi43ZmYxOWEyNDNlNmUx MjdhNTFjOGU1YzJmNWEwMjUxM2MwYWQzMGFjIDEwMDY0NAotLS0gYS9XZWJDb3JlL3JlbmRlcmlu Zy9SZW5kZXJUcmVlQXNUZXh0LmNwcAorKysgYi9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUcmVl QXNUZXh0LmNwcApAQCAtNTgwLDYgKzU4MCw3IEBAIHN0YXRpYyBTdHJpbmcgbm9kZVBvc2l0aW9u KE5vZGUqIG5vZGUpCiB7CiAgICAgU3RyaW5nIHJlc3VsdDsKIAorICAgIEVsZW1lbnQqIGJvZHkg PSBub2RlLT5kb2N1bWVudCgpLT5ib2R5KCk7CiAgICAgTm9kZSogcGFyZW50OwogICAgIGZvciAo Tm9kZSogbiA9IG5vZGU7IG47IG4gPSBwYXJlbnQpIHsKICAgICAgICAgcGFyZW50ID0gbi0+cGFy ZW50Tm9kZSgpOwpAQCAtNTg3LDkgKzU4OCwxNCBAQCBzdGF0aWMgU3RyaW5nIG5vZGVQb3NpdGlv bihOb2RlKiBub2RlKQogICAgICAgICAgICAgcGFyZW50ID0gbi0+c2hhZG93UGFyZW50Tm9kZSgp OwogICAgICAgICBpZiAobiAhPSBub2RlKQogICAgICAgICAgICAgcmVzdWx0ICs9ICIgb2YgIjsK LSAgICAgICAgaWYgKHBhcmVudCkKKyAgICAgICAgaWYgKHBhcmVudCkgeworICAgICAgICAgICAg aWYgKGJvZHkgJiYgcGFyZW50ID09IGJvZHkpIHsKKyAgICAgICAgICAgICAgICAvLyBXZSBkb24n dCBjYXJlIHdoYXQgb2Zmc2V0IGJvZHkgbWF5IGJlIGluIHRoZSBkb2N1bWVudC4KKyAgICAgICAg ICAgICAgICByZXN1bHQgKz0gImJvZHkiOworICAgICAgICAgICAgICAgIGJyZWFrOworICAgICAg ICAgICAgfQogICAgICAgICAgICAgcmVzdWx0ICs9ICJjaGlsZCAiICsgU3RyaW5nOjpudW1iZXIo bi0+bm9kZUluZGV4KCkpICsgIiB7IiArIGdldFRhZ05hbWUobikgKyAifSI7Ci0gICAgICAgIGVs c2UKKyAgICAgICAgfSBlbHNlCiAgICAgICAgICAgICByZXN1bHQgKz0gImRvY3VtZW50IjsKICAg ICB9CiAK