42231 2010-07-13 21:58:01 -0700 [chromium] Linux scrollbar steppers are "clickable" even when disabled 2010-07-14 20:18:59 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 estade webkit-unassigned commit-queue oldest_to_newest 250948 0 estade 2010-07-13 21:58:01 -0700 When the new scrollbar steppers are disabled (the scrollbar is all the way at the top or bottom of the track), they look disabled, but clicking them still makes them change color. This is contrary to the gtk themes the steppers try to emulate. 250949 1 61467 estade 2010-07-13 22:00:52 -0700 Created attachment 61467 patch 250990 2 61467 tkent 2010-07-13 23:27:10 -0700 Comment on attachment 61467 patch The code looks good. Please update your WebKit tree and remake the patch please. 251271 3 61536 estade 2010-07-14 10:30:14 -0700 Created attachment 61536 synced 251587 4 61536 tkent 2010-07-14 19:21:00 -0700 Comment on attachment 61536 synced OK 251613 5 61536 commit-queue 2010-07-14 20:18:55 -0700 Comment on attachment 61536 synced Clearing flags on attachment: 61536 Committed r63397: <http://trac.webkit.org/changeset/63397> 251614 6 commit-queue 2010-07-14 20:18:59 -0700 All reviewed patches have been landed. Closing bug. 61467 2010-07-13 22:00:52 -0700 2010-07-14 10:30:14 -0700 patch tmp.diff text/plain 2061 estade SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2MzI4MikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTAtMDctMTMgIEV2YW4gU3RhZGUgIDxlc3RhZGVAY2hyb21pdW0u b3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtj aHJvbWl1bV0gTGludXggc2Nyb2xsYmFyIHN0ZXBwZXJzIGFyZSAiY2xpY2thYmxlIiBldmVuIHdo ZW4gZGlzYWJsZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTQyMjMxCisKKyAgICAgICAgTm90IHRlc3RlZCBieSBsYXlvdXQgdGVzdHMuCisKKyAgICAg ICAgKiBwbGF0Zm9ybS9jaHJvbWl1bS9TY3JvbGxiYXJUaGVtZUNocm9taXVtTGludXguY3BwOgor ICAgICAgICAoV2ViQ29yZTo6U2Nyb2xsYmFyVGhlbWVDaHJvbWl1bUxpbnV4OjpwYWludEJ1dHRv bik6CisKIDIwMTAtMDctMTMgIEtlbnQgVGFtdXJhICA8dGtlbnRAY2hyb21pdW0ub3JnPgogCiAg ICAgICAgIFJldmlld2VkIGJ5IERhcmluIEZpc2hlci4KSW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0v Y2hyb21pdW0vU2Nyb2xsYmFyVGhlbWVDaHJvbWl1bUxpbnV4LmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBX ZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL1Njcm9sbGJhclRoZW1lQ2hyb21pdW1MaW51eC5jcHAJ KHJldmlzaW9uIDYzMjc3KQorKysgV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9TY3JvbGxiYXJU aGVtZUNocm9taXVtTGludXguY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xODgsMTQgKzE4OCwxNiBA QCB2b2lkIFNjcm9sbGJhclRoZW1lQ2hyb21pdW1MaW51eDo6cGFpbnRCCiAgICAgU2tDb2xvclRv SFNWKFJlbmRlclRoZW1lQ2hyb21pdW1MaW51eDo6dHJhY2tDb2xvcigpLCB0cmFja0hTVik7CiAg ICAgU2tDb2xvciBidXR0b25Db2xvciA9IHNhdHVyYXRlQW5kQnJpZ2h0ZW4odHJhY2tIU1YsIDAs IDAuMik7CiAgICAgU2tDb2xvciBiYWNrZ3JvdW5kQ29sb3IgPSBidXR0b25Db2xvcjsKLSAgICBp ZiAocGFydCA9PSBzY3JvbGxiYXItPnByZXNzZWRQYXJ0KCkpIHsKLSAgICAgICAgU2tTY2FsYXIg YnV0dG9uSFNWWzNdOwotICAgICAgICBTa0NvbG9yVG9IU1YoYnV0dG9uQ29sb3IsIGJ1dHRvbkhT Vik7Ci0gICAgICAgIGJ1dHRvbkNvbG9yID0gc2F0dXJhdGVBbmRCcmlnaHRlbihidXR0b25IU1Ys IDAsIC0wLjEpOwotICAgIH0gZWxzZSBpZiAocGFydCA9PSBzY3JvbGxiYXItPmhvdmVyZWRQYXJ0 KCkgJiYgZW5hYmxlZCkgewotICAgICAgICBTa1NjYWxhciBidXR0b25IU1ZbM107Ci0gICAgICAg IFNrQ29sb3JUb0hTVihidXR0b25Db2xvciwgYnV0dG9uSFNWKTsKLSAgICAgICAgYnV0dG9uQ29s b3IgPSBzYXR1cmF0ZUFuZEJyaWdodGVuKGJ1dHRvbkhTViwgMCwgMC4wNSk7CisgICAgaWYgKGVu YWJsZWQpIHsKKyAgICAgICAgaWYgKHBhcnQgPT0gc2Nyb2xsYmFyLT5wcmVzc2VkUGFydCgpKSB7 CisgICAgICAgICAgICBTa1NjYWxhciBidXR0b25IU1ZbM107CisgICAgICAgICAgICBTa0NvbG9y VG9IU1YoYnV0dG9uQ29sb3IsIGJ1dHRvbkhTVik7CisgICAgICAgICAgICBidXR0b25Db2xvciA9 IHNhdHVyYXRlQW5kQnJpZ2h0ZW4oYnV0dG9uSFNWLCAwLCAtMC4xKTsKKyAgICAgICAgfSBlbHNl IGlmIChwYXJ0ID09IHNjcm9sbGJhci0+aG92ZXJlZFBhcnQoKSkgeworICAgICAgICAgICAgU2tT Y2FsYXIgYnV0dG9uSFNWWzNdOworICAgICAgICAgICAgU2tDb2xvclRvSFNWKGJ1dHRvbkNvbG9y LCBidXR0b25IU1YpOworICAgICAgICAgICAgYnV0dG9uQ29sb3IgPSBzYXR1cmF0ZUFuZEJyaWdo dGVuKGJ1dHRvbkhTViwgMCwgMC4wNSk7CisgICAgICAgIH0KICAgICB9CiAKICAgICBTa0lSZWN0 IHNrcmVjdDsK 61536 2010-07-14 10:30:14 -0700 2010-07-14 20:18:55 -0700 synced tmp.diff text/plain 1686 estade SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2MzMyNykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTAtMDctMTQgIEV2YW4gU3RhZGUgIDxlc3RhZGVAY2hyb21pdW0u b3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtj aHJvbWl1bV0gTGludXggc2Nyb2xsYmFyIHN0ZXBwZXJzIGFyZSAiY2xpY2thYmxlIiBldmVuIHdo ZW4gZGlzYWJsZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTQyMjMxCisKKyAgICAgICAgTm90IHRlc3RlZCBieSBsYXlvdXQgdGVzdHMuCisKKyAgICAg ICAgKiBwbGF0Zm9ybS9jaHJvbWl1bS9TY3JvbGxiYXJUaGVtZUNocm9taXVtTGludXguY3BwOgor ICAgICAgICAoV2ViQ29yZTo6U2Nyb2xsYmFyVGhlbWVDaHJvbWl1bUxpbnV4OjpwYWludEJ1dHRv bik6CisKIDIwMTAtMDctMTQgIEFuZHJlYXMgS2xpbmcgIDxhbmRyZWFzLmtsaW5nQG5va2lhLmNv bT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KSW5kZXg6IFdlYkNvcmUvcGxh dGZvcm0vY2hyb21pdW0vU2Nyb2xsYmFyVGhlbWVDaHJvbWl1bUxpbnV4LmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL1Njcm9sbGJhclRoZW1lQ2hyb21pdW1MaW51 eC5jcHAJKHJldmlzaW9uIDYzMzI3KQorKysgV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9TY3Jv bGxiYXJUaGVtZUNocm9taXVtTGludXguY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMTgsMTAgKzEx OCwxMiBAQCB2b2lkIFNjcm9sbGJhclRoZW1lQ2hyb21pdW1MaW51eDo6cGFpbnRCCiAgICAgICAg IHx8IChkaXJlY3Rpb24gPT0gUGxhdGZvcm1UaGVtZUNocm9taXVtR3RrOjpFYXN0IHx8IGRpcmVj dGlvbiA9PSBQbGF0Zm9ybVRoZW1lQ2hyb21pdW1HdGs6OlNvdXRoKSAmJiBzY3JvbGxiYXItPmN1 cnJlbnRQb3MoKSAhPSBzY3JvbGxiYXItPm1heGltdW0oKSkKICAgICAgICAgc3RhdGVzIHw9IEVu YWJsZWRTdGF0ZTsKIAotICAgIGlmIChwYXJ0ID09IHNjcm9sbGJhci0+cHJlc3NlZFBhcnQoKSkK LSAgICAgICAgc3RhdGVzIHw9IFByZXNzZWRTdGF0ZTsKLSAgICBlbHNlIGlmIChwYXJ0ID09IHNj cm9sbGJhci0+aG92ZXJlZFBhcnQoKSAmJiBzdGF0ZXMgJiBFbmFibGVkU3RhdGUpCi0gICAgICAg IHN0YXRlcyB8PSBIb3ZlclN0YXRlOworICAgIGlmIChzdGF0ZXMgJiBFbmFibGVkU3RhdGUpIHsK KyAgICAgICAgaWYgKHBhcnQgPT0gc2Nyb2xsYmFyLT5wcmVzc2VkUGFydCgpKQorICAgICAgICAg ICAgc3RhdGVzIHw9IFByZXNzZWRTdGF0ZTsKKyAgICAgICAgZWxzZSBpZiAocGFydCA9PSBzY3Jv bGxiYXItPmhvdmVyZWRQYXJ0KCkpCisgICAgICAgICAgICBzdGF0ZXMgfD0gSG92ZXJTdGF0ZTsK KyAgICB9CiAKICAgICBQbGF0Zm9ybVRoZW1lQ2hyb21pdW1HdGs6OnBhaW50QXJyb3dCdXR0b24o Z2MsIHJlY3QsIGRpcmVjdGlvbiwgc3RhdGVzKTsKIH0K