42219 2010-07-13 17:48:56 -0700 AX: VoiceOver cannot navigate this page because Safari is taking too long 2010-07-14 13:31:17 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 cfleizach cfleizach bdakin darin oldest_to_newest 250860 0 cfleizach 2010-07-13 17:48:56 -0700 VoiceOver can't navigate this page because Safari is used absoluteFocusRingQuads() to calculate the size of the web area, which descends into every child element and sums up the rectangles. http://www.siye.co.uk/siye/viewstory.php?action=printable&textsize=0&sid=12548&chapter=all#top I think the web area should not use absoluteFocusRingQuads(), but absoluteQuads() instead 250862 1 61441 cfleizach 2010-07-13 17:50:58 -0700 Created attachment 61441 patch 250863 2 61442 cfleizach 2010-07-13 17:51:52 -0700 Created attachment 61442 patch 250954 3 61442 darin 2010-07-13 22:12:02 -0700 Comment on attachment 61442 patch > + // absoluteFocusRingQuads will query the hierarchy below this element, which for large webpages can be very slow. > + // For a web area, which will have the most elements of any element, absoluteQuads should be used. Are there any other cases where absoluteQuads would be better? Should absoluteFocusRungQuads itself have an optimization for this case? r=me 250962 4 cfleizach 2010-07-13 22:24:21 -0700 (In reply to comment #3) > (From update of attachment 61442 [details]) > > + // absoluteFocusRingQuads will query the hierarchy below this element, which for large webpages can be very slow. > > + // For a web area, which will have the most elements of any element, absoluteQuads should be used. > > Are there any other cases where absoluteQuads would be better? Should absoluteFocusRungQuads itself have an optimization for this case? > I was trying to think of other cases that might be pertinent (AXGroups being the best candidate), but it seemed more prudent to wait for evidence of those cases than make assumptions here. I looked through absoluteFocusRingQuads and given that the nature of the function seems to iterate every child, it didn't look like there was much that could be done (since there are over 15000 children of this web area). If you have any ideas off the top of your head please let me know. > r=me 251401 5 cfleizach 2010-07-14 13:31:17 -0700 http://trac.webkit.org/changeset/63350 61441 2010-07-13 17:50:58 -0700 2010-07-13 17:51:52 -0700 patch patch.txt text/plain 1522 cfleizach SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2MzI3MCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTAtMDctMTMgIENocmlzIEZsZWl6YWNoICA8Y2ZsZWl6YWNoQGFw cGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBBWDogVm9pY2VPdmVyIGNhbm5vdCBuYXZpZ2F0ZSB0aGlzIHBhZ2UgYmVjYXVzZSBTYWZhcmkg aXMgdGFraW5nIHRvbyBsb25nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD00MjIxOQorCisgICAgICAgIE5vIHRlc3RzLiBFeGlzdGluZyB0ZXN0cyBjb3Zl ciBjaGFuZ2UuCisKKyAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlSZW5kZXJP YmplY3QuY3BwOgorICAgICAgICAoV2ViQ29yZTo6QWNjZXNzaWJpbGl0eVJlbmRlck9iamVjdDo6 Ym91bmRpbmdCb3hSZWN0KToKKwogMjAxMC0wNy0xMyAgQW5kcmVhcyBLbGluZyAgPGFuZHJlYXMu a2xpbmdAbm9raWEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgpJbmRl eDogV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlSZW5kZXJPYmplY3QuY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFdlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5UmVuZGVyT2Jq ZWN0LmNwcAkocmV2aXNpb24gNjI5NjApCisrKyBXZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNz aWJpbGl0eVJlbmRlck9iamVjdC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEzOTcsOCArMTM5Nywx MCBAQAogICAgIGlmIChvYmotPm5vZGUoKSkgLy8gSWYgd2UgYXJlIGEgY29udGludWF0aW9uLCB3 ZSB3YW50IHRvIG1ha2Ugc3VyZSB0byB1c2UgdGhlIHByaW1hcnkgcmVuZGVyZXIuCiAgICAgICAg IG9iaiA9IG9iai0+bm9kZSgpLT5yZW5kZXJlcigpOwogICAgIAorICAgIC8vIGFic29sdXRlRm9j dXNSaW5nUXVhZHMgd2lsbCB0aGUgaGllcmFyY2h5IGJlbG93IHRoaXMgZWxlbWVudCwgd2hpY2gg Zm9yIGxhcmdlIHdlYnBhZ2VzIGNhbiBiZSB2ZXJ5IHNsb3cuCisgICAgLy8gRm9yIGEgd2ViIGFy ZWEsIHdoaWNoIHdpbGwgaGF2ZSB0aGUgbW9zdCBlbGVtZW50cyBvZiBhbnkgZWxlbWVudCwgYWJz b2x1dGVRdWFkcyBzaG91bGQgYmUgdXNlZC4KICAgICBWZWN0b3I8RmxvYXRRdWFkPiBxdWFkczsK LSAgICBpZiAob2JqLT5pc1RleHQoKSkKKyAgICBpZiAob2JqLT5pc1RleHQoKSB8fCBpc1dlYkFy ZWEoKSkKICAgICAgICAgb2JqLT5hYnNvbHV0ZVF1YWRzKHF1YWRzKTsKICAgICBlbHNlCiAgICAg ICAgIG9iai0+YWJzb2x1dGVGb2N1c1JpbmdRdWFkcyhxdWFkcyk7Cg== 61442 2010-07-13 17:51:52 -0700 2010-07-13 22:12:02 -0700 patch patch.txt text/plain 1528 cfleizach SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2MzI3MCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTAtMDctMTMgIENocmlzIEZsZWl6YWNoICA8Y2ZsZWl6YWNoQGFw cGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBBWDogVm9pY2VPdmVyIGNhbm5vdCBuYXZpZ2F0ZSB0aGlzIHBhZ2UgYmVjYXVzZSBTYWZhcmkg aXMgdGFraW5nIHRvbyBsb25nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD00MjIxOQorCisgICAgICAgIE5vIHRlc3RzLiBFeGlzdGluZyB0ZXN0cyBjb3Zl ciBjaGFuZ2UuCisKKyAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlSZW5kZXJP YmplY3QuY3BwOgorICAgICAgICAoV2ViQ29yZTo6QWNjZXNzaWJpbGl0eVJlbmRlck9iamVjdDo6 Ym91bmRpbmdCb3hSZWN0KToKKwogMjAxMC0wNy0xMyAgQW5kcmVhcyBLbGluZyAgPGFuZHJlYXMu a2xpbmdAbm9raWEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgpJbmRl eDogV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlSZW5kZXJPYmplY3QuY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFdlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5UmVuZGVyT2Jq ZWN0LmNwcAkocmV2aXNpb24gNjI5NjApCisrKyBXZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNz aWJpbGl0eVJlbmRlck9iamVjdC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEzOTcsOCArMTM5Nywx MCBAQAogICAgIGlmIChvYmotPm5vZGUoKSkgLy8gSWYgd2UgYXJlIGEgY29udGludWF0aW9uLCB3 ZSB3YW50IHRvIG1ha2Ugc3VyZSB0byB1c2UgdGhlIHByaW1hcnkgcmVuZGVyZXIuCiAgICAgICAg IG9iaiA9IG9iai0+bm9kZSgpLT5yZW5kZXJlcigpOwogICAgIAorICAgIC8vIGFic29sdXRlRm9j dXNSaW5nUXVhZHMgd2lsbCBxdWVyeSB0aGUgaGllcmFyY2h5IGJlbG93IHRoaXMgZWxlbWVudCwg d2hpY2ggZm9yIGxhcmdlIHdlYnBhZ2VzIGNhbiBiZSB2ZXJ5IHNsb3cuCisgICAgLy8gRm9yIGEg d2ViIGFyZWEsIHdoaWNoIHdpbGwgaGF2ZSB0aGUgbW9zdCBlbGVtZW50cyBvZiBhbnkgZWxlbWVu dCwgYWJzb2x1dGVRdWFkcyBzaG91bGQgYmUgdXNlZC4KICAgICBWZWN0b3I8RmxvYXRRdWFkPiBx dWFkczsKLSAgICBpZiAob2JqLT5pc1RleHQoKSkKKyAgICBpZiAob2JqLT5pc1RleHQoKSB8fCBp c1dlYkFyZWEoKSkKICAgICAgICAgb2JqLT5hYnNvbHV0ZVF1YWRzKHF1YWRzKTsKICAgICBlbHNl CiAgICAgICAgIG9iai0+YWJzb2x1dGVGb2N1c1JpbmdRdWFkcyhxdWFkcyk7Cg==