42210 2010-07-13 16:32:41 -0700 [chromium] Autofill menu shows seperator at the wrong place when an entry is deleted 2010-07-14 20:01:00 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC Windows 7 RESOLVED FIXED P2 Normal --- 1 sky sky commit-queue dhollowa jhawkins levin oldest_to_newest 250807 0 sky 2010-07-13 16:32:41 -0700 - Trigger the autofill popup in a form text input where you have autofill and autocomplete values. - In the popup, select the autocomplete value and press the delete key Expected: The selected entry is deleted and the menu shows the remaining entries, the separator and "Autofill options" Actual: The selected entry is deleted but "Autofill options" menu shows before the separator and if selected fills the text input with the actula "Autofill options" string 250810 1 61430 sky 2010-07-13 16:36:08 -0700 Created attachment 61430 Initial fix 250817 2 jhawkins 2010-07-13 16:43:17 -0700 LGTM 250984 3 61430 levin 2010-07-13 23:02:48 -0700 Comment on attachment 61430 Initial fix > Index: ChangeLog > + * ../../WebKit/chromium/src/AutoFillPopupMenuClient.cpp: > A few probloems: 1. The is either the wrong ChangeLog or else this patch is malformed. It should be the ChangeLog at WebKit/chromium/ChangeLog. 2. The path in the ChangeLog is messed up. 3. The function being modified is missing in the ChangeLog. My bad if I missed any of these things before. Lastly,it is nice to give a *small* comment by the function in the ChangeLog to explain what was done. (It looks like the change involves account for the separator index.) 251292 4 61539 sky 2010-07-14 11:04:46 -0700 Created attachment 61539 Addresses review feedback Adds call to popupmenuclient to make sure the removal is allowed. Without this the WebViewClient was notified even if the remove wasn't allowed. 251322 5 jhawkins 2010-07-14 11:36:46 -0700 Patch set 2 LGTM, much better. 251366 6 dhollowa 2010-07-14 12:41:37 -0700 LGTM. 251606 7 61539 commit-queue 2010-07-14 20:00:55 -0700 Comment on attachment 61539 Addresses review feedback Clearing flags on attachment: 61539 Committed r63395: <http://trac.webkit.org/changeset/63395> 251607 8 commit-queue 2010-07-14 20:01:00 -0700 All reviewed patches have been landed. Closing bug. 61430 2010-07-13 16:36:08 -0700 2010-07-14 11:04:46 -0700 Initial fix webkit.patch text/plain 1533 sky SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDYzMjU5 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTAtMDct MTMgIFNjb3R0IFZpb2xldCAgPHNreUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0Nocm9taXVtXSBBdXRvZmlsbCBtZW51IHNo b3dzIHNlcGVyYXRvciBhdCB0aGUgd3JvbmcgcGxhY2Ugd2hlbiBhbiBlbnRyeSBpcyBkZWxldGVk CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MjIxMAor CisgICAgICAgICogLi4vLi4vV2ViS2l0L2Nocm9taXVtL3NyYy9BdXRvRmlsbFBvcHVwTWVudUNs aWVudC5jcHA6CisKIDIwMTAtMDctMTMgIFNjb3R0IFZpb2xldCAgPHNreUBjaHJvbWl1bS5vcmc+ CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGF2aWQgTGV2aW4uCkluZGV4OiBXZWJLaXQvY2hyb21p dW0vc3JjL0F1dG9GaWxsUG9wdXBNZW51Q2xpZW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQv Y2hyb21pdW0vc3JjL0F1dG9GaWxsUG9wdXBNZW51Q2xpZW50LmNwcAkocmV2aXNpb24gNjMyNTIp CisrKyBXZWJLaXQvY2hyb21pdW0vc3JjL0F1dG9GaWxsUG9wdXBNZW51Q2xpZW50LmNwcAkod29y a2luZyBjb3B5KQpAQCAtODYsMTAgKzg2LDE4IEBAIFdlYlN0cmluZyBBdXRvRmlsbFBvcHVwTWVu dUNsaWVudDo6Z2V0TGEKIAogdm9pZCBBdXRvRmlsbFBvcHVwTWVudUNsaWVudDo6cmVtb3ZlU3Vn Z2VzdGlvbkF0SW5kZXgodW5zaWduZWQgbGlzdEluZGV4KQogewotICAgIC8vIEZJWE1FOiBEbyB3 ZSB3YW50IHRvIHJlbW92ZSBBdXRvRmlsbCBzdWdnZXN0aW9ucz8KKyAgICBpZiAobV9zZXBhcmF0 b3JJbmRleCAhPSAtMSAmJiBsaXN0SW5kZXggPj0gbV9zZXBhcmF0b3JJbmRleCkKKyAgICAgICAg cmV0dXJuOyAvLyBEb24ndCBhbGxvdyBkZWxldGluZyBhbnl0aGluZyBhZnRlciB0aGUgc2VwYXJh dG9yLgorCiAgICAgQVNTRVJUKGxpc3RJbmRleCA8IG1fbmFtZXMuc2l6ZSgpKTsKKworICAgIC8v IE5vIG5lZWQgdG8gY29udmVydCBsaXN0SW5kZXggYXMgd2UgZW5zdXJlZCBpdCdzIG5vdCBwYXN0 IHRoZSBzZXBhcmF0b3IuCiAgICAgbV9uYW1lcy5yZW1vdmUobGlzdEluZGV4KTsKICAgICBtX2xh YmVscy5yZW1vdmUobGlzdEluZGV4KTsKKworICAgIC8vIFNoaWZ0IHRoZSBzZXBhcmF0b3IgaW5k ZXggaWYgbmVjZXNzYXJ5LgorICAgIGlmIChtX3NlcGFyYXRvckluZGV4ICE9IC0xKQorICAgICAg ICBtX3NlcGFyYXRvckluZGV4LS07CiB9CiAKIHZvaWQgQXV0b0ZpbGxQb3B1cE1lbnVDbGllbnQ6 OnZhbHVlQ2hhbmdlZCh1bnNpZ25lZCBsaXN0SW5kZXgsIGJvb2wgZmlyZUV2ZW50cykK 61539 2010-07-14 11:04:46 -0700 2010-07-14 20:00:55 -0700 Addresses review feedback webkit.patch text/plain 3892 sky SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNjMzMzEpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTAtMDctMTQgIFNjb3R0 IFZpb2xldCAgPHNreUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgW2Nocm9taXVtXSBBdXRvZmlsbCBtZW51IHNob3dzIHNlcGVy YXRvciBhdCB0aGUgd3JvbmcgcGxhY2Ugd2hlbiBhbiBlbnRyeSBpcyBkZWxldGVkCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MjIxMAorCisgICAgICAg ICogc3JjL0F1dG9GaWxsUG9wdXBNZW51Q2xpZW50LmNwcDoKKyAgICAgICAgKFdlYktpdDo6QXV0 b0ZpbGxQb3B1cE1lbnVDbGllbnQ6OnJlbW92ZVN1Z2dlc3Rpb25BdEluZGV4KTogVXBkYXRlcyBp bnRlcm5hbCBkYXRhIGFwcHJvcHJpYXRlbHkuCisgICAgICAgIChXZWJLaXQ6OkF1dG9GaWxsUG9w dXBNZW51Q2xpZW50OjpjYW5SZW1vdmVTdWdnZXN0aW9uQXRJbmRleCk6IE5vdyBjYWxsZWQgYmVm b3JlIHJlbW92YWwgdG8gc2VlIGlmIGNhbiByZW1vdmUuCisgICAgICAgICogc3JjL0F1dG9GaWxs UG9wdXBNZW51Q2xpZW50Lmg6IEZpeGVkIHdoaXRlc3BhY2UgYW5kIGFkZGVkIG1ldGhvZC4KKyAg ICAgICAgKiBzcmMvV2ViVmlld0ltcGwuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJWaWV3SW1w bDo6YXV0b2NvbXBsZXRlSGFuZGxlS2V5RXZlbnQpOiBBZGRlZCBjYWxsIHRvIGNhblJlbW92ZVN1 Z2dlc3Rpb25BdEluZGV4LgorCiAyMDEwLTA3LTE0ICBTaGVyaWZmIEJvdCAgPHdlYmtpdC5yZXZp ZXcuYm90QGdtYWlsLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByNjMz MDUuCkluZGV4OiBXZWJLaXQvY2hyb21pdW0vc3JjL0F1dG9GaWxsUG9wdXBNZW51Q2xpZW50LmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBXZWJLaXQvY2hyb21pdW0vc3JjL0F1dG9GaWxsUG9wdXBNZW51Q2xp ZW50LmNwcAkocmV2aXNpb24gNjMzMjkpCisrKyBXZWJLaXQvY2hyb21pdW0vc3JjL0F1dG9GaWxs UG9wdXBNZW51Q2xpZW50LmNwcAkod29ya2luZyBjb3B5KQpAQCAtODYsMTAgKzg2LDI3IEBAIFdl YlN0cmluZyBBdXRvRmlsbFBvcHVwTWVudUNsaWVudDo6Z2V0TGEKIAogdm9pZCBBdXRvRmlsbFBv cHVwTWVudUNsaWVudDo6cmVtb3ZlU3VnZ2VzdGlvbkF0SW5kZXgodW5zaWduZWQgbGlzdEluZGV4 KQogewotICAgIC8vIEZJWE1FOiBEbyB3ZSB3YW50IHRvIHJlbW92ZSBBdXRvRmlsbCBzdWdnZXN0 aW9ucz8KLSAgICBBU1NFUlQobGlzdEluZGV4IDwgbV9uYW1lcy5zaXplKCkpOwotICAgIG1fbmFt ZXMucmVtb3ZlKGxpc3RJbmRleCk7Ci0gICAgbV9sYWJlbHMucmVtb3ZlKGxpc3RJbmRleCk7Cisg ICAgaWYgKCFjYW5SZW1vdmVTdWdnZXN0aW9uQXRJbmRleChsaXN0SW5kZXgpKQorICAgICAgICBy ZXR1cm47CisKKyAgICBpbnQgaW5kZXggPSBjb252ZXJ0TGlzdEluZGV4VG9JbnRlcm5hbEluZGV4 KGxpc3RJbmRleCk7CisKKyAgICBBU1NFUlQoaW5kZXggPCBtX25hbWVzLnNpemUoKSk7CisKKyAg ICBtX25hbWVzLnJlbW92ZShpbmRleCk7CisgICAgbV9sYWJlbHMucmVtb3ZlKGluZGV4KTsKKwor ICAgIC8vIFNoaWZ0IHRoZSBzZXBhcmF0b3IgaW5kZXggaWYgbmVjZXNzYXJ5LgorICAgIGlmICht X3NlcGFyYXRvckluZGV4ICE9IC0xKQorICAgICAgICBtX3NlcGFyYXRvckluZGV4LS07Cit9CisK K2Jvb2wgQXV0b0ZpbGxQb3B1cE1lbnVDbGllbnQ6OmNhblJlbW92ZVN1Z2dlc3Rpb25BdEluZGV4 KHVuc2lnbmVkIGxpc3RJbmRleCkKK3sKKyAgICAvLyBPbmx5IGFsbG93IGRlbGV0aW9uIG9mIGl0 ZW1zIGJlZm9yZSB0aGUgc2VwYXJhdG9yIGFuZCB0aG9zZSB0aGF0IGRvbid0CisgICAgLy8gaGF2 ZSBhIGxhYmVsIChhdXRvY29tcGxldGUpLgorICAgIGludCBpbmRleCA9IGNvbnZlcnRMaXN0SW5k ZXhUb0ludGVybmFsSW5kZXgobGlzdEluZGV4KTsKKyAgICByZXR1cm4gbV9sYWJlbHNbaW5kZXhd LmlzRW1wdHkoKSAmJiAobV9zZXBhcmF0b3JJbmRleCA9PSAtMSB8fCBsaXN0SW5kZXggPCBtX3Nl cGFyYXRvckluZGV4KTsKIH0KIAogdm9pZCBBdXRvRmlsbFBvcHVwTWVudUNsaWVudDo6dmFsdWVD aGFuZ2VkKHVuc2lnbmVkIGxpc3RJbmRleCwgYm9vbCBmaXJlRXZlbnRzKQpJbmRleDogV2ViS2l0 L2Nocm9taXVtL3NyYy9BdXRvRmlsbFBvcHVwTWVudUNsaWVudC5oCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdl YktpdC9jaHJvbWl1bS9zcmMvQXV0b0ZpbGxQb3B1cE1lbnVDbGllbnQuaAkocmV2aXNpb24gNjMz MjkpCisrKyBXZWJLaXQvY2hyb21pdW0vc3JjL0F1dG9GaWxsUG9wdXBNZW51Q2xpZW50LmgJKHdv cmtpbmcgY29weSkKQEAgLTU5LDEwICs1OSwxMyBAQCBwdWJsaWM6CiAKICAgICAvLyBSZXR1cm5z IHRoZSBsYWJlbCBhdCB8bGlzdEluZGV4fC4KICAgICB2aXJ0dWFsIFdlYlN0cmluZyBnZXRMYWJl bCh1bnNpZ25lZCBsaXN0SW5kZXgpIGNvbnN0OwotICAgIAorCiAgICAgLy8gUmVtb3ZlcyB0aGUg c3VnZ2VzdGlvbiBhdCB8bGlzdEluZGV4fCBmcm9tIHRoZSBsaXN0IG9mIHN1Z2dlc3Rpb25zLgog ICAgIHZpcnR1YWwgdm9pZCByZW1vdmVTdWdnZXN0aW9uQXRJbmRleCh1bnNpZ25lZCBsaXN0SW5k ZXgpOwogCisgICAgLy8gUmV0dXJucyB0cnVlIGlmIHRoZSBzdWdnZXN0aW9uIGF0IHxsaXN0SW5k ZXh8IGNhbiBiZSByZW1vdmVkLgorICAgIGJvb2wgY2FuUmVtb3ZlU3VnZ2VzdGlvbkF0SW5kZXgo dW5zaWduZWQgbGlzdEluZGV4KTsKKwogICAgIC8vIFdlYkNvcmU6OlBvcHVwTWVudUNsaWVudCBt ZXRob2RzOgogICAgIHZpcnR1YWwgdm9pZCB2YWx1ZUNoYW5nZWQodW5zaWduZWQgbGlzdEluZGV4 LCBib29sIGZpcmVFdmVudHMgPSB0cnVlKTsKICAgICB2aXJ0dWFsIHZvaWQgc2VsZWN0aW9uQ2hh bmdlZCh1bnNpZ25lZCwgYm9vbCk7CkluZGV4OiBXZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJ bXBsLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmNw cAkocmV2aXNpb24gNjMzMjkpCisrKyBXZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmNw cAkod29ya2luZyBjb3B5KQpAQCAtNTg5LDYgKzU4OSwxMCBAQCBib29sIFdlYlZpZXdJbXBsOjph dXRvY29tcGxldGVIYW5kbGVLZXlFCiAgICAgICAgIH0KIAogICAgICAgICBpbnQgc2VsZWN0ZWRJ bmRleCA9IG1fYXV0b0ZpbGxQb3B1cC0+c2VsZWN0ZWRJbmRleCgpOworCisgICAgICAgIGlmICgh bV9hdXRvRmlsbFBvcHVwQ2xpZW50LT5jYW5SZW1vdmVTdWdnZXN0aW9uQXRJbmRleChzZWxlY3Rl ZEluZGV4KSkKKyAgICAgICAgICAgIHJldHVybiBmYWxzZTsKKwogICAgICAgICBIVE1MSW5wdXRF bGVtZW50KiBpbnB1dEVsZW1lbnQgPSBzdGF0aWNfY2FzdDxIVE1MSW5wdXRFbGVtZW50Kj4oZWxl bWVudCk7CiAgICAgICAgIFdlYlN0cmluZyBuYW1lID0gaW5wdXRFbGVtZW50LT5uYW1lKCk7CiAg ICAgICAgIFdlYlN0cmluZyB2YWx1ZSA9IG1fYXV0b0ZpbGxQb3B1cENsaWVudC0+aXRlbVRleHQo c2VsZWN0ZWRJbmRleCk7Cg==