42206 2010-07-13 14:51:04 -0700 [chromium] autofill suggestion popup should show the entire text 2010-07-14 19:16:45 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 0 jcivelli webkit-unassigned commit-queue dhollowa jhawkins webkit.review.bot oldest_to_newest 250759 0 jcivelli 2010-07-13 14:51:04 -0700 To ensure that users do not fill a form with information they do not realized they specified, the autofill suggestion popup should show the entire text (right now it limits the popup width to the text input width). 250764 1 61421 jcivelli 2010-07-13 14:58:55 -0700 Created attachment 61421 Initial patch 250768 2 jhawkins 2010-07-13 15:00:33 -0700 LGTM 250769 3 webkit.review.bot 2010-07-13 15:01:00 -0700 Attachment 61421 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebKit/chromium/src/WebViewImpl.cpp:163: One space before end of line comments [whitespace/comments] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 250777 4 61421 levin 2010-07-13 15:30:29 -0700 Comment on attachment 61421 Initial patch > Index: WebKit/chromium/src/WebViewImpl.cpp > + false, // restrictWidthOfListBox (for security reasons show the entire > + // entry so the user doesn't enter information it did not intend to) Please consider starting with a capital letter "For security..." and ending with a period " did no intend to." 251260 5 61532 jcivelli 2010-07-14 10:17:01 -0700 Created attachment 61532 Patch for landing 251581 6 61532 commit-queue 2010-07-14 19:16:40 -0700 Comment on attachment 61532 Patch for landing Clearing flags on attachment: 61532 Committed r63391: <http://trac.webkit.org/changeset/63391> 251582 7 commit-queue 2010-07-14 19:16:45 -0700 All reviewed patches have been landed. Closing bug. 61421 2010-07-13 14:58:55 -0700 2010-07-14 10:16:56 -0700 Initial patch popup_width.patch text/plain 1405 jcivelli SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cNCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NCi0tLSBXZWJLaXQv Y2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiA2MzI0OSkKKysrIFdlYktpdC9jaHJvbWl1bS9D aGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMiBAQAorMjAxMC0wNy0xMyAgSmF5 IENpdmVsbGkgIDxqY2l2ZWxsaUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW2Nocm9taXVtXSBkb24ndCByZXN0cmljdCB0aGUg d2lkdGggb2YgdGhlIGF1dG9maWxsIHBvcHVwLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDIyMDYKKworICAgICAgICAqIHNyYy9XZWJWaWV3SW1wbC5j cHA6CisKIDIwMTAtMDctMTMgIEFsYmVydCBKLiBXb25nICA8YWp3b25nQGNocm9taXVtLm9yZz4K IAogICAgICAgICBVbnJldmlld2VkLCBidWlsZCBmaXguCkluZGV4OiBXZWJLaXQvY2hyb21pdW0v c3JjL1dlYlZpZXdJbXBsLmNwcA0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KLS0tIFdlYktpdC9jaHJvbWl1bS9zcmMv V2ViVmlld0ltcGwuY3BwCShyZXZpc2lvbiA2MzEzMSkKKysrIFdlYktpdC9jaHJvbWl1bS9zcmMv V2ViVmlld0ltcGwuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNjAsNyArMTYwLDggQEAgc3RhdGlj IGNvbnN0IFBvcHVwQ29udGFpbmVyU2V0dGluZ3MgYXV0bwogICAgIGZhbHNlLCAgLy8gc2V0VGV4 dE9uSW5kZXhDaGFuZ2UKICAgICBmYWxzZSwgIC8vIGFjY2VwdE9uQWJhbmRvbgogICAgIHRydWUs ICAgLy8gbG9vcFNlbGVjdGlvbk5hdmlnYXRpb24KLSAgICB0cnVlLCAgIC8vIHJlc3RyaWN0V2lk dGhPZkxpc3RCb3guIFNhbWUgYXMgb3RoZXIgYnJvd3NlciAoRngsIElFLCBhbmQgc2FmYXJpKQor ICAgIGZhbHNlLCAgLy8gcmVzdHJpY3RXaWR0aE9mTGlzdEJveCAoZm9yIHNlY3VyaXR5IHJlYXNv bnMgc2hvdyB0aGUgZW50aXJlCisgICAgICAgICAgICAvLyBlbnRyeSBzbyB0aGUgdXNlciBkb2Vz bid0IGVudGVyIGluZm9ybWF0aW9uIGl0IGRpZCBub3QgaW50ZW5kIHRvKQogICAgIC8vIEZvciBz dWdnZXN0aW9ucywgd2UgdXNlIHRoZSBkaXJlY3Rpb24gb2YgdGhlIGlucHV0IGZpZWxkIGFzIHRo ZSBkaXJlY3Rpb24KICAgICAvLyBvZiB0aGUgcG9wdXAgaXRlbXMuIFRoZSBtYWluIHJlYXNvbiBp cyB0byBrZWVwIHRoZSBkaXNwbGF5IG9mIGl0ZW1zIGluCiAgICAgLy8gZHJvcC1kb3duIHRoZSBz YW1lIGFzIHRoZSBpdGVtcyBpbiB0aGUgaW5wdXQgZmllbGQuCg== 61532 2010-07-14 10:17:01 -0700 2010-07-14 19:16:40 -0700 Patch for landing bug-42206-20100714101700.patch text/plain 1635 jcivelli SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNjMzMjYpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTAtMDctMTMgIEpheSBD aXZlbGxpICA8amNpdmVsbGlAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IERh dmlkIExldmluLgorCisgICAgICAgIFtjaHJvbWl1bV0gZG9uJ3QgcmVzdHJpY3QgdGhlIHdpZHRo IG9mIHRoZSBhdXRvZmlsbCBwb3B1cC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTQyMjA2CisKKyAgICAgICAgKiBzcmMvV2ViVmlld0ltcGwuY3BwOgor CiAyMDEwLTA3LTE0ICBTaGVyaWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90QGdtYWlsLmNvbT4K IAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByNjMzMDUuCkluZGV4OiBXZWJLaXQv Y2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQvY2hyb21p dW0vc3JjL1dlYlZpZXdJbXBsLmNwcAkocmV2aXNpb24gNjMzMjYpCisrKyBXZWJLaXQvY2hyb21p dW0vc3JjL1dlYlZpZXdJbXBsLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTU4LDEwICsxNTgsMTEg QEAgQ09NUElMRV9BU1NFUlRfTUFUQ0hJTkdfRU5VTShEcmFnT3BlcmF0aQogQ09NUElMRV9BU1NF UlRfTUFUQ0hJTkdfRU5VTShEcmFnT3BlcmF0aW9uRXZlcnkpOwogCiBzdGF0aWMgY29uc3QgUG9w dXBDb250YWluZXJTZXR0aW5ncyBhdXRvRmlsbFBvcHVwU2V0dGluZ3MgPSB7Ci0gICAgZmFsc2Us ICAvLyBzZXRUZXh0T25JbmRleENoYW5nZQotICAgIGZhbHNlLCAgLy8gYWNjZXB0T25BYmFuZG9u Ci0gICAgdHJ1ZSwgICAvLyBsb29wU2VsZWN0aW9uTmF2aWdhdGlvbgotICAgIHRydWUsICAgLy8g cmVzdHJpY3RXaWR0aE9mTGlzdEJveC4gU2FtZSBhcyBvdGhlciBicm93c2VyIChGeCwgSUUsIGFu ZCBzYWZhcmkpCisgICAgZmFsc2UsIC8vIHNldFRleHRPbkluZGV4Q2hhbmdlCisgICAgZmFsc2Us IC8vIGFjY2VwdE9uQWJhbmRvbgorICAgIHRydWUsICAvLyBsb29wU2VsZWN0aW9uTmF2aWdhdGlv bgorICAgIGZhbHNlLCAvLyByZXN0cmljdFdpZHRoT2ZMaXN0Qm94IChGb3Igc2VjdXJpdHkgcmVh c29ucyBzaG93IHRoZSBlbnRpcmUgZW50cnkKKyAgICAgICAgICAgLy8gc28gdGhlIHVzZXIgZG9l c24ndCBlbnRlciBpbmZvcm1hdGlvbiBpdCBkaWQgbm90IGludGVuZCB0by4pCiAgICAgLy8gRm9y IHN1Z2dlc3Rpb25zLCB3ZSB1c2UgdGhlIGRpcmVjdGlvbiBvZiB0aGUgaW5wdXQgZmllbGQgYXMg dGhlIGRpcmVjdGlvbgogICAgIC8vIG9mIHRoZSBwb3B1cCBpdGVtcy4gVGhlIG1haW4gcmVhc29u IGlzIHRvIGtlZXAgdGhlIGRpc3BsYXkgb2YgaXRlbXMgaW4KICAgICAvLyBkcm9wLWRvd24gdGhl IHNhbWUgYXMgdGhlIGl0ZW1zIGluIHRoZSBpbnB1dCBmaWVsZC4K