42189 2010-07-13 13:27:10 -0700 Failing 2d.path.stroke.prune.line philip canvas test 2010-07-16 21:07:41 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 mdelaney7 mdelaney7 adele commit-queue oldest_to_newest 250703 0 mdelaney7 2010-07-13 13:27:10 -0700 Safari 5 fails 2d.path.stroke.prune.line canvas test. 250924 1 61461 mdelaney7 2010-07-13 20:06:15 -0700 Created attachment 61461 Patch 250926 2 61461 adele 2010-07-13 20:20:54 -0700 Comment on attachment 61461 Patch Looks good. The local variable should get a more meaningful name - like "path". There are a bunch of "p"s and "cp"s in this file, so you don't have to fix those, but since you're adding a new one, you might as well give it a good name. r=me! Do you want to use the commit-queue for this? 250927 3 61461 adele 2010-07-13 20:34:43 -0700 Comment on attachment 61461 Patch Actually, I think you don't need the local variable at all. You can just write it like this: if (p == CGPathGetCurrentPoint(m_path)) 251307 4 61545 mdelaney7 2010-07-14 11:25:32 -0700 Created attachment 61545 Updated with Adele's suggestions. Updated with Adele's suggestions. 251344 5 61545 commit-queue 2010-07-14 12:02:43 -0700 Comment on attachment 61545 Updated with Adele's suggestions. Rejecting patch 61545 from commit-queue. mdelaney@apple.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in WebKitTools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). Due to bug 30084 the commit-queue will require a restart after your change. Please contact eseidel@chromium.org to request a commit-queue restart. After restart the commit-queue will correctly respect your committer rights. 251348 6 61545 darin 2010-07-14 12:13:11 -0700 Comment on attachment 61545 Updated with Adele's suggestions. > void Path::addLineTo(const FloatPoint& p) > -{ > +{ Should not add trailing spaces here. Is it right to have the check be in the CG version of Path::addLineTo? Maybe the caller should do the check in platform independent code. I think it would be good to follow up and investigate that. 251349 7 mdelaney7 2010-07-14 12:17:10 -0700 @Darin: I wanted to put the checking higher up in CanvasRenderingContext2D.cpp so that it would be platform independent, but there's currently no way to expose the current point in in the path, so I'm adding that in at the moment. Though, I'm worried that there may be a good reason why that isn't exposed. I can't find one yet since it seems fine as long as the current point in the path isn't exposed at the canvas api layer we should be all good. 251629 8 61545 commit-queue 2010-07-14 20:52:25 -0700 Comment on attachment 61545 Updated with Adele's suggestions. Rejecting patch 61545 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--ignore-tests', 'compositing', '--quiet']" exit_code: 1 Running build-dumprendertree Compiling Java tests make: Nothing to be done for `default'. Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 20689 test cases. svg/custom/marker-overflow-clip.svg -> failed Exiting early after 1 failures. 18057 tests run. 335.97s total testing time 18056 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 26 test cases (<1%) had stderr output Full output: http://webkit-commit-queue.appspot.com/results/3401413 252827 9 61545 kling 2010-07-16 21:01:55 -0700 Comment on attachment 61545 Updated with Adele's suggestions. Since Path has currentPoint() now, this can and should be done in cross-platform code. 252828 10 mdelaney7 2010-07-16 21:04:35 -0700 True. I actually rolled that into the stroke.prune.arc fix, so I should obsolete this bug. Doing that now... 252829 11 mdelaney7 2010-07-16 21:07:41 -0700 Fixed in https://bugs.webkit.org/show_bug.cgi?id=42188, fix committed r63599 61461 2010-07-13 20:06:15 -0700 2010-07-14 11:25:32 -0700 Patch bug-42189-20100713200614.patch text/plain 2341 mdelaney7 SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2MzI3NikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMTAtMDctMTMgIE1hdHRoZXcgRGVsYW5leSAgPG1kZWxhbmV5QGFw cGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBGYWlsaW5nIDJkLnBhdGguc3Ryb2tlLnBydW5lLmxpbmUgcGhpbGlwIGNhbnZhcyB0ZXN0Cisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MjE4OQorCisg ICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2cvUGF0aENHLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OlBhdGg6OmFkZExpbmVUbyk6IEFkZGVkIGNoZWNrIHRvIG9taXQgYWRkaW5nIHplcm8tbGVu Z3RoIGxpbmVzLgorCiAyMDEwLTA3LTEzICBTaGVyaWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90 QGdtYWlsLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByNjMxNjIuCklu ZGV4OiBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NnL1BhdGhDRy5jcHAKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jZy9QYXRoQ0cuY3BwCShyZXZpc2lvbiA2MzI3 NSkKKysrIFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2cvUGF0aENHLmNwcAkod29ya2luZyBj b3B5KQpAQCAtMTkyLDcgKzE5MiwxMSBAQCB2b2lkIFBhdGg6Om1vdmVUbyhjb25zdCBGbG9hdFBv aW50JiBwb2luCiB9CiAKIHZvaWQgUGF0aDo6YWRkTGluZVRvKGNvbnN0IEZsb2F0UG9pbnQmIHAp Ci17Cit7ICAgCisgICAgQ0dQb2ludCBwMCA9IENHUGF0aEdldEN1cnJlbnRQb2ludChtX3BhdGgp OworICAgIGlmIChwMC54ID09IHAueCgpICYmIHAwLnkgPT0gcC55KCkpCisgICAgICAgIHJldHVy bjsKKyAgICAKICAgICBDR1BhdGhBZGRMaW5lVG9Qb2ludChtX3BhdGgsIDAsIHAueCgpLCBwLnko KSk7CiB9CiAKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlv dXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDYzMjc2KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTAtMDctMTMgIE1hdHRoZXcg RGVsYW5leSAgPG1kZWxhbmV5QGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBGYWlsaW5nIDJkLnBhdGguc3Ryb2tlLnBydW5lLmxpbmUg cGhpbGlwIGNhbnZhcyB0ZXN0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD00MjE4OQorCisgICAgICAgICogcGxhdGZvcm0vbWFjL1NraXBwZWQ6IFVuc2tp cCB0ZXN0IC0gbm93IHBhc3NpbmcuCisKIDIwMTAtMDctMTMgIE1hY2llaiBTdGFjaG93aWFrICA8 bWpzQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBPbGl2ZXIgSHVudC4KSW5kZXg6 IExheW91dFRlc3RzL3BsYXRmb3JtL21hYy9Ta2lwcGVkCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRl c3RzL3BsYXRmb3JtL21hYy9Ta2lwcGVkCShyZXZpc2lvbiA2MzI3NSkKKysrIExheW91dFRlc3Rz L3BsYXRmb3JtL21hYy9Ta2lwcGVkCSh3b3JraW5nIGNvcHkpCkBAIC0yMjcsNyArMjI3LDYgQEAg Y2FudmFzL3BoaWxpcC90ZXN0cy8yZC5wYXRoLnJlY3Qud2luZGluZwogY2FudmFzL3BoaWxpcC90 ZXN0cy8yZC5wYXRoLnN0cm9rZS5wcnVuZS5hcmMuaHRtbAogY2FudmFzL3BoaWxpcC90ZXN0cy8y ZC5wYXRoLnN0cm9rZS5wcnVuZS5jbG9zZWQuaHRtbAogY2FudmFzL3BoaWxpcC90ZXN0cy8yZC5w YXRoLnN0cm9rZS5wcnVuZS5jdXJ2ZS5odG1sCi1jYW52YXMvcGhpbGlwL3Rlc3RzLzJkLnBhdGgu c3Ryb2tlLnBydW5lLmxpbmUuaHRtbAogY2FudmFzL3BoaWxpcC90ZXN0cy8yZC5wYXR0ZXJuLmlt YWdlLmJyb2tlbi5odG1sCiBjYW52YXMvcGhpbGlwL3Rlc3RzLzJkLnBhdHRlcm4uaW1hZ2UuaW5j b21wbGV0ZS5odG1sCiBjYW52YXMvcGhpbGlwL3Rlc3RzLzJkLnBhdHRlcm4uaW1hZ2UubnVsbC5o dG1sCg== 61545 2010-07-14 11:25:32 -0700 2010-07-16 21:01:55 -0700 Updated with Adele's suggestions. bug-42189-2.patch text/plain 2263 mdelaney7 SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2MzI3NikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMTAtMDctMTMgIE1hdHRoZXcgRGVsYW5leSAgPG1kZWxhbmV5QGFw cGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBGYWlsaW5nIDJkLnBhdGguc3Ryb2tlLnBydW5lLmxpbmUgcGhpbGlwIGNhbnZhcyB0ZXN0Cisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MjE4OQorCisg ICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2cvUGF0aENHLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OlBhdGg6OmFkZExpbmVUbyk6IEFkZGVkIGNoZWNrIHRvIG9taXQgYWRkaW5nIHplcm8tbGVu Z3RoIGxpbmVzLgorCiAyMDEwLTA3LTEzICBTaGVyaWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90 QGdtYWlsLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByNjMxNjIuCklu ZGV4OiBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NnL1BhdGhDRy5jcHAKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jZy9QYXRoQ0cuY3BwICAgICAocmV2aXNpb24g NjMyNzUpCisrKyBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NnL1BhdGhDRy5jcHAgICAgICh3 b3JraW5nIGNvcHkpCkBAIC0xOTIsNyArMTkyLDEwIEBACiB9CiAKIHZvaWQgUGF0aDo6YWRkTGlu ZVRvKGNvbnN0IEZsb2F0UG9pbnQmIHApCi17Cit7ICAgCisgICAgaWYgKHAgPT0gQ0dQYXRoR2V0 Q3VycmVudFBvaW50KG1fcGF0aCkpCisgICAgICAgIHJldHVybjsKKyAgICAKICAgICBDR1BhdGhB ZGRMaW5lVG9Qb2ludChtX3BhdGgsIDAsIHAueCgpLCBwLnkoKSk7CiB9CiAKSW5kZXg6IExheW91 dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDYzMjc2KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTIgQEAKKzIwMTAtMDctMTMgIE1hdHRoZXcgRGVsYW5leSAgPG1kZWxhbmV5QGFw cGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBGYWlsaW5nIDJkLnBhdGguc3Ryb2tlLnBydW5lLmxpbmUgcGhpbGlwIGNhbnZhcyB0ZXN0Cisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MjE4OQorCisg ICAgICAgICogcGxhdGZvcm0vbWFjL1NraXBwZWQ6IFVuc2tpcCB0ZXN0IC0gbm93IHBhc3Npbmcu CisKIDIwMTAtMDctMTMgIE1hY2llaiBTdGFjaG93aWFrICA8bWpzQGFwcGxlLmNvbT4KIAogICAg ICAgICBSZXZpZXdlZCBieSBPbGl2ZXIgSHVudC4KSW5kZXg6IExheW91dFRlc3RzL3BsYXRmb3Jt L21hYy9Ta2lwcGVkCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL3BsYXRmb3JtL21hYy9Ta2lw cGVkCShyZXZpc2lvbiA2MzI3NSkKKysrIExheW91dFRlc3RzL3BsYXRmb3JtL21hYy9Ta2lwcGVk CSh3b3JraW5nIGNvcHkpCkBAIC0yMjcsNyArMjI3LDYgQEAgY2FudmFzL3BoaWxpcC90ZXN0cy8y ZC5wYXRoLnJlY3Qud2luZGluZwogY2FudmFzL3BoaWxpcC90ZXN0cy8yZC5wYXRoLnN0cm9rZS5w cnVuZS5hcmMuaHRtbAogY2FudmFzL3BoaWxpcC90ZXN0cy8yZC5wYXRoLnN0cm9rZS5wcnVuZS5j bG9zZWQuaHRtbAogY2FudmFzL3BoaWxpcC90ZXN0cy8yZC5wYXRoLnN0cm9rZS5wcnVuZS5jdXJ2 ZS5odG1sCi1jYW52YXMvcGhpbGlwL3Rlc3RzLzJkLnBhdGguc3Ryb2tlLnBydW5lLmxpbmUuaHRt bAogY2FudmFzL3BoaWxpcC90ZXN0cy8yZC5wYXR0ZXJuLmltYWdlLmJyb2tlbi5odG1sCiBjYW52 YXMvcGhpbGlwL3Rlc3RzLzJkLnBhdHRlcm4uaW1hZ2UuaW5jb21wbGV0ZS5odG1sCiBjYW52YXMv cGhpbGlwL3Rlc3RzLzJkLnBhdHRlcm4uaW1hZ2UubnVsbC5odG1sCg==