42180 2010-07-13 11:14:03 -0700 [chromium] Autofill popup menu is broken when cycling through all the suggestions 2010-07-14 16:02:48 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 0 jcivelli webkit-unassigned commit-queue dhollowa jhawkins oldest_to_newest 250629 0 jcivelli 2010-07-13 11:14:03 -0700 - Bring up a form autofill or autocomplete popup in Chromium - Arrow down so you pass all the suggestions and cycle back to the 1st one - Press ESC to close the popup Expected: The popup is closed. Actual: The popup linger and cannot be closed anymore. This was introduced by https://bugs.webkit.org/attachment.cgi?id=58439 250644 1 61400 jcivelli 2010-07-13 11:34:18 -0700 Created attachment 61400 Initial patch This is effectively a revert of https://bugs.webkit.org/show_bug.cgi?id=42180 That CL fixed a Chromium crasher: http://code.google.com/p/chromium/issues/detail?id=46287 that I cannot reproduce with this new code. 250648 2 jhawkins 2010-07-13 11:39:08 -0700 LGTM. We'll keep an eye on the crashers and see if the original crash pops up again. 251488 3 61400 commit-queue 2010-07-14 16:02:43 -0700 Comment on attachment 61400 Initial patch Clearing flags on attachment: 61400 Committed r63367: <http://trac.webkit.org/changeset/63367> 251489 4 commit-queue 2010-07-14 16:02:48 -0700 All reviewed patches have been landed. Closing bug. 61400 2010-07-13 11:34:18 -0700 2010-07-14 16:02:43 -0700 Initial patch ghost_popup.patch text/plain 1394 jcivelli SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cNCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NCi0tLSBXZWJLaXQv Y2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiA2MzIyNSkKKysrIFdlYktpdC9jaHJvbWl1bS9D aGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wNy0xMyAgSmF5 IENpdmVsbGkgIDxqY2l2ZWxsaUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRG9uJ3Qgbm90aWZ5IHRoZSBXZWJWaWV3IHRoYXQg dGhlIHBvcHVwIGhhcyBiZWVuIGNsb3NlZCB3aGVuIHRoZQorICAgICAgICBzZWxlY3Rpb24gaXMg Y2xlYXJlZCwgYXMgdGhlIHBvcHVwIGlzIG5vdCBnb25lIGFuZCB3b3VsZCBsaW5nZXIKKyAgICAg ICAgYXMgYSBnaG9zdCBwb3B1cC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTQyMTgwCisKKyAgICAgICAgKiBzcmMvQXV0b0ZpbGxQb3B1cE1lbnVDbGll bnQuY3BwOgorICAgICAgICAoV2ViS2l0OjpBdXRvRmlsbFBvcHVwTWVudUNsaWVudDo6c2VsZWN0 aW9uQ2xlYXJlZCk6CisKIDIwMTAtMDctMTAgIFpoZW55YW8gTW8gIDx6bW9AZ29vZ2xlLmNvbT4K IAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBGaXNoZXIuCkluZGV4OiBXZWJLaXQvY2hyb21p dW0vc3JjL0F1dG9GaWxsUG9wdXBNZW51Q2xpZW50LmNwcA0KPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KLS0tIFdlYktp dC9jaHJvbWl1bS9zcmMvQXV0b0ZpbGxQb3B1cE1lbnVDbGllbnQuY3BwCShyZXZpc2lvbiA2MzEz MSkKKysrIFdlYktpdC9jaHJvbWl1bS9zcmMvQXV0b0ZpbGxQb3B1cE1lbnVDbGllbnQuY3BwCSh3 b3JraW5nIGNvcHkpCkBAIC0xNDEsOCArMTQxLDkgQEAgdm9pZCBBdXRvRmlsbFBvcHVwTWVudUNs aWVudDo6c2VsZWN0aW9uQwogCiB2b2lkIEF1dG9GaWxsUG9wdXBNZW51Q2xpZW50OjpzZWxlY3Rp b25DbGVhcmVkKCkKIHsKLSAgICAvLyBTYW1lIGVmZmVjdCBkZXNpcmVkIGFzIHBvcHVwRGlkSGlk ZSwgc28gY2FsbCB0aHJvdWdoLgotICAgIHBvcHVwRGlkSGlkZSgpOworICAgIFdlYlZpZXdJbXBs KiB3ZWJWaWV3ID0gZ2V0V2ViVmlldygpOworICAgIGlmICh3ZWJWaWV3KQorICAgICAgICB3ZWJW aWV3LT5jbGllbnQoKS0+ZGlkQ2xlYXJBdXRvRmlsbFNlbGVjdGlvbihXZWJOb2RlKGdldFRleHRG aWVsZCgpKSk7CiB9CiAKIFN0cmluZyBBdXRvRmlsbFBvcHVwTWVudUNsaWVudDo6aXRlbVRleHQo dW5zaWduZWQgbGlzdEluZGV4KSBjb25zdAo=