42175 2010-07-13 09:57:39 -0700 REGRESSION(55056) debug builds ASSERT falsely on pages with animations 2010-07-13 11:21:44 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 jamesr jamesr mitz simon.fraser oldest_to_newest 250583 0 jamesr 2010-07-13 09:57:39 -0700 REGRESSION(55056) debug builds ASSERT falsely on pages with animations 250585 1 jamesr 2010-07-13 10:03:00 -0700 The ASSERT()s in RenderObject::repaintAfterLayoutIfNeeded added by r55065 are failing on pages with animations if h/w compositing is not enabled. Looks like the same root issue as https://bugs.webkit.org/show_bug.cgi?id=37048. 250587 2 61390 jamesr 2010-07-13 10:04:32 -0700 Created attachment 61390 Patch 250590 3 61390 simon.fraser 2010-07-13 10:13:24 -0700 Comment on attachment 61390 Patch OK, but I'd rather we fix the underlying cause (use some timestamp for all animation calculations within a given style change/layout). 250637 4 61390 jamesr 2010-07-13 11:21:40 -0700 Comment on attachment 61390 Patch Clearing flags on attachment: 61390 Committed r63226: <http://trac.webkit.org/changeset/63226> 250638 5 jamesr 2010-07-13 11:21:44 -0700 All reviewed patches have been landed. Closing bug. 61390 2010-07-13 10:04:32 -0700 2010-07-13 11:21:39 -0700 Patch bug-42175-20100713100431.patch text/plain 2905 jamesr ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZGNkZDM4ZTVmNGEyZDhhY2UxMzEzMGM0MTYwNDIxMDJkOWM3ODdjMy4uYWJjZTUwNDk1ODMzMGE5 ZDFjZmQ1M2FjYmE3YjQ2ZjdkYjY4Mzg3YiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMiBAQAorMjAxMC0wNy0xMyAgSmFt ZXMgUm9iaW5zb24gIDxqYW1lc3JAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJFR1JFU1NJT04oNTUwNTYpIGRlYnVnIGJ1aWxk cyBBU1NFUlQgZmFsc2VseSBvbiBwYWdlcyB3aXRoIGFuaW1hdGlvbnMKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQyMTc1CisKKyAgICAgICAgUmV2aXNp b24gNTUwNjUgYWRkZWQgc29tZSByZXBhaW50IGJveCBwcmVjb21wdXRhdGlvbiBhbmQgc29tZSBk ZWJ1ZyBBU1NFUlQoKWlvbnMKKyAgICAgICAgdG8gZW5zdXJlIHRoZSBwcmVjb21wdXRlZCB2YWx1 ZXMgd2VyZSB2YWxpZC4gIEhvd2V2ZXIsIGlmIGFuaW1hdGlvbnMgYXJlIGVuYWJsZWQgYW5kCisg ICAgICAgIG5vdCBoYXJkd2FyZSBhY2NlbGVyYXRlZCwgdGhlIHJlcGFpbnQgYm94IGRpbWVuc2lv bnMgYmVjb21lIHRpbWUtZGVwZW5kZW50IGFuZCB0aGUKKyAgICAgICAgQVNTRVJUKClzIGNhbiB0 cmlnZ2VyLiAgVGhpcyBjYW4gbWFrZSBpdCBpbXBvc3NpYmxlIHRvIGludGVyYWN0aXZlbHkgZGVi dWcgcGFnZXMKKyAgICAgICAgbGlrZSBnb29nbGUgbWFwcy4KKworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzcwNDggaXMgYW5vdGhlciBleGFtcGxlIG9m IGFuIGFzc2VydGlvbgorICAgICAgICBmYWlsaW5nIGR1ZSB0byB0aW1lIGRlcGVuZGVudCBhbmlt YXRpb24gdmFsdWVzLgorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlck9iamVjdC5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpSZW5kZXJPYmplY3Q6OnJlcGFpbnRBZnRlckxheW91dElmTmVlZGVk KToKKwogMjAxMC0wNy0xMiAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgogCiAgICAg ICAgIFJldmlld2VkIGJ5IEVyaWMgU2VpZGVsLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9yZW5kZXJp bmcvUmVuZGVyT2JqZWN0LmNwcCBiL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck9iamVjdC5jcHAK aW5kZXggODdkNjA2OGFhY2NiMzcwOTBiZWMzMWI0ZDQ2Zjg0OTJiZTI2NTIxOS4uZDMyMTNiNjNm YTJkYWFmMDVhYjQ4ZGJhYmVkZjU2ODJhODE5OWY5NiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9yZW5k ZXJpbmcvUmVuZGVyT2JqZWN0LmNwcAorKysgYi9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJPYmpl Y3QuY3BwCkBAIC0xMzU0LDcgKzEzNTQsOCBAQCBib29sIFJlbmRlck9iamVjdDo6cmVwYWludEFm dGVyTGF5b3V0SWZOZWVkZWQoUmVuZGVyQm94TW9kZWxPYmplY3QqIHJlcGFpbnRDb250YQogICAg IGlmICh2LT5wcmludGluZygpKQogICAgICAgICByZXR1cm4gZmFsc2U7IC8vIERvbid0IHJlcGFp bnQgaWYgd2UncmUgcHJpbnRpbmcuCiAKLSAgICBBU1NFUlQoIW5ld0JvdW5kc1B0ciB8fCAqbmV3 Qm91bmRzUHRyID09IGNsaXBwZWRPdmVyZmxvd1JlY3RGb3JSZXBhaW50KHJlcGFpbnRDb250YWlu ZXIpKTsKKyAgICAvLyBUaGlzIEFTU0VSVCBmYWlscyBkdWUgdG8gYW5pbWF0aW9ucy4gIFNlZSBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzcwNDgKKyAgICAvLyBBU1NF UlQoIW5ld0JvdW5kc1B0ciB8fCAqbmV3Qm91bmRzUHRyID09IGNsaXBwZWRPdmVyZmxvd1JlY3RG b3JSZXBhaW50KHJlcGFpbnRDb250YWluZXIpKTsKICAgICBJbnRSZWN0IG5ld0JvdW5kcyA9IG5l d0JvdW5kc1B0ciA/ICpuZXdCb3VuZHNQdHIgOiBjbGlwcGVkT3ZlcmZsb3dSZWN0Rm9yUmVwYWlu dChyZXBhaW50Q29udGFpbmVyKTsKICAgICBJbnRSZWN0IG5ld091dGxpbmVCb3g7CiAKQEAgLTEz NjMsNyArMTM2NCw4IEBAIGJvb2wgUmVuZGVyT2JqZWN0OjpyZXBhaW50QWZ0ZXJMYXlvdXRJZk5l ZWRlZChSZW5kZXJCb3hNb2RlbE9iamVjdCogcmVwYWludENvbnRhCiAgICAgaWYgKCFmdWxsUmVw YWludCAmJiBzdHlsZSgpLT5ib3JkZXJGaXQoKSA9PSBCb3JkZXJGaXRMaW5lcykKICAgICAgICAg ZnVsbFJlcGFpbnQgPSB0cnVlOwogICAgIGlmICghZnVsbFJlcGFpbnQpIHsKLSAgICAgICAgQVNT RVJUKCFuZXdPdXRsaW5lQm94UmVjdFB0ciB8fCAqbmV3T3V0bGluZUJveFJlY3RQdHIgPT0gb3V0 bGluZUJvdW5kc0ZvclJlcGFpbnQocmVwYWludENvbnRhaW5lcikpOworICAgICAgICAvLyBUaGlz IEFTU0VSVCBmYWlscyBkdWUgdG8gYW5pbWF0aW9ucy4gIFNlZSBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzcwNDgKKyAgICAgICAgLy8gQVNTRVJUKCFuZXdPdXRsaW5l Qm94UmVjdFB0ciB8fCAqbmV3T3V0bGluZUJveFJlY3RQdHIgPT0gb3V0bGluZUJvdW5kc0ZvclJl cGFpbnQocmVwYWludENvbnRhaW5lcikpOwogICAgICAgICBuZXdPdXRsaW5lQm94ID0gbmV3T3V0 bGluZUJveFJlY3RQdHIgPyAqbmV3T3V0bGluZUJveFJlY3RQdHIgOiBvdXRsaW5lQm91bmRzRm9y UmVwYWludChyZXBhaW50Q29udGFpbmVyKTsKICAgICAgICAgaWYgKG5ld091dGxpbmVCb3gubG9j YXRpb24oKSAhPSBvbGRPdXRsaW5lQm94LmxvY2F0aW9uKCkgfHwgKG11c3RSZXBhaW50QmFja2dy b3VuZE9yQm9yZGVyKCkgJiYgKG5ld0JvdW5kcyAhPSBvbGRCb3VuZHMgfHwgbmV3T3V0bGluZUJv eCAhPSBvbGRPdXRsaW5lQm94KSkpCiAgICAgICAgICAgICBmdWxsUmVwYWludCA9IHRydWU7Cg==