42172 2010-07-13 09:28:26 -0700 [chromium] Tabbing away after you highlight an autofill entry results in the label for the autofill profile getting included in the field 2010-07-13 12:57:08 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 sky sky commit-queue webkit.review.bot oldest_to_newest 250557 0 sky 2010-07-13 09:28:26 -0700 1. Go to "options -> personal stuff -> change autofill settings" and create an address profile with the label "Home". Let the name be "John Doe" 2. Navigate to a web page with name and address fields. 3. Click in the empty first name field on the web page. 4. Hit the down arrow key on your keyboard until "John (Home)" is highlighted. 5. Hit the tab key on your keyboard to move to the next field. What is the expected output? The first name field is filled with the text "John". What do you see instead? The first name field is filled with the text "John (Home)". Additional information: If you click on "John (Home)" with your mouse, the correct name is entered in the first name field. It is only when you tab away from the selection that the label gets added to the name. It looks like the Autofill++ entry is being treated like an Autofill classic entry when you tab away from the field. 250594 1 61391 sky 2010-07-13 10:22:00 -0700 Created attachment 61391 Makes tab commit selection 250599 2 webkit.review.bot 2010-07-13 10:24:16 -0700 Attachment 61391 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebCore/platform/chromium/PopupMenuChromium.cpp:756: One space before end of line comments [whitespace/comments] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 250609 3 61391 levin 2010-07-13 10:37:25 -0700 Comment on attachment 61391 Makes tab commit selection r=me with two minor fixes to the comment: 1.Capitalize the first letter in the comment. 2.Only one space before the comment as the style bot noted. (r- only b/c you aren't a committer.) 250612 4 61394 sky 2010-07-13 10:39:11 -0700 Created attachment 61394 Fixes style nits and adds correct reviewer. 250685 5 61394 commit-queue 2010-07-13 12:57:04 -0700 Comment on attachment 61394 Fixes style nits and adds correct reviewer. Clearing flags on attachment: 61394 Committed r63236: <http://trac.webkit.org/changeset/63236> 250686 6 commit-queue 2010-07-13 12:57:08 -0700 All reviewed patches have been landed. Closing bug. 61391 2010-07-13 10:22:00 -0700 2010-07-13 10:39:11 -0700 Makes tab commit selection webkit.patch text/plain 1498 sky SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDYzMjE4 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTAtMDct MTMgIFNjb3R0IFZpb2xldCAgPHNreUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0Nocm9taXVtXSBNYWtlcyBwcmVzc2luZyB0 YWIgYWNjZXB0IHRoZSBjdXJyZW50bHkgc2VsZWN0ZWQgaXRlbSBpbiBhIHBvcHVwLgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDIxNzIKKworICAgICAg ICAqIFdlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vUG9wdXBNZW51Q2hyb21pdW0uY3BwOgorCiAy MDEwLTA3LTEyICBYYW4gTG9wZXogIDx4bG9wZXpAaWdhbGlhLmNvbT4KIAogICAgICAgICBSZXZp ZXdlZCBieSBHdXN0YXZvIE5vcm9uaGEuCkluZGV4OiBXZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVt L1BvcHVwTWVudUNocm9taXVtLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL2No cm9taXVtL1BvcHVwTWVudUNocm9taXVtLmNwcAkocmV2aXNpb24gNjMxMzkpCisrKyBXZWJDb3Jl L3BsYXRmb3JtL2Nocm9taXVtL1BvcHVwTWVudUNocm9taXVtLmNwcAkod29ya2luZyBjb3B5KQpA QCAtNzUxLDggKzc1MSwxMSBAQCBib29sIFBvcHVwTGlzdEJveDo6aGFuZGxlS2V5RXZlbnQoY29u c3QgCiAgICAgaWYgKGV2ZW50LndpbmRvd3NWaXJ0dWFsS2V5Q29kZSgpID09IFZLRVlfVEFCKSB7 CiAgICAgICAgIC8vIFRBQiBpcyBhIHNwZWNpYWwgY2FzZSBhcyBpdCBzaG91bGQgc2VsZWN0IHRo ZSBjdXJyZW50IGl0ZW0gaWYgYW55IGFuZAogICAgICAgICAvLyBhZHZhbmNlIGZvY3VzLgotICAg ICAgICBpZiAobV9zZWxlY3RlZEluZGV4ID49IDApCi0gICAgICAgICAgICBtX3BvcHVwQ2xpZW50 LT5zZXRUZXh0RnJvbUl0ZW0obV9zZWxlY3RlZEluZGV4KTsKKyAgICAgICAgaWYgKG1fc2VsZWN0 ZWRJbmRleCA+PSAwKSB7CisgICAgICAgICAgICBhY2NlcHRJbmRleChtX3NlbGVjdGVkSW5kZXgp OyAgLy8gbWF5IGRlbGV0ZSB1cy4KKyAgICAgICAgICAgIC8vIFJldHVybiBmYWxzZSBzbyB0aGUg VEFCIGtleSBldmVudCBpcyBwcm9wYWdhdGVkIHRvIHRoZSBwYWdlLgorICAgICAgICAgICAgcmV0 dXJuIGZhbHNlOworICAgICAgICB9CiAgICAgICAgIC8vIENhbGwgYWJhbmRvbigpIHNvIHdlIGhv bm9yIG1fYWNjZXB0ZWRJbmRleE9uQWJhbmRvbiBpZiBzZXQuCiAgICAgICAgIGFiYW5kb24oKTsK ICAgICAgICAgLy8gUmV0dXJuIGZhbHNlIHNvIHRoZSBUQUIga2V5IGV2ZW50IGlzIHByb3BhZ2F0 ZWQgdG8gdGhlIHBhZ2UuCg== 61394 2010-07-13 10:39:11 -0700 2010-07-13 12:57:04 -0700 Fixes style nits and adds correct reviewer. webkit.patch text/plain 1494 sky SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDYzMjE4 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTAtMDct MTMgIFNjb3R0IFZpb2xldCAgPHNreUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgRGF2aWQgTGV2aW4uCisKKyAgICAgICAgW0Nocm9taXVtXSBNYWtlcyBwcmVzc2luZyB0YWIg YWNjZXB0IHRoZSBjdXJyZW50bHkgc2VsZWN0ZWQgaXRlbSBpbiBhIHBvcHVwLgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDIxNzIKKworICAgICAgICAq IFdlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vUG9wdXBNZW51Q2hyb21pdW0uY3BwOgorCiAyMDEw LTA3LTEyICBYYW4gTG9wZXogIDx4bG9wZXpAaWdhbGlhLmNvbT4KIAogICAgICAgICBSZXZpZXdl ZCBieSBHdXN0YXZvIE5vcm9uaGEuCkluZGV4OiBXZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL1Bv cHVwTWVudUNocm9taXVtLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL2Nocm9t aXVtL1BvcHVwTWVudUNocm9taXVtLmNwcAkocmV2aXNpb24gNjMxMzkpCisrKyBXZWJDb3JlL3Bs YXRmb3JtL2Nocm9taXVtL1BvcHVwTWVudUNocm9taXVtLmNwcAkod29ya2luZyBjb3B5KQpAQCAt NzUxLDggKzc1MSwxMSBAQCBib29sIFBvcHVwTGlzdEJveDo6aGFuZGxlS2V5RXZlbnQoY29uc3Qg CiAgICAgaWYgKGV2ZW50LndpbmRvd3NWaXJ0dWFsS2V5Q29kZSgpID09IFZLRVlfVEFCKSB7CiAg ICAgICAgIC8vIFRBQiBpcyBhIHNwZWNpYWwgY2FzZSBhcyBpdCBzaG91bGQgc2VsZWN0IHRoZSBj dXJyZW50IGl0ZW0gaWYgYW55IGFuZAogICAgICAgICAvLyBhZHZhbmNlIGZvY3VzLgotICAgICAg ICBpZiAobV9zZWxlY3RlZEluZGV4ID49IDApCi0gICAgICAgICAgICBtX3BvcHVwQ2xpZW50LT5z ZXRUZXh0RnJvbUl0ZW0obV9zZWxlY3RlZEluZGV4KTsKKyAgICAgICAgaWYgKG1fc2VsZWN0ZWRJ bmRleCA+PSAwKSB7CisgICAgICAgICAgICBhY2NlcHRJbmRleChtX3NlbGVjdGVkSW5kZXgpOyAv LyBNYXkgZGVsZXRlIHVzLgorICAgICAgICAgICAgLy8gUmV0dXJuIGZhbHNlIHNvIHRoZSBUQUIg a2V5IGV2ZW50IGlzIHByb3BhZ2F0ZWQgdG8gdGhlIHBhZ2UuCisgICAgICAgICAgICByZXR1cm4g ZmFsc2U7CisgICAgICAgIH0KICAgICAgICAgLy8gQ2FsbCBhYmFuZG9uKCkgc28gd2UgaG9ub3Ig bV9hY2NlcHRlZEluZGV4T25BYmFuZG9uIGlmIHNldC4KICAgICAgICAgYWJhbmRvbigpOwogICAg ICAgICAvLyBSZXR1cm4gZmFsc2Ugc28gdGhlIFRBQiBrZXkgZXZlbnQgaXMgcHJvcGFnYXRlZCB0 byB0aGUgcGFnZS4K