42168 2010-07-13 08:40:41 -0700 REGRESSION (r63192): Pixel test failure in contain-and-cover.html 2010-07-13 09:38:48 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 0 podivilov kling jorlow kling mnaganov oldest_to_newest 250529 0 podivilov 2010-07-13 08:40:41 -0700 contain-and-cover.html start failing after http://trac.webkit.org/changeset/63192, http://build.chromium.org/buildbot/waterfall.fyi/builders/Webkit%20Linux%20(webkit.org)/builds/32026 Could you please have a look? 250531 1 jorlow 2010-07-13 08:47:55 -0700 Why am I cc'ed on this? Also you really need to provide WAY more information to non-Chromium contributors. There's basically no context here. And no link to where he can see the actual failing test/results. (Hopefully we'll be able to get pixel tests working on build.webkit.org soon!) 250534 2 61383 podivilov 2010-07-13 08:51:02 -0700 Created attachment 61383 add contain-and-cover.html to test_expectations 250535 3 jorlow 2010-07-13 08:53:18 -0700 Is this a real regression? If so (and you can't get ahold of Andreas) then you should revert it and not paper over the regression. If it's not a real regression then you should probably go ahead and check in a new baseline. 250540 4 podivilov 2010-07-13 09:03:43 -0700 (In reply to comment #3) > Is this a real regression? If so (and you can't get ahold of Andreas) then you should revert it and not paper over the regression. If it's not a real regression then you should probably go ahead and check in a new baseline. I've cc'ed you just because you were in https://bugs.webkit.org/show_bug.cgi?id=38108 which seemed very similar to this problem. I'm not sure if it's a regression or not, that's why I've created this bug. 250542 5 kling 2010-07-13 09:09:53 -0700 Just a quick note to let you know I'm looking at this right now. 250545 6 podivilov 2010-07-13 09:15:08 -0700 (In reply to comment #5) > Just a quick note to let you know I'm looking at this right now. Andreas, it's my bad, this is actually the same problem as https://bugs.webkit.org/show_bug.cgi?id=38108, and absolutely not connected to r63192. For some reason image diff was first detected by buildbots just after your change. 250547 7 podivilov 2010-07-13 09:19:25 -0700 *** This bug has been marked as a duplicate of bug 38108 *** 250551 8 kling 2010-07-13 09:22:36 -0700 Not so fast, this actually did regress with my change (r63192). Didn't notice it since we don't have pixel tests for Qt. ;( Working on a fix right now. 250559 9 podivilov 2010-07-13 09:29:41 -0700 If so, could you please revert it? *** This bug has been marked as a duplicate of bug 38108 *** 250564 10 podivilov 2010-07-13 09:32:50 -0700 Duplicate -> Unconfirmed 250570 11 kling 2010-07-13 09:38:48 -0700 Reverted with <http://trac.webkit.org/changeset/63213> 61383 2010-07-13 08:51:02 -0700 2010-07-13 09:15:42 -0700 add contain-and-cover.html to test_expectations tmp.patch text/plain 1080 podivilov ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAxMGI2MmYxLi5kNmYxMTI3IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTAtMDct MTMgIFBhdmVsIFBvZGl2aWxvdiAgPHBvZGl2aWxvdkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0Nocm9taXVtXSBBZGQgY29u dGFpbi1hbmQtY292ZXIuaHRtbCB0byB0ZXN0X2V4cGVjdGF0aW9ucy50eHQKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQyMTY4CisKKyAgICAgICAgKiBw bGF0Zm9ybS9jaHJvbWl1bS90ZXN0X2V4cGVjdGF0aW9ucy50eHQ6CisKIDIwMTAtMDctMTMgIEFu ZHJlYXMgS2xpbmcgIDxhbmRyZWFzLmtsaW5nQG5va2lhLmNvbT4KIAogICAgICAgICBSdWJiZXIt c3RhbXBlZCBieSBTaW1vbiBIYXVzbWFubi4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRm b3JtL2Nocm9taXVtL3Rlc3RfZXhwZWN0YXRpb25zLnR4dCBiL0xheW91dFRlc3RzL3BsYXRmb3Jt L2Nocm9taXVtL3Rlc3RfZXhwZWN0YXRpb25zLnR4dAppbmRleCA4ODc2YTFmLi43ZDdmZGU0IDEw MDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS90ZXN0X2V4cGVjdGF0aW9u cy50eHQKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vdGVzdF9leHBlY3RhdGlv bnMudHh0CkBAIC0zMDEzLDMgKzMwMTMsNSBAQCBCVUdBV09ORyBNQUMgOiBzdmcvY3VzdG9tL2Ns aXAtcGF0aC1jaGlsZC1jaGFuZ2VzLnN2ZyA9IFRFWFQKIAogQlVHNDg4NTkgV0lOIDogZmFzdC9p bmxpbmUvY29udGludWF0aW9uLW91dGxpbmVzLXdpdGgtbGF5ZXJzLTIuaHRtbCA9IElNQUdFK1RF WFQKIAorLy8gU3RhcnRlZCBmYWlsaW5nIGF0IDYzMTkyCitCVUdXSzQyMTY4IFdJTiBMSU5VWCA6 IGZhc3QvYmFja2dyb3VuZHMvc2l6ZS9jb250YWluLWFuZC1jb3Zlci5odG1sID0gSU1BR0UK