42157 2010-07-13 05:41:52 -0700 [v8] Web Inspector: inspector front-end crashes upon JS exception in front-end callbacks 2010-07-13 07:23:43 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 caseq webkit-unassigned commit-queue pfeldman yurys oldest_to_newest 250451 0 caseq 2010-07-13 05:41:52 -0700 Inspector front-end renderer crashes if a front-end callback (such as WebInspector.parsedScriptSource) throws a JS exception (e.g. due to JS syntax error). 250453 1 61359 caseq 2010-07-13 05:48:36 -0700 Created attachment 61359 patch 250456 2 61359 yurys 2010-07-13 05:52:24 -0700 Comment on attachment 61359 patch WebKit/chromium/src/WebDevToolsFrontendImpl.cpp:179 + if (tryCatch.HasCaught()) { You don't need this, just calling tryCatch.SetVerbose(true) should be enough. 250463 3 61362 caseq 2010-07-13 06:03:52 -0700 Created attachment 61362 patch 250484 4 61362 commit-queue 2010-07-13 07:23:39 -0700 Comment on attachment 61362 patch Clearing flags on attachment: 61362 Committed r63201: <http://trac.webkit.org/changeset/63201> 250485 5 commit-queue 2010-07-13 07:23:43 -0700 All reviewed patches have been landed. Closing bug. 61359 2010-07-13 05:48:36 -0700 2010-07-13 06:03:52 -0700 patch dispatch-crash.patch text/plain 1692 caseq SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNjMxOTgpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDctMTMgIEFuZHJl eSBLb3N5YWtvdiAgPGNhc2VxQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBjYXRjaCBhbmQgbG9nIEpT IGV4Y2VwdGlvbnMgcmVzdWx0aW5nIGZyb20gZXhlY3V0aW5nIGEgCisgICAgICAgIHNjcmlwdCBv biBpbnNwZWN0b3IgZnJvbnQtZW5kIHRvIHByZXZlbnQgcmVuZGVyZXIgZnJvbSBjcmFzaGluZy4K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQyMTU3CisK KyAgICAgICAgKiBzcmMvV2ViRGV2VG9vbHNGcm9udGVuZEltcGwuY3BwOgorICAgICAgICAoV2Vi S2l0OjpXZWJEZXZUb29sc0Zyb250ZW5kSW1wbDo6ZXhlY3V0ZVNjcmlwdCk6CisKIDIwMTAtMDct MTMgIEtlbnQgVGFtdXJhICA8dGtlbnRAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFVucmV2aWV3 ZWQsIGJ1aWxkIGZpeC4KSW5kZXg6IFdlYktpdC9jaHJvbWl1bS9zcmMvV2ViRGV2VG9vbHNGcm9u dGVuZEltcGwuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9jaHJvbWl1bS9zcmMvV2ViRGV2VG9v bHNGcm9udGVuZEltcGwuY3BwCShyZXZpc2lvbiA2Mjc2NikKKysrIFdlYktpdC9jaHJvbWl1bS9z cmMvV2ViRGV2VG9vbHNGcm9udGVuZEltcGwuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNzQsNyAr MTc0LDEzIEBAIHZvaWQgV2ViRGV2VG9vbHNGcm9udGVuZEltcGw6OmV4ZWN1dGVTY3IKICAgICBW ZWN0b3I8IHY4OjpIYW5kbGU8djg6OlZhbHVlPiA+IGFyZ3M7CiAgICAgZm9yIChzaXplX3QgaSA9 IDA7IGkgPCB2LnNpemUoKTsgaSsrKQogICAgICAgICBhcmdzLmFwcGVuZChUb1Y4U3RyaW5nKHYu YXQoaSkpKTsKKyAgICB2ODo6VHJ5Q2F0Y2ggdHJ5Q2F0Y2g7CiAgICAgZnVuY3Rpb24tPkNhbGwo ZnJhbWVDb250ZXh0LT5HbG9iYWwoKSwgYXJncy5zaXplKCksIGFyZ3MuZGF0YSgpKTsKKyAgICBp ZiAodHJ5Q2F0Y2guSGFzQ2F1Z2h0KCkpIHsKKyAgICAgICAgdjg6OkhhbmRsZTx2ODo6TWVzc2Fn ZT4gbWVzc2FnZSA9IHRyeUNhdGNoLk1lc3NhZ2UoKTsKKyAgICAgICAgZnJhbWUtPmZyYW1lKCkt PmRvbVdpbmRvdygpLT5jb25zb2xlKCktPmFkZE1lc3NhZ2UoSlNNZXNzYWdlU291cmNlLCBMb2dN ZXNzYWdlVHlwZSwgRXJyb3JNZXNzYWdlTGV2ZWwsIFdlYkNvcmU6OnRvV2ViQ29yZVN0cmluZyht ZXNzYWdlLT5HZXQoKSksIG1lc3NhZ2UtPkdldExpbmVOdW1iZXIoKSwKKyAgICAgICAgICAgIFdl YkNvcmU6OnRvV2ViQ29yZVN0cmluZyhtZXNzYWdlLT5HZXRTY3JpcHRSZXNvdXJjZU5hbWUoKSkp OworICAgIH0KIH0KIAogdm9pZCBXZWJEZXZUb29sc0Zyb250ZW5kSW1wbDo6c2VuZFJwY01lc3Nh Z2UoY29uc3QgV2ViRGV2VG9vbHNNZXNzYWdlRGF0YSYgZGF0YSkK 61362 2010-07-13 06:03:52 -0700 2010-07-13 07:23:39 -0700 patch dispatch-crash.patch text/plain 1284 caseq SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNjMxOTgpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDctMTMgIEFuZHJl eSBLb3N5YWtvdiAgPGNhc2VxQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBjYXRjaCBhbmQgbG9nIEpT IGV4Y2VwdGlvbnMgcmVzdWx0aW5nIGZyb20gZXhlY3V0aW5nIGEgCisgICAgICAgIHNjcmlwdCBv biBpbnNwZWN0b3IgZnJvbnQtZW5kIHRvIHByZXZlbnQgcmVuZGVyZXIgZnJvbSBjcmFzaGluZy4K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQyMTU3CisK KyAgICAgICAgKiBzcmMvV2ViRGV2VG9vbHNGcm9udGVuZEltcGwuY3BwOgorICAgICAgICAoV2Vi S2l0OjpXZWJEZXZUb29sc0Zyb250ZW5kSW1wbDo6ZXhlY3V0ZVNjcmlwdCk6CisKIDIwMTAtMDct MTMgIEtlbnQgVGFtdXJhICA8dGtlbnRAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFVucmV2aWV3 ZWQsIGJ1aWxkIGZpeC4KSW5kZXg6IFdlYktpdC9jaHJvbWl1bS9zcmMvV2ViRGV2VG9vbHNGcm9u dGVuZEltcGwuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9jaHJvbWl1bS9zcmMvV2ViRGV2VG9v bHNGcm9udGVuZEltcGwuY3BwCShyZXZpc2lvbiA2Mjc2NikKKysrIFdlYktpdC9jaHJvbWl1bS9z cmMvV2ViRGV2VG9vbHNGcm9udGVuZEltcGwuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNzQsNiAr MTc0LDggQEAgdm9pZCBXZWJEZXZUb29sc0Zyb250ZW5kSW1wbDo6ZXhlY3V0ZVNjcgogICAgIFZl Y3Rvcjwgdjg6OkhhbmRsZTx2ODo6VmFsdWU+ID4gYXJnczsKICAgICBmb3IgKHNpemVfdCBpID0g MDsgaSA8IHYuc2l6ZSgpOyBpKyspCiAgICAgICAgIGFyZ3MuYXBwZW5kKFRvVjhTdHJpbmcodi5h dChpKSkpOworICAgIHY4OjpUcnlDYXRjaCB0cnlDYXRjaDsKKyAgICB0cnlDYXRjaC5TZXRWZXJi b3NlKHRydWUpOwogICAgIGZ1bmN0aW9uLT5DYWxsKGZyYW1lQ29udGV4dC0+R2xvYmFsKCksIGFy Z3Muc2l6ZSgpLCBhcmdzLmRhdGEoKSk7CiB9CiAK