42150 2010-07-13 01:11:47 -0700 [Qt] CSS border style not cleared for SVG object 2010-07-14 19:56:25 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) All All RESOLVED FIXED Qt P3 Normal --- 0 mirko webkit-qt-unassigned kenneth kling oldest_to_newest 250379 0 mirko 2010-07-13 01:11:47 -0700 The same bug as stated by report https://bugs.webkit.org/show_bug.cgi?id=25738 is present within the Qt binding of WebKit. 250381 1 61343 mirko 2010-07-13 01:19:33 -0700 Created attachment 61343 Proposed patch. 250428 2 61343 kling 2010-07-13 03:58:10 -0700 Comment on attachment 61343 Proposed patch. While the change looks fairly reasonable, I cannot actually reproduce the problem with QtWebKit trunk. What versions of Qt and QtWebKit are you using? 250429 3 kenneth 2010-07-13 04:03:50 -0700 Wrong coding style, though. Should not use braces. 251030 4 61343 hausmann 2010-07-14 01:44:55 -0700 Comment on attachment 61343 Proposed patch. Yeah, patch looks good to me. It's a safe thing to do, and the original patch for Skia is doing the same. Would be nice to join the layout test coverage for this. I'm going to say r+ but cq- because it needs the coding style fix before landing. So if someone wants to land it, go ahead :). Otherwise Mirko just attach a new patch and we'll run it through the commit queue. 251605 5 kling 2010-07-14 19:56:25 -0700 Committed r63394: <http://trac.webkit.org/changeset/63394> 61343 2010-07-13 01:19:33 -0700 2010-07-14 01:44:55 -0700 Proposed patch. proposed.patch text/plain 1156 mirko ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ODE5ZWVkNC4uNmQ5M2MyZSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMC0wNy0xMyAgTWlya28gRGFtaWFu aSAgPG1pcmtvQGRldmVsZXIuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFtRdF0gQ1NTIGJvcmRlciBzdHlsZSBub3QgY2xlYXJlZCBmb3IgU1ZH IG9iamVjdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 NDIxNTAKKworICAgICAgICBGb3IgdGVzdHMgYW5kIGRlc2NyaXB0aW9uIHNlZToKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI1NzM4CisKKyAgICAgICAg KiBwbGF0Zm9ybS9ncmFwaGljcy9xdC9HcmFwaGljc0NvbnRleHRRdC5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpHcmFwaGljc0NvbnRleHQ6OnNldExpbmVEYXNoKToKKwogMjAxMC0wNy0xMiAgRXJp YyBTZWlkZWwgIDxlcmljQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBC YXJ0aC4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvR3JhcGhpY3ND b250ZXh0UXQuY3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9HcmFwaGljc0NvbnRl eHRRdC5jcHAKaW5kZXggOTEzYTc2NC4uMzhmNzNjNyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9xdC9HcmFwaGljc0NvbnRleHRRdC5jcHAKKysrIGIvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9xdC9HcmFwaGljc0NvbnRleHRRdC5jcHAKQEAgLTEwMTUsNiArMTAxNSw4 IEBAIHZvaWQgR3JhcGhpY3NDb250ZXh0OjpzZXRMaW5lRGFzaChjb25zdCBEYXNoQXJyYXkmIGRh c2hlcywgZmxvYXQgZGFzaE9mZnNldCkKIAogICAgICAgICBwZW4uc2V0RGFzaFBhdHRlcm4ocGF0 dGVybik7CiAgICAgICAgIHBlbi5zZXREYXNoT2Zmc2V0KGRhc2hPZmZzZXQpOworICAgIH0gZWxz ZSB7CisgICAgICAgIHBlbi5zZXRTdHlsZShRdDo6U29saWRMaW5lKTsKICAgICB9CiAgICAgcC0+ c2V0UGVuKHBlbik7CiB9Cg==