42143 2010-07-12 22:37:31 -0700 Fix line number handling in HTMLTreeBuilder to fix a zillion layout tests 2010-07-13 00:40:05 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 41123 1 eric eric abarth commit-queue eric sam tonyg webkit.review.bot oldest_to_newest 250315 0 eric 2010-07-12 22:37:31 -0700 Fix line number handling in HTMLTreeBuilder to fix a zillion layout tests 250318 1 61328 eric 2010-07-12 22:40:03 -0700 Created attachment 61328 Patch 250323 2 61328 abarth 2010-07-12 22:51:42 -0700 Comment on attachment 61328 Patch This whole +1 thing is out of control. Can we use the type system to make this easier? Can we just agree on either 0 or 1 based? 250330 3 eric 2010-07-12 22:59:08 -0700 Interesting thought. We could use the type system to convert from parser line numbers to script line numbers. I completely agree that the +1 thing is out of control. 250355 4 61328 commit-queue 2010-07-12 23:53:28 -0700 Comment on attachment 61328 Patch Clearing flags on attachment: 61328 Committed r63180: <http://trac.webkit.org/changeset/63180> 250356 5 commit-queue 2010-07-12 23:53:33 -0700 All reviewed patches have been landed. Closing bug. 250366 6 webkit.review.bot 2010-07-13 00:40:05 -0700 http://trac.webkit.org/changeset/63180 might have broken Chromium Win Release The following changes are on the blame list: http://trac.webkit.org/changeset/63178 http://trac.webkit.org/changeset/63179 http://trac.webkit.org/changeset/63180 http://trac.webkit.org/changeset/63181 61328 2010-07-12 22:40:03 -0700 2010-07-12 23:53:28 -0700 Patch bug-42143-20100712224002.patch text/plain 1824 eric ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NGI3ZTQzMzkxYWYyMDk5ZDg2NjEwOGQwMWE4Yjc1YjY3NGUyMGZjYy4uNThiZjM1ODQ3OTEzNmJj ZDJhMGY0NzI5ZDc0MGIzNjAwNDQ4OWVlOCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTIsNiArMiwxOSBAQAogCiAgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgogCisgICAgICAgIEZpeCBsaW5lIG51bWJlciBoYW5kbGlu ZyBpbiBIVE1MVHJlZUJ1aWxkZXIgdG8gZml4IGEgemlsbGlvbiBsYXlvdXQgdGVzdHMKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQyMTQzCisKKyAgICAg ICAgQ292ZXJlZCBieSBhIHppbGxpb24gbGF5b3V0IHRlc3RzLgorCisgICAgICAgICogaHRtbC9I VE1MVHJlZUJ1aWxkZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRNTFRyZWVCdWlsZGVyOjpw cm9jZXNzRW5kVGFnKToKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxUcmVlQnVpbGRlcjo6cHJvY2Vz c1NjcmlwdFN0YXJ0VGFnKToKKworMjAxMC0wNy0xMiAgRXJpYyBTZWlkZWwgIDxlcmljQHdlYmtp dC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKICAgICAgICAg Rml4IHR5cG8gaW4gImNsb3NlIHRoZSBjZWxsIiB3aGljaCBjYXVzZWQgYXNzZXJ0aW9uCiAgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MjEzOAogCmRpZmYg LS1naXQgYS9XZWJDb3JlL2h0bWwvSFRNTFRyZWVCdWlsZGVyLmNwcCBiL1dlYkNvcmUvaHRtbC9I VE1MVHJlZUJ1aWxkZXIuY3BwCmluZGV4IGI3ZjYzN2NiODk1NGVhOTdkZGY1YTA5Nzg4ZWRmNTEz NjdhYzgwOWUuLjhhMzU3ZmZkMTQ0ZmFiNGM1ZDk4MWEwM2JlNmVhZDkyMDU2ODIyNDcgMTAwNjQ0 Ci0tLSBhL1dlYkNvcmUvaHRtbC9IVE1MVHJlZUJ1aWxkZXIuY3BwCisrKyBiL1dlYkNvcmUvaHRt bC9IVE1MVHJlZUJ1aWxkZXIuY3BwCkBAIC0yMjUxLDYgKzIyNTEsNyBAQCB2b2lkIEhUTUxUcmVl QnVpbGRlcjo6cHJvY2Vzc0VuZFRhZyhBdG9taWNIVE1MVG9rZW4mIHRva2VuKQogICAgICAgICAg ICAgbV9pc1BhdXNlZCA9IHRydWU7CiAgICAgICAgICAgICBBU1NFUlQobV90cmVlLmN1cnJlbnRF bGVtZW50KCktPmhhc1RhZ05hbWUoc2NyaXB0VGFnKSk7CiAgICAgICAgICAgICBtX3NjcmlwdFRv UHJvY2VzcyA9IG1fdHJlZS5jdXJyZW50RWxlbWVudCgpOworICAgICAgICAgICAgbV9zY3JpcHRU b1Byb2Nlc3NTdGFydExpbmUgPSBtX2xhc3RTY3JpcHRFbGVtZW50U3RhcnRMaW5lICsgMTsKICAg ICAgICAgICAgIG1fdHJlZS5vcGVuRWxlbWVudHMoKS0+cG9wKCk7CiAgICAgICAgICAgICBzZXRJ bnNlcnRpb25Nb2RlKG1fb3JpZ2luYWxJbnNlcnRpb25Nb2RlKTsKICAgICAgICAgICAgIHJldHVy bjsKQEAgLTI3NzUsNiArMjc3Niw3IEBAIHZvaWQgSFRNTFRyZWVCdWlsZGVyOjpwcm9jZXNzU2Ny aXB0U3RhcnRUYWcoQXRvbWljSFRNTFRva2VuJiB0b2tlbikKICAgICBtX3RyZWUuaW5zZXJ0U2Ny aXB0RWxlbWVudCh0b2tlbik7CiAgICAgbV90b2tlbml6ZXItPnNldFN0YXRlKEhUTUxUb2tlbml6 ZXI6OlNjcmlwdERhdGFTdGF0ZSk7CiAgICAgbV9vcmlnaW5hbEluc2VydGlvbk1vZGUgPSBtX2lu c2VydGlvbk1vZGU7CisgICAgbV9sYXN0U2NyaXB0RWxlbWVudFN0YXJ0TGluZSA9IG1fdG9rZW5p emVyLT5saW5lTnVtYmVyKCk7CiAgICAgc2V0SW5zZXJ0aW9uTW9kZShUZXh0TW9kZSk7CiB9CiAK