42138 2010-07-12 21:45:40 -0700 Fix typo in "close the cell" which caused assertion 2010-07-13 01:42:31 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 41123 1 eric eric abarth commit-queue eric webkit.review.bot oldest_to_newest 250286 0 eric 2010-07-12 21:45:40 -0700 Fix typo in "close the cell" which caused assertion 250287 1 61322 eric 2010-07-12 21:46:26 -0700 Created attachment 61322 Patch 250326 2 61322 abarth 2010-07-12 22:53:43 -0700 Comment on attachment 61322 Patch You've got to put the table in the table scope, apparently. 250349 3 61322 commit-queue 2010-07-12 23:26:28 -0700 Comment on attachment 61322 Patch Rejecting patch 61322 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--ignore-tests', 'compositing', '--quiet']" exit_code: 1 Running build-dumprendertree Compiling Java tests make: Nothing to be done for `default'. Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 20653 test cases. html5lib/runner.html -> failed Exiting early after 1 failures. 15520 tests run. 279.46s total testing time 15519 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 12 test cases (<1%) had stderr output Full output: http://webkit-commit-queue.appspot.com/results/3506203 250383 4 eric 2010-07-13 01:23:30 -0700 Committed r63183: <http://trac.webkit.org/changeset/63183> 250388 5 webkit.review.bot 2010-07-13 01:42:31 -0700 http://trac.webkit.org/changeset/63183 might have broken GTK Linux 32-bit Release 61322 2010-07-12 21:46:26 -0700 2010-07-12 23:26:28 -0700 Patch bug-42138-20100712214625.patch text/plain 2769 eric ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBhNmUwMGZiOTEzYmQwZDA4MjA0NmMzMTQ3Y2RkYmFkODFmOGM0NjFkLi5kMDlmNGFm YzQ5NGMyNmNlMjAxNjg4ODkzYzNiMDE4MTU3ODhiY2YxIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0yLDYgKzIsMTUgQEAK IAogICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KIAorICAgICAgICBGaXggdHlw byBpbiAiY2xvc2UgdGhlIGNlbGwiIHdoaWNoIGNhdXNlZCBhc3NlcnRpb24KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQyMTM4CisKKyAgICAgICAgKiBo dG1sNWxpYi9yZXNvdXJjZXMvdGFibGVzMDEuZGF0OgorCisyMDEwLTA3LTEyICBFcmljIFNlaWRl bCAgPGVyaWNAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKwogICAgICAgICBGaXggYSB0eXBvIGluIHRoZSBhZG9wdGlvbiBhZ2VuY3kgY2F1c2luZyB0 ZXN0IGZhaWx1cmVzCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD00MjEzMwogCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9odG1sNWxpYi9yZXNvdXJjZXMv dGFibGVzMDEuZGF0IGIvTGF5b3V0VGVzdHMvaHRtbDVsaWIvcmVzb3VyY2VzL3RhYmxlczAxLmRh dAppbmRleCA4YzU2NTJlMDNjMTA0ODU4MWVlYjkxMmM5ZjNkYzU2MDJmYzFiNmUzLi44OGVmMWZl MmVlOWU4NWVkNTY2ZjBlZDQ4ODg3MzBhMTM4OTE3OWNhIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9odG1sNWxpYi9yZXNvdXJjZXMvdGFibGVzMDEuZGF0CisrKyBiL0xheW91dFRlc3RzL2h0bWw1 bGliL3Jlc291cmNlcy90YWJsZXMwMS5kYXQKQEAgLTE4MSwzICsxODEsMTcgQEAKIHwgICAgICAg ICA8dHI+CiB8ICAgICAgICAgICA8dGQ+CiB8ICAgICAgICAgPHRyPgorCisjZGF0YQorPHRhYmxl Pjx0ZD48YnV0dG9uPjx0ZD4KKyNlcnJvcnMKKyNkb2N1bWVudAorfCA8aHRtbD4KK3wgICA8aGVh ZD4KK3wgICA8Ym9keT4KK3wgICAgIDx0YWJsZT4KK3wgICAgICAgPHRib2R5PgorfCAgICAgICAg IDx0cj4KK3wgICAgICAgICAgIDx0ZD4KK3wgICAgICAgICAgICAgPGJ1dHRvbj4KK3wgICAgICAg ICAgIDx0ZD4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VM b2cKaW5kZXggNGQ1OTMzNTQxMTlhMzUzYjY5OWQyYjg0MzhhMDQ0MDhlNGU1Yzc0MS4uNGI3ZTQz MzkxYWYyMDk5ZDg2NjEwOGQwMWE4Yjc1YjY3NGUyMGZjYyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9D aGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTIsNiArMiwxNiBAQAogCiAgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgogCisgICAgICAgIEZpeCB0eXBvIGluICJj bG9zZSB0aGUgY2VsbCIgd2hpY2ggY2F1c2VkIGFzc2VydGlvbgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDIxMzgKKworICAgICAgICAqIGh0bWwvSFRN TFRyZWVCdWlsZGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxUcmVlQnVpbGRlcjo6Y2xv c2VUaGVDZWxsKToKKworMjAxMC0wNy0xMiAgRXJpYyBTZWlkZWwgIDxlcmljQHdlYmtpdC5vcmc+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKICAgICAgICAgRml4IGEg dHlwbyBpbiB0aGUgYWRvcHRpb24gYWdlbmN5IGNhdXNpbmcgdGVzdCBmYWlsdXJlcwogICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDIxMzMKIApkaWZmIC0t Z2l0IGEvV2ViQ29yZS9odG1sL0hUTUxUcmVlQnVpbGRlci5jcHAgYi9XZWJDb3JlL2h0bWwvSFRN TFRyZWVCdWlsZGVyLmNwcAppbmRleCA4MGQ0NTMwNTkyMTNmMGIxYzMwYzVjODg4NmIzNWEwZDk3 ZGFlOWI4Li5iN2Y2MzdjYjg5NTRlYTk3ZGRmNWEwOTc4OGVkZjUxMzY3YWM4MDllIDEwMDY0NAot LS0gYS9XZWJDb3JlL2h0bWwvSFRNTFRyZWVCdWlsZGVyLmNwcAorKysgYi9XZWJDb3JlL2h0bWwv SFRNTFRyZWVCdWlsZGVyLmNwcApAQCAtMTA2OSwxMiArMTA2OSwxMiBAQCBib29sIEhUTUxUcmVl QnVpbGRlcjo6cHJvY2Vzc0NvbGdyb3VwRW5kVGFnRm9ySW5Db2x1bW5Hcm91cCgpCiB2b2lkIEhU TUxUcmVlQnVpbGRlcjo6Y2xvc2VUaGVDZWxsKCkKIHsKICAgICBBU1NFUlQoaW5zZXJ0aW9uTW9k ZSgpID09IEluQ2VsbE1vZGUpOwotICAgIGlmIChtX3RyZWUub3BlbkVsZW1lbnRzKCktPmluU2Nv cGUodGRUYWcpKSB7Ci0gICAgICAgIEFTU0VSVCghbV90cmVlLm9wZW5FbGVtZW50cygpLT5pblNj b3BlKHRoVGFnKSk7CisgICAgaWYgKG1fdHJlZS5vcGVuRWxlbWVudHMoKS0+aW5UYWJsZVNjb3Bl KHRkVGFnKSkgeworICAgICAgICBBU1NFUlQoIW1fdHJlZS5vcGVuRWxlbWVudHMoKS0+aW5UYWJs ZVNjb3BlKHRoVGFnKSk7CiAgICAgICAgIHByb2Nlc3NGYWtlRW5kVGFnKHRkVGFnKTsKICAgICAg ICAgcmV0dXJuOwogICAgIH0KLSAgICBBU1NFUlQobV90cmVlLm9wZW5FbGVtZW50cygpLT5pblNj b3BlKHRoVGFnKSk7CisgICAgQVNTRVJUKG1fdHJlZS5vcGVuRWxlbWVudHMoKS0+aW5UYWJsZVNj b3BlKHRoVGFnKSk7CiAgICAgcHJvY2Vzc0Zha2VFbmRUYWcodGhUYWcpOwogICAgIEFTU0VSVChp bnNlcnRpb25Nb2RlKCkgPT0gSW5Sb3dNb2RlKTsKIH0K