42132 2010-07-12 19:52:36 -0700 Need support for a WebKit2-specific Skipped list (and initially add accessibility tests to it) 2010-07-12 20:18:03 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 mjs mjs webkit.review.bot oldest_to_newest 250255 0 mjs 2010-07-12 19:52:36 -0700 Need support for a WebKit2-specific Skipped list (and initially add accessibility tests to it) 250259 1 61316 mjs 2010-07-12 19:58:48 -0700 Created attachment 61316 Patch 250260 2 webkit.review.bot 2010-07-12 20:00:30 -0700 Attachment 61316 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebKitTools/Scripts/old-run-webkit-tests:351: Line contains tab character. [whitespace/tab] [5] WebKitTools/Scripts/old-run-webkit-tests:352: Line contains tab character. [whitespace/tab] [5] WebKitTools/Scripts/old-run-webkit-tests:1886: Line contains tab character. [whitespace/tab] [5] WebKitTools/Scripts/old-run-webkit-tests:1887: Line contains tab character. [whitespace/tab] [5] WebKitTools/Scripts/old-run-webkit-tests:1888: Line contains tab character. [whitespace/tab] [5] WebKitTools/Scripts/old-run-webkit-tests:1889: Line contains tab character. [whitespace/tab] [5] WebKitTools/Scripts/old-run-webkit-tests:1890: Line contains tab character. [whitespace/tab] [5] WebKitTools/Scripts/old-run-webkit-tests:1921: Line contains tab character. [whitespace/tab] [5] Total errors found: 8 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 250261 3 61316 sam 2010-07-12 20:01:47 -0700 Comment on attachment 61316 Patch > > +if ($useWebKitTestRunner) { > + if (isAppleMacWebKit()) { > + $realPlatform = $platform; > + $platform = "mac-wk2"; > + } > +} Looks like a case of the "tabs." There are a few others of these. > +# THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. > +# > + > +# <https://bugs.webkit.org/show_bug.cgi?id=42130> WebKit2 needs to support accessibility > +# <https://bugs.webkit.org/show_bug.cgi?id=42131> WebKitTestRunner needs to support accessibility-related DRT APIs > +accessibility > \ No newline at end of file Need a newline. Other than that, r=me. 250265 4 mjs 2010-07-12 20:18:03 -0700 http://trac.webkit.org/changeset/63163 61316 2010-07-12 19:58:48 -0700 2010-07-12 20:01:46 -0700 Patch bug-42132-20100712195847.patch text/plain 5508 mjs SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDYzMTYxKQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMDctMTIgIE1hY2llaiBTdGFjaG93aWFr ICA8bWpzQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBOZWVkIHN1cHBvcnQgZm9yIGEgV2ViS2l0Mi1zcGVjaWZpYyBTa2lwcGVkIGxp c3QgKGFuZCBpbml0aWFsbHkgYWRkIGFjY2Vzc2liaWxpdHkgdGVzdHMgdG8gaXQpCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MjEzMgorCisgICAgICAg ICogU2NyaXB0cy9vbGQtcnVuLXdlYmtpdC10ZXN0czogSW4gLS13ZWJraXQtdGVzdC1ydW5uZXIg bW9kZSwgYWRkIG1hYy13azIgdG8gbGlzdCBvZgorICAgICAgICBwbGF0Zm9ybSBkaXJlY3Rvcmll cy4KKwogMjAxMC0wNy0xMiAgTWFjaWVqIFN0YWNob3dpYWsgIDxtanNAYXBwbGUuY29tPgogCiAg ICAgICAgIFJldmlld2VkIGJ5IEFuZGVycyBDYXJsc3Nvbi4KSW5kZXg6IFdlYktpdFRvb2xzL1Nj cmlwdHMvb2xkLXJ1bi13ZWJraXQtdGVzdHMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0VG9vbHMvU2Ny aXB0cy9vbGQtcnVuLXdlYmtpdC10ZXN0cwkocmV2aXNpb24gNjMwNjMpCisrKyBXZWJLaXRUb29s cy9TY3JpcHRzL29sZC1ydW4td2Via2l0LXRlc3RzCSh3b3JraW5nIGNvcHkpCkBAIC0xODQsNiAr MTg0LDggQEAgbXkgJHByZXR0eURpZmZUYWcgPSAicHJldHR5LWRpZmYiOwogbXkgJGRpZmZzVGFn ID0gImRpZmZzIjsKIG15ICRlcnJvclRhZyA9ICJzdGRlcnIiOwogCitteSAkcmVhbFBsYXRmb3Jt OworCiBteSBAbWFjUGxhdGZvcm1zID0gKCJtYWMtdGlnZXIiLCAibWFjLWxlb3BhcmQiLCAibWFj LXNub3dsZW9wYXJkIiwgIm1hYyIpOwogbXkgQHdpblBsYXRmb3JtcyA9ICgid2luLXhwIiwgIndp bi12aXN0YSIsICJ3aW4tNyIsICJ3aW4iKTsKIApAQCAtMzQ0LDYgKzM0NiwxNCBAQCBpZiAoISRn ZXRPcHRpb25zUmVzdWx0IHx8ICRzaG93SGVscCkgewogICAgIGV4aXQgMTsKIH0KIAoraWYgKCR1 c2VXZWJLaXRUZXN0UnVubmVyKSB7CisgICAgaWYgKGlzQXBwbGVNYWNXZWJLaXQoKSkgeworCSRy ZWFsUGxhdGZvcm0gPSAkcGxhdGZvcm07CisJJHBsYXRmb3JtID0gIm1hYy13azIiOworICAgIH0K K30KKworCiBteSAkaWdub3JlU2tpcHBlZCA9ICR0cmVhdFNraXBwZWQgZXEgImlnbm9yZSI7CiBt eSAkc2tpcHBlZE9ubHkgPSAkdHJlYXRTa2lwcGVkIGVxICJvbmx5IjsKIApAQCAtMTg2OSwxMCAr MTg3OSwxNiBAQCBzdWIgYnVpbGRQbGF0Zm9ybVJlc3VsdEhpZXJhcmNoeSgpCiAgICAgbXkgJGlz TWFjID0gJHBsYXRmb3JtID1+IC9ebWFjLzsKICAgICBteSAkaXNXaW4gPSAkcGxhdGZvcm0gPX4g L153aW4vOwogICAgIGlmICgkaXNNYWMgfHwgJGlzV2luKSB7CisJbXkgJGVmZmVjdGl2ZVBsYXRm b3JtID0gJHBsYXRmb3JtOworCWlmICgkcGxhdGZvcm0gZXEgIm1hYy13azIiKSB7CisJICAgIHB1 c2ggQHBsYXRmb3JtcywgIm1hYy13azIiOworCSAgICAkZWZmZWN0aXZlUGxhdGZvcm0gPSAkcmVh bFBsYXRmb3JtOworCX0KKwogICAgICAgICBteSBAcGxhdGZvcm1MaXN0ID0gJGlzTWFjID8gQG1h Y1BsYXRmb3JtcyA6IEB3aW5QbGF0Zm9ybXM7CiAgICAgICAgIG15ICRpOwogICAgICAgICBmb3Ig KCRpID0gMDsgJGkgPCBAcGxhdGZvcm1MaXN0OyAkaSsrKSB7Ci0gICAgICAgICAgICBsYXN0IGlm ICRwbGF0Zm9ybUxpc3RbJGldIGVxICRwbGF0Zm9ybTsKKyAgICAgICAgICAgIGxhc3QgaWYgJHBs YXRmb3JtTGlzdFskaV0gZXEgJGVmZmVjdGl2ZVBsYXRmb3JtOwogICAgICAgICB9CiAgICAgICAg IGZvciAoOyAkaSA8IEBwbGF0Zm9ybUxpc3Q7ICRpKyspIHsKICAgICAgICAgICAgIHB1c2ggQHBs YXRmb3JtcywgJHBsYXRmb3JtTGlzdFskaV07CkBAIC0xODg5LDcgKzE5MDUsNyBAQCBzdWIgYnVp bGRQbGF0Zm9ybVJlc3VsdEhpZXJhcmNoeSgpCiAgICAgICAgIG15ICRzY29wZWQgPSBjYXRkaXIo JHBsYXRmb3JtQmFzZURpcmVjdG9yeSwgJHBsYXRmb3Jtc1skaV0pOwogICAgICAgICBwdXNoKEBo aWVyYXJjaHksICRzY29wZWQpIGlmICgtZCAkc2NvcGVkKTsKICAgICB9Ci0KKyAgICAKICAgICBy ZXR1cm4gQGhpZXJhcmNoeTsKIH0KIApAQCAtMTg5Nyw3ICsxOTEzLDkgQEAgc3ViIGJ1aWxkUGxh dGZvcm1UZXN0SGllcmFyY2h5KEApCiB7CiAgICAgbXkgKEBwbGF0Zm9ybUhpZXJhcmNoeSkgPSBA XzsKICAgICByZXR1cm4gQHBsYXRmb3JtSGllcmFyY2h5IGlmIChAcGxhdGZvcm1IaWVyYXJjaHkg PCAyKTsKLQorICAgIGlmICgkcGxhdGZvcm1IaWVyYXJjaHlbMF0gPX4gL21hYy13azIvKSB7CisJ cmV0dXJuICgkcGxhdGZvcm1IaWVyYXJjaHlbMF0sICRwbGF0Zm9ybUhpZXJhcmNoeVsxXSwgJHBs YXRmb3JtSGllcmFyY2h5WyQjcGxhdGZvcm1IaWVyYXJjaHldKTsKKyAgICB9CiAgICAgcmV0dXJu ICgkcGxhdGZvcm1IaWVyYXJjaHlbMF0sICRwbGF0Zm9ybUhpZXJhcmNoeVskI3BsYXRmb3JtSGll cmFyY2h5XSk7CiB9CiAKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDYzMTYxKQorKysgTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDctMTIgIE1h Y2llaiBTdGFjaG93aWFrICA8bWpzQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBOZWVkIHN1cHBvcnQgZm9yIGEgV2ViS2l0Mi1zcGVj aWZpYyBTa2lwcGVkIGxpc3QgKGFuZCBpbml0aWFsbHkgYWRkIGFjY2Vzc2liaWxpdHkgdGVzdHMg dG8gaXQpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00 MjEzMgorCisgICAgICAgICogcGxhdGZvcm0vbWFjLXdrMjogQWRkZWQuCisgICAgICAgICogcGxh dGZvcm0vbWFjLXdrMi9Ta2lwcGVkOiBBZGRlZC4gSW5pdGlhbGx5IGFkZCB0aGUgYWNjZXNzaWJp bGl0eQorICAgICAgICBkaXJlY3RvcnkgKHdpdGggdHdvIGJsb2NraW5nIGJ1Z3MpLgorCiAyMDEw LTA3LTEyICBZdXRhIEtpdGFtdXJhICA8eXV0YWtAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJl dmlld2VkIGJ5IEFsZXhleSBQcm9za3VyeWFrb3YuCkluZGV4OiBMYXlvdXRUZXN0cy9wbGF0Zm9y bS9tYWMtd2syL1NraXBwZWQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFj LXdrMi9Ta2lwcGVkCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjLXdr Mi9Ta2lwcGVkCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDMxIEBACisjCisjIENvcHlyaWdodCAo QykgMjAwOCBBcHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCisjCisjIFJlZGlzdHJpYnV0 aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0aG91dAor IyBtb2RpZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5n IGNvbmRpdGlvbnMKKyMgYXJlIG1ldDoKKyMKKyMgMS4gIFJlZGlzdHJpYnV0aW9ucyBvZiBzb3Vy Y2UgY29kZSBtdXN0IHJldGFpbiB0aGUgYWJvdmUgY29weXJpZ2h0CisjICAgICBub3RpY2UsIHRo aXMgbGlzdCBvZiBjb25kaXRpb25zIGFuZCB0aGUgZm9sbG93aW5nIGRpc2NsYWltZXIuIAorIyAy LiAgUmVkaXN0cmlidXRpb25zIGluIGJpbmFyeSBmb3JtIG11c3QgcmVwcm9kdWNlIHRoZSBhYm92 ZSBjb3B5cmlnaHQKKyMgICAgIG5vdGljZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRo ZSBmb2xsb3dpbmcgZGlzY2xhaW1lciBpbiB0aGUKKyMgICAgIGRvY3VtZW50YXRpb24gYW5kL29y IG90aGVyIG1hdGVyaWFscyBwcm92aWRlZCB3aXRoIHRoZSBkaXN0cmlidXRpb24uIAorIyAzLiAg TmVpdGhlciB0aGUgbmFtZSBvZiBBcHBsZSBDb21wdXRlciwgSW5jLiAoIkFwcGxlIikgbm9yIHRo ZSBuYW1lcyBvZgorIyAgICAgaXRzIGNvbnRyaWJ1dG9ycyBtYXkgYmUgdXNlZCB0byBlbmRvcnNl IG9yIHByb21vdGUgcHJvZHVjdHMgZGVyaXZlZAorIyAgICAgZnJvbSB0aGlzIHNvZnR3YXJlIHdp dGhvdXQgc3BlY2lmaWMgcHJpb3Igd3JpdHRlbiBwZXJtaXNzaW9uLiAKKyMKKyMgVEhJUyBTT0ZU V0FSRSBJUyBQUk9WSURFRCBCWSBBUFBMRSBBTkQgSVRTIENPTlRSSUJVVE9SUyAiQVMgSVMiIEFO RCBBTlkKKyMgRVhQUkVTUyBPUiBJTVBMSUVEIFdBUlJBTlRJRVMsIElOQ0xVRElORywgQlVUIE5P VCBMSU1JVEVEIFRPLCBUSEUgSU1QTElFRAorIyBXQVJSQU5USUVTIE9GIE1FUkNIQU5UQUJJTElU WSBBTkQgRklUTkVTUyBGT1IgQSBQQVJUSUNVTEFSIFBVUlBPU0UgQVJFCisjIERJU0NMQUlNRUQu IElOIE5PIEVWRU5UIFNIQUxMIEFQUExFIE9SIElUUyBDT05UUklCVVRPUlMgQkUgTElBQkxFIEZP UiBBTlkKKyMgRElSRUNULCBJTkRJUkVDVCwgSU5DSURFTlRBTCwgU1BFQ0lBTCwgRVhFTVBMQVJZ LCBPUiBDT05TRVFVRU5USUFMIERBTUFHRVMKKyMgKElOQ0xVRElORywgQlVUIE5PVCBMSU1JVEVE IFRPLCBQUk9DVVJFTUVOVCBPRiBTVUJTVElUVVRFIEdPT0RTIE9SIFNFUlZJQ0VTOworIyBMT1NT IE9GIFVTRSwgREFUQSwgT1IgUFJPRklUUzsgT1IgQlVTSU5FU1MgSU5URVJSVVBUSU9OKSBIT1dF VkVSIENBVVNFRCBBTkQKKyMgT04gQU5ZIFRIRU9SWSBPRiBMSUFCSUxJVFksIFdIRVRIRVIgSU4g Q09OVFJBQ1QsIFNUUklDVCBMSUFCSUxJVFksIE9SIFRPUlQKKyMgKElOQ0xVRElORyBORUdMSUdF TkNFIE9SIE9USEVSV0lTRSkgQVJJU0lORyBJTiBBTlkgV0FZIE9VVCBPRiBUSEUgVVNFIE9GCisj IFRISVMgU09GVFdBUkUsIEVWRU4gSUYgQURWSVNFRCBPRiBUSEUgUE9TU0lCSUxJVFkgT0YgU1VD SCBEQU1BR0UuCisjCisKKyMgPGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD00MjEzMD4gV2ViS2l0MiBuZWVkcyB0byBzdXBwb3J0IGFjY2Vzc2liaWxpdHkKKyMgPGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MjEzMT4gV2ViS2l0VGVzdFJ1bm5l ciBuZWVkcyB0byBzdXBwb3J0IGFjY2Vzc2liaWxpdHktcmVsYXRlZCBEUlQgQVBJcworYWNjZXNz aWJpbGl0eQpcIE5vIG5ld2xpbmUgYXQgZW5kIG9mIGZpbGUK