42123 2010-07-12 18:04:13 -0700 [Cairo] Incorrect Test for Text Fill 2010-07-12 23:21:32 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC Windows XP RESOLVED FIXED P2 Normal --- 1 bfulgham webkit-unassigned krit mihnea mrobinson webkit.review.bot oldest_to_newest 250202 0 bfulgham 2010-07-12 18:04:13 -0700 Mihnea Ovidenea reported that several test cases fail because of an invalid test in FontCairo.cpp: bfulgham@bfulgham-Win7VM ~/WebKit/WebCore/platform/graphics/cairo $ svn diff FontCairo.cpp Index: FontCairo.cpp =================================================================== --- FontCairo.cpp (revision 62870) +++ FontCairo.cpp (working copy) @@ -73,7 +73,7 @@ FloatSize shadowSize; float shadowBlur = 0; Color shadowColor; - bool hasShadow = context->textDrawingMode() == cTextFill && + bool hasShadow = context->textDrawingMode() & cTextFill && context->getShadow(shadowSize, shadowBlur, shadowColor); // TODO: Blur support Tests that show this problem: 1. fast/text/stroking-decorations.html 2. fast/text/stroking.html 3. fast/text/shadow-translucent-fill.html 250210 1 61306 bfulgham 2010-07-12 18:12:34 -0700 Created attachment 61306 Correct shadow test for stroke & fill case 250212 2 webkit.review.bot 2010-07-12 18:14:17 -0700 Attachment 61306 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebCore/platform/graphics/cairo/FontCairo.cpp:76: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 250214 3 61307 bfulgham 2010-07-12 18:16:04 -0700 Created attachment 61307 Correct shadow test for (stroke & fill) case. Update that corrects some style warnings. 250215 4 webkit.review.bot 2010-07-12 18:17:03 -0700 Attachment 61307 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebCore/platform/graphics/cairo/FontCairo.cpp:76: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 250216 5 61308 bfulgham 2010-07-12 18:17:45 -0700 Created attachment 61308 Correct style warnings. Attach the correct file this time! 250303 6 61308 krit 2010-07-12 22:15:45 -0700 Comment on attachment 61308 Correct style warnings. r=me 250304 7 krit 2010-07-12 22:16:15 -0700 Please add title and bug link to the changelog 250345 8 mrobinson 2010-07-12 23:21:32 -0700 Committed r63176: <http://trac.webkit.org/changeset/63176> 61306 2010-07-12 18:12:34 -0700 2010-07-12 18:16:04 -0700 Correct shadow test for stroke & fill case text_shadow_cairo.patch text/plain 1629 bfulgham SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2MzE1MikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjIgQEAKKzIwMTAtMDctMTIgIE1paG5lYSBPdmlkZW5lYSAgPG1paG5lYUBhZG9i ZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg Q29ycmVjdCB0ZXN0IHVzZWQgZm9yIHRleHQgc2hhZG93LiAgSXQgY3VycmVudGx5IGNoZWNrcyBm b3IKKyAgICAgICAgZXF1YWxpdHkgd2l0aCBjVGV4dEZpbGwuICBIb3dldmVyLCB0aGlzIHRlc3Qg ZmFpbHMgaWYgdGhlCisgICAgICAgIHRleHQgZHJhd2luZyBtb2RlIGlzIHNldCB0byAnY1RleHRG aWxsIHwgY1RleHRTdHJva2UnLiAgRml4CisgICAgICAgIGlzIHRvIG1vZGlmeSB0aGUgdGVzdCB0 byBiZSBsaWtlIG90aGVyIENhaXJvIHVzZXMgb2YgdGhlCisgICAgICAgIHRleHQgZHJhd2luZyBt b2RlLCBhbmQgY2hlY2sgZm9yIHRoZSBjVGV4dEZpbGwgYml0IGJlaW5nCisgICAgICAgIHNldCwg bm90IGZvciBlcXVhbGl0eSB3aXRoIHRoZSBiaXQuCisKKyAgICAgICAgQ292ZXJlZCBieSB0aGUg Zm9sbG93aW5nIHRlc3RzOgorICAgICAgICAgICBmYXN0L3RleHQvc3Ryb2tpbmctZGVjb3JhdGlv bnMuaHRtbAorICAgICAgICAgICBmYXN0L3RleHQvc3Ryb2tpbmcuaHRtbAorICAgICAgICAgICBm YXN0L3RleHQvc2hhZG93LXRyYW5zbHVjZW50LWZpbGwuaHRtbAorCisgICAgICAgICogcGxhdGZv cm0vZ3JhcGhpY3MvY2Fpcm8vRm9udENhaXJvLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZvbnQ6 OmRyYXdHbHlwaHMpOgorCiAyMDEwLTA3LTEyICBDaHJpcyBGbGVpemFjaCAgPGNmbGVpemFjaEBh cHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCkluZGV4OiBXZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhaXJvL0ZvbnRDYWlyby5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9Gb250Q2Fpcm8uY3BwCShyZXZpc2lvbiA2 MzE1MikKKysrIFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vRm9udENhaXJvLmNwcAko d29ya2luZyBjb3B5KQpAQCAtNzMsNyArNzMsNyBAQCB2b2lkIEZvbnQ6OmRyYXdHbHlwaHMoR3Jh cGhpY3NDb250ZXh0KiBjCiAgICAgRmxvYXRTaXplIHNoYWRvd1NpemU7CiAgICAgZmxvYXQgc2hh ZG93Qmx1ciA9IDA7CiAgICAgQ29sb3Igc2hhZG93Q29sb3I7Ci0gICAgYm9vbCBoYXNTaGFkb3cg PSBjb250ZXh0LT50ZXh0RHJhd2luZ01vZGUoKSA9PSBjVGV4dEZpbGwgJiYKKyAgICBib29sIGhh c1NoYWRvdyA9IGNvbnRleHQtPnRleHREcmF3aW5nTW9kZSgpICYgY1RleHRGaWxsICYmCiAgICAg ICAgIGNvbnRleHQtPmdldFNoYWRvdyhzaGFkb3dTaXplLCBzaGFkb3dCbHVyLCBzaGFkb3dDb2xv cik7CiAKICAgICAvLyBUT0RPOiBCbHVyIHN1cHBvcnQK 61307 2010-07-12 18:16:04 -0700 2010-07-12 18:17:45 -0700 Correct shadow test for (stroke & fill) case. text_shadow_cairo.patch text/plain 1629 bfulgham SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2MzE1MikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjIgQEAKKzIwMTAtMDctMTIgIE1paG5lYSBPdmlkZW5lYSAgPG1paG5lYUBhZG9i ZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg Q29ycmVjdCB0ZXN0IHVzZWQgZm9yIHRleHQgc2hhZG93LiAgSXQgY3VycmVudGx5IGNoZWNrcyBm b3IKKyAgICAgICAgZXF1YWxpdHkgd2l0aCBjVGV4dEZpbGwuICBIb3dldmVyLCB0aGlzIHRlc3Qg ZmFpbHMgaWYgdGhlCisgICAgICAgIHRleHQgZHJhd2luZyBtb2RlIGlzIHNldCB0byAnY1RleHRG aWxsIHwgY1RleHRTdHJva2UnLiAgRml4CisgICAgICAgIGlzIHRvIG1vZGlmeSB0aGUgdGVzdCB0 byBiZSBsaWtlIG90aGVyIENhaXJvIHVzZXMgb2YgdGhlCisgICAgICAgIHRleHQgZHJhd2luZyBt b2RlLCBhbmQgY2hlY2sgZm9yIHRoZSBjVGV4dEZpbGwgYml0IGJlaW5nCisgICAgICAgIHNldCwg bm90IGZvciBlcXVhbGl0eSB3aXRoIHRoZSBiaXQuCisKKyAgICAgICAgQ292ZXJlZCBieSB0aGUg Zm9sbG93aW5nIHRlc3RzOgorICAgICAgICAgICBmYXN0L3RleHQvc3Ryb2tpbmctZGVjb3JhdGlv bnMuaHRtbAorICAgICAgICAgICBmYXN0L3RleHQvc3Ryb2tpbmcuaHRtbAorICAgICAgICAgICBm YXN0L3RleHQvc2hhZG93LXRyYW5zbHVjZW50LWZpbGwuaHRtbAorCisgICAgICAgICogcGxhdGZv cm0vZ3JhcGhpY3MvY2Fpcm8vRm9udENhaXJvLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZvbnQ6 OmRyYXdHbHlwaHMpOgorCiAyMDEwLTA3LTEyICBDaHJpcyBGbGVpemFjaCAgPGNmbGVpemFjaEBh cHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCkluZGV4OiBXZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhaXJvL0ZvbnRDYWlyby5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9Gb250Q2Fpcm8uY3BwCShyZXZpc2lvbiA2 MzE1MikKKysrIFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vRm9udENhaXJvLmNwcAko d29ya2luZyBjb3B5KQpAQCAtNzMsNyArNzMsNyBAQCB2b2lkIEZvbnQ6OmRyYXdHbHlwaHMoR3Jh cGhpY3NDb250ZXh0KiBjCiAgICAgRmxvYXRTaXplIHNoYWRvd1NpemU7CiAgICAgZmxvYXQgc2hh ZG93Qmx1ciA9IDA7CiAgICAgQ29sb3Igc2hhZG93Q29sb3I7Ci0gICAgYm9vbCBoYXNTaGFkb3cg PSBjb250ZXh0LT50ZXh0RHJhd2luZ01vZGUoKSA9PSBjVGV4dEZpbGwgJiYKKyAgICBib29sIGhh c1NoYWRvdyA9IGNvbnRleHQtPnRleHREcmF3aW5nTW9kZSgpICYgY1RleHRGaWxsICYmCiAgICAg ICAgIGNvbnRleHQtPmdldFNoYWRvdyhzaGFkb3dTaXplLCBzaGFkb3dCbHVyLCBzaGFkb3dDb2xv cik7CiAKICAgICAvLyBUT0RPOiBCbHVyIHN1cHBvcnQK 61308 2010-07-12 18:17:45 -0700 2010-07-12 22:18:25 -0700 Correct style warnings. text_shadow_cairo.patch text/plain 1730 bfulgham SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2MzE1MikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjIgQEAKKzIwMTAtMDctMTIgIE1paG5lYSBPdmlkZW5lYSAgPG1paG5lYUBhZG9i ZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg Q29ycmVjdCB0ZXN0IHVzZWQgZm9yIHRleHQgc2hhZG93LiAgSXQgY3VycmVudGx5IGNoZWNrcyBm b3IKKyAgICAgICAgZXF1YWxpdHkgd2l0aCBjVGV4dEZpbGwuICBIb3dldmVyLCB0aGlzIHRlc3Qg ZmFpbHMgaWYgdGhlCisgICAgICAgIHRleHQgZHJhd2luZyBtb2RlIGlzIHNldCB0byAnY1RleHRG aWxsIHwgY1RleHRTdHJva2UnLiAgRml4CisgICAgICAgIGlzIHRvIG1vZGlmeSB0aGUgdGVzdCB0 byBiZSBsaWtlIG90aGVyIENhaXJvIHVzZXMgb2YgdGhlCisgICAgICAgIHRleHQgZHJhd2luZyBt b2RlLCBhbmQgY2hlY2sgZm9yIHRoZSBjVGV4dEZpbGwgYml0IGJlaW5nCisgICAgICAgIHNldCwg bm90IGZvciBlcXVhbGl0eSB3aXRoIHRoZSBiaXQuCisKKyAgICAgICAgQ292ZXJlZCBieSB0aGUg Zm9sbG93aW5nIHRlc3RzOgorICAgICAgICAgICBmYXN0L3RleHQvc3Ryb2tpbmctZGVjb3JhdGlv bnMuaHRtbAorICAgICAgICAgICBmYXN0L3RleHQvc3Ryb2tpbmcuaHRtbAorICAgICAgICAgICBm YXN0L3RleHQvc2hhZG93LXRyYW5zbHVjZW50LWZpbGwuaHRtbAorCisgICAgICAgICogcGxhdGZv cm0vZ3JhcGhpY3MvY2Fpcm8vRm9udENhaXJvLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZvbnQ6 OmRyYXdHbHlwaHMpOgorCiAyMDEwLTA3LTEyICBDaHJpcyBGbGVpemFjaCAgPGNmbGVpemFjaEBh cHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCkluZGV4OiBXZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhaXJvL0ZvbnRDYWlyby5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9Gb250Q2Fpcm8uY3BwCShyZXZpc2lvbiA2 MzE1MikKKysrIFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vRm9udENhaXJvLmNwcAko d29ya2luZyBjb3B5KQpAQCAtNzMsOCArNzMsOCBAQCB2b2lkIEZvbnQ6OmRyYXdHbHlwaHMoR3Jh cGhpY3NDb250ZXh0KiBjCiAgICAgRmxvYXRTaXplIHNoYWRvd1NpemU7CiAgICAgZmxvYXQgc2hh ZG93Qmx1ciA9IDA7CiAgICAgQ29sb3Igc2hhZG93Q29sb3I7Ci0gICAgYm9vbCBoYXNTaGFkb3cg PSBjb250ZXh0LT50ZXh0RHJhd2luZ01vZGUoKSA9PSBjVGV4dEZpbGwgJiYKLSAgICAgICAgY29u dGV4dC0+Z2V0U2hhZG93KHNoYWRvd1NpemUsIHNoYWRvd0JsdXIsIHNoYWRvd0NvbG9yKTsKKyAg ICBib29sIGhhc1NoYWRvdyA9IGNvbnRleHQtPnRleHREcmF3aW5nTW9kZSgpICYgY1RleHRGaWxs CisgICAgICAgICAgICAgICAgICAgICAmJiBjb250ZXh0LT5nZXRTaGFkb3coc2hhZG93U2l6ZSwg c2hhZG93Qmx1ciwgc2hhZG93Q29sb3IpOwogCiAgICAgLy8gVE9ETzogQmx1ciBzdXBwb3J0CiAg ICAgaWYgKGhhc1NoYWRvdykgewo=