42122 2010-07-12 17:51:33 -0700 Adding directional property enums back into CSSComputedStyleDeclaration::getPropertyCSSValue 2010-07-12 18:15:35 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 ajwong ajwong arv oldest_to_newest 250197 0 ajwong 2010-07-12 17:51:33 -0700 Chromium build needs all enum values represented inside a switch statement or else it throws an error. Adding in the enum values handled by resolveDirectionAwareProperty() into the switch statement with an ASSERT_NOT_REACHED() to make the compiler happy. 250199 1 61304 ajwong 2010-07-12 17:57:17 -0700 Created attachment 61304 add enums back into switch. 250201 2 61304 arv 2010-07-12 18:00:43 -0700 Comment on attachment 61304 add enums back into switch. Looks good with the following exception + Reviewed by NOBODY (OOPS!). Change to "Unreviewed, build fix." 250209 3 61304 jianli 2010-07-12 18:12:23 -0700 Comment on attachment 61304 add enums back into switch. r=me Generally looks good. Before landing your patch, please add more details to ChangeLog to describe why you need to add back enums. 250213 4 ajwong 2010-07-12 18:15:35 -0700 Landed as r63153 with beefed up changelog. Resolving. 61304 2010-07-12 17:57:17 -0700 2010-07-12 18:12:23 -0700 add enums back into switch. 42122.patch text/plain 1904 ajwong ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MjYwNGZhMS4uYTMxNGJlYSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0wNy0xMiAgQWxiZXJ0IEouIFdv bmcgIDxhandvbmdAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIEFkZGluZyBkaXJlY3Rpb25hbCBwcm9wZXJ0eSBlbnVtcyBiYWNr IGludG8gQ1NTQ29tcHV0ZWRTdHlsZURlY2xhcmF0aW9uOjpnZXRQcm9wZXJ0eUNTU1ZhbHVlCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MjEyMgorCisg ICAgICAgICogY3NzL0NTU0NvbXB1dGVkU3R5bGVEZWNsYXJhdGlvbi5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpDU1NDb21wdXRlZFN0eWxlRGVjbGFyYXRpb246OmdldFByb3BlcnR5Q1NTVmFsdWUp OgorCiAyMDEwLTA3LTEyICBDaHJpcyBGbGVpemFjaCAgPGNmbGVpemFjaEBhcHBsZS5jb20+CiAK ICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCmRpZmYgLS1naXQgYS9XZWJDb3JlL2Nz cy9DU1NDb21wdXRlZFN0eWxlRGVjbGFyYXRpb24uY3BwIGIvV2ViQ29yZS9jc3MvQ1NTQ29tcHV0 ZWRTdHlsZURlY2xhcmF0aW9uLmNwcAppbmRleCA3ZDc2MTc2Li43YTU4YjcyIDEwMDY0NAotLS0g YS9XZWJDb3JlL2Nzcy9DU1NDb21wdXRlZFN0eWxlRGVjbGFyYXRpb24uY3BwCisrKyBiL1dlYkNv cmUvY3NzL0NTU0NvbXB1dGVkU3R5bGVEZWNsYXJhdGlvbi5jcHAKQEAgLTE0MzksNiArMTQzOSwx NCBAQCBQYXNzUmVmUHRyPENTU1ZhbHVlPiBDU1NDb21wdXRlZFN0eWxlRGVjbGFyYXRpb246Omdl dFByb3BlcnR5Q1NTVmFsdWUoaW50IHByb3BlcgogICAgICAgICBjYXNlIENTU1Byb3BlcnR5VGV4 dFVuZGVybGluZVdpZHRoOgogICAgICAgICAgICAgYnJlYWs7CiAKKyAgICAgICAgLyogRGlyZWN0 aW9uYWwgcHJvcGVydGllcyBhcmUgcmVzb2x2ZWQgYnkgcmVzb2x2ZURpcmVjdGlvbkF3YXJlUHJv cGVydHkoKSBiZWZvcmUgdGhlIHN3aXRjaC4gKi8KKyAgICAgICAgY2FzZSBDU1NQcm9wZXJ0eVdl YmtpdE1hcmdpbkVuZDoKKyAgICAgICAgY2FzZSBDU1NQcm9wZXJ0eVdlYmtpdE1hcmdpblN0YXJ0 OgorICAgICAgICBjYXNlIENTU1Byb3BlcnR5V2Via2l0UGFkZGluZ0VuZDoKKyAgICAgICAgY2Fz ZSBDU1NQcm9wZXJ0eVdlYmtpdFBhZGRpbmdTdGFydDoKKyAgICAgICAgICAgIEFTU0VSVF9OT1Rf UkVBQ0hFRCgpOworICAgICAgICAgICAgYnJlYWs7CisKICAgICAgICAgLyogVW5pbXBsZW1lbnRl ZCBAZm9udC1mYWNlIHByb3BlcnRpZXMgKi8KICAgICAgICAgY2FzZSBDU1NQcm9wZXJ0eUZvbnRT dHJldGNoOgogICAgICAgICBjYXNlIENTU1Byb3BlcnR5U3JjOgpAQCAtMTQ2NCw4ICsxNDcyLDYg QEAgUGFzc1JlZlB0cjxDU1NWYWx1ZT4gQ1NTQ29tcHV0ZWRTdHlsZURlY2xhcmF0aW9uOjpnZXRQ cm9wZXJ0eUNTU1ZhbHVlKGludCBwcm9wZXIKICAgICAgICAgY2FzZSBDU1NQcm9wZXJ0eVdlYmtp dENvbHVtbnM6CiAgICAgICAgIGNhc2UgQ1NTUHJvcGVydHlXZWJraXRDb2x1bW5SdWxlOgogICAg ICAgICBjYXNlIENTU1Byb3BlcnR5V2Via2l0TWFyZ2luQ29sbGFwc2U6Ci0gICAgICAgIGNhc2Ug Q1NTUHJvcGVydHlXZWJraXRNYXJnaW5FbmQ6Ci0gICAgICAgIGNhc2UgQ1NTUHJvcGVydHlXZWJr aXRNYXJnaW5TdGFydDoKICAgICAgICAgY2FzZSBDU1NQcm9wZXJ0eVdlYmtpdE1hcnF1ZWU6CiAg ICAgICAgIGNhc2UgQ1NTUHJvcGVydHlXZWJraXRNYXJxdWVlU3BlZWQ6CiAgICAgICAgIGNhc2Ug Q1NTUHJvcGVydHlXZWJraXRNYXNrOgo=