42120 2010-07-12 17:38:45 -0700 Optimize m_compositingDependsOnGeometry logic added in bug 34009 2018-12-01 11:42:04 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) All OS X 10.5 RESOLVED FIXED P2 Normal --- 1 simon.fraser simon.fraser a ismail simon.fraser oldest_to_newest 250185 0 simon.fraser 2010-07-12 17:38:45 -0700 Bug 34009 add m_compositingDependsOnGeometry, but it never goes to false after being set to true. This should be fixed. 250801 1 61426 simon.fraser 2010-07-13 16:24:30 -0700 Created attachment 61426 WIP patch 1484020 2 simon.fraser 2018-12-01 11:42:04 -0800 m_compositingDependsOnGeometry has gone. 61426 2010-07-13 16:24:30 -0700 2010-07-13 16:24:30 -0700 WIP patch check-hierarchy-on-next-update.patch text/plain 3448 simon.fraser ZGlmZiAtLWdpdCBhL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9zaXRvci5jcHAg Yi9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckNvbXBvc2l0b3IuY3BwCmluZGV4IDFmZGEz NGMuLjgzNTZkYWUgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQ29t cG9zaXRvci5jcHAKKysrIGIvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21wb3NpdG9y LmNwcApAQCAtOTQsNyArOTQsNyBAQCBSZW5kZXJMYXllckNvbXBvc2l0b3I6OlJlbmRlckxheWVy Q29tcG9zaXRvcihSZW5kZXJWaWV3KiByZW5kZXJWaWV3KQogICAgICwgbV9zaG93RGVidWdCb3Jk ZXJzKGZhbHNlKQogICAgICwgbV9zaG93UmVwYWludENvdW50ZXIoZmFsc2UpCiAgICAgLCBtX2Nv bXBvc2l0aW5nQ29uc3VsdHNPdmVybGFwKHRydWUpCi0gICAgLCBtX2NvbXBvc2l0aW5nRGVwZW5k c09uR2VvbWV0cnkoZmFsc2UpCisgICAgLCBtX2NoZWNrSGllcmFyY2h5T25OZXh0TGF5ZXJVcGRh dGUoZmFsc2UpCiAgICAgLCBtX2NvbXBvc2l0aW5nKGZhbHNlKQogICAgICwgbV9jb21wb3NpdGlu Z0xheWVyc05lZWRSZWJ1aWxkKGZhbHNlKQogICAgICwgbV9yb290TGF5ZXJBdHRhY2htZW50KFJv b3RMYXllclVuYXR0YWNoZWQpCkBAIC0xNjksMTAgKzE2OSwxMiBAQCB2b2lkIFJlbmRlckxheWVy Q29tcG9zaXRvcjo6c2NoZWR1bGVTeW5jKCkKIAogdm9pZCBSZW5kZXJMYXllckNvbXBvc2l0b3I6 OnVwZGF0ZUNvbXBvc2l0aW5nTGF5ZXJzKENvbXBvc2l0aW5nVXBkYXRlVHlwZSB1cGRhdGVUeXBl LCBSZW5kZXJMYXllciogdXBkYXRlUm9vdCkKIHsKLSAgICBpZiAoIW1fY29tcG9zaXRpbmdEZXBl bmRzT25HZW9tZXRyeSAmJiAhbV9jb21wb3NpdGluZykKKyAgICBpZiAoIW1fY2hlY2tIaWVyYXJj aHlPbk5leHRMYXllclVwZGF0ZSAmJiAhbV9jb21wb3NpdGluZykKICAgICAgICAgcmV0dXJuOwog Ci0gICAgYm9vbCBjaGVja0ZvckhpZXJhcmNoeVVwZGF0ZSA9IG1fY29tcG9zaXRpbmdEZXBlbmRz T25HZW9tZXRyeTsKKyAgICBib29sIGNoZWNrRm9ySGllcmFyY2h5VXBkYXRlID0gbV9jaGVja0hp ZXJhcmNoeU9uTmV4dExheWVyVXBkYXRlOworICAgIG1fY2hlY2tIaWVyYXJjaHlPbk5leHRMYXll clVwZGF0ZSA9IGZhbHNlOworCiAgICAgYm9vbCBuZWVkR2VvbWV0cnlVcGRhdGUgPSBmYWxzZTsK ICAgICAKICAgICBzd2l0Y2ggKHVwZGF0ZVR5cGUpIHsKQEAgLTExOTksMTEgKzEyMDEsMTEgQEAg Ym9vbCBSZW5kZXJMYXllckNvbXBvc2l0b3I6OnJlcXVpcmVzQ29tcG9zaXRpbmdGb3JQbHVnaW4o UmVuZGVyT2JqZWN0KiByZW5kZXJlcikKICAgICBpZiAoIWVtYmVkUmVuZGVyZXItPmFsbG93c0Fj Y2VsZXJhdGVkQ29tcG9zaXRpbmcoKSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwogCi0gICAgbV9j b21wb3NpdGluZ0RlcGVuZHNPbkdlb21ldHJ5ID0gdHJ1ZTsKLQogICAgIC8vIElmIHdlIGNhbid0 IHJlbGlhYmx5IGtub3cgdGhlIHNpemUgb2YgdGhlIHBsdWdpbiB5ZXQsIGRvbid0IGNoYW5nZSBj b21wb3NpdGluZyBzdGF0ZS4KLSAgICBpZiAocmVuZGVyZXItPm5lZWRzTGF5b3V0KCkpCisgICAg aWYgKHJlbmRlcmVyLT5uZWVkc0xheW91dCgpKSB7CisgICAgICAgIG1fY2hlY2tIaWVyYXJjaHlP bk5leHRMYXllclVwZGF0ZSA9IHRydWU7CiAgICAgICAgIHJldHVybiBlbWJlZFJlbmRlcmVyLT5o YXNMYXllcigpICYmIGVtYmVkUmVuZGVyZXItPmxheWVyKCktPmlzQ29tcG9zaXRlZCgpOworICAg IH0KIAogICAgIC8vIERvbid0IGdvIGludG8gY29tcG9zaXRpbmcgbW9kZSBpZiBoZWlnaHQgb3Ig d2lkdGggYXJlIHplcm8sIG9yIHNpemUgaXMgMXgxLgogICAgIEludFJlY3QgY29udGVudEJveCA9 IGVtYmVkUmVuZGVyZXItPmNvbnRlbnRCb3hSZWN0KCk7CkBAIC0xMjIwLDE1ICsxMjIyLDE1IEBA IGJvb2wgUmVuZGVyTGF5ZXJDb21wb3NpdG9yOjpyZXF1aXJlc0NvbXBvc2l0aW5nRm9ySUZyYW1l KFJlbmRlck9iamVjdCogcmVuZGVyZXIpCiAgICAgaWYgKCFpZnJhbWVSZW5kZXJlci0+cmVxdWly ZXNBY2NlbGVyYXRlZENvbXBvc2l0aW5nKCkpCiAgICAgICAgIHJldHVybiBmYWxzZTsKIAotICAg IG1fY29tcG9zaXRpbmdEZXBlbmRzT25HZW9tZXRyeSA9IHRydWU7Ci0KICAgICBSZW5kZXJMYXll ckNvbXBvc2l0b3IqIGlubmVyQ29tcG9zaXRvciA9IGlmcmFtZUNvbnRlbnRzQ29tcG9zaXRvcihp ZnJhbWVSZW5kZXJlcik7CiAgICAgaWYgKCFpbm5lckNvbXBvc2l0b3ItPnNob3VsZFByb3BhZ2F0 ZUNvbXBvc2l0aW5nVG9FbmNsb3NpbmdJRnJhbWUoKSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwog CiAgICAgLy8gSWYgd2UgY2FuJ3QgcmVsaWFibHkga25vdyB0aGUgc2l6ZSBvZiB0aGUgaWZyYW1l IHlldCwgZG9uJ3QgY2hhbmdlIGNvbXBvc2l0aW5nIHN0YXRlLgotICAgIGlmIChyZW5kZXJlci0+ bmVlZHNMYXlvdXQoKSkKKyAgICBpZiAocmVuZGVyZXItPm5lZWRzTGF5b3V0KCkpIHsKKyAgICAg ICAgbV9jaGVja0hpZXJhcmNoeU9uTmV4dExheWVyVXBkYXRlID0gdHJ1ZTsKICAgICAgICAgcmV0 dXJuIGlmcmFtZVJlbmRlcmVyLT5oYXNMYXllcigpICYmIGlmcmFtZVJlbmRlcmVyLT5sYXllcigp LT5pc0NvbXBvc2l0ZWQoKTsKKyAgICB9CiAgICAgCiAgICAgLy8gRG9uJ3QgZ28gaW50byBjb21w b3NpdGluZyBtb2RlIGlmIGhlaWdodCBvciB3aWR0aCBhcmUgemVyby4KICAgICBJbnRSZWN0IGNv bnRlbnRCb3ggPSBpZnJhbWVSZW5kZXJlci0+Y29udGVudEJveFJlY3QoKTsKZGlmZiAtLWdpdCBh L1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9zaXRvci5oIGIvV2ViQ29yZS9yZW5k ZXJpbmcvUmVuZGVyTGF5ZXJDb21wb3NpdG9yLmgKaW5kZXggNjMzZWNkMS4uM2JmM2FkZiAxMDA2 NDQKLS0tIGEvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21wb3NpdG9yLmgKKysrIGIv V2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21wb3NpdG9yLmgKQEAgLTIyNSw3ICsyMjUs NyBAQCBwcml2YXRlOgogICAgIC8vIFdoZW4gdHJ1ZSwgd2UgaGF2ZSB0byB3YWl0IHVudGlsIGxh eW91dCBoYXMgaGFwcGVuZWQgYmVmb3JlIHdlIGNhbiBkZWNpZGUgd2hldGhlciB0byBlbnRlciBj b21wb3NpdGluZyBtb2RlLAogICAgIC8vIGJlY2F1c2Ugb25seSB0aGVuIGRvIHdlIGtub3cgdGhl IGZpbmFsIHNpemUgb2YgcGx1Z2lucyBhbmQgaWZyYW1lcy4KICAgICAvLyBGSVhNRTogb25jZSBz ZXQsIHRoaXMgaXMgbmV2ZXIgY2xlYXJlZC4KLSAgICBtdXRhYmxlIGJvb2wgbV9jb21wb3NpdGlu Z0RlcGVuZHNPbkdlb21ldHJ5OworICAgIG11dGFibGUgYm9vbCBtX2NoZWNrSGllcmFyY2h5T25O ZXh0TGF5ZXJVcGRhdGU7CiAKICAgICBib29sIG1fY29tcG9zaXRpbmc7CiAgICAgYm9vbCBtX2Nv bXBvc2l0aW5nTGF5ZXJzTmVlZFJlYnVpbGQ7Cg==