42117 2010-07-12 16:16:33 -0700 AX: Data table heuristics: consider assuming data table for 'zebra-striped' rows 2010-07-14 14:11:53 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 cfleizach cfleizach bdakin oldest_to_newest 250122 0 cfleizach 2010-07-12 16:16:33 -0700 Data table heuristics: consider assuming data table for 'zebra-striped' rows * NOTES We should consider adding a data table heuristic if every other row is an alternating color. 'zebra-striped' rows are a common design pattern. See screen shot that was not triggered as a data table before the ARIA roles were added. 250126 1 61281 cfleizach 2010-07-12 16:18:56 -0700 Created attachment 61281 Patch 251268 2 61281 darin 2010-07-14 10:26:02 -0700 Comment on attachment 61281 Patch > + Vector<Color> alternatingColorCache; Why a variable-size vector here instead of a fixed array? 251273 3 61281 darin 2010-07-14 10:34:23 -0700 Comment on attachment 61281 Patch > + // For the first 5 rows, cache the background color so we can check if this table has zebra-striped rows. > + if (row < 5 && row == (int)alternatingColorCache.size()) { If you have to do type casting, you should do a C++ cast, not C. > + alternatingColorCache.append(rowColor); I'm not sure "cache" is the right name for this data structure. I'd just call it rowColors. Code seems OK, I’ll say r=me 251418 4 cfleizach 2010-07-14 14:11:32 -0700 http://trac.webkit.org/changeset/63353 251419 5 cfleizach 2010-07-14 14:11:53 -0700 looks like the commit-log-editor chose the wrong change log 61281 2010-07-12 16:18:56 -0700 2010-07-14 10:34:23 -0700 Patch bug-42117-20100712161855.patch text/plain 7213 cfleizach SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2MzEzNSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTAtMDctMTIgIENocmlzIEZsZWl6YWNoICA8Y2ZsZWl6YWNoQGFw cGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBBWDogRGF0YSB0YWJsZSBoZXVyaXN0aWNzOiBjb25zaWRlciBhc3N1bWluZyBkYXRhIHRhYmxl IGZvciAnemVicmEtc3RyaXBlZCcgcm93cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NDIxMTcKKworICAgICAgICBUZXN0OiBwbGF0Zm9ybS9tYWMvYWNj ZXNzaWJpbGl0eS90YWJsZS13aXRoLXplYnJhLXJvd3MuaHRtbAorCisgICAgICAgICogYWNjZXNz aWJpbGl0eS9BY2Nlc3NpYmlsaXR5VGFibGUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6QWNjZXNz aWJpbGl0eVRhYmxlOjppc1RhYmxlRXhwb3NhYmxlVGhyb3VnaEFjY2Vzc2liaWxpdHkpOgorCiAy MDEwLTA3LTEyICBFcmljIFNlaWRlbCAgPGVyaWNAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZp ZXdlZCBieSBBZGFtIEJhcnRoLgpJbmRleDogV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2li aWxpdHlUYWJsZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vz c2liaWxpdHlUYWJsZS5jcHAJKHJldmlzaW9uIDYyOTU5KQorKysgV2ViQ29yZS9hY2Nlc3NpYmls aXR5L0FjY2Vzc2liaWxpdHlUYWJsZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEzNyw2ICsxMzcs NyBAQCBib29sIEFjY2Vzc2liaWxpdHlUYWJsZTo6aXNUYWJsZUV4cG9zYWJsCiAgICAgdW5zaWdu ZWQgYm9yZGVyZWRDZWxsQ291bnQgPSAwOwogICAgIHVuc2lnbmVkIGJhY2tncm91bmREaWZmZXJl bmNlQ2VsbENvdW50ID0gMDsKICAgICAKKyAgICBWZWN0b3I8Q29sb3I+IGFsdGVybmF0aW5nQ29s b3JDYWNoZTsKICAgICBpbnQgaGVhZGVyc0luRmlyc3RDb2x1bW5Db3VudCA9IDA7CiAgICAgZm9y IChpbnQgcm93ID0gMDsgcm93IDwgbnVtUm93czsgKytyb3cpIHsKICAgICAKQEAgLTE4OSw2ICsx OTAsMTggQEAgYm9vbCBBY2Nlc3NpYmlsaXR5VGFibGU6OmlzVGFibGVFeHBvc2FibAogICAgICAg ICAgICAgLy8gaWYgd2UndmUgZm91bmQgMTAgImdvb2QiIGNlbGxzLCB3ZSBkb24ndCBuZWVkIHRv IGtlZXAgc2VhcmNoaW5nCiAgICAgICAgICAgICBpZiAoYm9yZGVyZWRDZWxsQ291bnQgPj0gMTAg fHwgYmFja2dyb3VuZERpZmZlcmVuY2VDZWxsQ291bnQgPj0gMTApCiAgICAgICAgICAgICAgICAg cmV0dXJuIHRydWU7CisgICAgICAgICAgICAKKyAgICAgICAgICAgIC8vIEZvciB0aGUgZmlyc3Qg NSByb3dzLCBjYWNoZSB0aGUgYmFja2dyb3VuZCBjb2xvciBzbyB3ZSBjYW4gY2hlY2sgaWYgdGhp cyB0YWJsZSBoYXMgemVicmEtc3RyaXBlZCByb3dzLgorICAgICAgICAgICAgaWYgKHJvdyA8IDUg JiYgcm93ID09IChpbnQpYWx0ZXJuYXRpbmdDb2xvckNhY2hlLnNpemUoKSkgeworICAgICAgICAg ICAgICAgIFJlbmRlck9iamVjdCogcmVuZGVyUm93ID0gY2VsbC0+cGFyZW50KCk7CisgICAgICAg ICAgICAgICAgaWYgKCFyZW5kZXJSb3cgfHwgIXJlbmRlclJvdy0+aXNUYWJsZVJvdygpKQorICAg ICAgICAgICAgICAgICAgICBjb250aW51ZTsKKyAgICAgICAgICAgICAgICBSZW5kZXJTdHlsZSog cm93UmVuZGVyU3R5bGUgPSByZW5kZXJSb3ctPnN0eWxlKCk7CisgICAgICAgICAgICAgICAgaWYg KCFyb3dSZW5kZXJTdHlsZSkKKyAgICAgICAgICAgICAgICAgICAgY29udGludWU7CisgICAgICAg ICAgICAgICAgQ29sb3Igcm93Q29sb3IgPSByb3dSZW5kZXJTdHlsZS0+dmlzaXRlZERlcGVuZGVu dENvbG9yKENTU1Byb3BlcnR5QmFja2dyb3VuZENvbG9yKTsKKyAgICAgICAgICAgICAgICBhbHRl cm5hdGluZ0NvbG9yQ2FjaGUuYXBwZW5kKHJvd0NvbG9yKTsKKyAgICAgICAgICAgIH0KICAgICAg ICAgfQogICAgICAgICAKICAgICAgICAgaWYgKCFyb3cgJiYgaGVhZGVyc0luRmlyc3RSb3dDb3Vu dCA9PSBudW1Db2xzICYmIG51bUNvbHMgPiAxKQpAQCAtMjExLDYgKzIyNCwyMSBAQCBib29sIEFj Y2Vzc2liaWxpdHlUYWJsZTo6aXNUYWJsZUV4cG9zYWJsCiAgICAgaWYgKGJhY2tncm91bmREaWZm ZXJlbmNlQ2VsbENvdW50ID49IG5lZWRlZENlbGxDb3VudCkKICAgICAgICAgcmV0dXJuIHRydWU7 CiAKKyAgICAvLyBDaGVjayBpZiB0aGVyZSBpcyBhbiBhbHRlcm5hdGluZyByb3cgYmFja2dyb3Vu ZCBjb2xvciBpbmRpY2F0aW5nIGEgemVicmEgc3RyaXBlZCBzdHlsZSBwYXR0ZXJuLgorICAgIHVu c2lnbmVkIGNvbG9yQ2FjaGVDb3VudCA9IGFsdGVybmF0aW5nQ29sb3JDYWNoZS5zaXplKCk7Cisg ICAgaWYgKGNvbG9yQ2FjaGVDb3VudCA+IDIpIHsKKyAgICAgICAgQ29sb3IgZmlyc3RDb2xvciA9 IGFsdGVybmF0aW5nQ29sb3JDYWNoZVswXTsKKyAgICAgICAgZm9yICh1bnNpZ25lZCBrID0gMTsg ayA8IGNvbG9yQ2FjaGVDb3VudDsgaysrKSB7CisgICAgICAgICAgICAvLyBJZiBhbiBvZGQgcm93 IHdhcyB0aGUgc2FtZSBjb2xvciBhcyB0aGUgZmlyc3Qgcm93LCBpdHMgbm90IGFsdGVybmF0aW5n LgorICAgICAgICAgICAgaWYgKGsgJSAyID09IDEgJiYgYWx0ZXJuYXRpbmdDb2xvckNhY2hlW2td ID09IGZpcnN0Q29sb3IpCisgICAgICAgICAgICAgICAgcmV0dXJuIGZhbHNlOworICAgICAgICAg ICAgLy8gSWYgYW4gZXZlbiByb3cgaXMgbm90IHRoZSBzYW1lIGFzIHRoZSBmaXJzdCByb3csIGl0 cyBub3QgYWx0ZXJuYXRpbmcuCisgICAgICAgICAgICBpZiAoIShrICUgMikgJiYgYWx0ZXJuYXRp bmdDb2xvckNhY2hlW2tdICE9IGZpcnN0Q29sb3IpCisgICAgICAgICAgICAgICAgcmV0dXJuIGZh bHNlOworICAgICAgICB9CisgICAgICAgIHJldHVybiB0cnVlOworICAgIH0KKyAgICAKICAgICBy ZXR1cm4gZmFsc2U7CiB9CiAgICAgCkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiA2MzEzNSkKKysrIExheW91 dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDEwLTA3 LTEyICBDaHJpcyBGbGVpemFjaCAgPGNmbGVpemFjaEBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQVg6IERhdGEgdGFibGUgaGV1cmlz dGljczogY29uc2lkZXIgYXNzdW1pbmcgZGF0YSB0YWJsZSBmb3IgJ3plYnJhLXN0cmlwZWQnIHJv d3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQyMTE3 CisKKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMvYWNjZXNzaWJpbGl0eS90YWJsZS13aXRoLXplYnJh LXJvd3MtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMvYWNjZXNz aWJpbGl0eS90YWJsZS13aXRoLXplYnJhLXJvd3MuaHRtbDogQWRkZWQuCisKIDIwMTAtMDctMTIg IEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFk YW0gQmFydGguCkluZGV4OiBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvYWNjZXNzaWJpbGl0eS90 YWJsZS13aXRoLXplYnJhLXJvd3MtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRl c3RzL3BsYXRmb3JtL21hYy9hY2Nlc3NpYmlsaXR5L3RhYmxlLXdpdGgtemVicmEtcm93cy1leHBl Y3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvYWNjZXNz aWJpbGl0eS90YWJsZS13aXRoLXplYnJhLXJvd3MtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQpA QCAtMCwwICsxLDE2IEBACisnJHNjcicJc2NyaXB0aW5nIGFkZGl0aW9ucyBmb2xkZXIJUHJvcGVy dHkgb2YgY2xhc3M6IGRvbWFpbglTeXN0ZW0gRXZlbnRzIDogRGlzay1Gb2xkZXItRmlsZSBTdWl0 ZQkxCisnJWRvYycJbXVzaWMgZm9sZGVyCVByb3BlcnR5IG9mIGNsYXNzOiB1c2VyIGRvbWFpbiBv YmplY3QJU3lzdGVtIEV2ZW50cyA6IERpc2stRm9sZGVyLUZpbGUgU3VpdGUJMgorJ8OCwrVkb2Mn CW11c2ljIGZvbGRlcglFbnVtZXJhdGlvbglTdGFuZGFyZCBBZGRpdGlvbnMgOiBGaWxlIENvbW1h bmRzCTMKKyfDhuKAmWhscCcJaGVscAlFbnVtZXJhdGlvbglTdGFuZGFyZCBBZGRpdGlvbnMgOiBG aWxlIENvbW1hbmRzCTQKKyfDhuKAmWhscCcJaGVscCBmb2xkZXIJRW51bWVyYXRpb24JU3RhbmRh cmQgQWRkaXRpb25zIDogRmlsZSBDb21tYW5kcwk1Cisnw4bigJlsaWInCXNoYXJlZCBsaWJyYXJp ZXMJRW51bWVyYXRpb24JU3RhbmRhcmQgQWRkaXRpb25zIDogRmlsZSBDb21tYW5kcwk2CitUaGlz IHRlc3RzIHRoYXQgdGFibGVzIHdpdGggemVicmEgc3RyaXBlZCByb3dzIGFyZSBleHBvc2VkIGFz IEFYVGFibGVzLgorCitPbiBzdWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJpZXMgb2YgIlBBU1Mi IG1lc3NhZ2VzLCBmb2xsb3dlZCBieSAiVEVTVCBDT01QTEVURSIuCisKKworUEFTUyBhY2Nlc3Np YmlsaXR5Q29udHJvbGxlci5mb2N1c2VkRWxlbWVudC5yb2xlIGlzICdBWFJvbGU6IEFYVGFibGUn CitQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCisKK1RFU1QgQ09NUExFVEUKKwpJbmRl eDogTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2FjY2Vzc2liaWxpdHkvdGFibGUtd2l0aC16ZWJy YS1yb3dzLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2FjY2Vz c2liaWxpdHkvdGFibGUtd2l0aC16ZWJyYS1yb3dzLmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlv dXRUZXN0cy9wbGF0Zm9ybS9tYWMvYWNjZXNzaWJpbGl0eS90YWJsZS13aXRoLXplYnJhLXJvd3Mu aHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSw0MCBAQAorPCFET0NUWVBFIEhUTUwgUFVCTElD ICItLy9JRVRGLy9EVEQgSFRNTC8vRU4iPgorPGh0bWw+Cis8aGVhZD4KKzxsaW5rIHJlbD0ic3R5 bGVzaGVldCIgaHJlZj0iLi4vLi4vLi4vZmFzdC9qcy9yZXNvdXJjZXMvanMtdGVzdC1zdHlsZS5j c3MiPgorPHNjcmlwdD4KK3ZhciBzdWNjZXNzZnVsbHlQYXJzZWQgPSBmYWxzZTsKKzwvc2NyaXB0 PgorPHNjcmlwdCBzcmM9Ii4uLy4uLy4uL2Zhc3QvanMvcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpz Ij48L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5IGlkPSJib2R5Ij4KKworPCEtLSBUaGlzIHRhYmxl IHNob3VsZCBhcHBlYXIgYXMgYW4gQVhUYWJsZSBiZWNhdXNlIGl0IGhhcyB6ZWJyYSBzdHJpcGVk IHJvd3MgLS0+Cis8dGFibGUgdGFiaW5kZXg9MCBpZD0idGFibGUxIj4KKzx0ciBiZ2NvbG9yPSIj RTBFMEUwIj48dGQ+PHR0Pickc2NyJzwvdHQ+PC90ZD48dGQ+PHR0PnNjcmlwdGluZyBhZGRpdGlv bnMgZm9sZGVyPC90dD48L3RkPjx0ZD5Qcm9wZXJ0eSBvZiBjbGFzczogZG9tYWluPC90ZD48dGQ+ U3lzdGVtIEV2ZW50cyA6IERpc2stRm9sZGVyLUZpbGUgU3VpdGU8L3RkPjx0ZCBhbGlnbj0icmln aHQiPjE8L3RkPjwvdHI+Cis8dHI+PHRkPjx0dD4nJWRvYyc8L3R0PjwvdGQ+PHRkPjx0dD5tdXNp YyBmb2xkZXI8L3R0PjwvdGQ+PHRkPlByb3BlcnR5IG9mIGNsYXNzOiB1c2VyIGRvbWFpbiBvYmpl Y3Q8L3RkPjx0ZD5TeXN0ZW0gRXZlbnRzIDogRGlzay1Gb2xkZXItRmlsZSBTdWl0ZTwvdGQ+PHRk IGFsaWduPSJyaWdodCI+MjwvdGQ+PC90cj4KKzx0ciBiZ2NvbG9yPSIjRTBFMEUwIj48dGQ+PHR0 PifCtWRvYyc8L3R0PjwvdGQ+PHRkPjx0dD5tdXNpYyBmb2xkZXI8L3R0PjwvdGQ+PHRkPkVudW1l cmF0aW9uPC90ZD48dGQ+U3RhbmRhcmQgQWRkaXRpb25zIDogRmlsZSBDb21tYW5kczwvdGQ+PHRk IGFsaWduPSJyaWdodCI+MzwvdGQ+PC90cj4KKzx0cj48dGQ+PHR0PifGkmhscCc8L3R0PjwvdGQ+ PHRkPjx0dD5oZWxwPC90dD48L3RkPjx0ZD5FbnVtZXJhdGlvbjwvdGQ+PHRkPlN0YW5kYXJkIEFk ZGl0aW9ucyA6IEZpbGUgQ29tbWFuZHM8L3RkPjx0ZCBhbGlnbj0icmlnaHQiPjQ8L3RkPjwvdHI+ Cis8dHIgYmdjb2xvcj0iI0UwRTBFMCI+PHRkPjx0dD4nxpJobHAnPC90dD48L3RkPjx0ZD48dHQ+ aGVscCBmb2xkZXI8L3R0PjwvdGQ+PHRkPkVudW1lcmF0aW9uPC90ZD48dGQ+U3RhbmRhcmQgQWRk aXRpb25zIDogRmlsZSBDb21tYW5kczwvdGQ+PHRkIGFsaWduPSJyaWdodCI+NTwvdGQ+PC90cj4K Kzx0cj48dGQ+PHR0PifGkmxpYic8L3R0PjwvdGQ+PHRkPjx0dD5zaGFyZWQgbGlicmFyaWVzPC90 dD48L3RkPjx0ZD5FbnVtZXJhdGlvbjwvdGQ+PHRkPlN0YW5kYXJkIEFkZGl0aW9ucyA6IEZpbGUg Q29tbWFuZHM8L3RkPjx0ZCBhbGlnbj0icmlnaHQiPjY8L3RkPjwvdHI+Cis8L3RhYmxlPgorCis8 cCBpZD0iZGVzY3JpcHRpb24iPjwvcD4KKzxkaXYgaWQ9ImNvbnNvbGUiPjwvZGl2PgorCis8c2Ny aXB0PgorCisgICAgZGVzY3JpcHRpb24oIlRoaXMgdGVzdHMgdGhhdCB0YWJsZXMgd2l0aCB6ZWJy YSBzdHJpcGVkIHJvd3MgYXJlIGV4cG9zZWQgYXMgQVhUYWJsZXMuIik7CisKKyAgICBpZiAod2lu ZG93LmFjY2Vzc2liaWxpdHlDb250cm9sbGVyKSB7CisKKyAgICAgICAgICBkb2N1bWVudC5nZXRF bGVtZW50QnlJZCgidGFibGUxIikuZm9jdXMoKTsKKyAgICAgICAgICBzaG91bGRCZSgiYWNjZXNz aWJpbGl0eUNvbnRyb2xsZXIuZm9jdXNlZEVsZW1lbnQucm9sZSIsICInQVhSb2xlOiBBWFRhYmxl JyIpOworICAgIH0KKworICAgIHN1Y2Nlc3NmdWxseVBhcnNlZCA9IHRydWU7Cis8L3NjcmlwdD4K KworPHNjcmlwdCBzcmM9Ii4uLy4uLy4uL2Zhc3QvanMvcmVzb3VyY2VzL2pzLXRlc3QtcG9zdC5q cyI+PC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+Cg==