42113 2010-07-12 14:42:30 -0700 Chromium: not sending key down events to plugins 2010-07-12 22:30:46 -0700 1 1 1 Unclassified WebKit Plug-ins 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 viettrungluu webkit-unassigned abarth commit-queue fishd jam viettrungluu oldest_to_newest 250064 0 viettrungluu 2010-07-12 14:42:30 -0700 Chromium isn't sending key down events to plugins. This was broken by r62743. 250078 1 61273 viettrungluu 2010-07-12 14:56:35 -0700 Created attachment 61273 proposed patch 250092 2 61273 abarth 2010-07-12 15:16:23 -0700 Comment on attachment 61273 proposed patch Clear Main Comment Box:8 + * ../../../../src/WebPluginContainerImpl.cpp: This path is wrong. 250108 3 61278 viettrungluu 2010-07-12 15:52:14 -0700 Created attachment 61278 (hopefully) fixed patch The previous patch also had broken paths. Hopefully this one is okay. 250109 4 jam 2010-07-12 15:53:14 -0700 whoa, sorry about that. 250110 5 61279 viettrungluu 2010-07-12 15:53:24 -0700 Created attachment 61279 patch again Remembering to click the "patch" checkbox. 250311 6 61279 commit-queue 2010-07-12 22:30:41 -0700 Comment on attachment 61279 patch again Clearing flags on attachment: 61279 Committed r63170: <http://trac.webkit.org/changeset/63170> 250312 7 commit-queue 2010-07-12 22:30:46 -0700 All reviewed patches have been landed. Closing bug. 61273 2010-07-12 14:56:35 -0700 2010-07-12 15:52:14 -0700 proposed patch wk-42113 text/plain 1311 viettrungluu SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDYzMTIz KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTAtMDct MTIgIFZpZXQtVHJ1bmcgTHV1ICA8dmlldHRydW5nbHV1QGNocm9taXVtLm9yZz4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbQ2hyb21pdW1dIFBhc3Mg a2V5IGRvd25zIG9uIHRvIHBsdWdpbnMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD00MjExMworCisgICAgICAgICogLi4vLi4vLi4vLi4vc3JjL1dlYlBs dWdpbkNvbnRhaW5lckltcGwuY3BwOgorCiAyMDEwLTA3LTEyICBBbGV4YW5kZXIgUGF2bG92ICA8 YXBhdmxvdkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgWXVyeSBTZW1pa2hh dHNreS4KSW5kZXg6IHNyYy9XZWJQbHVnaW5Db250YWluZXJJbXBsLmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBzcmMvV2ViUGx1Z2luQ29udGFpbmVySW1wbC5jcHAJKHJldmlzaW9uIDYyODQ0KQorKysgc3Jj L1dlYlBsdWdpbkNvbnRhaW5lckltcGwuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00NTgsMTIgKzQ1 OCwxMyBAQCB2b2lkIFdlYlBsdWdpbkNvbnRhaW5lckltcGw6OmhhbmRsZUtleWJvCiAgICAgICAg ICAgICAmJiB3ZWJFdmVudC53aW5kb3dzS2V5Q29kZSA9PSBWS0VZX0MpIHsKICAgICAgICAgICAg IGNvcHkoKTsKICAgICAgICAgICAgIGV2ZW50LT5zZXREZWZhdWx0SGFuZGxlZCgpOworICAgICAg ICAgICAgcmV0dXJuOwogICAgICAgICB9Ci0gICAgfSBlbHNlIHsKLSAgICAgICAgV2ViQ3Vyc29y SW5mbyBjdXJzb3JJbmZvOwotICAgICAgICBpZiAobV93ZWJQbHVnaW4tPmhhbmRsZUlucHV0RXZl bnQod2ViRXZlbnQsIGN1cnNvckluZm8pKQotICAgICAgICAgICAgZXZlbnQtPnNldERlZmF1bHRI YW5kbGVkKCk7CiAgICAgfQorCisgICAgV2ViQ3Vyc29ySW5mbyBjdXJzb3JJbmZvOworICAgIGlm IChtX3dlYlBsdWdpbi0+aGFuZGxlSW5wdXRFdmVudCh3ZWJFdmVudCwgY3Vyc29ySW5mbykpCisg ICAgICAgIGV2ZW50LT5zZXREZWZhdWx0SGFuZGxlZCgpOwogfQogCiB2b2lkIFdlYlBsdWdpbkNv bnRhaW5lckltcGw6OmNhbGN1bGF0ZUdlb21ldHJ5KGNvbnN0IEludFJlY3QmIGZyYW1lUmVjdCwK 61278 2010-07-12 15:52:14 -0700 2010-07-12 15:53:24 -0700 (hopefully) fixed patch wk-42113-2 application/octet-stream 1448 viettrungluu ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IGRkNjhjYTguLjJmYjdlNWEgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpAQCAtMSwzICsx LDEzIEBACisyMDEwLTA3LTEyICBWaWV0LVRydW5nIEx1dSAgPHZpZXR0cnVuZ2x1dUBjaHJvbWl1 bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg W0Nocm9taXVtXSBQYXNzIGtleSBkb3duIGV2ZW50cyBvbiB0byBwbHVnaW5zLgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDIxMTMKKworICAgICAgICAq IHNyYy9XZWJQbHVnaW5Db250YWluZXJJbXBsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViUGx1 Z2luQ29udGFpbmVySW1wbDo6aGFuZGxlS2V5Ym9hcmRFdmVudCk6CisKIDIwMTAtMDctMDggIFZp dGFseSBSZXBlc2hrbyAgPHZpdGFseXJAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2Vk IGJ5IFBhdmVsIEZlbGRtYW4uCmRpZmYgLS1naXQgYS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlBs dWdpbkNvbnRhaW5lckltcGwuY3BwIGIvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJQbHVnaW5Db250 YWluZXJJbXBsLmNwcAppbmRleCAzNjc5NmE2Li5lMjRlMzcyIDEwMDY0NAotLS0gYS9XZWJLaXQv Y2hyb21pdW0vc3JjL1dlYlBsdWdpbkNvbnRhaW5lckltcGwuY3BwCisrKyBiL1dlYktpdC9jaHJv bWl1bS9zcmMvV2ViUGx1Z2luQ29udGFpbmVySW1wbC5jcHAKQEAgLTQ1OCwxMiArNDU4LDEzIEBA IHZvaWQgV2ViUGx1Z2luQ29udGFpbmVySW1wbDo6aGFuZGxlS2V5Ym9hcmRFdmVudChLZXlib2Fy ZEV2ZW50KiBldmVudCkKICAgICAgICAgICAgICYmIHdlYkV2ZW50LndpbmRvd3NLZXlDb2RlID09 IFZLRVlfQykgewogICAgICAgICAgICAgY29weSgpOwogICAgICAgICAgICAgZXZlbnQtPnNldERl ZmF1bHRIYW5kbGVkKCk7CisgICAgICAgICAgICByZXR1cm47CiAgICAgICAgIH0KLSAgICB9IGVs c2UgewotICAgICAgICBXZWJDdXJzb3JJbmZvIGN1cnNvckluZm87Ci0gICAgICAgIGlmIChtX3dl YlBsdWdpbi0+aGFuZGxlSW5wdXRFdmVudCh3ZWJFdmVudCwgY3Vyc29ySW5mbykpCi0gICAgICAg ICAgICBldmVudC0+c2V0RGVmYXVsdEhhbmRsZWQoKTsKICAgICB9CisKKyAgICBXZWJDdXJzb3JJ bmZvIGN1cnNvckluZm87CisgICAgaWYgKG1fd2ViUGx1Z2luLT5oYW5kbGVJbnB1dEV2ZW50KHdl YkV2ZW50LCBjdXJzb3JJbmZvKSkKKyAgICAgICAgZXZlbnQtPnNldERlZmF1bHRIYW5kbGVkKCk7 CiB9CiAKIHZvaWQgV2ViUGx1Z2luQ29udGFpbmVySW1wbDo6Y2FsY3VsYXRlR2VvbWV0cnkoY29u c3QgSW50UmVjdCYgZnJhbWVSZWN0LAo= 61279 2010-07-12 15:53:24 -0700 2010-07-12 22:30:41 -0700 patch again wk-42113-2 text/plain 1448 viettrungluu ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IGRkNjhjYTguLjJmYjdlNWEgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpAQCAtMSwzICsx LDEzIEBACisyMDEwLTA3LTEyICBWaWV0LVRydW5nIEx1dSAgPHZpZXR0cnVuZ2x1dUBjaHJvbWl1 bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg W0Nocm9taXVtXSBQYXNzIGtleSBkb3duIGV2ZW50cyBvbiB0byBwbHVnaW5zLgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDIxMTMKKworICAgICAgICAq IHNyYy9XZWJQbHVnaW5Db250YWluZXJJbXBsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViUGx1 Z2luQ29udGFpbmVySW1wbDo6aGFuZGxlS2V5Ym9hcmRFdmVudCk6CisKIDIwMTAtMDctMDggIFZp dGFseSBSZXBlc2hrbyAgPHZpdGFseXJAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2Vk IGJ5IFBhdmVsIEZlbGRtYW4uCmRpZmYgLS1naXQgYS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlBs dWdpbkNvbnRhaW5lckltcGwuY3BwIGIvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJQbHVnaW5Db250 YWluZXJJbXBsLmNwcAppbmRleCAzNjc5NmE2Li5lMjRlMzcyIDEwMDY0NAotLS0gYS9XZWJLaXQv Y2hyb21pdW0vc3JjL1dlYlBsdWdpbkNvbnRhaW5lckltcGwuY3BwCisrKyBiL1dlYktpdC9jaHJv bWl1bS9zcmMvV2ViUGx1Z2luQ29udGFpbmVySW1wbC5jcHAKQEAgLTQ1OCwxMiArNDU4LDEzIEBA IHZvaWQgV2ViUGx1Z2luQ29udGFpbmVySW1wbDo6aGFuZGxlS2V5Ym9hcmRFdmVudChLZXlib2Fy ZEV2ZW50KiBldmVudCkKICAgICAgICAgICAgICYmIHdlYkV2ZW50LndpbmRvd3NLZXlDb2RlID09 IFZLRVlfQykgewogICAgICAgICAgICAgY29weSgpOwogICAgICAgICAgICAgZXZlbnQtPnNldERl ZmF1bHRIYW5kbGVkKCk7CisgICAgICAgICAgICByZXR1cm47CiAgICAgICAgIH0KLSAgICB9IGVs c2UgewotICAgICAgICBXZWJDdXJzb3JJbmZvIGN1cnNvckluZm87Ci0gICAgICAgIGlmIChtX3dl YlBsdWdpbi0+aGFuZGxlSW5wdXRFdmVudCh3ZWJFdmVudCwgY3Vyc29ySW5mbykpCi0gICAgICAg ICAgICBldmVudC0+c2V0RGVmYXVsdEhhbmRsZWQoKTsKICAgICB9CisKKyAgICBXZWJDdXJzb3JJ bmZvIGN1cnNvckluZm87CisgICAgaWYgKG1fd2ViUGx1Z2luLT5oYW5kbGVJbnB1dEV2ZW50KHdl YkV2ZW50LCBjdXJzb3JJbmZvKSkKKyAgICAgICAgZXZlbnQtPnNldERlZmF1bHRIYW5kbGVkKCk7 CiB9CiAKIHZvaWQgV2ViUGx1Z2luQ29udGFpbmVySW1wbDo6Y2FsY3VsYXRlR2VvbWV0cnkoY29u c3QgSW50UmVjdCYgZnJhbWVSZWN0LAo=