42111 2010-07-12 14:11:57 -0700 [Chromium] "justify" alignment is not honored for complext script rendering in Linux 2010-07-27 15:34:06 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Other Linux RESOLVED DUPLICATE 39014 P2 Normal --- 1 xji xji agl evan jshin webkit.review.bot oldest_to_newest 250039 0 xji 2010-07-12 14:11:57 -0700 Open the attached html page in chrome. Observe the text alignment. The css style in the html page is "text-align:justify". So, the text should be justified. Instead, the spaces is not evenly distributed and the text is not justified. In Chromium bug: http://code.google.com/p/chromium/issues/detail?id=48873 250040 1 61268 xji 2010-07-12 14:12:28 -0700 Created attachment 61268 test case 250145 2 61292 xji 2010-07-12 16:43:55 -0700 Created attachment 61292 patch Claire Ho who works on Android proposed this patch. Since the complex script handling of Andriod is pretty much similar to that in Chromium Linux, the patch should apply to Chromium Linux as well. On Claire's behalf, I am loading this patch for review. I did not add new test, after the patch, pixel test result of one existing test will change in Linux, and it needs rebaseline from canary. 250146 3 webkit.review.bot 2010-07-12 16:45:51 -0700 Attachment 61292 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebCore/platform/graphics/chromium/FontLinux.cpp:514: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] WebCore/platform/graphics/chromium/FontLinux.cpp:537: One space before end of line comments [whitespace/comments] [5] WebCore/platform/graphics/chromium/FontLinux.cpp:538: One space before end of line comments [whitespace/comments] [5] WebCore/platform/graphics/chromium/FontLinux.cpp:539: One space before end of line comments [whitespace/comments] [5] Total errors found: 4 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 250148 4 61293 xji 2010-07-12 16:49:04 -0700 Created attachment 61293 patch Claire Ho who works on Android proposed this patch. Since the complex script handling of Andriod is pretty much similar to that in Chromium Linux, the patch should apply to Chromium Linux as well. On Claire's behalf, I am loading this patch for review. I did not add new test, after the patch, pixel test result of one existing test will change in Linux, and it needs rebaseline from canary. 250156 5 61293 agl 2010-07-12 16:57:54 -0700 Comment on attachment 61293 patch Please patch in the patch from https://bugs.webkit.org/show_bug.cgi?id=39014 and see if that fixes the issue. 256896 6 xji 2010-07-27 15:34:06 -0700 *** This bug has been marked as a duplicate of bug 39014 *** 61268 2010-07-12 14:12:28 -0700 2010-07-12 14:12:28 -0700 test case space_in_justify_alignment.html text/html 385 xji PCFET0NUWVBFIGh0bWw+CjxodG1sPgo8aGVhZD4KPG1ldGEgaHR0cC1lcXVpdj0iQ29udGVudC1U eXBlIiBjb250ZW50PSJ0ZXh0L2h0bWw7IGNoYXJzZXQ9VVRGLTgiPgo8L2hlYWQ+Cjxib2R5ID4K PHAgc3R5bGU9IndpZHRoOiAzMDBweDsgdGV4dC1hbGlnbjoganVzdGlmeTsgZGlyZWN0aW9uOiBy dGw7IGZvbnQtc2l6ZTogNDBweDsgZm9udC1mYW1pbHk6IE5vbkFudGlBbGlhc2VkU2FucyI+CgkJ PHNwYW4+16fWsNeY1rTXmdei1rjXlCBb16nXnCDXkNeV16og15DXlSAKCQnXlNeR16jXlCDXkNeX 16og15DXlSDXmdeV16rXqCwg15vXkteV158g16fWsNeY1rTXmdei1rjXlCDXqta815XWudeb1rTX mdeqIChzeW5jb3BlKV08L3NwYW4+CjwvcD4KPC9ib2R5Pgo8L2h0bWw+Cg== 61292 2010-07-12 16:43:55 -0700 2010-07-12 16:48:10 -0700 patch 42111.v1 text/plain 4403 xji SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2MzEzNykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTAtMDctMTIgIFhpYW9tZWkgSmkgIDx4amlAY2hyb21pdW0ub3Jn PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENvbXBs ZXggc2NyaXB0IHNob3VsZCBiZSBqdXN0aWZpZWQgaW4gcmVuZGVyaW5nIHdoZW4gdGhlIGFsaWdu bWVudAorICAgICAgICBpcyAianVzdGlmeSIuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD00MjExMQorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mv Y2hyb21pdW0vRm9udExpbnV4LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlRleHRSdW5XYWxrZXI6 OlRleHRSdW5XYWxrZXIpOgorICAgICAgICAoV2ViQ29yZTo6VGV4dFJ1bldhbGtlcjo6c2V0R2x5 cGhYUG9zaXRpb25zKToKKyAgICAgICAgKFdlYkNvcmU6OlRleHRSdW5XYWxrZXI6OnNldHVwUGFk ZGluZ0FuZFNwYWNlR2x5cGgpOgorCiAyMDEwLTA3LTEyICBFcmljIFNlaWRlbCAgPGVyaWNAd2Vi a2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBBZGFtIEJhcnRoLgpJbmRleDogV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9Gb250TGludXguY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vRm9udExpbnV4LmNwcAkocmV2aXNp b24gNjMxMTYpCisrKyBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0ZvbnRMaW51 eC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE5NSw2ICsxOTUsNyBAQCBwdWJsaWM6CiAgICAgICAg ICAgICBtX2l0ZW0uc3RyaW5nID0gc3RyaW5nOwogICAgICAgICB9CiAKKyAgICAgICAgc2V0dXBQ YWRkaW5nQW5kU3BhY2VHbHlwaCgpOwogICAgICAgICByZXNldCgpOwogICAgIH0KIApAQCAtNDYy LDYgKzQ2MywyMCBAQCBwcml2YXRlOgogICAgICAgICAgICAgbV94UG9zaXRpb25zW2ldID0gbV9v ZmZzZXRYICsgcG9zaXRpb24gKyBvZmZzZXRYOwogCiAgICAgICAgICAgICBkb3VibGUgYWR2YW5j ZSA9IHRydW5jYXRlRml4ZWRQb2ludFRvSW50ZWdlcihtX2l0ZW0uYWR2YW5jZXNbaV0pOworICAg ICAgICAgICAgLy8gQWNjb3VudCBmb3IgcGFkZGluZy4gV2ViQ29yZSB1c2VzIHNwYWNlIHBhZGRp bmcgdG8ganVzdGlmeQorICAgICAgICAgICAgLy8gdGV4dC4gV2UgZGlzdHJpYnV0ZSB0aGUgc3Bl Y2lmaWVkIHBhZGRpbmcgb3ZlciB0aGUgYXZhaWxhYmxlCisgICAgICAgICAgICAvLyBzcGFjZXMg aW4gdGhlIHJ1bi4KKyAgICAgICAgICAgIGlmIChtX3BhZGRpbmcgJiYgbV9nbHlwaHMxNltpXSA9 PSBtX3NwYWNlR2x5cGgpIHsKKyAgICAgICAgICAgICAgICAvLyBVc2UgbGVmdG92ZXIgcGFkZGlu ZyBpZiBub3QgZXZlbmx5IGRpdmlzaWJsZSBieSBudW1iZXIKKyAgICAgICAgICAgICAgICAvLyBv ZiBzcGFjZXMuCisgICAgICAgICAgICAgICAgaWYgKG1fcGFkZGluZyA8IG1fcGFkUGVyU3BhY2Up IHsKKyAgICAgICAgICAgICAgICAgICAgYWR2YW5jZSArPSBtX3BhZGRpbmc7CisgICAgICAgICAg ICAgICAgICAgIG1fcGFkZGluZyA9IDA7CisgICAgICAgICAgICAgICAgfSBlbHNlIHsKKyAgICAg ICAgICAgICAgICAgICAgYWR2YW5jZSArPSBtX3BhZFBlclNwYWNlOworICAgICAgICAgICAgICAg ICAgICBtX3BhZGRpbmcgLT0gbV9wYWRQZXJTcGFjZTsKKyAgICAgICAgICAgICAgICB9CisgICAg ICAgICAgICB9CiAgICAgICAgICAgICBwb3NpdGlvbiArPSBhZHZhbmNlOwogICAgICAgICB9CiAg ICAgICAgIG1fcGl4ZWxXaWR0aCA9IHBvc2l0aW9uOwpAQCAtNDg0LDYgKzQ5OSwyNyBAQCBwcml2 YXRlOgogICAgICAgICB9CiAgICAgfQogCisgICAgdm9pZCBzZXR1cFBhZGRpbmdBbmRTcGFjZUds eXBoKCkKKyAgICB7CisgICAgICAgIG1fcGFkZGluZyA9IG1fcnVuLnBhZGRpbmcoKTsKKyAgICAg ICAgaWYgKCFtX3BhZGRpbmcpCisgICAgICAgICAgICBtX3BhZFBlclNwYWNlID0gMDsKKyAgICAg ICAgZWxzZSB7CisgICAgICAgICAgICB1bnNpZ25lZCBudW1TcGFjZXMgPSAwOworICAgICAgICAg ICAgLy8gR2V0IG51bWJlciBvZiBzcGFjZXMuCisgICAgICAgICAgICBmb3IgKGludCBzID0gMDsg cyA8IG1fcnVuLmxlbmd0aCgpOyBzKyspCisgICAgICAgICAgICAgICAgaWYgKEZvbnQ6OnRyZWF0 QXNTcGFjZShtX3J1bltzXSkpCisgICAgICAgICAgICAgICAgICAgIG51bVNwYWNlcysrOworCisg ICAgICAgICAgICBpZiAobnVtU3BhY2VzID09IDApCisgICAgICAgICAgICAgICAgbV9wYWRQZXJT cGFjZSA9IDA7CisgICAgICAgICAgICBlbHNlCisgICAgICAgICAgICAgICAgbV9wYWRQZXJTcGFj ZSA9IHN0YXRpY19jYXN0PGRvdWJsZT4obV9wYWRkaW5nIC8gbnVtU3BhY2VzKTsKKyAgICAgICAg fQorICAgICAgICBtX3NwYWNlR2x5cGggPSBtX2ZvbnQtPmdseXBoRGF0YUZvckNoYXJhY3Rlcign ICcsIGZhbHNlLCBmYWxzZSkuZ2x5cGg7CisgICAgfQorCisKICAgICBjb25zdCBGb250KiBjb25z dCBtX2ZvbnQ7CiAgICAgSEJfU2hhcGVySXRlbSBtX2l0ZW07CiAgICAgdWludDE2X3QqIG1fZ2x5 cGhzMTY7IC8vIEEgdmVjdG9yIG9mIDE2LWJpdCBnbHlwaCBpZHMuCkBAIC00OTgsNiArNTM0LDkg QEAgcHJpdmF0ZToKICAgICBPd25BcnJheVB0cjxVQ2hhcj4gbV9ub3JtYWxpemVkQnVmZmVyOyAv LyBBIGJ1ZmZlciBmb3Igbm9ybWFsaXplZCBydW4uCiAgICAgY29uc3QgVGV4dFJ1biYgbV9ydW47 CiAgICAgYm9vbCBtX2l0ZXJhdGVCYWNrd2FyZHM7CisgICAgdW5zaWduZWQgbV9wYWRkaW5nOyAg Ly8gVG90YWwgcGFkZGluZy4KKyAgICBkb3VibGUgbV9wYWRQZXJTcGFjZTsgIC8vIE51bWJlciBv ZiBwYWRkaW5nIHBlciBzcGFjZS4KKyAgICB1aW50MTZfdCBtX3NwYWNlR2x5cGg7ICAvLyBTcGFj ZSBnbHlwaCBvZiBtX2ZvbnQuCiB9OwogCiBzdGF0aWMgdm9pZCBzZXR1cEZvclRleHRQYWludGlu ZyhTa1BhaW50KiBwYWludCwgU2tDb2xvciBjb2xvcikKSW5kZXg6IExheW91dFRlc3RzL0NoYW5n ZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDYzMTM3 KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTAtMDctMTIgIFhpYW9tZWkgSmkgIDx4amlAY2hyb21pdW0ub3JnPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENvbXBsZXggc2NyaXB0IHNo b3VsZCBiZSBqdXN0aWZpZWQgaW4gcmVuZGVyaW5nIHdoZW4gdGhlIGFsaWdubWVudAorICAgICAg ICBpcyAianVzdGlmeSIuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD00MjExMQorCisgICAgICAgICogcGxhdGZvcm0vY2hyb21pdW0vdGVzdF9leHBlY3Rh dGlvbnMudHh0OgorCiAyMDEwLTA3LTEyICBFcmljIFNlaWRlbCAgPGVyaWNAd2Via2l0Lm9yZz4K IAogICAgICAgICBSZXZpZXdlZCBieSBBZGFtIEJhcnRoLgpJbmRleDogTGF5b3V0VGVzdHMvcGxh dGZvcm0vY2hyb21pdW0vdGVzdF9leHBlY3RhdGlvbnMudHh0Cj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91 dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL3Rlc3RfZXhwZWN0YXRpb25zLnR4dAkocmV2aXNpb24g NjMxMTYpCisrKyBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS90ZXN0X2V4cGVjdGF0aW9u cy50eHQJKHdvcmtpbmcgY29weSkKQEAgLTMwOTcsMyArMzA5Nyw2IEBAIEJVR19XSzM4MDE2IFdJ TiBMSU5VWCA6IGZhc3QvYmxvY2svcG9zaXQKIEJVR19XSzM4MDE2IFdJTiA6IGZhc3QvZm9ybXMv aW5wdXQtZmlyc3QtbGV0dGVyLmh0bWwgPSBJTUFHRStURVhUCiAKIEJVRzQ4ODU5IFdJTiA6IGZh c3QvaW5saW5lL2NvbnRpbnVhdGlvbi1vdXRsaW5lcy13aXRoLWxheWVycy0yLmh0bWwgPSBJTUFH RStURVhUCisKKy8vIHBpeGVsIHRlc3QgZXhwZWN0ZWQgdG8gZmFpbCBhZnRlciBmaXggb2YgYnVn IDQyMTExCitCVUc0MjExMSBMSU5VWCA6IGZhc3QvdGV4dC9hdHN1aS1zcGFjaW5nLWZlYXR1cmVz Lmh0bWwgPSBJTUFHRQo= 61293 2010-07-12 16:49:04 -0700 2010-07-12 16:57:54 -0700 patch 42111.v1 text/plain 4396 xji SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2MzEzNykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTAtMDctMTIgIFhpYW9tZWkgSmkgIDx4amlAY2hyb21pdW0ub3Jn PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENvbXBs ZXggc2NyaXB0IHNob3VsZCBiZSBqdXN0aWZpZWQgaW4gcmVuZGVyaW5nIHdoZW4gdGhlIGFsaWdu bWVudAorICAgICAgICBpcyAianVzdGlmeSIuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD00MjExMQorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mv Y2hyb21pdW0vRm9udExpbnV4LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlRleHRSdW5XYWxrZXI6 OlRleHRSdW5XYWxrZXIpOgorICAgICAgICAoV2ViQ29yZTo6VGV4dFJ1bldhbGtlcjo6c2V0R2x5 cGhYUG9zaXRpb25zKToKKyAgICAgICAgKFdlYkNvcmU6OlRleHRSdW5XYWxrZXI6OnNldHVwUGFk ZGluZ0FuZFNwYWNlR2x5cGgpOgorCiAyMDEwLTA3LTEyICBFcmljIFNlaWRlbCAgPGVyaWNAd2Vi a2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBBZGFtIEJhcnRoLgpJbmRleDogV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9Gb250TGludXguY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vRm9udExpbnV4LmNwcAkocmV2aXNp b24gNjMxMTYpCisrKyBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0ZvbnRMaW51 eC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE5NSw2ICsxOTUsNyBAQCBwdWJsaWM6CiAgICAgICAg ICAgICBtX2l0ZW0uc3RyaW5nID0gc3RyaW5nOwogICAgICAgICB9CiAKKyAgICAgICAgc2V0dXBQ YWRkaW5nQW5kU3BhY2VHbHlwaCgpOwogICAgICAgICByZXNldCgpOwogICAgIH0KIApAQCAtNDYy LDYgKzQ2MywyMCBAQCBwcml2YXRlOgogICAgICAgICAgICAgbV94UG9zaXRpb25zW2ldID0gbV9v ZmZzZXRYICsgcG9zaXRpb24gKyBvZmZzZXRYOwogCiAgICAgICAgICAgICBkb3VibGUgYWR2YW5j ZSA9IHRydW5jYXRlRml4ZWRQb2ludFRvSW50ZWdlcihtX2l0ZW0uYWR2YW5jZXNbaV0pOworICAg ICAgICAgICAgLy8gQWNjb3VudCBmb3IgcGFkZGluZy4gV2ViQ29yZSB1c2VzIHNwYWNlIHBhZGRp bmcgdG8ganVzdGlmeQorICAgICAgICAgICAgLy8gdGV4dC4gV2UgZGlzdHJpYnV0ZSB0aGUgc3Bl Y2lmaWVkIHBhZGRpbmcgb3ZlciB0aGUgYXZhaWxhYmxlCisgICAgICAgICAgICAvLyBzcGFjZXMg aW4gdGhlIHJ1bi4KKyAgICAgICAgICAgIGlmIChtX3BhZGRpbmcgJiYgbV9nbHlwaHMxNltpXSA9 PSBtX3NwYWNlR2x5cGgpIHsKKyAgICAgICAgICAgICAgICAvLyBVc2UgbGVmdG92ZXIgcGFkZGlu ZyBpZiBub3QgZXZlbmx5IGRpdmlzaWJsZSBieSBudW1iZXIKKyAgICAgICAgICAgICAgICAvLyBv ZiBzcGFjZXMuCisgICAgICAgICAgICAgICAgaWYgKG1fcGFkZGluZyA8IG1fcGFkUGVyU3BhY2Up IHsKKyAgICAgICAgICAgICAgICAgICAgYWR2YW5jZSArPSBtX3BhZGRpbmc7CisgICAgICAgICAg ICAgICAgICAgIG1fcGFkZGluZyA9IDA7CisgICAgICAgICAgICAgICAgfSBlbHNlIHsKKyAgICAg ICAgICAgICAgICAgICAgYWR2YW5jZSArPSBtX3BhZFBlclNwYWNlOworICAgICAgICAgICAgICAg ICAgICBtX3BhZGRpbmcgLT0gbV9wYWRQZXJTcGFjZTsKKyAgICAgICAgICAgICAgICB9CisgICAg ICAgICAgICB9CiAgICAgICAgICAgICBwb3NpdGlvbiArPSBhZHZhbmNlOwogICAgICAgICB9CiAg ICAgICAgIG1fcGl4ZWxXaWR0aCA9IHBvc2l0aW9uOwpAQCAtNDg0LDYgKzQ5OSwyNyBAQCBwcml2 YXRlOgogICAgICAgICB9CiAgICAgfQogCisgICAgdm9pZCBzZXR1cFBhZGRpbmdBbmRTcGFjZUds eXBoKCkKKyAgICB7CisgICAgICAgIG1fcGFkZGluZyA9IG1fcnVuLnBhZGRpbmcoKTsKKyAgICAg ICAgaWYgKCFtX3BhZGRpbmcpCisgICAgICAgICAgICBtX3BhZFBlclNwYWNlID0gMDsKKyAgICAg ICAgZWxzZSB7CisgICAgICAgICAgICB1bnNpZ25lZCBudW1TcGFjZXMgPSAwOworICAgICAgICAg ICAgLy8gR2V0IG51bWJlciBvZiBzcGFjZXMuCisgICAgICAgICAgICBmb3IgKGludCBzID0gMDsg cyA8IG1fcnVuLmxlbmd0aCgpOyBzKyspCisgICAgICAgICAgICAgICAgaWYgKEZvbnQ6OnRyZWF0 QXNTcGFjZShtX3J1bltzXSkpCisgICAgICAgICAgICAgICAgICAgIG51bVNwYWNlcysrOworCisg ICAgICAgICAgICBpZiAoIW51bVNwYWNlcykKKyAgICAgICAgICAgICAgICBtX3BhZFBlclNwYWNl ID0gMDsKKyAgICAgICAgICAgIGVsc2UKKyAgICAgICAgICAgICAgICBtX3BhZFBlclNwYWNlID0g c3RhdGljX2Nhc3Q8ZG91YmxlPihtX3BhZGRpbmcgLyBudW1TcGFjZXMpOworICAgICAgICB9Cisg ICAgICAgIG1fc3BhY2VHbHlwaCA9IG1fZm9udC0+Z2x5cGhEYXRhRm9yQ2hhcmFjdGVyKCcgJywg ZmFsc2UsIGZhbHNlKS5nbHlwaDsKKyAgICB9CisKKwogICAgIGNvbnN0IEZvbnQqIGNvbnN0IG1f Zm9udDsKICAgICBIQl9TaGFwZXJJdGVtIG1faXRlbTsKICAgICB1aW50MTZfdCogbV9nbHlwaHMx NjsgLy8gQSB2ZWN0b3Igb2YgMTYtYml0IGdseXBoIGlkcy4KQEAgLTQ5OCw2ICs1MzQsOSBAQCBw cml2YXRlOgogICAgIE93bkFycmF5UHRyPFVDaGFyPiBtX25vcm1hbGl6ZWRCdWZmZXI7IC8vIEEg YnVmZmVyIGZvciBub3JtYWxpemVkIHJ1bi4KICAgICBjb25zdCBUZXh0UnVuJiBtX3J1bjsKICAg ICBib29sIG1faXRlcmF0ZUJhY2t3YXJkczsKKyAgICB1bnNpZ25lZCBtX3BhZGRpbmc7IC8vIFRv dGFsIHBhZGRpbmcuCisgICAgZG91YmxlIG1fcGFkUGVyU3BhY2U7IC8vIE51bWJlciBvZiBwYWRk aW5nIHBlciBzcGFjZS4KKyAgICB1aW50MTZfdCBtX3NwYWNlR2x5cGg7IC8vIFNwYWNlIGdseXBo IG9mIG1fZm9udC4KIH07CiAKIHN0YXRpYyB2b2lkIHNldHVwRm9yVGV4dFBhaW50aW5nKFNrUGFp bnQqIHBhaW50LCBTa0NvbG9yIGNvbG9yKQpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gNjMxMzcpCisrKyBM YXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMyBAQAorMjAx MC0wNy0xMiAgWGlhb21laSBKaSAgPHhqaUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ29tcGxleCBzY3JpcHQgc2hvdWxkIGJl IGp1c3RpZmllZCBpbiByZW5kZXJpbmcgd2hlbiB0aGUgYWxpZ25tZW50CisgICAgICAgIGlzICJq dXN0aWZ5Ii4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTQyMTExCisKKyAgICAgICAgKiBwbGF0Zm9ybS9jaHJvbWl1bS90ZXN0X2V4cGVjdGF0aW9ucy50 eHQ6CisKIDIwMTAtMDctMTIgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgogCiAgICAg ICAgIFJldmlld2VkIGJ5IEFkYW0gQmFydGguCkluZGV4OiBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9j aHJvbWl1bS90ZXN0X2V4cGVjdGF0aW9ucy50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMv cGxhdGZvcm0vY2hyb21pdW0vdGVzdF9leHBlY3RhdGlvbnMudHh0CShyZXZpc2lvbiA2MzExNikK KysrIExheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL3Rlc3RfZXhwZWN0YXRpb25zLnR4dAko d29ya2luZyBjb3B5KQpAQCAtMzA5NywzICszMDk3LDYgQEAgQlVHX1dLMzgwMTYgV0lOIExJTlVY IDogZmFzdC9ibG9jay9wb3NpdAogQlVHX1dLMzgwMTYgV0lOIDogZmFzdC9mb3Jtcy9pbnB1dC1m aXJzdC1sZXR0ZXIuaHRtbCA9IElNQUdFK1RFWFQKIAogQlVHNDg4NTkgV0lOIDogZmFzdC9pbmxp bmUvY29udGludWF0aW9uLW91dGxpbmVzLXdpdGgtbGF5ZXJzLTIuaHRtbCA9IElNQUdFK1RFWFQK KworLy8gcGl4ZWwgdGVzdCBleHBlY3RlZCB0byBmYWlsIGFmdGVyIGZpeCBvZiBidWcgNDIxMTEK K0JVRzQyMTExIExJTlVYIDogZmFzdC90ZXh0L2F0c3VpLXNwYWNpbmctZmVhdHVyZXMuaHRtbCA9 IElNQUdFCg==