42094 2010-07-12 10:43:46 -0700 [Qt] REGRESSION?(62951): media tests fail 2014-02-01 18:59:51 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) All All RESOLVED INVALID Qt, QtTriaged P2 Normal --- 86679 79666 1 ossy nancy.piedra abecsi diegohcg hausmann menard nancy.piedra pnormand vestbo webkit.review.bot oldest_to_newest 249907 0 ossy 2010-07-12 10:43:46 -0700 After r62951 landed, two media tests fail on our bots which have Qt 4.6.3 (and Qt 4.7.0) with Qt Mobility API 1.0.1. They pass on "Qt Linux Release" bot on build.webkit.org, which has Qt 4.6.2 with Qt Mobility API 1.0.0 Is it a regression? What do you think? http://webkit.sed.hu/buildbot/results/x86-64%20Linux%20Qt%20Release/r63096%20%286846%29/media/restore-from-page-cache-pretty-diff.html http://webkit.sed.hu/buildbot/results/x86-64%20Linux%20Qt%20Release/r63096%20%286846%29/media/video-can-play-type-pretty-diff.html --- /home/webkitbuildbot/slaves/release64bit/buildslave/qt-linux-64-release/build/layout-test-results/media/restore-from-page-cache-expected.txt 2010-07-12 10:32:28.099646483 -0700 +++ /home/webkitbuildbot/slaves/release64bit/buildslave/qt-linux-64-release/build/layout-test-results/media/restore-from-page-cache-actual.txt 2010-07-12 10:32:28.099646483 -0700 @@ -6,4 +6,5 @@ *** Page going into cache *** Page returned from cache EXPECTED (loadCount == '1') OK +EVENT(loadstart) --- /home/webkitbuildbot/slaves/release64bit/buildslave/qt-linux-64-release/build/layout-test-results/media/video-can-play-type-expected.txt 2010-07-12 10:32:28.164565846 -0700 +++ /home/webkitbuildbot/slaves/release64bit/buildslave/qt-linux-64-release/build/layout-test-results/media/video-can-play-type-actual.txt 2010-07-12 10:32:28.164565846 -0700 @@ -1,10 +1,10 @@ Test HTMLMediaElement canPlayType() method. EXPECTED (video.canPlayType() == '') OK -EXPECTED (video.canPlayType('video/') == '') OK -EXPECTED (video.canPlayType('video/blahblah') == '') OK -EXPECTED (video.canPlayType('video/mpeg; codecs="avc1.4D400C"') == 'probably') OK -EXPECTED (video.canPlayType(' video/mp4 ; video/mp4; codecs="mp4v.20.8, mp4a.40.2"') == 'probably') OK +EXPECTED (video.canPlayType('video/') == ''), OBSERVED 'maybe' FAIL +EXPECTED (video.canPlayType('video/blahblah') == ''), OBSERVED 'maybe' FAIL +EXPECTED (video.canPlayType('video/mpeg; codecs="avc1.4D400C"') == 'probably'), OBSERVED 'maybe' FAIL +EXPECTED (video.canPlayType(' video/mp4 ; video/mp4; codecs="mp4v.20.8, mp4a.40.2"') == 'probably'), OBSERVED 'maybe' FAIL EXPECTED (video.canPlayType('audio/mpeg') == 'maybe') OK EXPECTED (video.canPlayType('audio/wav') == 'maybe') OK END OF TEST 377727 1 nancy.piedra 2011-04-01 05:23:51 -0700 With QtMobility master & Qt 4.7.2 on Linux, restore-from-page-cache passes for me. But video-can-play-type still fails. I think that MediaPlayerPrivateQt.cpp does not implement to the HTML5 specification. I will take a look at that. 378266 2 nancy.piedra 2011-04-01 18:25:31 -0700 The root cause of the video-can-play-type has been identified as an error in QtMobility in the following bug: https://bugs.webkit.org/show_bug.cgi?id=53275 This bug can probably be closed as a duplicate of 53275. 378741 3 nancy.piedra 2011-04-04 05:40:12 -0700 Acutally, this bug should be kept open because still some changes will be needed to the Qt MediaPlayer implementation to pass this test. 625439 4 142262 menard 2012-05-16 07:56:43 -0700 Created attachment 142262 Patch 625441 5 menard 2012-05-16 07:58:13 -0700 (In reply to comment #4) > Created an attachment (id=142262) [details] > Patch Let's give a shot and we can skip some of them if needed. Some coverage (395) is better than 0 coverage. 625617 6 pnormand 2012-05-16 10:37:24 -0700 (In reply to comment #5) > (In reply to comment #4) > > Created an attachment (id=142262) [details] [details] > > Patch > > Let's give a shot and we can skip some of them if needed. Some coverage (395) is better than 0 coverage. What about the http/tests/media? I suspect some of them pass as well. 625624 7 menard 2012-05-16 10:42:07 -0700 (In reply to comment #6) > (In reply to comment #5) > > (In reply to comment #4) > > > Created an attachment (id=142262) [details] [details] [details] > > > Patch > > > > Let's give a shot and we can skip some of them if needed. Some coverage (395) is better than 0 coverage. > > What about the http/tests/media? I suspect some of them pass as well. One thing at a time :) 625800 8 142262 webkit.review.bot 2012-05-16 13:30:31 -0700 Comment on attachment 142262 Patch Clearing flags on attachment: 142262 Committed r117332: <http://trac.webkit.org/changeset/117332> 625801 9 webkit.review.bot 2012-05-16 13:30:38 -0700 All reviewed patches have been landed. Closing bug. 625897 10 webkit.review.bot 2012-05-16 15:01:33 -0700 Re-opened since this is blocked by 86679 142262 2012-05-16 07:56:43 -0700 2012-05-16 13:30:31 -0700 Patch bug-42094-20120516085533.patch text/plain 2750 menard U3VidmVyc2lvbiBSZXZpc2lvbjogMTE3MjczCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZjljMTA3NTQ2N2JhNTEwZDEyZWQ4 NzFjYjgwYTRmMDM3MGEyZTc5Ni4uNTFlNjE2OTc3MjU3OTBmY2NkNDAwMzczNTE0OGFjNmUxZWIy NDI4NiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEyLTA1LTE2ICBBbGV4aXMgTWVuYXJkICA8 YWxleGlzLm1lbmFyZEBvcGVuYm9zc2Eub3JnPgorCisgICAgICAgIFtRdF0gUkVHUkVTU0lPTj8o NjI5NTEpOiBtZWRpYSB0ZXN0cyBmYWlsCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD00MjA5NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIEVuYWJsZSBzb21lIG1lZGlhIGxheW91dCB0ZXN0cyBzbyB0aGF0IG91 ciBjb3ZlcmFnZSBpcyBtb3JlIHRoYW4gaW5leGlzdGFudC4KKworICAgICAgICAqIHBsYXRmb3Jt L3F0L1NraXBwZWQ6CisKIDIwMTItMDUtMTYgIEFycGl0YSBCYWh1Z3VuYSAgPGFycGl0YWJhaHVn dW5hQGdtYWlsLmNvbT4KIAogICAgICAgICAiYm9yZGVyOiBjb2xsYXBzZSIgKyAiZGlzcGxheTog bm9uZSIgcm93cyBpbiB0aGUgdGJvZHkgd2hpbGUgaGF2aW5nIHRoZWFkIG9yIHRmb290IGRvZXNu J3QgcmVuZGVyIHRoZSBvcHBvc2l0ZSBib3JkZXIKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3Bs YXRmb3JtL3F0L1NraXBwZWQgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9Ta2lwcGVkCmluZGV4 IDcxMTIyYTJjYzQ4ZmIwODkwNzI3MWUyODdjMjdjNDFhODk0OTNmNjQuLmZiNzAwM2RlNDVkMGZm YjRlNTg4YTA4ZjNhMTkyMjUyZjBhZWViYTMgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRm b3JtL3F0L1NraXBwZWQKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvU2tpcHBlZApAQCAt OTU1LDkgKzk1NSw4IEBAIGZhc3Qvc2VsZWN0b3JzL3VucXVhbGlmaWVkLWhvdmVyLXN0cmljdC5o dG1sCiAjIGZhaWxpbmcgbWVkaWEgdGVzdHMKICMgPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ICMKIAotIyBb UXRdIG1lZGlhIHRlc3RzIGFyZSBmbGFrZXkKLSMgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTU3OTgzCi1tZWRpYQorIyBUcmFjayBpcyBub3QgZW5hYmxlIHlldAorbWVk aWEvdHJhY2sKIAogIyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzgz NzYKIG1lZGlhL21lZGlhLWRvY3VtZW50LWF1ZGlvLXNpemUuaHRtbApAQCAtMTA3OCw2ICsxMDc3 LDI0IEBAIG1lZGlhL21lZGlhLWRvY3VtZW50LWF1ZGlvLXJlcGFpbnQuaHRtbAogIyBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTc0NzYKIG1lZGlhL3ZpZGVvLXBsYXli YWNrcmF0ZS5odG1sCiAKK21lZGlhL1czQy9hdWRpby9jYW5QbGF5VHlwZS9jYW5QbGF5VHlwZV9z dXBwb3J0ZWRfYnV0X25vX2NvZGVjc19wYXJhbWV0ZXJfMi5odG1sCittZWRpYS9XM0MvdmlkZW8v Y2FuUGxheVR5cGUvY2FuUGxheVR5cGVfY29kZWNzX29yZGVyXzEuaHRtbAorbWVkaWEvVzNDL3Zp ZGVvL2NhblBsYXlUeXBlL2NhblBsYXlUeXBlX2NvZGVjc19vcmRlcl8zLmh0bWwKK21lZGlhL1cz Qy92aWRlby9jYW5QbGF5VHlwZS9jYW5QbGF5VHlwZV9zdXBwb3J0ZWRfYnV0X25vX2NvZGVjc19w YXJhbWV0ZXJfMS5odG1sCittZWRpYS9XM0MvdmlkZW8vY2FuUGxheVR5cGUvY2FuUGxheVR5cGVf c3VwcG9ydGVkX2J1dF9ub19jb2RlY3NfcGFyYW1ldGVyXzMuaHRtbAorbWVkaWEvVzNDL3ZpZGVv L2NhblBsYXlUeXBlL2NhblBsYXlUeXBlX3R3b19pbXBsaWVzX29uZV8xLmh0bWwKK21lZGlhL1cz Qy92aWRlby9jYW5QbGF5VHlwZS9jYW5QbGF5VHlwZV90d29faW1wbGllc19vbmVfMi5odG1sCitt ZWRpYS9XM0MvdmlkZW8vY2FuUGxheVR5cGUvY2FuUGxheVR5cGVfdHdvX2ltcGxpZXNfb25lXzUu aHRtbAorbWVkaWEvVzNDL3ZpZGVvL2NhblBsYXlUeXBlL2NhblBsYXlUeXBlX3R3b19pbXBsaWVz X29uZV82Lmh0bWwKK21lZGlhL2F1ZGlvLWdhcmJhZ2UtY29sbGVjdC5odG1sCittZWRpYS9tZWRp YS1jb250aW51ZXMtcGxheWluZy1hZnRlci1yZXBsYWNlLXNvdXJjZS5odG1sCittZWRpYS9ub2Rl c0Zyb21SZWN0LXNoYWRvd0NvbnRlbnQuaHRtbAorbWVkaWEvc291cmNlcy1mYWxsYmFjay1jb2Rl Y3MuaHRtbAorbWVkaWEvdmlkZW8tY29udHJvbHMtcmVuZGVyaW5nLXRvZ2dsZS1kaXNwbGF5LW5v bmUuaHRtbAorbWVkaWEvdmlkZW8tY29udHJvbHMtdG9nZ2xpbmcuaHRtbAorbWVkaWEvdmlkZW8t cGxheWluZy1hbmQtcGF1c2UuaHRtbAorbWVkaWEvdmlkZW8tdm9sdW1lLmh0bWwKKwogIyA9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PSAjCiAjIENyYXNoaW5nIHRlc3RzIGR1ZSB0byByZS1lbmFibGVkIFBo b25vbiBzdXBwb3J0IGluIEJ1aWxkYm90J3MgUXQgICAgICAgICAgICAgICMKICMgU2tpcCB0aGVz ZSB1bnRpbCBhIHByb3BlciBzb2x1dGlvbiBmb3IgdGhlIFBob25vbiByZWxhdGVkIGNyYXNoZXMg Zm91bmQuICAgICAgIwo=