42086 2010-07-12 09:27:19 -0700 Add WARN_UNUSED_RETURN to the smart pointer "leak" member functions 2010-07-12 09:41:32 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 andersca andersca oldest_to_newest 249878 0 andersca 2010-07-12 09:27:19 -0700 Add WARN_UNUSED_RETURN to the smart pointer "leak" member functions 249883 1 61239 andersca 2010-07-12 09:38:14 -0700 Created attachment 61239 Patch 249884 2 61239 mitz 2010-07-12 09:39:09 -0700 Comment on attachment 61239 Patch r=me! 249887 3 andersca 2010-07-12 09:41:32 -0700 Committed r63093: <http://trac.webkit.org/changeset/63093> 61239 2010-07-12 09:38:14 -0700 2010-07-12 09:39:09 -0700 Patch bug-42086-20100712093813.patch text/plain 4067 andersca ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwppbmRleCAzNzM5YTJlNDIyMTVmODNjZjFjYWMwMDM1OTg5OGExNmYxMDRlMWE4Li4y N2Y5ZDIyMTBiMGVhYWFjOWU2Y2Y0YmFmYTJiNmYzMWJjNjNhMDBmIDEwMDY0NAotLS0gYS9KYXZh U2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTkgQEAKKzIwMTAtMDctMTIgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxl LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBB ZGQgV0FSTl9VTlVTRURfUkVUVVJOIHRvIHRoZSBzbWFydCBwb2ludGVyICJsZWFrIiBtZW1iZXIg ZnVuY3Rpb25zCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD00MjA4NgorCisgICAgICAgICogd3RmL093blB0ci5oOgorICAgICAgICAqIHd0Zi9QYXNzT3du UHRyLmg6CisgICAgICAgICogd3RmL1Bhc3NSZWZQdHIuaDoKKyAgICAgICAgKFdURjo6UGFzc1Jl ZlB0cjo6cmVsZWFzZVJlZik6CisgICAgICAgIChXVEY6Ok5vbk51bGxQYXNzUmVmUHRyOjpsZWFr UmVmKToKKyAgICAgICAgKFdURjo6Tm9uTnVsbFBhc3NSZWZQdHI6OnJlbGVhc2VSZWYpOgorICAg ICAgICAqIHd0Zi9SZXRhaW5QdHIuaDoKKyAgICAgICAgKFdURjo6UmV0YWluUHRyOjpyZWxlYXNl UmVmKToKKwogMjAxMC0wNy0xMCAgT2xpdmVyIEh1bnQgIDxvbGl2ZXJAYXBwbGUuY29tPgogCiAg ICAgICAgIFJldmlld2VkIGJ5IE1hY2llaiBTdGFjaG93aWFrLgpkaWZmIC0tZ2l0IGEvSmF2YVNj cmlwdENvcmUvd3RmL093blB0ci5oIGIvSmF2YVNjcmlwdENvcmUvd3RmL093blB0ci5oCmluZGV4 IGY4MGYzZTA2MDc2ZjNjNDEyMzMyNjg1NGZmNDdkMjIzZmJkYzBiMmEuLmNhZGZhZDJiMTFmODgy NjBkZjQ1OGQ3YzI2NjllZWVlZGEzNDY3ZTkgMTAwNjQ0Ci0tLSBhL0phdmFTY3JpcHRDb3JlL3d0 Zi9Pd25QdHIuaAorKysgYi9KYXZhU2NyaXB0Q29yZS93dGYvT3duUHRyLmgKQEAgLTYwLDcgKzYw LDcgQEAgbmFtZXNwYWNlIFdURiB7CiAKICAgICAgICAgdm9pZCBjbGVhcigpOwogICAgICAgICBQ YXNzT3duUHRyPFQ+IHJlbGVhc2UoKTsKLSAgICAgICAgUHRyVHlwZSBsZWFrUHRyKCk7CisgICAg ICAgIFB0clR5cGUgbGVha1B0cigpIFdBUk5fVU5VU0VEX1JFVFVSTjsKIAogICAgICAgICBWYWx1 ZVR5cGUmIG9wZXJhdG9yKigpIGNvbnN0IHsgQVNTRVJUKG1fcHRyKTsgcmV0dXJuICptX3B0cjsg fQogICAgICAgICBQdHJUeXBlIG9wZXJhdG9yLT4oKSBjb25zdCB7IEFTU0VSVChtX3B0cik7IHJl dHVybiBtX3B0cjsgfQpkaWZmIC0tZ2l0IGEvSmF2YVNjcmlwdENvcmUvd3RmL1Bhc3NPd25QdHIu aCBiL0phdmFTY3JpcHRDb3JlL3d0Zi9QYXNzT3duUHRyLmgKaW5kZXggMzgzYTkxNGRkYThjOWY2 NTg5OWZiZjFhNjU2ZDM3NjY1OTkxOGJiMi4uYTIyM2ZhOWI1ZmJiMGZiNTk2ZmY3OTUwOTNjMzI2 NDllMTE0ZjNhYSAxMDA2NDQKLS0tIGEvSmF2YVNjcmlwdENvcmUvd3RmL1Bhc3NPd25QdHIuaAor KysgYi9KYXZhU2NyaXB0Q29yZS93dGYvUGFzc093blB0ci5oCkBAIC01OSw3ICs1OSw3IEBAIG5h bWVzcGFjZSBXVEYgewogICAgICAgICBQdHJUeXBlIGdldCgpIGNvbnN0IHsgcmV0dXJuIG1fcHRy OyB9CiAKICAgICAgICAgdm9pZCBjbGVhcigpOwotICAgICAgICBQdHJUeXBlIGxlYWtQdHIoKSBj b25zdDsKKyAgICAgICAgUHRyVHlwZSBsZWFrUHRyKCkgY29uc3QgV0FSTl9VTlVTRURfUkVUVVJO OwogCiAgICAgICAgIFZhbHVlVHlwZSYgb3BlcmF0b3IqKCkgY29uc3QgeyBBU1NFUlQobV9wdHIp OyByZXR1cm4gKm1fcHRyOyB9CiAgICAgICAgIFB0clR5cGUgb3BlcmF0b3ItPigpIGNvbnN0IHsg QVNTRVJUKG1fcHRyKTsgcmV0dXJuIG1fcHRyOyB9CmRpZmYgLS1naXQgYS9KYXZhU2NyaXB0Q29y ZS93dGYvUGFzc1JlZlB0ci5oIGIvSmF2YVNjcmlwdENvcmUvd3RmL1Bhc3NSZWZQdHIuaAppbmRl eCAyYWY1YTM5ZWM5ZTczODI5MDg4NWM0YTgwYmY3N2UxOTk4ZjIzNTRlLi4yMzA2MzdhOWU1ZGRh NjNhYjQyNjY1NmNjNmMyMmFiMzgxZmM2MWMyIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29yZS93 dGYvUGFzc1JlZlB0ci5oCisrKyBiL0phdmFTY3JpcHRDb3JlL3d0Zi9QYXNzUmVmUHRyLmgKQEAg LTc3LDcgKzc3LDcgQEAgbmFtZXNwYWNlIFdURiB7CiAgICAgICAgIFQqIGdldCgpIGNvbnN0IHsg cmV0dXJuIG1fcHRyOyB9CiAKICAgICAgICAgdm9pZCBjbGVhcigpOwotICAgICAgICBUKiBsZWFr UmVmKCkgY29uc3Q7CisgICAgICAgIFQqIGxlYWtSZWYoKSBjb25zdCBXQVJOX1VOVVNFRF9SRVRV Uk47CiAKICAgICAgICAgVCYgb3BlcmF0b3IqKCkgY29uc3QgeyByZXR1cm4gKm1fcHRyOyB9CiAg ICAgICAgIFQqIG9wZXJhdG9yLT4oKSBjb25zdCB7IHJldHVybiBtX3B0cjsgfQpAQCAtOTYsNyAr OTYsNyBAQCBuYW1lc3BhY2UgV1RGIHsKICAgICAgICAgZnJpZW5kIFBhc3NSZWZQdHIgYWRvcHRS ZWY8VD4oVCopOwogCiAgICAgICAgIC8vIEZJWE1FOiBSZW1vdmUgcmVsZWFzZVJlZiBvbmNlIHdl IGNoYW5nZSBhbGwgY2FsbGVycyB0byBjYWxsIGxlYWtSZWYgaW5zdGVhZC4KLSAgICAgICAgVCog cmVsZWFzZVJlZigpIGNvbnN0IHsgcmV0dXJuIGxlYWtSZWYoKTsgfQorICAgICAgICBUKiByZWxl YXNlUmVmKCkgY29uc3QgeyByZXR1cm4gbGVha1JlZigpOyB9IFdBUk5fVU5VU0VEX1JFVFVSTjsK IAogICAgIHByaXZhdGU6CiAgICAgICAgIC8vIGFkb3B0aW5nIGNvbnN0cnVjdG9yCkBAIC0xNTIs MTMgKzE1MiwxMyBAQCBuYW1lc3BhY2UgV1RGIHsKICAgICAgICAgVCogZ2V0KCkgY29uc3QgeyBy ZXR1cm4gbV9wdHI7IH0KIAogICAgICAgICB2b2lkIGNsZWFyKCk7Ci0gICAgICAgIFQqIGxlYWtS ZWYoKSBjb25zdCB7IFQqIHRtcCA9IG1fcHRyOyBtX3B0ciA9IDA7IHJldHVybiB0bXA7IH0KKyAg ICAgICAgVCogbGVha1JlZigpIGNvbnN0IHsgVCogdG1wID0gbV9wdHI7IG1fcHRyID0gMDsgcmV0 dXJuIHRtcDsgfSBXQVJOX1VOVVNFRF9SRVRVUk47CiAKICAgICAgICAgVCYgb3BlcmF0b3IqKCkg Y29uc3QgeyByZXR1cm4gKm1fcHRyOyB9CiAgICAgICAgIFQqIG9wZXJhdG9yLT4oKSBjb25zdCB7 IHJldHVybiBtX3B0cjsgfQogCiAgICAgICAgIC8vIEZJWE1FOiBSZW1vdmUgcmVsZWFzZVJlZiBv bmNlIHdlIGNoYW5nZSBhbGwgY2FsbGVycyB0byBjYWxsIGxlYWtSZWYgaW5zdGVhZC4KLSAgICAg ICAgVCogcmVsZWFzZVJlZigpIGNvbnN0IHsgcmV0dXJuIGxlYWtSZWYoKTsgfQorICAgICAgICBU KiByZWxlYXNlUmVmKCkgY29uc3QgeyByZXR1cm4gbGVha1JlZigpOyB9IFdBUk5fVU5VU0VEX1JF VFVSTjsKIAogICAgIHByaXZhdGU6CiAgICAgICAgIG11dGFibGUgVCogbV9wdHI7CmRpZmYgLS1n aXQgYS9KYXZhU2NyaXB0Q29yZS93dGYvUmV0YWluUHRyLmggYi9KYXZhU2NyaXB0Q29yZS93dGYv UmV0YWluUHRyLmgKaW5kZXggZjVhMDI3ZWFhZGIxNzk2OWZmZDU5NmQ1ZDJlNjI1MDBhMmY2N2Y3 Ni4uMjc2OGJlNzc0ZDRiYTBkNzg4MzY4NWU3NWM5NzM1OTE3MTdlNjE3YSAxMDA2NDQKLS0tIGEv SmF2YVNjcmlwdENvcmUvd3RmL1JldGFpblB0ci5oCisrKyBiL0phdmFTY3JpcHRDb3JlL3d0Zi9S ZXRhaW5QdHIuaApAQCAtNzEsNyArNzEsNyBAQCBuYW1lc3BhY2UgV1RGIHsKICAgICAgICAgCiAg ICAgICAgIFB0clR5cGUgZ2V0KCkgY29uc3QgeyByZXR1cm4gbV9wdHI7IH0KICAgICAgICAgCi0g ICAgICAgIFB0clR5cGUgcmVsZWFzZVJlZigpIHsgUHRyVHlwZSB0bXAgPSBtX3B0cjsgbV9wdHIg PSAwOyByZXR1cm4gdG1wOyB9CisgICAgICAgIFB0clR5cGUgcmVsZWFzZVJlZigpIHsgUHRyVHlw ZSB0bXAgPSBtX3B0cjsgbV9wdHIgPSAwOyByZXR1cm4gdG1wOyB9IFdBUk5fVU5VU0VEX1JFVFVS TjsKICAgICAgICAgCiAgICAgICAgIFB0clR5cGUgb3BlcmF0b3ItPigpIGNvbnN0IHsgcmV0dXJu IG1fcHRyOyB9CiAgICAgICAgIAo=