42051 2010-07-11 18:35:33 -0700 browser cache and webkit cache used for resources listed as fallback and/or network in cache manifest file. 2010-07-13 10:41:11 -0700 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) All All RESOLVED INVALID http://htmltest.freetzi.com/fallback/index.html P2 Normal --- 0 liachen webkit-unassigned ap lyon.chen staikos yong.li.webkit oldest_to_newest 249667 0 liachen 2010-07-11 18:35:33 -0700 When loading resources listed in fallback and/or network sections in a cache manifest file, we use webkit cache and browser cache, which could result in wrong resource used when online status changed during a browser session: Steps to reproduce: 1. load http://htmltest.freetzi.com/fallback/index.html; 2. the image should display "online"; 3. remove all network connection; 4. open a new tab and load http://htmltest.freetzi.com/fallback/index.html; 5. the image should display "offline", but it shows "online". The reason is when we loading online.gif for the new tab, it doesn't check whether it's a fallback resource before we load it from webkit cache. Another aspect of this issue is, we can also load fallback/network resources from browser cache, so we also need to make every load of fallback/network resources with cache policy of CachePolicyReload/ReloadIgnoringCacheData. 249668 1 61184 liachen 2010-07-11 18:42:36 -0700 Created attachment 61184 patch for 42051 249688 2 61190 liachen 2010-07-11 21:54:24 -0700 Created attachment 61190 patch for 42051 Updated with dummy implementation of ApplicationCacheHost::isFallbackOrNetworkResource() for Chromium port, which don't need it except for compiling purpose. 249937 3 ap 2010-07-12 11:52:15 -0700 Say, there is an offline app for an image gallery, and it loads images from network, having the URLs in NETWORK section. Surely we don't want to bypass network loader cache for these, and the behavior you describe is better than the alternative. When I last looked at the spec, it didn't say that we should bypass caches. If you think that would be a better behavior, it should probably be incorporated in the spec first. 249956 4 lyon.chen 2010-07-12 12:18:13 -0700 (In reply to comment #3) > When I last looked at the spec, it didn't say that we should bypass caches. If you think that would be a better behavior, it should probably be incorporated in the spec first. Yeah, I agree there's no specific mentioning bypass user agent specific caches like webkit cache and webkit client application cache in the spec, but I do think without bypassing all these caches, we will give these web applications a wrong information that it's still online, while it is not, as shown my reproduce steps listed above. 249965 5 ap 2010-07-12 12:29:17 -0700 A Web application can always serve the resource with pragma no-store to prevent caching if that's the way it discovers the "online" state. Re-reading comment 3, I think that it can be misread, so to avoid confusion, my position is that the current behavior is preferable. If you would like to change it, I think that the best thing to do would be to e-mail WHATWG or W3C HTMLWG mailing list, asking for a clarification and a possible spec change. 249974 6 lyon.chen 2010-07-12 12:42:59 -0700 (In reply to comment #5) > If you would like to change it, I think that the best thing to do would be to e-mail WHATWG or W3C HTMLWG mailing list, asking for a clarification and a possible spec change. Good suggestion, will ask for clarification on this. 250600 7 lyon.chen 2010-07-13 10:25:28 -0700 (In reply to comment #6) Based on comments above by Alexey Proskuryakov, and comments in webkit-dev and whatwg@lists.whatwg.org, I agree this bug is not valid. Offline web application should use cache-control if they want to make sure the resources in fallback list are from original server. 61184 2010-07-11 18:42:36 -0700 2010-07-11 21:54:24 -0700 patch for 42051 42051.patch text/plain 4457 liachen ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MTdhOWFlOS4uNjNiNWRkZiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMiBAQAorMjAxMC0wNy0xMSAgTHlvbiBDaGVuICA8 bGlhY2hlbkByaW0uY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIGJyb3dzZXIgY2FjaGUgYW5kIHdlYmtpdCBjYWNoZSB1c2VkIGZvciByZXNvdXJj ZXMgbGlzdGVkIGFzIGZhbGxiYWNrIGFuZC9vciBuZXR3b3JrIGluIGNhY2hlIG1hbmlmZXN0IGZp bGUuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MjA1 MQorCisgICAgICAgIFRoZSBzb2x1dGlvbiBpcyBjaGVja2luZyB3aGV0aGVyIGEgcmVzb3VyY2Ug aXMgYSBmYWxsYmFjay9uZXR3b3JrIHJlc291cmNlIGl0ZW0gb3Igbm90IGJlZm9yZSBsb2FkaW5n IGl0IGZyb20KKyAgICAgICAgd2Via2l0IGNhY2hlIG9yIHNlbmRpbmcgYSBsb2FkIHJlcXVlc3Qs IGlmIHllcywgdGhlbiB1c2UgYSBjYWNoZSBwb2xpY3kgd2lsbCBwcm9oaWJpdCBsb2FkaW5nIGl0 IGZyb20gY2FjaGUsIGJvdGgKKyAgICAgICAgd2Via2l0IGNhY2hlIGFuZCBicm93c2VyIGNhY2hl LgorCisgICAgICAgICogbG9hZGVyL0RvY0xvYWRlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpE b2NMb2FkZXI6OmNoZWNrRm9yUmVsb2FkKToKKyAgICAgICAgKiBsb2FkZXIvUmVzb3VyY2VMb2Fk ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVzb3VyY2VMb2FkZXI6OmxvYWQpOgorICAgICAg ICAqIGxvYWRlci9hcHBjYWNoZS9BcHBsaWNhdGlvbkNhY2hlSG9zdC5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpBcHBsaWNhdGlvbkNhY2hlSG9zdDo6aXNGYWxsYmFja09yTmV0d29ya1Jlc291cmNl KToKKyAgICAgICAgKiBsb2FkZXIvYXBwY2FjaGUvQXBwbGljYXRpb25DYWNoZUhvc3QuaDoKKwog MjAxMC0wNy0xMSAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgogCiAgICAgICAgIFJ1 YmJlci1zdGFtcGVkIGJ5IEVyaWMgU2VpZGVsCmRpZmYgLS1naXQgYS9XZWJDb3JlL2xvYWRlci9E b2NMb2FkZXIuY3BwIGIvV2ViQ29yZS9sb2FkZXIvRG9jTG9hZGVyLmNwcAppbmRleCAyZjc1ZmY5 Li5lZWMzODMwIDEwMDY0NAotLS0gYS9XZWJDb3JlL2xvYWRlci9Eb2NMb2FkZXIuY3BwCisrKyBi L1dlYkNvcmUvbG9hZGVyL0RvY0xvYWRlci5jcHAKQEAgLTI3LDYgKzI3LDcgQEAKICNpbmNsdWRl ICJjb25maWcuaCIKICNpbmNsdWRlICJEb2NMb2FkZXIuaCIKIAorI2luY2x1ZGUgIkFwcGxpY2F0 aW9uQ2FjaGVIb3N0LmgiCiAjaW5jbHVkZSAiQ2FjaGUuaCIKICNpbmNsdWRlICJDYWNoZWRDU1NT dHlsZVNoZWV0LmgiCiAjaW5jbHVkZSAiQ2FjaGVkRm9udC5oIgpAQCAtMzUsNiArMzYsNyBAQAog I2luY2x1ZGUgIkNhY2hlZFhTTFN0eWxlU2hlZXQuaCIKICNpbmNsdWRlICJDb25zb2xlLmgiCiAj aW5jbHVkZSAiRG9jdW1lbnQuaCIKKyNpbmNsdWRlICJEb2N1bWVudExvYWRlci5oIgogI2luY2x1 ZGUgIkRPTVdpbmRvdy5oIgogI2luY2x1ZGUgIkhUTUxFbGVtZW50LmgiCiAjaW5jbHVkZSAiRnJh bWUuaCIKQEAgLTk1LDcgKzk3LDE2IEBAIHZvaWQgRG9jTG9hZGVyOjpjaGVja0ZvclJlbG9hZChj b25zdCBLVVJMJiBmdWxsVVJMKQogICAgIGlmICghZXhpc3RpbmcgfHwgZXhpc3RpbmctPmlzUHJl bG9hZGVkKCkpCiAgICAgICAgIHJldHVybjsKIAotICAgIHN3aXRjaCAoY2FjaGVQb2xpY3koKSkg eworICAgIENhY2hlUG9saWN5IHBvbGljeSA9IGNhY2hlUG9saWN5KCk7CisKKyNpZiBFTkFCTEUo T0ZGTElORV9XRUJfQVBQTElDQVRJT05TKSAmJiBPUyhPTFlNUElBKQorICAgIC8vIERvbid0IHVz ZSBjYWNoZSBmb3IgcmVzb3VyY2VzIGxpc3RlZCBhcyBGYWxsYmFjayBhbmQvb3IgTmV0d29yawor ICAgIEZyYW1lKiBmID0gZnJhbWUoKTsKKyAgICBpZiAoZiAmJiBmLT5sb2FkZXIoKS0+ZG9jdW1l bnRMb2FkZXIoKS0+YXBwbGljYXRpb25DYWNoZUhvc3QoKS0+aXNGYWxsYmFja09yTmV0d29ya1Jl c291cmNlKGZ1bGxVUkwpKQorICAgICAgICBwb2xpY3kgPSBDYWNoZVBvbGljeVJlbG9hZDsKKyNl bmRpZgorCisgICAgc3dpdGNoIChwb2xpY3kpIHsKICAgICBjYXNlIENhY2hlUG9saWN5VmVyaWZ5 OgogICAgICAgICBpZiAoIWV4aXN0aW5nLT5tdXN0UmV2YWxpZGF0ZShDYWNoZVBvbGljeVZlcmlm eSkpCiAgICAgICAgICAgICByZXR1cm47CmRpZmYgLS1naXQgYS9XZWJDb3JlL2xvYWRlci9SZXNv dXJjZUxvYWRlci5jcHAgYi9XZWJDb3JlL2xvYWRlci9SZXNvdXJjZUxvYWRlci5jcHAKaW5kZXgg NTdlNTNlYi4uYjdhZDBjYSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9sb2FkZXIvUmVzb3VyY2VMb2Fk ZXIuY3BwCisrKyBiL1dlYkNvcmUvbG9hZGVyL1Jlc291cmNlTG9hZGVyLmNwcApAQCAtMTM1LDYg KzEzNSwxMCBAQCBib29sIFJlc291cmNlTG9hZGVyOjpsb2FkKGNvbnN0IFJlc291cmNlUmVxdWVz dCYgcikKICNpZiBFTkFCTEUoT0ZGTElORV9XRUJfQVBQTElDQVRJT05TKQogICAgIGlmIChtX2Rv Y3VtZW50TG9hZGVyLT5hcHBsaWNhdGlvbkNhY2hlSG9zdCgpLT5tYXliZUxvYWRSZXNvdXJjZSh0 aGlzLCBjbGllbnRSZXF1ZXN0LCByLnVybCgpKSkKICAgICAgICAgcmV0dXJuIHRydWU7CisKKyAg ICAvLyBCYXNlZCBvbiBodHRwOi8vd3d3LnczLm9yZy9UUi9odG1sNS9vZmZsaW5lLmh0bWwsIGFu eSB1cmxzIGxpc3RlZCBpbiBGQUxMQkFDSyBvciBORVRXT1JLIHNob3VsZCBieXBhc3MgY2FjaGUu CisgICAgaWYgKG1fZG9jdW1lbnRMb2FkZXItPmFwcGxpY2F0aW9uQ2FjaGVIb3N0KCktPmlzRmFs bGJhY2tPck5ldHdvcmtSZXNvdXJjZShjbGllbnRSZXF1ZXN0LnVybCgpKSkKKyAgICAgICAgY2xp ZW50UmVxdWVzdC5zZXRDYWNoZVBvbGljeShSZWxvYWRJZ25vcmluZ0NhY2hlRGF0YSk7CiAjZW5k aWYKIAogICAgIGlmIChtX2RlZmVyc0xvYWRpbmcpIHsKZGlmZiAtLWdpdCBhL1dlYkNvcmUvbG9h ZGVyL2FwcGNhY2hlL0FwcGxpY2F0aW9uQ2FjaGVIb3N0LmNwcCBiL1dlYkNvcmUvbG9hZGVyL2Fw cGNhY2hlL0FwcGxpY2F0aW9uQ2FjaGVIb3N0LmNwcAppbmRleCBmNjNkZTU1Li5kMjQzOWQyIDEw MDY0NAotLS0gYS9XZWJDb3JlL2xvYWRlci9hcHBjYWNoZS9BcHBsaWNhdGlvbkNhY2hlSG9zdC5j cHAKKysrIGIvV2ViQ29yZS9sb2FkZXIvYXBwY2FjaGUvQXBwbGljYXRpb25DYWNoZUhvc3QuY3Bw CkBAIC0yMjMsNiArMjIzLDEzIEBAIGJvb2wgQXBwbGljYXRpb25DYWNoZUhvc3Q6OmNhbkNhY2hl SW5QYWdlQ2FjaGUoKSBjb25zdAogICAgIHJldHVybiAhYXBwbGljYXRpb25DYWNoZSgpICYmICFj YW5kaWRhdGVBcHBsaWNhdGlvbkNhY2hlR3JvdXAoKTsKIH0KIAorYm9vbCBBcHBsaWNhdGlvbkNh Y2hlSG9zdDo6aXNGYWxsYmFja09yTmV0d29ya1Jlc291cmNlKGNvbnN0IEtVUkwmIHVybCkgY29u c3QKK3sKKyAgICBBcHBsaWNhdGlvbkNhY2hlKiBjYWNoZSA9IGFwcGxpY2F0aW9uQ2FjaGUoKTsK KworICAgIHJldHVybiBjYWNoZSAmJiBjYWNoZS0+aXNDb21wbGV0ZSgpICYmIChjYWNoZS0+dXJs TWF0Y2hlc0ZhbGxiYWNrTmFtZXNwYWNlKHVybCkgfHwgY2FjaGUtPmlzVVJMSW5PbmxpbmVXaGl0 ZWxpc3QodXJsKSk7Cit9CisKIHZvaWQgQXBwbGljYXRpb25DYWNoZUhvc3Q6OnNldERPTUFwcGxp Y2F0aW9uQ2FjaGUoRE9NQXBwbGljYXRpb25DYWNoZSogZG9tQXBwbGljYXRpb25DYWNoZSkKIHsK ICAgICBBU1NFUlQoIW1fZG9tQXBwbGljYXRpb25DYWNoZSB8fCAhZG9tQXBwbGljYXRpb25DYWNo ZSk7CmRpZmYgLS1naXQgYS9XZWJDb3JlL2xvYWRlci9hcHBjYWNoZS9BcHBsaWNhdGlvbkNhY2hl SG9zdC5oIGIvV2ViQ29yZS9sb2FkZXIvYXBwY2FjaGUvQXBwbGljYXRpb25DYWNoZUhvc3QuaApp bmRleCBhNWI1NWU5Li45YzkwYjUzIDEwMDY0NAotLS0gYS9XZWJDb3JlL2xvYWRlci9hcHBjYWNo ZS9BcHBsaWNhdGlvbkNhY2hlSG9zdC5oCisrKyBiL1dlYkNvcmUvbG9hZGVyL2FwcGNhY2hlL0Fw cGxpY2F0aW9uQ2FjaGVIb3N0LmgKQEAgLTEwMiw2ICsxMDIsNyBAQCBuYW1lc3BhY2UgV2ViQ29y ZSB7CiAgICAgICAgIHZvaWQgbWF5YmVMb2FkRmFsbGJhY2tTeW5jaHJvbm91c2x5KGNvbnN0IFJl c291cmNlUmVxdWVzdCYsIFJlc291cmNlRXJyb3ImLCBSZXNvdXJjZVJlc3BvbnNlJiwgVmVjdG9y PGNoYXI+JiBkYXRhKTsKIAogICAgICAgICBib29sIGNhbkNhY2hlSW5QYWdlQ2FjaGUoKSBjb25z dDsKKyAgICAgICAgYm9vbCBpc0ZhbGxiYWNrT3JOZXR3b3JrUmVzb3VyY2UoY29uc3QgS1VSTCYp IGNvbnN0OwogCiAgICAgICAgIFN0YXR1cyBzdGF0dXMoKSBjb25zdDsgIAogICAgICAgICBib29s IHVwZGF0ZSgpOwo= 61190 2010-07-11 21:54:24 -0700 2010-07-12 11:52:24 -0700 patch for 42051 42051.patch text/plain 5850 liachen ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MTdhOWFlOS4uNjNiNWRkZiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMiBAQAorMjAxMC0wNy0xMSAgTHlvbiBDaGVuICA8 bGlhY2hlbkByaW0uY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIGJyb3dzZXIgY2FjaGUgYW5kIHdlYmtpdCBjYWNoZSB1c2VkIGZvciByZXNvdXJj ZXMgbGlzdGVkIGFzIGZhbGxiYWNrIGFuZC9vciBuZXR3b3JrIGluIGNhY2hlIG1hbmlmZXN0IGZp bGUuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MjA1 MQorCisgICAgICAgIFRoZSBzb2x1dGlvbiBpcyBjaGVja2luZyB3aGV0aGVyIGEgcmVzb3VyY2Ug aXMgYSBmYWxsYmFjay9uZXR3b3JrIHJlc291cmNlIGl0ZW0gb3Igbm90IGJlZm9yZSBsb2FkaW5n IGl0IGZyb20KKyAgICAgICAgd2Via2l0IGNhY2hlIG9yIHNlbmRpbmcgYSBsb2FkIHJlcXVlc3Qs IGlmIHllcywgdGhlbiB1c2UgYSBjYWNoZSBwb2xpY3kgd2lsbCBwcm9oaWJpdCBsb2FkaW5nIGl0 IGZyb20gY2FjaGUsIGJvdGgKKyAgICAgICAgd2Via2l0IGNhY2hlIGFuZCBicm93c2VyIGNhY2hl LgorCisgICAgICAgICogbG9hZGVyL0RvY0xvYWRlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpE b2NMb2FkZXI6OmNoZWNrRm9yUmVsb2FkKToKKyAgICAgICAgKiBsb2FkZXIvUmVzb3VyY2VMb2Fk ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVzb3VyY2VMb2FkZXI6OmxvYWQpOgorICAgICAg ICAqIGxvYWRlci9hcHBjYWNoZS9BcHBsaWNhdGlvbkNhY2hlSG9zdC5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpBcHBsaWNhdGlvbkNhY2hlSG9zdDo6aXNGYWxsYmFja09yTmV0d29ya1Jlc291cmNl KToKKyAgICAgICAgKiBsb2FkZXIvYXBwY2FjaGUvQXBwbGljYXRpb25DYWNoZUhvc3QuaDoKKwog MjAxMC0wNy0xMSAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgogCiAgICAgICAgIFJ1 YmJlci1zdGFtcGVkIGJ5IEVyaWMgU2VpZGVsCmRpZmYgLS1naXQgYS9XZWJDb3JlL2xvYWRlci9E b2NMb2FkZXIuY3BwIGIvV2ViQ29yZS9sb2FkZXIvRG9jTG9hZGVyLmNwcAppbmRleCAyZjc1ZmY5 Li5lZWMzODMwIDEwMDY0NAotLS0gYS9XZWJDb3JlL2xvYWRlci9Eb2NMb2FkZXIuY3BwCisrKyBi L1dlYkNvcmUvbG9hZGVyL0RvY0xvYWRlci5jcHAKQEAgLTI3LDYgKzI3LDcgQEAKICNpbmNsdWRl ICJjb25maWcuaCIKICNpbmNsdWRlICJEb2NMb2FkZXIuaCIKIAorI2luY2x1ZGUgIkFwcGxpY2F0 aW9uQ2FjaGVIb3N0LmgiCiAjaW5jbHVkZSAiQ2FjaGUuaCIKICNpbmNsdWRlICJDYWNoZWRDU1NT dHlsZVNoZWV0LmgiCiAjaW5jbHVkZSAiQ2FjaGVkRm9udC5oIgpAQCAtMzUsNiArMzYsNyBAQAog I2luY2x1ZGUgIkNhY2hlZFhTTFN0eWxlU2hlZXQuaCIKICNpbmNsdWRlICJDb25zb2xlLmgiCiAj aW5jbHVkZSAiRG9jdW1lbnQuaCIKKyNpbmNsdWRlICJEb2N1bWVudExvYWRlci5oIgogI2luY2x1 ZGUgIkRPTVdpbmRvdy5oIgogI2luY2x1ZGUgIkhUTUxFbGVtZW50LmgiCiAjaW5jbHVkZSAiRnJh bWUuaCIKQEAgLTk1LDcgKzk3LDE2IEBAIHZvaWQgRG9jTG9hZGVyOjpjaGVja0ZvclJlbG9hZChj b25zdCBLVVJMJiBmdWxsVVJMKQogICAgIGlmICghZXhpc3RpbmcgfHwgZXhpc3RpbmctPmlzUHJl bG9hZGVkKCkpCiAgICAgICAgIHJldHVybjsKIAotICAgIHN3aXRjaCAoY2FjaGVQb2xpY3koKSkg eworICAgIENhY2hlUG9saWN5IHBvbGljeSA9IGNhY2hlUG9saWN5KCk7CisKKyNpZiBFTkFCTEUo T0ZGTElORV9XRUJfQVBQTElDQVRJT05TKSAmJiBPUyhPTFlNUElBKQorICAgIC8vIERvbid0IHVz ZSBjYWNoZSBmb3IgcmVzb3VyY2VzIGxpc3RlZCBhcyBGYWxsYmFjayBhbmQvb3IgTmV0d29yawor ICAgIEZyYW1lKiBmID0gZnJhbWUoKTsKKyAgICBpZiAoZiAmJiBmLT5sb2FkZXIoKS0+ZG9jdW1l bnRMb2FkZXIoKS0+YXBwbGljYXRpb25DYWNoZUhvc3QoKS0+aXNGYWxsYmFja09yTmV0d29ya1Jl c291cmNlKGZ1bGxVUkwpKQorICAgICAgICBwb2xpY3kgPSBDYWNoZVBvbGljeVJlbG9hZDsKKyNl bmRpZgorCisgICAgc3dpdGNoIChwb2xpY3kpIHsKICAgICBjYXNlIENhY2hlUG9saWN5VmVyaWZ5 OgogICAgICAgICBpZiAoIWV4aXN0aW5nLT5tdXN0UmV2YWxpZGF0ZShDYWNoZVBvbGljeVZlcmlm eSkpCiAgICAgICAgICAgICByZXR1cm47CmRpZmYgLS1naXQgYS9XZWJDb3JlL2xvYWRlci9SZXNv dXJjZUxvYWRlci5jcHAgYi9XZWJDb3JlL2xvYWRlci9SZXNvdXJjZUxvYWRlci5jcHAKaW5kZXgg NTdlNTNlYi4uYjdhZDBjYSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9sb2FkZXIvUmVzb3VyY2VMb2Fk ZXIuY3BwCisrKyBiL1dlYkNvcmUvbG9hZGVyL1Jlc291cmNlTG9hZGVyLmNwcApAQCAtMTM1LDYg KzEzNSwxMCBAQCBib29sIFJlc291cmNlTG9hZGVyOjpsb2FkKGNvbnN0IFJlc291cmNlUmVxdWVz dCYgcikKICNpZiBFTkFCTEUoT0ZGTElORV9XRUJfQVBQTElDQVRJT05TKQogICAgIGlmIChtX2Rv Y3VtZW50TG9hZGVyLT5hcHBsaWNhdGlvbkNhY2hlSG9zdCgpLT5tYXliZUxvYWRSZXNvdXJjZSh0 aGlzLCBjbGllbnRSZXF1ZXN0LCByLnVybCgpKSkKICAgICAgICAgcmV0dXJuIHRydWU7CisKKyAg ICAvLyBCYXNlZCBvbiBodHRwOi8vd3d3LnczLm9yZy9UUi9odG1sNS9vZmZsaW5lLmh0bWwsIGFu eSB1cmxzIGxpc3RlZCBpbiBGQUxMQkFDSyBvciBORVRXT1JLIHNob3VsZCBieXBhc3MgY2FjaGUu CisgICAgaWYgKG1fZG9jdW1lbnRMb2FkZXItPmFwcGxpY2F0aW9uQ2FjaGVIb3N0KCktPmlzRmFs bGJhY2tPck5ldHdvcmtSZXNvdXJjZShjbGllbnRSZXF1ZXN0LnVybCgpKSkKKyAgICAgICAgY2xp ZW50UmVxdWVzdC5zZXRDYWNoZVBvbGljeShSZWxvYWRJZ25vcmluZ0NhY2hlRGF0YSk7CiAjZW5k aWYKIAogICAgIGlmIChtX2RlZmVyc0xvYWRpbmcpIHsKZGlmZiAtLWdpdCBhL1dlYkNvcmUvbG9h ZGVyL2FwcGNhY2hlL0FwcGxpY2F0aW9uQ2FjaGVIb3N0LmNwcCBiL1dlYkNvcmUvbG9hZGVyL2Fw cGNhY2hlL0FwcGxpY2F0aW9uQ2FjaGVIb3N0LmNwcAppbmRleCBmNjNkZTU1Li5kMjQzOWQyIDEw MDY0NAotLS0gYS9XZWJDb3JlL2xvYWRlci9hcHBjYWNoZS9BcHBsaWNhdGlvbkNhY2hlSG9zdC5j cHAKKysrIGIvV2ViQ29yZS9sb2FkZXIvYXBwY2FjaGUvQXBwbGljYXRpb25DYWNoZUhvc3QuY3Bw CkBAIC0yMjMsNiArMjIzLDEzIEBAIGJvb2wgQXBwbGljYXRpb25DYWNoZUhvc3Q6OmNhbkNhY2hl SW5QYWdlQ2FjaGUoKSBjb25zdAogICAgIHJldHVybiAhYXBwbGljYXRpb25DYWNoZSgpICYmICFj YW5kaWRhdGVBcHBsaWNhdGlvbkNhY2hlR3JvdXAoKTsKIH0KIAorYm9vbCBBcHBsaWNhdGlvbkNh Y2hlSG9zdDo6aXNGYWxsYmFja09yTmV0d29ya1Jlc291cmNlKGNvbnN0IEtVUkwmIHVybCkgY29u c3QKK3sKKyAgICBBcHBsaWNhdGlvbkNhY2hlKiBjYWNoZSA9IGFwcGxpY2F0aW9uQ2FjaGUoKTsK KworICAgIHJldHVybiBjYWNoZSAmJiBjYWNoZS0+aXNDb21wbGV0ZSgpICYmIChjYWNoZS0+dXJs TWF0Y2hlc0ZhbGxiYWNrTmFtZXNwYWNlKHVybCkgfHwgY2FjaGUtPmlzVVJMSW5PbmxpbmVXaGl0 ZWxpc3QodXJsKSk7Cit9CisKIHZvaWQgQXBwbGljYXRpb25DYWNoZUhvc3Q6OnNldERPTUFwcGxp Y2F0aW9uQ2FjaGUoRE9NQXBwbGljYXRpb25DYWNoZSogZG9tQXBwbGljYXRpb25DYWNoZSkKIHsK ICAgICBBU1NFUlQoIW1fZG9tQXBwbGljYXRpb25DYWNoZSB8fCAhZG9tQXBwbGljYXRpb25DYWNo ZSk7CmRpZmYgLS1naXQgYS9XZWJDb3JlL2xvYWRlci9hcHBjYWNoZS9BcHBsaWNhdGlvbkNhY2hl SG9zdC5oIGIvV2ViQ29yZS9sb2FkZXIvYXBwY2FjaGUvQXBwbGljYXRpb25DYWNoZUhvc3QuaApp bmRleCBhNWI1NWU5Li45YzkwYjUzIDEwMDY0NAotLS0gYS9XZWJDb3JlL2xvYWRlci9hcHBjYWNo ZS9BcHBsaWNhdGlvbkNhY2hlSG9zdC5oCisrKyBiL1dlYkNvcmUvbG9hZGVyL2FwcGNhY2hlL0Fw cGxpY2F0aW9uQ2FjaGVIb3N0LmgKQEAgLTEwMiw2ICsxMDIsNyBAQCBuYW1lc3BhY2UgV2ViQ29y ZSB7CiAgICAgICAgIHZvaWQgbWF5YmVMb2FkRmFsbGJhY2tTeW5jaHJvbm91c2x5KGNvbnN0IFJl c291cmNlUmVxdWVzdCYsIFJlc291cmNlRXJyb3ImLCBSZXNvdXJjZVJlc3BvbnNlJiwgVmVjdG9y PGNoYXI+JiBkYXRhKTsKIAogICAgICAgICBib29sIGNhbkNhY2hlSW5QYWdlQ2FjaGUoKSBjb25z dDsKKyAgICAgICAgYm9vbCBpc0ZhbGxiYWNrT3JOZXR3b3JrUmVzb3VyY2UoY29uc3QgS1VSTCYp IGNvbnN0OwogCiAgICAgICAgIFN0YXR1cyBzdGF0dXMoKSBjb25zdDsgIAogICAgICAgICBib29s IHVwZGF0ZSgpOwpkaWZmIC0tZ2l0IGEvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZyBiL1dlYktp dC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXggMGIzYjExMC4uMmQyNzE2MiAxMDA2NDQKLS0tIGEv V2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZworKysgYi9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9n CkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMDctMTEgIEx5b24gQ2hlbiAgPGxpYWNoZW5AcmltLmNv bT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBicm93 c2VyIGNhY2hlIGFuZCB3ZWJraXQgY2FjaGUgdXNlZCBmb3IgcmVzb3VyY2VzIGxpc3RlZCBhcyBm YWxsYmFjayBhbmQvb3IgbmV0d29yayBpbiBjYWNoZSBtYW5pZmVzdCBmaWxlLgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDIwNTEKKworICAgICAgICBJ bXBsZW1lbnQgYSBkdW1teSB2ZXJzaW9uIG9mIEFwcGxpY2F0aW9uQ2FjaGVIb3N0Ojppc0ZhbGxi YWNrT3JOZXR3b3JrUmVzb3VyY2UoKS4KKworICAgICAgICAqIHNyYy9BcHBsaWNhdGlvbkNhY2hl SG9zdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpBcHBsaWNhdGlvbkNhY2hlSG9zdDo6aXNGYWxs YmFja09yTmV0d29ya1Jlc291cmNlKToKKwogMjAxMC0wNy0wOSAgSm9obiBBYmQtRWwtTWFsZWsg IDxqYW1AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEZpc2hlci4K ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9zcmMvQXBwbGljYXRpb25DYWNoZUhvc3QuY3Bw IGIvV2ViS2l0L2Nocm9taXVtL3NyYy9BcHBsaWNhdGlvbkNhY2hlSG9zdC5jcHAKaW5kZXggYjkw MTI2Zi4uNjlkZGIxYiAxMDA2NDQKLS0tIGEvV2ViS2l0L2Nocm9taXVtL3NyYy9BcHBsaWNhdGlv bkNhY2hlSG9zdC5jcHAKKysrIGIvV2ViS2l0L2Nocm9taXVtL3NyYy9BcHBsaWNhdGlvbkNhY2hl SG9zdC5jcHAKQEAgLTE5MCw2ICsxOTAsMTIgQEAgYm9vbCBBcHBsaWNhdGlvbkNhY2hlSG9zdDo6 Y2FuQ2FjaGVJblBhZ2VDYWNoZSgpIGNvbnN0CiAgICAgcmV0dXJuIGZhbHNlOwogfQogCitib29s IEFwcGxpY2F0aW9uQ2FjaGVIb3N0Ojppc0ZhbGxiYWNrT3JOZXR3b3JrUmVzb3VyY2UoY29uc3Qg S1VSTCYpIGNvbnN0Cit7CisgICAgLy8gTi9BIHRvIHRoZSBjaHJvbWl1bSBwb3J0IHdoaWNoIGRv ZXNuJ3QgdXNlIHRoZSBwYWdlIGNhY2hlLgorICAgIHJldHVybiBmYWxzZTsKK30KKwogdm9pZCBB cHBsaWNhdGlvbkNhY2hlSG9zdDo6c2V0RE9NQXBwbGljYXRpb25DYWNoZShET01BcHBsaWNhdGlv bkNhY2hlKiBkb21BcHBsaWNhdGlvbkNhY2hlKQogewogICAgIEFTU0VSVCghbV9kb21BcHBsaWNh dGlvbkNhY2hlIHx8ICFkb21BcHBsaWNhdGlvbkNhY2hlKTsK