42042 2010-07-11 05:42:54 -0700 An empty value for xml:lang isn't considered 2010-08-13 18:01:11 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) All All RESOLVED FIXED http://www.w3.org/TR/REC-xml/#sec-lang-tag EasyFix, HasReduction P2 Normal --- 1 me webkit-unassigned abarth ap eric mitz rwlbuis webkit.review.bot oldest_to_newest 249619 0 61175 me 2010-07-11 05:42:54 -0700 Created attachment 61175 Test case for xml:lang According to the XML spec xml:lang="" is valid and declares that no language information is available. Webkit currently ignores empty values of xml:lang when applying styles. Firefox works as expected. I attached a test case. 249652 1 mitz 2010-07-11 14:35:24 -0700 I think the issue here is that the CSSSelector::PseudoLang case of checkOneSelector() uses value.isEmpty() in a couple of places where it should use value.isNull(). 252061 2 61706 rwlbuis 2010-07-15 13:33:07 -0700 Created attachment 61706 Patch Matches FireFox and Opera behaviour for :lang and empty lang attributes. 252083 3 61706 mitz 2010-07-15 13:50:29 -0700 Comment on attachment 61706 Patch > - if (value.isEmpty() || !value.startsWith(argument, false)) > + if (value.isNull() || !value.startsWith(argument, false)) Why is this change needed or desirable? 252338 4 rwlbuis 2010-07-15 22:44:43 -0700 Hi Mitz, (In reply to comment #3) > (From update of attachment 61706 [details]) > > - if (value.isEmpty() || !value.startsWith(argument, false)) > > + if (value.isNull() || !value.startsWith(argument, false)) > > Why is this change needed or desirable? Coming out of the loop, value.isEmpty() now means an acceptable value where we can test the :lang selector against, and value.isNull() means no lang value found, so we can break. Cheers, Rob. 252357 5 mitz 2010-07-15 23:49:21 -0700 (In reply to comment #4) > Hi Mitz, > > (In reply to comment #3) > > (From update of attachment 61706 [details] [details]) > > > - if (value.isEmpty() || !value.startsWith(argument, false)) > > > + if (value.isNull() || !value.startsWith(argument, false)) > > > > Why is this change needed or desirable? > > Coming out of the loop, value.isEmpty() now means an acceptable value where we can test > the :lang selector against, and value.isNull() means no lang value found, so we can break. Can you add a test for this? 252555 6 61815 rwlbuis 2010-07-16 09:28:28 -0700 Created attachment 61815 Patch Adapted testcase to incorporate Mitz' request. 252579 7 mitz 2010-07-16 10:18:29 -0700 I’m still confused. I updated to r63560, then I changed CSSStyleSelector.cpp:2616 back from isNull() to isEmpty() and built, then ran the test fast/css/lang-selector-empty-attribute.xhtml . The test still passes. What am I missing? 252684 8 rwlbuis 2010-07-16 13:42:52 -0700 (In reply to comment #7) > I’m still confused. I updated to r63560, then I changed CSSStyleSelector.cpp:2616 back from isNull() to isEmpty() and built, then ran the test fast/css/lang-selector-empty-attribute.xhtml . The test still passes. What am I missing? I can confirm, sorry about that. I'll debug tomorrow, maybe fastGetAttribute returns something different then I assumed,... Cheers, Rob. 263019 9 abarth 2010-08-10 22:37:41 -0700 This appears to have been landed. 263033 10 ap 2010-08-10 22:46:18 -0700 Yes, <http://trac.webkit.org/changeset/63560>. Rob, could you find out an answer to the question in comment 7? 263389 11 rwlbuis 2010-08-11 12:28:57 -0700 Hi, (In reply to comment #10) > Yes, <http://trac.webkit.org/changeset/63560>. > > Rob, could you find out an answer to the question in comment 7? Right, sorry, did not get to it before my summer vacation. Now that I look at it again, the change may not have been needed indeed, I mean the last isEmpty -> isNull change in my patch. Basically empty values (as well as null values) can never match the :lang selector, since at least the way we parse it it can't be empty, i.e. length > 0, so the original way to break early there seems fine to me. The only reason why that part of the patch worked, is that empty values will fail on the next if statement and so a break will be done as before, just (unneededly so) a bit later. I'll create a correcting patch soon. Cheers, Rob. 263411 12 64152 rwlbuis 2010-08-11 12:59:46 -0700 Created attachment 64152 correction patch 263413 13 rwlbuis 2010-08-11 13:01:15 -0700 Reopening because comment 7 needs to cleared first. 263415 14 64152 mitz 2010-08-11 13:02:35 -0700 Comment on attachment 64152 correction patch Thank you! 263459 15 webkit.review.bot 2010-08-11 14:40:49 -0700 http://trac.webkit.org/changeset/65182 might have broken Leopard Intel Release (Tests) The following changes are on the blame list: http://trac.webkit.org/changeset/65182 http://trac.webkit.org/changeset/65183 61175 2010-07-11 05:42:54 -0700 2010-07-11 05:42:54 -0700 Test case for xml:lang testxmllang.xhtml application/xhtml+xml 701 me PD94bWwgdmVyc2lvbj0iMS4wIiBlbmNvZGluZz0iVVRGLTgiID8+CjwhRE9DVFlQRSBodG1sIFBV QkxJQyAiLS8vVzNDLy9EVEQgWEhUTUwgMS4xLy9FTiIKICAgICJodHRwOi8vd3d3LnczLm9yZy9U Ui94aHRtbDExL0RURC94aHRtbDExLmR0ZCI+CjxodG1sIHhtbG5zPSJodHRwOi8vd3d3LnczLm9y Zy8xOTk5L3hodG1sIiB4bWw6bGFuZz0iZW4iPgoJPGhlYWQ+CgkJPHN0eWxlIHR5cGU9InRleHQv Y3NzIj4KCQkJc3BhbiB7YmFja2dyb3VuZDogd2hpdGV9CgkJCXNwYW46bGFuZyhlbikge2JhY2tn cm91bmQ6IGdyZWVufQoJCQlzcGFuOmxhbmcoZXMpIHtiYWNrZ3JvdW5kOiBsaW1lfQoJCQlzcGFu OmxhbmcoZGUpIHtiYWNrZ3JvdW5kOiByZWR9CgkJPC9zdHlsZT4KCQk8dGl0bGU+U2ltcGxlIHht bDpsYW5nIHRlc3Q8L3RpdGxlPgoJPC9oZWFkPgoJPGJvZHk+CgkJPHA+VGVzdHMgbG9jYWwgZGVm aW5pdGlvbiBvZiB4bWw6bGFuZy48L3A+CgkJPHA+PHNwYW4geG1sOmxhbmc9ImVzIj5UaGlzIGxp bmUgc2hvdWxkIGJlIGxpbWUuPC9zcGFuPjwvcD4KCQk8cD5UZXN0cyBpZiBlbXB0eSBsYW5ndWFn ZSBkZWNsYXJhdGlvbnMgYXJlIHN1cHBvcnRlZDwvcD4KCQk8cCB4bWw6bGFuZz0iZGUiPgoJCQk8 c3BhbiB4bWw6bGFuZz0iIj5UaGlzIGxpbmUgc2hvdWxkIGJlIHdoaXRlLjwvc3Bhbj4KCQk8L3A+ Cgk8L2JvZHk+CjwvaHRtbD4= 61706 2010-07-15 13:33:07 -0700 2010-07-16 09:28:19 -0700 Patch bug-42042-20100715223605.patch text/plain 5041 rwlbuis ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBkZWE2MjBhZWZlZTYyYTk2MWE4NjY2NTEzZGVjYzI2MzI5ZjM5ZThlLi5jN2NkMWZi MTQ2YjhmZTU4YjBhODZiMTc4MzdmOTQ1YmQxYWM0NThiIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAK KzIwMTAtMDctMTUgIFJvYiBCdWlzICA8cndsYnVpc0BnbWFpbC5jb20+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIHRlc3QgZm9yOgorICAgICAg ICBBbiBlbXB0eSB2YWx1ZSBmb3IgeG1sOmxhbmcgaXNuJ3QgY29uc2lkZXJlZAorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDIwNDIKKworICAgICAgICAq IGZhc3QvY3NzL2xhbmctc2VsZWN0b3ItZW1wdHktYXR0cmlidXRlLWV4cGVjdGVkLnR4dDogQWRk ZWQuCisgICAgICAgICogZmFzdC9jc3MvbGFuZy1zZWxlY3Rvci1lbXB0eS1hdHRyaWJ1dGUueGh0 bWw6IEFkZGVkLgorCiAyMDEwLTA3LTE1ICBOaWtvbGFzIFppbW1lcm1hbm4gIDxuemltbWVybWFu bkByaW0uY29tPgogCiAgICAgICAgIFJ1YmJlci1zdGFtcGVkIGJ5IERpcmsgU2NodWx6ZS4KZGlm ZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvY3NzL2xhbmctc2VsZWN0b3ItZW1wdHktYXR0cmli dXRlLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Zhc3QvY3NzL2xhbmctc2VsZWN0b3ItZW1w dHktYXR0cmlidXRlLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi4xOTBlNzgxZjY5NTdiMWQ1M2Yy ZmYzN2UzMDk4NTRmYzJiODk4NzczCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFz dC9jc3MvbGFuZy1zZWxlY3Rvci1lbXB0eS1hdHRyaWJ1dGUtZXhwZWN0ZWQudHh0CkBAIC0wLDAg KzEsMyBAQAorVGVzdHMgaWYgZW1wdHkgbGFuZ3VhZ2UgZGVjbGFyYXRpb25zIGFyZSBzdXBwb3J0 ZWQKKworU1VDQ0VTUwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9jc3MvbGFuZy1zZWxl Y3Rvci1lbXB0eS1hdHRyaWJ1dGUueGh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2Nzcy9sYW5nLXNl bGVjdG9yLWVtcHR5LWF0dHJpYnV0ZS54aHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5kMTM3MWI5MzQxYjE5NDA5 MmJlMjFlYWE0ZTdlZDFkYzhkNWIxNWU4Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMv ZmFzdC9jc3MvbGFuZy1zZWxlY3Rvci1lbXB0eS1hdHRyaWJ1dGUueGh0bWwKQEAgLTAsMCArMSwz NCBAQAorPGh0bWwgeG1sbnM9Imh0dHA6Ly93d3cudzMub3JnLzE5OTkveGh0bWwiPgorICA8aGVh ZD4KKyAgICA8c3R5bGUgdHlwZT0idGV4dC9jc3MiPgorICAgICAgc3BhbiB7YmFja2dyb3VuZDog d2hpdGU7ZGlzcGxheTpub25lfQorICAgICAgc3BhbjpsYW5nKGRlKSB7YmFja2dyb3VuZDogcmVk fQorICAgIDwvc3R5bGU+CisgICAgPHNjcmlwdD4KKyAgICAgIGZ1bmN0aW9uIGxvZyhtZXNzYWdl KSB7CisgICAgICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJjb25zb2xlIikuaW5uZXJIVE1M ICs9IG1lc3NhZ2U7CisgICAgICB9CisKKyAgICAgIGZ1bmN0aW9uIHRlc3QoKSB7CisgICAgICAg IGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCisgICAgICAgICAgICBsYXlvdXRUZXN0 Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7CisKKyAgICAgICAgdmFyIGkgPSBkb2N1bWVudC5nZXRF bGVtZW50QnlJZCgiZW1wdHlMYW5nIik7CisgICAgICAgIHZhciBpMiA9IGRvY3VtZW50LmdldEVs ZW1lbnRCeUlkKCJlbXB0eVhtbExhbmciKTsKKyAgICAgICAgaWYgKGRvY3VtZW50LmRlZmF1bHRW aWV3LmdldENvbXB1dGVkU3R5bGUoaSwgbnVsbCkuZ2V0UHJvcGVydHlWYWx1ZSgnYmFja2dyb3Vu ZC1jb2xvcicpID09ICJyZ2IoMjU1LCAyNTUsIDI1NSkiICZhbXA7JmFtcDsKKyAgICAgICAgICAg IGRvY3VtZW50LmRlZmF1bHRWaWV3LmdldENvbXB1dGVkU3R5bGUoaTIsIG51bGwpLmdldFByb3Bl cnR5VmFsdWUoJ2JhY2tncm91bmQtY29sb3InKSA9PSAicmdiKDI1NSwgMjU1LCAyNTUpIikKKyAg ICAgICAgICAgIGxvZygiU1VDQ0VTUyIpOworICAgICAgICBlbHNlCisgICAgICAgICAgICBsb2co IkZBSUxVUkUiKTsKKyAgICAgIH0KKyAgICA8L3NjcmlwdD4KKyAgPC9oZWFkPgorICA8Ym9keSBv bmxvYWQ9InRlc3QoKSI+CisgICAgPHA+VGVzdHMgaWYgZW1wdHkgbGFuZ3VhZ2UgZGVjbGFyYXRp b25zIGFyZSBzdXBwb3J0ZWQ8L3A+CisgICAgPHAgeG1sOmxhbmc9ImRlIj4KKyAgICAgIDxzcGFu IGxhbmc9IiIgaWQ9ImVtcHR5TGFuZyIvPgorICAgICAgPHNwYW4geG1sOmxhbmc9IiIgaWQ9ImVt cHR5WG1sTGFuZyIvPgorICAgIDwvcD4KKyAgICA8ZGl2IGlkPSJjb25zb2xlIj48L2Rpdj4KKyAg PC9ib2R5PgorPC9odG1sPgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3Jl L0NoYW5nZUxvZwppbmRleCAwYTk0NGM1NjlkNDE0NzlkNzgzNTQzODY0MDkzOWM4OTBkYTNhMjRm Li4zYWUzNmJlM2ZlMGMyMjhhYzMyOWQxMTg5OTA1MjE4NTc3NjEzYmQxIDEwMDY0NAotLS0gYS9X ZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBA CisyMDEwLTA3LTE1ICBSb2IgQnVpcyAgPHJ3bGJ1aXNAZ21haWwuY29tPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFuIGVtcHR5IHZhbHVlIGZvciB4 bWw6bGFuZyBpc24ndCBjb25zaWRlcmVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD00MjA0MgorCisgICAgICAgIEFsbG93IDpsYW5nIHNlbGVjdG9yIHRv IG1hdGNoIGVtcHR5IHZhbHVlcyBmb3IgeG1sOmxhbmcgYW5kCisgICAgICAgIGxhbmcgYXR0cmli dXRlcy4KKworICAgICAgICBUZXN0OiBmYXN0L2Nzcy9sYW5nLXNlbGVjdG9yLWVtcHR5LWF0dHJp YnV0ZS54aHRtbAorCisgICAgICAgICogY3NzL0NTU1N0eWxlU2VsZWN0b3IuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6Q1NTU3R5bGVTZWxlY3Rvcjo6U2VsZWN0b3JDaGVja2VyOjpjaGVja09uZVNl bGVjdG9yKToKKwogMjAxMC0wNy0xNSAgTmlrb2xhcyBaaW1tZXJtYW5uICA8bnppbW1lcm1hbm5A cmltLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBFcmljIFNlaWRlbC4KZGlmZiAtLWdpdCBh L1dlYkNvcmUvY3NzL0NTU1N0eWxlU2VsZWN0b3IuY3BwIGIvV2ViQ29yZS9jc3MvQ1NTU3R5bGVT ZWxlY3Rvci5jcHAKaW5kZXggZjk4Njk3MGZmZGZkM2FjOGY2ZmVkNWQzNmM4ZTBjYWZhOTU3ODM5 Ni4uNTRiZDcxMmQ3NDA0YzI1ZmQ3MWM3ZjViYzgwZmU3MGQxYjUwNWQ0OSAxMDA2NDQKLS0tIGEv V2ViQ29yZS9jc3MvQ1NTU3R5bGVTZWxlY3Rvci5jcHAKKysrIGIvV2ViQ29yZS9jc3MvQ1NTU3R5 bGVTZWxlY3Rvci5jcHAKQEAgLTI2MDAsMTEgKzI2MDAsMTEgQEAgYm9vbCBDU1NTdHlsZVNlbGVj dG9yOjpTZWxlY3RvckNoZWNrZXI6OmNoZWNrT25lU2VsZWN0b3IoQ1NTU2VsZWN0b3IqIHNlbCwg RWxlbWUKICAgICAgICAgICAgICAgICBBdG9taWNTdHJpbmcgdmFsdWU7CiAgICAgICAgICAgICAg ICAgLy8gVGhlIGxhbmd1YWdlIHByb3BlcnR5IGlzIGluaGVyaXRlZCwgc28gd2UgaXRlcmF0ZSBv dmVyIHRoZSBwYXJlbnRzCiAgICAgICAgICAgICAgICAgLy8gdG8gZmluZCB0aGUgZmlyc3QgbGFu Z3VhZ2UuCi0gICAgICAgICAgICAgICAgd2hpbGUgKG4gJiYgdmFsdWUuaXNFbXB0eSgpKSB7Cisg ICAgICAgICAgICAgICAgd2hpbGUgKG4gJiYgdmFsdWUuaXNOdWxsKCkpIHsKICAgICAgICAgICAg ICAgICAgICAgaWYgKG4tPmlzRWxlbWVudE5vZGUoKSkgewogICAgICAgICAgICAgICAgICAgICAg ICAgLy8gU3BlYzogeG1sOmxhbmcgdGFrZXMgcHJlY2VkZW5jZSAtLSBodHRwOi8vd3d3LnczLm9y Zy9UUi94aHRtbDEvI0NfNwogICAgICAgICAgICAgICAgICAgICAgICAgdmFsdWUgPSBzdGF0aWNf Y2FzdDxFbGVtZW50Kj4obiktPmZhc3RHZXRBdHRyaWJ1dGUoWE1MTmFtZXM6OmxhbmdBdHRyKTsK LSAgICAgICAgICAgICAgICAgICAgICAgIGlmICh2YWx1ZS5pc0VtcHR5KCkpCisgICAgICAgICAg ICAgICAgICAgICAgICBpZiAodmFsdWUuaXNOdWxsKCkpCiAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgdmFsdWUgPSBzdGF0aWNfY2FzdDxFbGVtZW50Kj4obiktPmZhc3RHZXRBdHRyaWJ1dGUo bGFuZ0F0dHIpOwogICAgICAgICAgICAgICAgICAgICB9IGVsc2UgaWYgKG4tPmlzRG9jdW1lbnRO b2RlKCkpCiAgICAgICAgICAgICAgICAgICAgICAgICAvLyBjaGVja2luZyB0aGUgTUlNRSBjb250 ZW50LWxhbmd1YWdlCkBAIC0yNjEzLDcgKzI2MTMsNyBAQCBib29sIENTU1N0eWxlU2VsZWN0b3I6 OlNlbGVjdG9yQ2hlY2tlcjo6Y2hlY2tPbmVTZWxlY3RvcihDU1NTZWxlY3Rvciogc2VsLCBFbGVt ZQogICAgICAgICAgICAgICAgICAgICBuID0gbi0+cGFyZW50KCk7CiAgICAgICAgICAgICAgICAg fQogICAgICAgICAgICAgICAgIGNvbnN0IEF0b21pY1N0cmluZyYgYXJndW1lbnQgPSBzZWwtPmFy Z3VtZW50KCk7Ci0gICAgICAgICAgICAgICAgaWYgKHZhbHVlLmlzRW1wdHkoKSB8fCAhdmFsdWUu c3RhcnRzV2l0aChhcmd1bWVudCwgZmFsc2UpKQorICAgICAgICAgICAgICAgIGlmICh2YWx1ZS5p c051bGwoKSB8fCAhdmFsdWUuc3RhcnRzV2l0aChhcmd1bWVudCwgZmFsc2UpKQogICAgICAgICAg ICAgICAgICAgICBicmVhazsKICAgICAgICAgICAgICAgICBpZiAodmFsdWUubGVuZ3RoKCkgIT0g YXJndW1lbnQubGVuZ3RoKCkgJiYgdmFsdWVbYXJndW1lbnQubGVuZ3RoKCldICE9ICctJykKICAg ICAgICAgICAgICAgICAgICAgYnJlYWs7Cg== 61815 2010-07-16 09:28:28 -0700 2010-08-11 12:59:39 -0700 Patch bug-42042-20100716183127.patch text/plain 5378 rwlbuis ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAwMzRkNGQwMDk2NGFkZWNmOWNlYzlmNGU4NDY4Mjk5NjA3OWJkMmFlLi4wZGU5Yjg3 NjNlNGE5MjFjY2NmZGYyNmNiNjIwYmEwMmU4M2Y5NmY2IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAK KzIwMTAtMDctMTUgIFJvYiBCdWlzICA8cndsYnVpc0BnbWFpbC5jb20+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIHRlc3QgZm9yOgorICAgICAg ICBBbiBlbXB0eSB2YWx1ZSBmb3IgeG1sOmxhbmcgaXNuJ3QgY29uc2lkZXJlZAorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDIwNDIKKworICAgICAgICAq IGZhc3QvY3NzL2xhbmctc2VsZWN0b3ItZW1wdHktYXR0cmlidXRlLWV4cGVjdGVkLnR4dDogQWRk ZWQuCisgICAgICAgICogZmFzdC9jc3MvbGFuZy1zZWxlY3Rvci1lbXB0eS1hdHRyaWJ1dGUueGh0 bWw6IEFkZGVkLgorCiAyMDEwLTA3LTE2ICBQYXZlbCBQb2Rpdmlsb3YgIDxwb2Rpdmlsb3ZAY2hy b21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFl1cnkgU2VtaWtoYXRza3kuCmRpZmYg LS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2Nzcy9sYW5nLXNlbGVjdG9yLWVtcHR5LWF0dHJpYnV0 ZS1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9mYXN0L2Nzcy9sYW5nLXNlbGVjdG9yLWVtcHR5 LWF0dHJpYnV0ZS1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uMTkwZTc4MWY2OTU3YjFkNTNmMmZm MzdlMzA5ODU0ZmMyYjg5ODc3MwotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3Qv Y3NzL2xhbmctc2VsZWN0b3ItZW1wdHktYXR0cmlidXRlLWV4cGVjdGVkLnR4dApAQCAtMCwwICsx LDMgQEAKK1Rlc3RzIGlmIGVtcHR5IGxhbmd1YWdlIGRlY2xhcmF0aW9ucyBhcmUgc3VwcG9ydGVk CisKK1NVQ0NFU1MKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvY3NzL2xhbmctc2VsZWN0 b3ItZW1wdHktYXR0cmlidXRlLnhodG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9jc3MvbGFuZy1zZWxl Y3Rvci1lbXB0eS1hdHRyaWJ1dGUueGh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uMmYzOWU2MTIzMDNmNDdlNDYz MTJiMTUxOWNmNzM4MDVmNmYyODY4MwotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zh c3QvY3NzL2xhbmctc2VsZWN0b3ItZW1wdHktYXR0cmlidXRlLnhodG1sCkBAIC0wLDAgKzEsNDQg QEAKKzxodG1sIHhtbG5zPSJodHRwOi8vd3d3LnczLm9yZy8xOTk5L3hodG1sIj4KKyAgPGhlYWQ+ CisgICAgPHN0eWxlIHR5cGU9InRleHQvY3NzIj4KKyAgICAgIHNwYW4ge2JhY2tncm91bmQ6IHdo aXRlO2Rpc3BsYXk6bm9uZX0KKyAgICAgIHNwYW46bGFuZyhkZSkge2JhY2tncm91bmQ6IHJlZH0K KyAgICA8L3N0eWxlPgorICAgIDxzY3JpcHQ+CisgICAgICBmdW5jdGlvbiBsb2cobWVzc2FnZSkg eworICAgICAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgiY29uc29sZSIpLmlubmVySFRNTCAr PSBtZXNzYWdlOworICAgICAgfQorCisgICAgICBmdW5jdGlvbiB0ZXN0KCkgeworICAgICAgICBp ZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKQorICAgICAgICAgICAgbGF5b3V0VGVzdENv bnRyb2xsZXIuZHVtcEFzVGV4dCgpOworCisgICAgICAgIHZhciBpID0gZG9jdW1lbnQuZ2V0RWxl bWVudEJ5SWQoImVtcHR5TGFuZyIpOworICAgICAgICBpZiAoZG9jdW1lbnQuZGVmYXVsdFZpZXcu Z2V0Q29tcHV0ZWRTdHlsZShpLCBudWxsKS5nZXRQcm9wZXJ0eVZhbHVlKCdiYWNrZ3JvdW5kLWNv bG9yJykgIT0gInJnYigyNTUsIDI1NSwgMjU1KSIpIHsKKyAgICAgICAgICAgIGxvZygiRkFJTFVS RSIpOworICAgICAgICAgICAgcmV0dXJuOworICAgICAgICB9CisgICAgICAgIHZhciBpMiA9IGRv Y3VtZW50LmdldEVsZW1lbnRCeUlkKCJlbXB0eVhtbExhbmciKTsKKyAgICAgICAgaWYgKGRvY3Vt ZW50LmRlZmF1bHRWaWV3LmdldENvbXB1dGVkU3R5bGUoaTIsIG51bGwpLmdldFByb3BlcnR5VmFs dWUoJ2JhY2tncm91bmQtY29sb3InKSAhPSAicmdiKDI1NSwgMjU1LCAyNTUpIikgeworICAgICAg ICAgICAgbG9nKCJGQUlMVVJFIik7CisgICAgICAgICAgICByZXR1cm47CisgICAgICAgfQorICAg ICAgICB2YXIgaTMgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgibm9MYW5nIik7CisgICAgICAg IGlmIChkb2N1bWVudC5kZWZhdWx0Vmlldy5nZXRDb21wdXRlZFN0eWxlKGkzLCBudWxsKS5nZXRQ cm9wZXJ0eVZhbHVlKCdiYWNrZ3JvdW5kLWNvbG9yJykgIT0gInJnYigyNTUsIDAsIDApIikgewor ICAgICAgICAgICAgbG9nKCJGQUlMVVJFIik7CisgICAgICAgICAgICByZXR1cm47CisgICAgICAg IH0KKyAgICAgICAgbG9nKCJTVUNDRVNTIik7CisgICAgICB9CisgICAgPC9zY3JpcHQ+CisgIDwv aGVhZD4KKyAgPGJvZHkgb25sb2FkPSJ0ZXN0KCkiPgorICAgIDxwPlRlc3RzIGlmIGVtcHR5IGxh bmd1YWdlIGRlY2xhcmF0aW9ucyBhcmUgc3VwcG9ydGVkPC9wPgorICAgIDxwIHhtbDpsYW5nPSJk ZSI+CisgICAgICA8c3BhbiBsYW5nPSIiIGlkPSJlbXB0eUxhbmciLz4KKyAgICAgIDxzcGFuIHht bDpsYW5nPSIiIGlkPSJlbXB0eVhtbExhbmciLz4KKyAgICAgIDxzcGFuIGlkPSJub0xhbmciLz4K KyAgICA8L3A+CisgICAgPGRpdiBpZD0iY29uc29sZSI+PC9kaXY+CisgIDwvYm9keT4KKzwvaHRt bD4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5k ZXggMmI5M2QzMGNiMGQ1ZTk5MzhjNzRiNTY3Mzk2YzgxMjc0NjJhNDc5NS4uMDQxOGVkYzRkOGM5 MDI2MTcxYmUzMjY4YTQyYjNhMWM3OTk1NzI1MSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VM b2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMC0wNy0xNSAg Um9iIEJ1aXMgIDxyd2xidWlzQGdtYWlsLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBBbiBlbXB0eSB2YWx1ZSBmb3IgeG1sOmxhbmcgaXNuJ3Qg Y29uc2lkZXJlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NDIwNDIKKworICAgICAgICBBbGxvdyA6bGFuZyBzZWxlY3RvciB0byBtYXRjaCBlbXB0eSB2 YWx1ZXMgZm9yIHhtbDpsYW5nIGFuZAorICAgICAgICBsYW5nIGF0dHJpYnV0ZXMuCisKKyAgICAg ICAgVGVzdDogZmFzdC9jc3MvbGFuZy1zZWxlY3Rvci1lbXB0eS1hdHRyaWJ1dGUueGh0bWwKKwor ICAgICAgICAqIGNzcy9DU1NTdHlsZVNlbGVjdG9yLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNT U1N0eWxlU2VsZWN0b3I6OlNlbGVjdG9yQ2hlY2tlcjo6Y2hlY2tPbmVTZWxlY3Rvcik6CisKIDIw MTAtMDctMTYgIEx1Y2FzIERlIE1hcmNoaSAgPGx1Y2FzLmRlbWFyY2hpQHByb2Z1c2lvbi5tb2Jp PgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFudG9uaW8gR29tZXMuCmRpZmYgLS1naXQgYS9XZWJD b3JlL2Nzcy9DU1NTdHlsZVNlbGVjdG9yLmNwcCBiL1dlYkNvcmUvY3NzL0NTU1N0eWxlU2VsZWN0 b3IuY3BwCmluZGV4IGNjNDg0MWRhMDc2YTk3NjU0Y2FhMWMwNWY5ODhjNTJkZTkyZjljODkuLjAx ODRkMTUxZDcxMGQ2NGYyMTBkODIyM2IwNzI5MTg1ZTY1Yzc0MjQgMTAwNjQ0Ci0tLSBhL1dlYkNv cmUvY3NzL0NTU1N0eWxlU2VsZWN0b3IuY3BwCisrKyBiL1dlYkNvcmUvY3NzL0NTU1N0eWxlU2Vs ZWN0b3IuY3BwCkBAIC0yNjAwLDExICsyNjAwLDExIEBAIGJvb2wgQ1NTU3R5bGVTZWxlY3Rvcjo6 U2VsZWN0b3JDaGVja2VyOjpjaGVja09uZVNlbGVjdG9yKENTU1NlbGVjdG9yKiBzZWwsIEVsZW1l CiAgICAgICAgICAgICAgICAgQXRvbWljU3RyaW5nIHZhbHVlOwogICAgICAgICAgICAgICAgIC8v IFRoZSBsYW5ndWFnZSBwcm9wZXJ0eSBpcyBpbmhlcml0ZWQsIHNvIHdlIGl0ZXJhdGUgb3ZlciB0 aGUgcGFyZW50cwogICAgICAgICAgICAgICAgIC8vIHRvIGZpbmQgdGhlIGZpcnN0IGxhbmd1YWdl LgotICAgICAgICAgICAgICAgIHdoaWxlIChuICYmIHZhbHVlLmlzRW1wdHkoKSkgeworICAgICAg ICAgICAgICAgIHdoaWxlIChuICYmIHZhbHVlLmlzTnVsbCgpKSB7CiAgICAgICAgICAgICAgICAg ICAgIGlmIChuLT5pc0VsZW1lbnROb2RlKCkpIHsKICAgICAgICAgICAgICAgICAgICAgICAgIC8v IFNwZWM6IHhtbDpsYW5nIHRha2VzIHByZWNlZGVuY2UgLS0gaHR0cDovL3d3dy53My5vcmcvVFIv eGh0bWwxLyNDXzcKICAgICAgICAgICAgICAgICAgICAgICAgIHZhbHVlID0gc3RhdGljX2Nhc3Q8 RWxlbWVudCo+KG4pLT5mYXN0R2V0QXR0cmlidXRlKFhNTE5hbWVzOjpsYW5nQXR0cik7Ci0gICAg ICAgICAgICAgICAgICAgICAgICBpZiAodmFsdWUuaXNFbXB0eSgpKQorICAgICAgICAgICAgICAg ICAgICAgICAgaWYgKHZhbHVlLmlzTnVsbCgpKQogICAgICAgICAgICAgICAgICAgICAgICAgICAg IHZhbHVlID0gc3RhdGljX2Nhc3Q8RWxlbWVudCo+KG4pLT5mYXN0R2V0QXR0cmlidXRlKGxhbmdB dHRyKTsKICAgICAgICAgICAgICAgICAgICAgfSBlbHNlIGlmIChuLT5pc0RvY3VtZW50Tm9kZSgp KQogICAgICAgICAgICAgICAgICAgICAgICAgLy8gY2hlY2tpbmcgdGhlIE1JTUUgY29udGVudC1s YW5ndWFnZQpAQCAtMjYxMyw3ICsyNjEzLDcgQEAgYm9vbCBDU1NTdHlsZVNlbGVjdG9yOjpTZWxl Y3RvckNoZWNrZXI6OmNoZWNrT25lU2VsZWN0b3IoQ1NTU2VsZWN0b3IqIHNlbCwgRWxlbWUKICAg ICAgICAgICAgICAgICAgICAgbiA9IG4tPnBhcmVudCgpOwogICAgICAgICAgICAgICAgIH0KICAg ICAgICAgICAgICAgICBjb25zdCBBdG9taWNTdHJpbmcmIGFyZ3VtZW50ID0gc2VsLT5hcmd1bWVu dCgpOwotICAgICAgICAgICAgICAgIGlmICh2YWx1ZS5pc0VtcHR5KCkgfHwgIXZhbHVlLnN0YXJ0 c1dpdGgoYXJndW1lbnQsIGZhbHNlKSkKKyAgICAgICAgICAgICAgICBpZiAodmFsdWUuaXNOdWxs KCkgfHwgIXZhbHVlLnN0YXJ0c1dpdGgoYXJndW1lbnQsIGZhbHNlKSkKICAgICAgICAgICAgICAg ICAgICAgYnJlYWs7CiAgICAgICAgICAgICAgICAgaWYgKHZhbHVlLmxlbmd0aCgpICE9IGFyZ3Vt ZW50Lmxlbmd0aCgpICYmIHZhbHVlW2FyZ3VtZW50Lmxlbmd0aCgpXSAhPSAnLScpCiAgICAgICAg ICAgICAgICAgICAgIGJyZWFrOwo= 64152 2010-08-11 12:59:46 -0700 2010-08-11 13:02:35 -0700 correction patch bug-42042-20100811220312.patch text/plain 1611 rwlbuis ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZmUxZDg5YWQ5NTVkMWIzOTAxZTFhZDYyNDNmNTJiNjBlMjhlODdiNS4uOGM2YTg2ZGMxZGVjNzBi NTM0MTMxZWYyODBjZDY0ZTg1ZjZkOTQyYSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxMC0wOC0xMSAgUm9i IEJ1aXMgIDxyd2xidWlzQGdtYWlsLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NDIwNDIKKyAgICAgICAgQW4gZW1wdHkgdmFsdWUgZm9yIHhtbDpsYW5nIGlzbid0IGNvbnNp ZGVyZWQKKworICAgICAgICBSZXZlcnQgbGFzdCBsaW5lIGNoYW5nZSBvZiBteSBwYXRjaCA7IGl0 IGhhcHBlbnMgdG8KKyAgICAgICAgYmVoYXZlIGNvcnJlY3RseSBhbmQgc2FtZSBhcyBiZWZvcmUs IGJ1dCBtYWtlcyB0aGUKKyAgICAgICAgdXNlIGNhc2Ugb2YgZW1wdHkgdmFsdWVzIHVubmVlZGVk bHkgc2xvd2VyLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4gKE5vIGNoYW5nZSBpbiBiZWhhdmlv cikKKworICAgICAgICAqIGNzcy9DU1NTdHlsZVNlbGVjdG9yLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OkNTU1N0eWxlU2VsZWN0b3I6OlNlbGVjdG9yQ2hlY2tlcjo6Y2hlY2tPbmVTZWxlY3Rvcik6 CisKIDIwMTAtMDgtMTEgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAogICAgICAg ICBSdWJiZXItc3RhbXBlZCBieSBFcmljIFNlaWRlbC4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvY3Nz L0NTU1N0eWxlU2VsZWN0b3IuY3BwIGIvV2ViQ29yZS9jc3MvQ1NTU3R5bGVTZWxlY3Rvci5jcHAK aW5kZXggYzNmNTE1OTVlYTM5MDE3ZjQ0MmYyNjM2ZTAzYjljOTgyYWY3MGY0ZC4uMmRhNDIyMjcy ODI2ZGZlYTc0MTBhMGFjMDk5MmRjY2Y4MTA5MDAwMiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9jc3Mv Q1NTU3R5bGVTZWxlY3Rvci5jcHAKKysrIGIvV2ViQ29yZS9jc3MvQ1NTU3R5bGVTZWxlY3Rvci5j cHAKQEAgLTI2MTcsNyArMjYxNyw3IEBAIGJvb2wgQ1NTU3R5bGVTZWxlY3Rvcjo6U2VsZWN0b3JD aGVja2VyOjpjaGVja09uZVNlbGVjdG9yKENTU1NlbGVjdG9yKiBzZWwsIEVsZW1lCiAgICAgICAg ICAgICAgICAgICAgIG4gPSBuLT5wYXJlbnQoKTsKICAgICAgICAgICAgICAgICB9CiAgICAgICAg ICAgICAgICAgY29uc3QgQXRvbWljU3RyaW5nJiBhcmd1bWVudCA9IHNlbC0+YXJndW1lbnQoKTsK LSAgICAgICAgICAgICAgICBpZiAodmFsdWUuaXNOdWxsKCkgfHwgIXZhbHVlLnN0YXJ0c1dpdGgo YXJndW1lbnQsIGZhbHNlKSkKKyAgICAgICAgICAgICAgICBpZiAodmFsdWUuaXNFbXB0eSgpIHx8 ICF2YWx1ZS5zdGFydHNXaXRoKGFyZ3VtZW50LCBmYWxzZSkpCiAgICAgICAgICAgICAgICAgICAg IGJyZWFrOwogICAgICAgICAgICAgICAgIGlmICh2YWx1ZS5sZW5ndGgoKSAhPSBhcmd1bWVudC5s ZW5ndGgoKSAmJiB2YWx1ZVthcmd1bWVudC5sZW5ndGgoKV0gIT0gJy0nKQogICAgICAgICAgICAg ICAgICAgICBicmVhazsK