42032 2010-07-10 15:13:58 -0700 Need to emulate MAX_VARYING_VECTORS/MAX_FRAGMENT_UNIFORM_VECTORs/MAX_VERTEX_UNIFORM_VECTORS for glGet 2010-07-13 10:23:46 -0700 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 zmo zmo abarth cmarrin dglazkov eric kbr oliver webkit.review.bot oldest_to_newest 249562 0 zmo 2010-07-10 15:13:58 -0700 In desktop gl, the corresponding enums are MAX_VARYING_FLOATS/MAX_FRAGMENT_UNIFORM_COMPONENTS/MAX_VERTEX_UNIFORM_COMPONENTS. The difference is a multitude of 4. 249563 1 61162 zmo 2010-07-10 15:18:11 -0700 Created attachment 61162 patch 250167 2 61162 kbr 2010-07-12 17:13:08 -0700 Comment on attachment 61162 patch Looks good to me. 250267 3 61162 fishd 2010-07-12 20:22:28 -0700 Comment on attachment 61162 patch WebCore/platform/graphics/mac/GraphicsContext3DMac.mm:1229 + *value /= 4; nit: you should explain this factor of 4 in the ChangeLog. desktop GL returns byte counts or something, and GLES2 needs to return 32bit word counts? R=me 250537 4 zmo 2010-07-13 08:55:10 -0700 (In reply to comment #3) > (From update of attachment 61162 [details]) > WebCore/platform/graphics/mac/GraphicsContext3DMac.mm:1229 > + *value /= 4; > nit: you should explain this factor of 4 in the ChangeLog. desktop GL returns > byte counts or something, and GLES2 needs to return 32bit word counts? > > R=me Will add a comment in the landing patch. 250579 5 zmo 2010-07-13 09:52:14 -0700 Committed r63215: <http://trac.webkit.org/changeset/63215> 250597 6 webkit.review.bot 2010-07-13 10:23:46 -0700 http://trac.webkit.org/changeset/63215 might have broken GTK Linux 64-bit Debug The following changes are on the blame list: http://trac.webkit.org/changeset/63216 http://trac.webkit.org/changeset/63215 61162 2010-07-10 15:18:11 -0700 2010-07-12 20:22:28 -0700 patch getmax.patch text/plain 5477 zmo SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2MzA1MikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMTAtMDctMTAgIFpoZW55YW8gTW8gIDx6bW9AZ29vZ2xlLmNvbT4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBOZWVkIHRv IGVtdWxhdGUgTUFYX1ZBUllJTkdfVkVDVE9SUy9NQVhfRlJBR01FTlRfVU5JRk9STV9WRUNUT1Jz L01BWF9WRVJURVhfVU5JRk9STV9WRUNUT1JTIGZvciBnbEdldAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDIwMzIKKworICAgICAgICAqIHBsYXRmb3Jt L2dyYXBoaWNzL21hYy9HcmFwaGljc0NvbnRleHQzRE1hYy5tbToKKyAgICAgICAgKFdlYkNvcmU6 OkdyYXBoaWNzQ29udGV4dDNEOjpnZXRJbnRlZ2Vydik6IEVtdWxhdGUgdGhlIGVudW1zLgorCiAy MDEwLTA3LTEwICBTYW0gV2VpbmlnICA8c2FtQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3 ZWQgYnkgQW5kZXJzIENhcmxzc29uLgpJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9t YWMvR3JhcGhpY3NDb250ZXh0M0RNYWMubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9tYWMvR3JhcGhpY3NDb250ZXh0M0RNYWMubW0JKHJldmlzaW9uIDYzMDQ5KQor KysgV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9tYWMvR3JhcGhpY3NDb250ZXh0M0RNYWMubW0J KHdvcmtpbmcgY29weSkKQEAgLTEyMjQsNiArMTIyNCwxOCBAQCB2b2lkIEdyYXBoaWNzQ29udGV4 dDNEOjpnZXRJbnRlZ2Vydih1bnNpCiAgICAgY2FzZSBJTVBMRU1FTlRBVElPTl9DT0xPUl9SRUFE X1RZUEU6CiAgICAgICAgICp2YWx1ZSA9IEdMX1VOU0lHTkVEX0JZVEU7CiAgICAgICAgIGJyZWFr OworICAgIGNhc2UgTUFYX0ZSQUdNRU5UX1VOSUZPUk1fVkVDVE9SUzoKKyAgICAgICAgOjpnbEdl dEludGVnZXJ2KEdMX01BWF9GUkFHTUVOVF9VTklGT1JNX0NPTVBPTkVOVFMsIHZhbHVlKTsKKyAg ICAgICAgKnZhbHVlIC89IDQ7CisgICAgICAgIGJyZWFrOworICAgIGNhc2UgTUFYX1ZFUlRFWF9V TklGT1JNX1ZFQ1RPUlM6CisgICAgICAgIDo6Z2xHZXRJbnRlZ2VydihHTF9NQVhfVkVSVEVYX1VO SUZPUk1fQ09NUE9ORU5UUywgdmFsdWUpOworICAgICAgICAqdmFsdWUgLz0gNDsKKyAgICAgICAg YnJlYWs7CisgICAgY2FzZSBNQVhfVkFSWUlOR19WRUNUT1JTOgorICAgICAgICA6OmdsR2V0SW50 ZWdlcnYoR0xfTUFYX1ZBUllJTkdfRkxPQVRTLCB2YWx1ZSk7CisgICAgICAgICp2YWx1ZSAvPSA0 OworICAgICAgICBicmVhazsKICAgICBkZWZhdWx0OgogICAgICAgICA6OmdsR2V0SW50ZWdlcnYo cG5hbWUsIHZhbHVlKTsKICAgICB9CkluZGV4OiBXZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cJKHJldmlzaW9uIDYzMDUyKQor KysgV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEz IEBACisyMDEwLTA3LTEwICBaaGVueWFvIE1vICA8em1vQGdvb2dsZS5jb20+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTmVlZCB0byBlbXVsYXRlIE1B WF9WQVJZSU5HX1ZFQ1RPUlMvTUFYX0ZSQUdNRU5UX1VOSUZPUk1fVkVDVE9Scy9NQVhfVkVSVEVY X1VOSUZPUk1fVkVDVE9SUyBmb3IgZ2xHZXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTQyMDMyCisKKyAgICAgICAgKiBzcmMvV2ViR3JhcGhpY3NDb250 ZXh0M0REZWZhdWx0SW1wbC5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYkdyYXBoaWNzQ29udGV4 dDNERGVmYXVsdEltcGw6OmdldEludGVnZXJ2KTogRW11bGF0ZSB0aGUgZW51bXMuCisKIDIwMTAt MDctMDkgIEpvaG4gQWJkLUVsLU1hbGVrICA8amFtQGNocm9taXVtLm9yZz4KIAogICAgICAgICBS ZXZpZXdlZCBieSBEYXJpbiBGaXNoZXIuCkluZGV4OiBXZWJLaXQvY2hyb21pdW0vc3JjL1dlYkdy YXBoaWNzQ29udGV4dDNERGVmYXVsdEltcGwuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9jaHJv bWl1bS9zcmMvV2ViR3JhcGhpY3NDb250ZXh0M0REZWZhdWx0SW1wbC5jcHAJKHJldmlzaW9uIDYz MDQ5KQorKysgV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJHcmFwaGljc0NvbnRleHQzRERlZmF1bHRJ bXBsLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTEyOCw2ICsxMTI4LDE4IEBAIHZvaWQgV2ViR3Jh cGhpY3NDb250ZXh0M0REZWZhdWx0SW1wbDo6Z2UKICAgICBjYXNlIDB4OEI5QTogLy8gSU1QTEVN RU5UQVRJT05fQ09MT1JfUkVBRF9UWVBFCiAgICAgICAgICp2YWx1ZSA9IEdMX1VOU0lHTkVEX0JZ VEU7CiAgICAgICAgIGJyZWFrOworICAgIGNhc2UgMHg4REZEOiAvLyBNQVhfRlJBR01FTlRfVU5J Rk9STV9WRUNUT1JTCisgICAgICAgIGdsR2V0SW50ZWdlcnYoR0xfTUFYX0ZSQUdNRU5UX1VOSUZP Uk1fQ09NUE9ORU5UUywgdmFsdWUpOworICAgICAgICAqdmFsdWUgLz0gNDsKKyAgICAgICAgYnJl YWs7CisgICAgY2FzZSAweDhERkI6IC8vIE1BWF9WRVJURVhfVU5JRk9STV9WRUNUT1JTCisgICAg ICAgIGdsR2V0SW50ZWdlcnYoR0xfTUFYX1ZFUlRFWF9VTklGT1JNX0NPTVBPTkVOVFMsIHZhbHVl KTsKKyAgICAgICAgKnZhbHVlIC89IDQ7CisgICAgICAgIGJyZWFrOworICAgIGNhc2UgMHg4REZD OiAvLyBNQVhfVkFSWUlOR19WRUNUT1JTCisgICAgICAgIGdsR2V0SW50ZWdlcnYoR0xfTUFYX1ZB UllJTkdfRkxPQVRTLCB2YWx1ZSk7CisgICAgICAgICp2YWx1ZSAvPSA0OworICAgICAgICBicmVh azsKICAgICBkZWZhdWx0OgogICAgICAgICBnbEdldEludGVnZXJ2KHBuYW1lLCB2YWx1ZSk7CiAg ICAgfQpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRl c3RzL0NoYW5nZUxvZwkocmV2aXNpb24gNjMwNTIpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJ KHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0wNy0xMCAgWmhlbnlhbyBNbyAg PHptb0Bnb29nbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIE5lZWQgdG8gZW11bGF0ZSBNQVhfVkFSWUlOR19WRUNUT1JTL01BWF9GUkFHTUVO VF9VTklGT1JNX1ZFQ1RPUnMvTUFYX1ZFUlRFWF9VTklGT1JNX1ZFQ1RPUlMgZm9yIGdsR2V0Cisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MjAzMgorCisg ICAgICAgICogZmFzdC9jYW52YXMvd2ViZ2wvZ2wtZ2V0LWNhbGxzLWV4cGVjdGVkLnR4dDogQWRk IHRoZSB0ZXN0IGNhc2VzIGZvciB0aGUgdGhyZWUgZW51bXMuCisgICAgICAgICogZmFzdC9jYW52 YXMvd2ViZ2wvZ2wtZ2V0LWNhbGxzLmh0bWw6IERpdHRvLgorCiAyMDEwLTA3LTEwICBTYW0gV2Vp bmlnICA8c2FtQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQW5kZXJzIENhcmxz c29uLgpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9jYW52YXMvd2ViZ2wvZ2wtZ2V0LWNhbGxzLWV4 cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2NhbnZhcy93ZWJnbC9n bC1nZXQtY2FsbHMtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiA2MzA0OSkKKysrIExheW91dFRlc3Rz L2Zhc3QvY2FudmFzL3dlYmdsL2dsLWdldC1jYWxscy1leHBlY3RlZC50eHQJKHdvcmtpbmcgY29w eSkKQEAgLTY3LDYgKzY3LDkgQEAgUEFTUyBjb250ZXh0LmdldFBhcmFtZXRlcihjb250ZXh0LlVO UEFDSwogUEFTUyBjb250ZXh0LmdldFBhcmFtZXRlcihjb250ZXh0LlVOUEFDS19GTElQX1lfV0VC R0wpIGlzIGZhbHNlCiBQQVNTIGNvbnRleHQuZ2V0UGFyYW1ldGVyKGNvbnRleHQuVU5QQUNLX1BS RU1VTFRJUExZX0FMUEhBX1dFQkdMKSBpcyBmYWxzZQogUEFTUyBjb250ZXh0LmdldFBhcmFtZXRl cihjb250ZXh0LlZJRVdQT1JUKSBpcyBbMCwgMCwgMiwgMl0KK1BBU1MgY29udGV4dC5nZXRQYXJh bWV0ZXIoY29udGV4dC5NQVhfRlJBR01FTlRfVU5JRk9STV9WRUNUT1JTKSA+PSAxNiBpcyB0cnVl CitQQVNTIGNvbnRleHQuZ2V0UGFyYW1ldGVyKGNvbnRleHQuTUFYX1ZFUlRFWF9VTklGT1JNX1ZF Q1RPUlMpID49IDEyOCBpcyB0cnVlCitQQVNTIGNvbnRleHQuZ2V0UGFyYW1ldGVyKGNvbnRleHQu TUFYX1ZBUllJTkdfVkVDVE9SUykgPj0gOCBpcyB0cnVlCiAKIFBBU1Mgc3VjY2Vzc2Z1bGx5UGFy c2VkIGlzIHRydWUKIApJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9jYW52YXMvd2ViZ2wvZ2wtZ2V0 LWNhbGxzLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9jYW52YXMvd2ViZ2wv Z2wtZ2V0LWNhbGxzLmh0bWwJKHJldmlzaW9uIDYzMDQ5KQorKysgTGF5b3V0VGVzdHMvZmFzdC9j YW52YXMvd2ViZ2wvZ2wtZ2V0LWNhbGxzLmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTk5LDYgKzk5 LDkgQEAgZWxzZSB7CiAgICAgc2hvdWxkQmUoJ2NvbnRleHQuZ2V0UGFyYW1ldGVyKGNvbnRleHQu VU5QQUNLX0ZMSVBfWV9XRUJHTCknLCAnZmFsc2UnKTsKICAgICBzaG91bGRCZSgnY29udGV4dC5n ZXRQYXJhbWV0ZXIoY29udGV4dC5VTlBBQ0tfUFJFTVVMVElQTFlfQUxQSEFfV0VCR0wpJywgJ2Zh bHNlJyk7CiAgICAgc2hvdWxkQmUoJ2NvbnRleHQuZ2V0UGFyYW1ldGVyKGNvbnRleHQuVklFV1BP UlQpJywgJ1swLCAwLCAyLCAyXScpOworICAgIHNob3VsZEJlVHJ1ZSgnY29udGV4dC5nZXRQYXJh bWV0ZXIoY29udGV4dC5NQVhfRlJBR01FTlRfVU5JRk9STV9WRUNUT1JTKSA+PSAxNicpOworICAg IHNob3VsZEJlVHJ1ZSgnY29udGV4dC5nZXRQYXJhbWV0ZXIoY29udGV4dC5NQVhfVkVSVEVYX1VO SUZPUk1fVkVDVE9SUykgPj0gMTI4Jyk7CisgICAgc2hvdWxkQmVUcnVlKCdjb250ZXh0LmdldFBh cmFtZXRlcihjb250ZXh0Lk1BWF9WQVJZSU5HX1ZFQ1RPUlMpID49IDgnKTsKIH0KIAogZGVidWco IiIpOwo=