42021 2010-07-10 00:17:55 -0700 isEqualNode should work for DocumentType nodes 2019-02-06 09:04:03 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) All OS X 10.5 RESOLVED FIXED P2 Normal --- 1 sam webkit-unassigned cdumez jamesr kling oldest_to_newest 249479 0 sam 2010-07-10 00:17:55 -0700 isEqualNode is implemented incorrectly for DocumentType nodes. According to DOM3, it supposed to check the publicId, systemId, internalSubset, entities and notations are equal. 249480 1 61143 sam 2010-07-10 00:19:21 -0700 Created attachment 61143 Patch 249513 2 61143 kling 2010-07-10 08:10:50 -0700 Comment on attachment 61143 Patch >WebCore/dom/Node.cpp:1795 > + NamedNodeMap* othereEntities = documentTypeOther->entities(); Variable name should be 'otherEntities' >WebCore/dom/Node.cpp:1798 > + if (entities && entities->mapsEquivalent(othereEntities)) > + return false; This looks wrong. Shouldn't it be "if (entities && !entities->mapsEquivalent(othereEntities))"? Same two comments for the 'notations' section below. 249556 3 sam 2010-07-10 14:27:05 -0700 (In reply to comment #2) > (From update of attachment 61143 [details]) > >WebCore/dom/Node.cpp:1795 > > + NamedNodeMap* othereEntities = documentTypeOther->entities(); > Variable name should be 'otherEntities' > > >WebCore/dom/Node.cpp:1798 > > + if (entities && entities->mapsEquivalent(othereEntities)) > > + return false; > This looks wrong. Shouldn't it be "if (entities && !entities->mapsEquivalent(othereEntities))"? > > Same two comments for the 'notations' section below. Thanks, I made these changes locally. Unfortunately these two bits are not testable at the moment. 249559 4 sam 2010-07-10 14:39:01 -0700 Landed in http://trac.webkit.org/changeset/63051. 249564 5 61143 darin 2010-07-10 15:19:09 -0700 Comment on attachment 61143 Patch Typos: othereEntities and othereNotations. Does mapsEquavalent handle an argument of 0 and return false? Those test cases don't seem to cover all the branches in that function. 249569 6 sam 2010-07-10 15:29:13 -0700 (In reply to comment #5) > (From update of attachment 61143 [details]) > Typos: othereEntities and othereNotations. Does mapsEquavalent handle an argument of 0 and return false? Those test cases don't seem to cover all the branches in that function. mapsEquavalent does handle a null map. I can't currently test the entities, notations or internalSubset branches as those can't currently be set to anything other than the default (null or the null string) in WebCore. I left in the tests since this is not a hot function but I could remove them if you think that would be better. 249628 7 ap 2010-07-11 09:12:27 -0700 *** Bug 38786 has been marked as a duplicate of this bug. *** 1503091 8 lforschler 2019-02-06 09:04:03 -0800 Mass moving XML DOM bugs to the "DOM" Component. 61143 2010-07-10 00:19:21 -0700 2010-07-10 15:19:09 -0700 Patch patch.diff text/plain 6930 sam SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2MzA0MSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTAtMDctMTAgIFNhbSBXZWluaWcgIDxzYW1Ad2Via2l0Lm9yZz4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBQYXRjaCBm b3IgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQyMDIxCisgICAgICAg IGlzRXF1YWxOb2RlIHNob3VsZCB3b3JrIGZvciBEb2N1bWVudFR5cGUgbm9kZXMKKworICAgICAg ICBUZXN0OiBmYXN0L2RvbS9Ob2RlL2lzRXF1YWxOb2RlLmh0bWwKKworICAgICAgICAqIGRvbS9O b2RlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok5vZGU6OmlzRXF1YWxOb2RlKTogQWRkIERvY3Vt ZW50VHlwZSBsb2dpYyBmcm9tIHRoZSBET00zIHNwZWMuCisKIDIwMTAtMDctMDkgIFRvbnkgQ2hh bmcgIDx0b255QGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBPamFuIFZhZmFp LgpJbmRleDogV2ViQ29yZS9kb20vTm9kZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9kb20v Tm9kZS5jcHAJKHJldmlzaW9uIDYzMDAwKQorKysgV2ViQ29yZS9kb20vTm9kZS5jcHAJKHdvcmtp bmcgY29weSkKQEAgLTQwLDYgKzQwLDcgQEAKICNpbmNsdWRlICJDb250ZXh0TWVudUNvbnRyb2xs ZXIuaCIKICNpbmNsdWRlICJET01JbXBsZW1lbnRhdGlvbi5oIgogI2luY2x1ZGUgIkRvY3VtZW50 LmgiCisjaW5jbHVkZSAiRG9jdW1lbnRUeXBlLmgiCiAjaW5jbHVkZSAiRHluYW1pY05vZGVMaXN0 LmgiCiAjaW5jbHVkZSAiRWxlbWVudC5oIgogI2luY2x1ZGUgIkV2ZW50LmgiCkBAIC0xNzMwLDEy ICsxNzMxLDEzIEBAIEtVUkwgTm9kZTo6YmFzZVVSSSgpIGNvbnN0CiAgICAgcmV0dXJuIHBhcmVu dE5vZGUoKSA/IHBhcmVudE5vZGUoKS0+YmFzZVVSSSgpIDogS1VSTCgpOwogfQogCi1ib29sIE5v ZGU6OmlzRXF1YWxOb2RlKE5vZGUgKm90aGVyKSBjb25zdAorYm9vbCBOb2RlOjppc0VxdWFsTm9k ZShOb2RlKiBvdGhlcikgY29uc3QKIHsKICAgICBpZiAoIW90aGVyKQogICAgICAgICByZXR1cm4g ZmFsc2U7CiAgICAgCi0gICAgaWYgKG5vZGVUeXBlKCkgIT0gb3RoZXItPm5vZGVUeXBlKCkpCisg ICAgTm9kZVR5cGUgbm9kZVR5cGUgPSB0aGlzLT5ub2RlVHlwZSgpOworICAgIGlmIChub2RlVHlw ZSAhPSBvdGhlci0+bm9kZVR5cGUoKSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgIAogICAg IGlmIChub2RlTmFtZSgpICE9IG90aGVyLT5ub2RlTmFtZSgpKQpAQCAtMTc1MywxNyArMTc1NSwx NyBAQCBib29sIE5vZGU6OmlzRXF1YWxOb2RlKE5vZGUgKm90aGVyKSBjb25zCiAgICAgaWYgKG5v ZGVWYWx1ZSgpICE9IG90aGVyLT5ub2RlVmFsdWUoKSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwog ICAgIAotICAgIE5hbWVkTm9kZU1hcCAqYXR0cnMgPSBhdHRyaWJ1dGVzKCk7Ci0gICAgTmFtZWRO b2RlTWFwICpvdGhlckF0dHJzID0gb3RoZXItPmF0dHJpYnV0ZXMoKTsKKyAgICBOYW1lZE5vZGVN YXAqIGF0dHJpYnV0ZXMgPSB0aGlzLT5hdHRyaWJ1dGVzKCk7CisgICAgTmFtZWROb2RlTWFwKiBv dGhlckF0dHJpYnV0ZXMgPSBvdGhlci0+YXR0cmlidXRlcygpOwogICAgIAotICAgIGlmICghYXR0 cnMgJiYgb3RoZXJBdHRycykKKyAgICBpZiAoIWF0dHJpYnV0ZXMgJiYgb3RoZXJBdHRyaWJ1dGVz KQogICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgCi0gICAgaWYgKGF0dHJzICYmICFhdHRycy0+ bWFwc0VxdWl2YWxlbnQob3RoZXJBdHRycykpCisgICAgaWYgKGF0dHJpYnV0ZXMgJiYgIWF0dHJp YnV0ZXMtPm1hcHNFcXVpdmFsZW50KG90aGVyQXR0cmlidXRlcykpCiAgICAgICAgIHJldHVybiBm YWxzZTsKICAgICAKLSAgICBOb2RlICpjaGlsZCA9IGZpcnN0Q2hpbGQoKTsKLSAgICBOb2RlICpv dGhlckNoaWxkID0gb3RoZXItPmZpcnN0Q2hpbGQoKTsKKyAgICBOb2RlKiBjaGlsZCA9IGZpcnN0 Q2hpbGQoKTsKKyAgICBOb2RlKiBvdGhlckNoaWxkID0gb3RoZXItPmZpcnN0Q2hpbGQoKTsKICAg ICAKICAgICB3aGlsZSAoY2hpbGQpIHsKICAgICAgICAgaWYgKCFjaGlsZC0+aXNFcXVhbE5vZGUo b3RoZXJDaGlsZCkpCkBAIC0xNzc2LDggKzE3NzgsMzMgQEAgYm9vbCBOb2RlOjppc0VxdWFsTm9k ZShOb2RlICpvdGhlcikgY29ucwogICAgIGlmIChvdGhlckNoaWxkKQogICAgICAgICByZXR1cm4g ZmFsc2U7CiAgICAgCi0gICAgLy8gRklYTUU6IEZvciBEb2N1bWVudFR5cGUgbm9kZXMgd2Ugc2hv dWxkIGNoZWNrIGVxdWFsaXR5IG9uCi0gICAgLy8gdGhlIGVudGl0aWVzIGFuZCBub3RhdGlvbnMg TmFtZWROb2RlTWFwcyBhcyB3ZWxsLgorICAgIGlmIChub2RlVHlwZSA9PSBET0NVTUVOVF9UWVBF X05PREUpIHsKKyAgICAgICAgY29uc3QgRG9jdW1lbnRUeXBlKiBkb2N1bWVudFR5cGVUaGlzID0g c3RhdGljX2Nhc3Q8Y29uc3QgRG9jdW1lbnRUeXBlKj4odGhpcyk7CisgICAgICAgIGNvbnN0IERv Y3VtZW50VHlwZSogZG9jdW1lbnRUeXBlT3RoZXIgPSBzdGF0aWNfY2FzdDxjb25zdCBEb2N1bWVu dFR5cGUqPihvdGhlcik7CisgICAgICAgIAorICAgICAgICBpZiAoZG9jdW1lbnRUeXBlVGhpcy0+ cHVibGljSWQoKSAhPSBkb2N1bWVudFR5cGVPdGhlci0+cHVibGljSWQoKSkKKyAgICAgICAgICAg IHJldHVybiBmYWxzZTsKKworICAgICAgICBpZiAoZG9jdW1lbnRUeXBlVGhpcy0+c3lzdGVtSWQo KSAhPSBkb2N1bWVudFR5cGVPdGhlci0+c3lzdGVtSWQoKSkKKyAgICAgICAgICAgIHJldHVybiBm YWxzZTsKKworICAgICAgICBpZiAoZG9jdW1lbnRUeXBlVGhpcy0+aW50ZXJuYWxTdWJzZXQoKSAh PSBkb2N1bWVudFR5cGVPdGhlci0+aW50ZXJuYWxTdWJzZXQoKSkKKyAgICAgICAgICAgIHJldHVy biBmYWxzZTsKKworICAgICAgICBOYW1lZE5vZGVNYXAqIGVudGl0aWVzID0gZG9jdW1lbnRUeXBl VGhpcy0+ZW50aXRpZXMoKTsKKyAgICAgICAgTmFtZWROb2RlTWFwKiBvdGhlcmVFbnRpdGllcyA9 IGRvY3VtZW50VHlwZU90aGVyLT5lbnRpdGllcygpOworICAgICAgICBpZiAoIWVudGl0aWVzICYm IG90aGVyZUVudGl0aWVzKQorICAgICAgICAgICAgcmV0dXJuIGZhbHNlOworICAgICAgICBpZiAo ZW50aXRpZXMgJiYgZW50aXRpZXMtPm1hcHNFcXVpdmFsZW50KG90aGVyZUVudGl0aWVzKSkKKyAg ICAgICAgICAgIHJldHVybiBmYWxzZTsKKworICAgICAgICBOYW1lZE5vZGVNYXAqIG5vdGF0aW9u cyA9IGRvY3VtZW50VHlwZVRoaXMtPm5vdGF0aW9ucygpOworICAgICAgICBOYW1lZE5vZGVNYXAq IG90aGVyZU5vdGF0aW9ucyA9IGRvY3VtZW50VHlwZU90aGVyLT5ub3RhdGlvbnMoKTsKKyAgICAg ICAgaWYgKCFub3RhdGlvbnMgJiYgb3RoZXJlTm90YXRpb25zKQorICAgICAgICAgICAgcmV0dXJu IGZhbHNlOworICAgICAgICBpZiAobm90YXRpb25zICYmIG5vdGF0aW9ucy0+bWFwc0VxdWl2YWxl bnQob3RoZXJlTm90YXRpb25zKSkKKyAgICAgICAgICAgIHJldHVybiBmYWxzZTsKKyAgICB9CiAg ICAgCiAgICAgcmV0dXJuIHRydWU7CiB9CkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiA2MzA0MSkKKysrIExh eW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDEw LTA3LTEwICBTYW0gV2VpbmlnICA8c2FtQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGVzdCBmb3IgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTQyMDIxCisgICAgICAgIGlzRXF1YWxOb2RlIHNob3VsZCB3 b3JrIGZvciBEb2N1bWVudFR5cGUgbm9kZXMKKworICAgICAgICAqIGZhc3QvZG9tL05vZGUvaXNF cXVhbE5vZGUtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2RvbS9Ob2RlL2lz RXF1YWxOb2RlLmh0bWw6IEFkZGVkLgorICAgICAgICAqIGZhc3QvZG9tL05vZGUvc2NyaXB0LXRl c3RzL2lzRXF1YWxOb2RlLmpzOiBBZGRlZC4KKwogMjAxMC0wNy0wOSAgVG9ueSBDaGFuZyAgPHRv bnlAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE9qYW4gVmFmYWkuCkluZGV4 OiBMYXlvdXRUZXN0cy9mYXN0L2RvbS9Ob2RlL2lzRXF1YWxOb2RlLWV4cGVjdGVkLnR4dAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2RvbS9Ob2RlL2lzRXF1YWxOb2RlLWV4cGVjdGVk LnR4dAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvZG9tL05vZGUvaXNFcXVhbE5v ZGUtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDEzIEBACitUZXN0IHRoZSBp c0VxdWFsTm9kZSBBUEkuCisKK09uIHN1Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNlcmllcyBvZiAi UEFTUyIgbWVzc2FnZXMsIGZvbGxvd2VkIGJ5ICJURVNUIENPTVBMRVRFIi4KKworCitUZXN0IGlz RXF1YWxOb2RlIGZvciBEb2N1bWVudFR5cGUgbm9kZXMuCitQQVNTIGRvY1R5cGVBbGxTZXQuaXNF cXVhbE5vZGUoZG9jVHlwZUFsbFNldDIpIGlzIHRydWUKK1BBU1MgZG9jVHlwZUFsbFNldC5pc0Vx dWFsTm9kZShkb2NUeXBlRGlmZmVyZW50UHVibGljSUQpIGlzIGZhbHNlCitQQVNTIGRvY1R5cGVB bGxTZXQuaXNFcXVhbE5vZGUoZG9jVHlwZURpZmZlcmVudFN5c3RlbUlEKSBpcyBmYWxzZQorUEFT UyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQorCitURVNUIENPTVBMRVRFCisKSW5kZXg6IExh eW91dFRlc3RzL2Zhc3QvZG9tL05vZGUvaXNFcXVhbE5vZGUuaHRtbAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBM YXlvdXRUZXN0cy9mYXN0L2RvbS9Ob2RlL2lzRXF1YWxOb2RlLmh0bWwJKHJldmlzaW9uIDApCisr KyBMYXlvdXRUZXN0cy9mYXN0L2RvbS9Ob2RlL2lzRXF1YWxOb2RlLmh0bWwJKHJldmlzaW9uIDAp CkBAIC0wLDAgKzEsMTMgQEAKKzwhRE9DVFlQRSBIVE1MIFBVQkxJQyAiLS8vSUVURi8vRFREIEhU TUwvL0VOIj4KKzxodG1sPgorPGhlYWQ+Cis8bGluayByZWw9InN0eWxlc2hlZXQiIGhyZWY9Ii4u Ly4uL2pzL3Jlc291cmNlcy9qcy10ZXN0LXN0eWxlLmNzcyI+Cis8c2NyaXB0IHNyYz0iLi4vLi4v anMvcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5Pgor PHAgaWQ9ImRlc2NyaXB0aW9uIj48L3A+Cis8ZGl2IGlkPSJjb25zb2xlIj48L2Rpdj4KKzxzY3Jp cHQgc3JjPSJzY3JpcHQtdGVzdHMvaXNFcXVhbE5vZGUuanMiPjwvc2NyaXB0PgorPHNjcmlwdCBz cmM9Ii4uLy4uL2pzL3Jlc291cmNlcy9qcy10ZXN0LXBvc3QuanMiPjwvc2NyaXB0PgorPC9ib2R5 PgorPC9odG1sPgpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9kb20vTm9kZS9zY3JpcHQtdGVzdHMv aXNFcXVhbE5vZGUuanMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9kb20vTm9kZS9z Y3JpcHQtdGVzdHMvaXNFcXVhbE5vZGUuanMJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9m YXN0L2RvbS9Ob2RlL3NjcmlwdC10ZXN0cy9pc0VxdWFsTm9kZS5qcwkocmV2aXNpb24gMCkKQEAg LTAsMCArMSwxMyBAQAorZGVzY3JpcHRpb24oIlRlc3QgdGhlIGlzRXF1YWxOb2RlIEFQSS4iKTsK KworZGVidWcoIlRlc3QgaXNFcXVhbE5vZGUgZm9yIERvY3VtZW50VHlwZSBub2Rlcy4iKTsKK3Zh ciBkb2NUeXBlQWxsU2V0ID0gZG9jdW1lbnQuaW1wbGVtZW50YXRpb24uY3JlYXRlRG9jdW1lbnRU eXBlKCdodG1sJywgJy0vL1czQy8vRFREIFhIVE1MIDEuMCBTdHJpY3QvL0VOJywgJ2h0dHA6Ly93 d3cudzMub3JnL1RSL3hodG1sMS9EVEQveGh0bWwxLXN0cmljdC5kdGQnKTsKK3ZhciBkb2NUeXBl QWxsU2V0MiA9IGRvY3VtZW50LmltcGxlbWVudGF0aW9uLmNyZWF0ZURvY3VtZW50VHlwZSgnaHRt bCcsICctLy9XM0MvL0RURCBYSFRNTCAxLjAgU3RyaWN0Ly9FTicsICdodHRwOi8vd3d3LnczLm9y Zy9UUi94aHRtbDEvRFREL3hodG1sMS1zdHJpY3QuZHRkJyk7Cit2YXIgZG9jVHlwZURpZmZlcmVu dFB1YmxpY0lEID0gZG9jdW1lbnQuaW1wbGVtZW50YXRpb24uY3JlYXRlRG9jdW1lbnRUeXBlKCdo dG1sJywgJ2ZvbycsICdodHRwOi8vd3d3LnczLm9yZy9UUi94aHRtbDEvRFREL3hodG1sMS1zdHJp Y3QuZHRkJyk7Cit2YXIgZG9jVHlwZURpZmZlcmVudFN5c3RlbUlEID0gZG9jdW1lbnQuaW1wbGVt ZW50YXRpb24uY3JlYXRlRG9jdW1lbnRUeXBlKCdodG1sJywgJy0vL1czQy8vRFREIFhIVE1MIDEu MCBTdHJpY3QvL0VOJywgJ2JhcicpOworCitzaG91bGRCZVRydWUoImRvY1R5cGVBbGxTZXQuaXNF cXVhbE5vZGUoZG9jVHlwZUFsbFNldDIpIik7CitzaG91bGRCZUZhbHNlKCJkb2NUeXBlQWxsU2V0 LmlzRXF1YWxOb2RlKGRvY1R5cGVEaWZmZXJlbnRQdWJsaWNJRCkiKTsKK3Nob3VsZEJlRmFsc2Uo ImRvY1R5cGVBbGxTZXQuaXNFcXVhbE5vZGUoZG9jVHlwZURpZmZlcmVudFN5c3RlbUlEKSIpOwor Cit2YXIgc3VjY2Vzc2Z1bGx5UGFyc2VkID0gdHJ1ZTsK