42010 2010-07-09 17:33:40 -0700 TreeWalker::previousNode does not handle FILTER_REJECT when processing lastChild 2019-02-06 09:04:14 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 craig.topper darin cdumez darin oldest_to_newest 249380 0 craig.topper 2010-07-09 17:33:40 -0700 A FILTER_REJECT response after calling acceptNode for a last child should not follow that node's last child pointer. 250070 1 darin 2010-07-12 14:49:00 -0700 Could you provide a test case? 250075 2 darin 2010-07-12 14:55:50 -0700 From code inspection, I’m not sure I see the problem. The logic looks right to me. I’ll need to see the test case to understand what is actually wrong. 250113 3 craig.topper 2010-07-12 15:57:09 -0700 I have a test case, but I'm at work right now and don't have access to it. But I can attempt to better explain the problem In the following code, a FILTER_REJECT response should terminate the loop instead of going back around. If you go back around you're asking for the lastChild of a node that was just rejected. 222 while (Node* lastChild = node->lastChild()) { 223 node = lastChild; 224 acceptNodeResult = acceptNode(state, node.get()); 225 if (state && state->hadException()) 226 return 0; 227 if (acceptNodeResult == NodeFilter::FILTER_ACCEPT) 228 continue; 229 } Also the "if (acceptNodeResult == NodeFilter::FILTER_ACCEPT)" part of the loop is pointless as it just does a continue which is exactly what would happen if it weren't there at all. 250117 4 darin 2010-07-12 16:07:19 -0700 I see. The code should probably just say: if (acceptNodeResult != NodeFilter::FILTER_ACCEPT) break; I think that’s right. 250118 5 craig.topper 2010-07-12 16:08:35 -0700 You don't want to do that because FILTER_SKIP would still allow you to see the children. So it should be if (acceptNodeResult == NodeFilter::FILTER_REJECT) break; 250289 6 61323 craig.topper 2010-07-12 21:57:28 -0700 Created attachment 61323 Test case 251482 7 darin 2010-07-14 15:51:08 -0700 Committed r63365: <http://trac.webkit.org/changeset/63365> 1503130 8 lforschler 2019-02-06 09:04:14 -0800 Mass moving XML DOM bugs to the "DOM" Component. 61323 2010-07-12 21:57:28 -0700 2010-07-12 21:57:28 -0700 Test case treewalker_prevnode.html text/html 1368 craig.topper PGh0bWw+CiAgPGhlYWQ+CiAgICA8dGl0bGU+VGVzdCBmb3IgV2ViS2l0IGJ1Z3MgaW4gVHJlZVdh bGtlcjwvdGl0bGU+CiAgPC9oZWFkPgogIDxib2R5IG9ubG9hZD0idGVzdFRyZWVXYWxrZXIoKSI+ CiAgICA8ZGl2IGlkPSJub2RlcyI+PGRpdiBpZD0iQTEiPjxkaXYgaWQ9IkIxIj48ZGl2IGlkPSJD MSI+PC9kaXY+PGRpdiBpZD0iQzIiPjxkaXYgaWQ9IkQxIj48L2Rpdj48ZGl2IGlkPSJEMiI+PC9k aXY+PC9kaXY+PC9kaXY+PGRpdiBpZD0iQjIiPjxkaXYgaWQ9IkMzIj48L2Rpdj48ZGl2IGlkPSJD NCI+PC9kaXY+PC9kaXY+PC9kaXY+PC9kaXY+CiAgICA8c2NyaXB0IHR5cGU9ImFwcGxpY2F0aW9u L2phdmFzY3JpcHQiPgpmdW5jdGlvbiBmaWx0ZXIxKG5vZGUpIHsKICBpZiAobm9kZS5pZCA9PSAi QjEiKQogICAgcmV0dXJuIE5vZGVGaWx0ZXIuRklMVEVSX1NLSVA7CgogIHJldHVybiBOb2RlRmls dGVyLkZJTFRFUl9BQ0NFUFQ7Cn0KCmZ1bmN0aW9uIGZpbHRlcjIobm9kZSkgewogIGlmIChub2Rl LmlkID09ICJDMiIpCiAgICByZXR1cm4gTm9kZUZpbHRlci5GSUxURVJfUkVKRUNUOwoKICByZXR1 cm4gTm9kZUZpbHRlci5GSUxURVJfQUNDRVBUOwp9CgpmdW5jdGlvbiB0ZXN0VHJlZVdhbGtlcigp IHsKICB3YWxrZXIgPSBkb2N1bWVudC5jcmVhdGVUcmVlV2Fsa2VyKGRvY3VtZW50LmdldEVsZW1l bnRCeUlkKCJub2RlcyIpLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgTm9k ZUZpbHRlci5TSE9XX0VMRU1FTlQsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBmaWx0ZXIyLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZmFsc2UpOwog IHdhbGtlci5maXJzdENoaWxkKCk7IC8vIEExCiAgaWYgKHdhbGtlci5jdXJyZW50Tm9kZS5pZCAh PSAiQTEiKQogICAgYWxlcnQoIkVycm9yIDgiKTsKICB3YWxrZXIubmV4dE5vZGUoKTsgLy8gQjEK ICBpZiAod2Fsa2VyLmN1cnJlbnROb2RlLmlkICE9ICJCMSIpCiAgICBhbGVydCgiRXJyb3IgOSIp OwogIHdhbGtlci5uZXh0Tm9kZSgpOyAvLyBDMQogIGlmICh3YWxrZXIuY3VycmVudE5vZGUuaWQg IT0gIkMxIikKICAgIGFsZXJ0KCJFcnJvciAxMCIpOwogIHdhbGtlci5uZXh0Tm9kZSgpOyAvLyBC MgogIGlmICh3YWxrZXIuY3VycmVudE5vZGUuaWQgIT0gIkIyIikKICAgIGFsZXJ0KCJFcnJvciAx MSIpOwogIHdhbGtlci5wcmV2aW91c05vZGUoKTsgLy8gQzEKICBpZiAod2Fsa2VyLmN1cnJlbnRO b2RlLmlkICE9ICJDMSIpCiAgICBhbGVydCgiRXJyb3IgMTIgZXhwZWN0ZWQgQzEgZ290ICIgKyB3 YWxrZXIuY3VycmVudE5vZGUuaWQpOwp9CiAgICA8L3NjcmlwdD4KICA8L2JvZHk+CjwvaHRtbD4K