42003 2010-07-09 16:44:01 -0700 User style sheets apply to pages immediately instead of waiting for reload 2010-07-13 14:08:11 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 aa webkit-unassigned aroben commit-queue hyatt mitz timothy oldest_to_newest 249351 0 aa 2010-07-09 16:44:01 -0700 User style sheets apply to pages immediately instead of waiting for reload. This seems inconsistent with user scripts, which must wait for a reload. An extension which uses both features will see inconsistent behavior. This could cause a problem if a stylesheet hides all images by default, and expects a script to run after, which shows some of them. 249454 1 timothy 2010-07-09 20:20:41 -0700 On the flip side we have had developers coment and expect the scripts to run when installed, like styles. In general they are surprised you need to reload to get scripts to work. 250660 2 aa 2010-07-13 11:57:35 -0700 I'm just going to do a quick hack to fix Chromium, then try something more clever and general separately. 250668 3 61405 aa 2010-07-13 12:15:15 -0700 Created attachment 61405 Patch 250673 4 mitz 2010-07-13 12:17:51 -0700 Will this change how the Style sheet menu in Safari’s Advanced preferences behaves? 250674 5 aa 2010-07-13 12:21:41 -0700 This patch won't affect Safari at all (it is Chromium-specific). The future work I do won't affect Safari either, but because the behavior will be configurable and I won't change the setting for Safari. 250708 6 aa 2010-07-13 13:31:52 -0700 Committed r63243: <http://trac.webkit.org/changeset/63243> 250735 7 61405 commit-queue 2010-07-13 14:08:11 -0700 Comment on attachment 61405 Patch Rejecting patch 61405 from commit-queue. Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Timothy Hatcher', u'--force']" exit_code: 1 Parsed 3 diffs from patch file(s). patching file WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file WebCore/page/PageGroup.cpp Hunk #1 FAILED at 242. Hunk #2 FAILED at 296. Hunk #3 FAILED at 329. Hunk #4 FAILED at 338. 4 out of 4 hunks FAILED -- saving rejects to file WebCore/page/PageGroup.cpp.rej patching file WebCore/page/PageGroup.h Hunk #1 FAILED at 94. 1 out of 1 hunk FAILED -- saving rejects to file WebCore/page/PageGroup.h.rej Full output: http://webkit-commit-queue.appspot.com/results/3548014 61405 2010-07-13 12:15:15 -0700 2010-07-13 14:08:11 -0700 Patch bug-42003-20100713121513.patch text/plain 4373 aa ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg M2IwNDM1MjQ0NjU3NDNkMjY0MmJlYTA0NzFiY2JiZmFiZTZkYzFkMS4uNDQwMTBiNGU1M2NhNDYx NGNjYjFmZTgzNGUyMWUwYjA1ZjEzMTkxZiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMCBAQAorMjAxMC0wNy0xMyAgQWFy b24gQm9vZG1hbiAgPGFhQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBEb24ndCByZXNldCBwZXItZG9jdW1lbnQgdXNlciBzdHls ZSBjYWNoZXMgd2hlbiB1c2VyIHN0eWxlcyBhcmUgdXBkYXRlZCBpbgorICAgICAgICBDaHJvbWl1 bS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDIw MDMKKworICAgICAgICAqIHBhZ2UvUGFnZUdyb3VwLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlBh Z2VHcm91cDo6YWRkVXNlclN0eWxlU2hlZXRUb1dvcmxkKToKKyAgICAgICAgKFdlYkNvcmU6OlBh Z2VHcm91cDo6cmVtb3ZlVXNlclN0eWxlU2hlZXRGcm9tV29ybGQpOgorICAgICAgICAoV2ViQ29y ZTo6UGFnZUdyb3VwOjpyZW1vdmVVc2VyU3R5bGVTaGVldHNGcm9tV29ybGQpOgorICAgICAgICAo V2ViQ29yZTo6UGFnZUdyb3VwOjpyZW1vdmVBbGxVc2VyQ29udGVudCk6CisgICAgICAgIChXZWJD b3JlOjpQYWdlR3JvdXA6OnJlc2V0VXNlclN0eWxlQ2FjaGVJbkFsbEZyYW1lcyk6CisgICAgICAg ICogcGFnZS9QYWdlR3JvdXAuaDoKKwogMjAxMC0wNy0xMyAgUmljaGFyZCBNb29yZSA8cmljaEBr ZGUub3JnPiwgUm9iZXJ0IEhvZ2FuICA8cm9iZXJ0QHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2 aWV3ZWQgYnkgU2ltb24gSGF1c21hbm4uCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BhZ2UvUGFnZUdy b3VwLmNwcCBiL1dlYkNvcmUvcGFnZS9QYWdlR3JvdXAuY3BwCmluZGV4IGI0NWI5ZWE0YWY5MjU3 NDY1MjVhZjFhZmNiODA4MjY2ZTAwYjdhMGUuLmUwNTAyYzU4ODVhODJkMmM3NzUzNzMxODdhY2Qw NjA1ODkxMjhjNGEgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGFnZS9QYWdlR3JvdXAuY3BwCisrKyBi L1dlYkNvcmUvcGFnZS9QYWdlR3JvdXAuY3BwCkBAIC0yNDIsMTIgKzI0Miw3IEBAIHZvaWQgUGFn ZUdyb3VwOjphZGRVc2VyU3R5bGVTaGVldFRvV29ybGQoRE9NV3JhcHBlcldvcmxkKiB3b3JsZCwg Y29uc3QgU3RyaW5nJiBzCiAgICAgICAgIHN0eWxlU2hlZXRzSW5Xb3JsZCA9IG5ldyBVc2VyU3R5 bGVTaGVldFZlY3RvcjsKICAgICBzdHlsZVNoZWV0c0luV29ybGQtPmFwcGVuZCh1c2VyU3R5bGVT aGVldC5yZWxlYXNlKCkpOwogCi0gICAgLy8gQ2xlYXIgb3VyIGNhY2hlZCBzaGVldHMgYW5kIGhh dmUgdGhlbSBqdXN0IHJlcGFyc2UuCi0gICAgSGFzaFNldDxQYWdlKj46OmNvbnN0X2l0ZXJhdG9y IGVuZCA9IG1fcGFnZXMuZW5kKCk7Ci0gICAgZm9yIChIYXNoU2V0PFBhZ2UqPjo6Y29uc3RfaXRl cmF0b3IgaXQgPSBtX3BhZ2VzLmJlZ2luKCk7IGl0ICE9IGVuZDsgKytpdCkgewotICAgICAgICBm b3IgKEZyYW1lKiBmcmFtZSA9ICgqaXQpLT5tYWluRnJhbWUoKTsgZnJhbWU7IGZyYW1lID0gZnJh bWUtPnRyZWUoKS0+dHJhdmVyc2VOZXh0KCkpCi0gICAgICAgICAgICBmcmFtZS0+ZG9jdW1lbnQo KS0+Y2xlYXJQYWdlR3JvdXBVc2VyU2hlZXRzKCk7Ci0gICAgfQorICAgIHJlc2V0VXNlclN0eWxl Q2FjaGVJbkFsbEZyYW1lcygpOwogfQogCiB2b2lkIFBhZ2VHcm91cDo6cmVtb3ZlVXNlclNjcmlw dEZyb21Xb3JsZChET01XcmFwcGVyV29ybGQqIHdvcmxkLCBjb25zdCBLVVJMJiB1cmwpCkBAIC0z MDEsMTMgKzI5Niw4IEBAIHZvaWQgUGFnZUdyb3VwOjpyZW1vdmVVc2VyU3R5bGVTaGVldEZyb21X b3JsZChET01XcmFwcGVyV29ybGQqIHdvcmxkLCBjb25zdCBLVVJMCiAgICAgICAgIGRlbGV0ZSBp dC0+c2Vjb25kOwogICAgICAgICBtX3VzZXJTdHlsZVNoZWV0cy0+cmVtb3ZlKGl0KTsKICAgICB9 Ci0gICAgCi0gICAgLy8gQ2xlYXIgb3VyIGNhY2hlZCBzaGVldHMgYW5kIGhhdmUgdGhlbSBqdXN0 IHJlcGFyc2UuCi0gICAgSGFzaFNldDxQYWdlKj46OmNvbnN0X2l0ZXJhdG9yIGVuZCA9IG1fcGFn ZXMuZW5kKCk7Ci0gICAgZm9yIChIYXNoU2V0PFBhZ2UqPjo6Y29uc3RfaXRlcmF0b3IgaXQgPSBt X3BhZ2VzLmJlZ2luKCk7IGl0ICE9IGVuZDsgKytpdCkgewotICAgICAgICBmb3IgKEZyYW1lKiBm cmFtZSA9ICgqaXQpLT5tYWluRnJhbWUoKTsgZnJhbWU7IGZyYW1lID0gZnJhbWUtPnRyZWUoKS0+ dHJhdmVyc2VOZXh0KCkpCi0gICAgICAgICAgICBmcmFtZS0+ZG9jdW1lbnQoKS0+Y2xlYXJQYWdl R3JvdXBVc2VyU2hlZXRzKCk7Ci0gICAgfQorCisgICAgcmVzZXRVc2VyU3R5bGVDYWNoZUluQWxs RnJhbWVzKCk7CiB9CiAKIHZvaWQgUGFnZUdyb3VwOjpyZW1vdmVVc2VyU2NyaXB0c0Zyb21Xb3Js ZChET01XcmFwcGVyV29ybGQqIHdvcmxkKQpAQCAtMzM5LDEyICszMjksNyBAQCB2b2lkIFBhZ2VH cm91cDo6cmVtb3ZlVXNlclN0eWxlU2hlZXRzRnJvbVdvcmxkKERPTVdyYXBwZXJXb3JsZCogd29y bGQpCiAgICAgZGVsZXRlIGl0LT5zZWNvbmQ7CiAgICAgbV91c2VyU3R5bGVTaGVldHMtPnJlbW92 ZShpdCk7CiAKLSAgICAvLyBDbGVhciBvdXIgY2FjaGVkIHNoZWV0cyBhbmQgaGF2ZSB0aGVtIGp1 c3QgcmVwYXJzZS4KLSAgICBIYXNoU2V0PFBhZ2UqPjo6Y29uc3RfaXRlcmF0b3IgZW5kID0gbV9w YWdlcy5lbmQoKTsKLSAgICBmb3IgKEhhc2hTZXQ8UGFnZSo+Ojpjb25zdF9pdGVyYXRvciBpdCA9 IG1fcGFnZXMuYmVnaW4oKTsgaXQgIT0gZW5kOyArK2l0KSB7Ci0gICAgICAgIGZvciAoRnJhbWUq IGZyYW1lID0gKCppdCktPm1haW5GcmFtZSgpOyBmcmFtZTsgZnJhbWUgPSBmcmFtZS0+dHJlZSgp LT50cmF2ZXJzZU5leHQoKSkKLSAgICAgICAgICAgIGZyYW1lLT5kb2N1bWVudCgpLT5jbGVhclBh Z2VHcm91cFVzZXJTaGVldHMoKTsKLSAgICB9CisgICAgcmVzZXRVc2VyU3R5bGVDYWNoZUluQWxs RnJhbWVzKCk7CiB9CiAKIHZvaWQgUGFnZUdyb3VwOjpyZW1vdmVBbGxVc2VyQ29udGVudCgpCkBA IC0zNTMsMTIgKzMzOCwyNCBAQCB2b2lkIFBhZ2VHcm91cDo6cmVtb3ZlQWxsVXNlckNvbnRlbnQo KQogICAgICAgICBkZWxldGVBbGxWYWx1ZXMoKm1fdXNlclNjcmlwdHMpOwogICAgICAgICBtX3Vz ZXJTY3JpcHRzLmNsZWFyKCk7CiAgICAgfQotICAgIAotICAgIAorCiAgICAgaWYgKG1fdXNlclN0 eWxlU2hlZXRzKSB7CiAgICAgICAgIGRlbGV0ZUFsbFZhbHVlcygqbV91c2VyU3R5bGVTaGVldHMp OwogICAgICAgICBtX3VzZXJTdHlsZVNoZWV0cy5jbGVhcigpOworICAgICAgICByZXNldFVzZXJT dHlsZUNhY2hlSW5BbGxGcmFtZXMoKTsKICAgICB9CiB9CiAKK3ZvaWQgUGFnZUdyb3VwOjpyZXNl dFVzZXJTdHlsZUNhY2hlSW5BbGxGcmFtZXMoKQoreworI2lmICFQTEFURk9STShDSFJPTUlVTSkK KyAgICAvLyBDbGVhciBvdXIgY2FjaGVkIHNoZWV0cyBhbmQgaGF2ZSB0aGVtIGp1c3QgcmVwYXJz ZS4KKyAgICBIYXNoU2V0PFBhZ2UqPjo6Y29uc3RfaXRlcmF0b3IgZW5kID0gbV9wYWdlcy5lbmQo KTsKKyAgICBmb3IgKEhhc2hTZXQ8UGFnZSo+Ojpjb25zdF9pdGVyYXRvciBpdCA9IG1fcGFnZXMu YmVnaW4oKTsgaXQgIT0gZW5kOyArK2l0KSB7CisgICAgICAgIGZvciAoRnJhbWUqIGZyYW1lID0g KCppdCktPm1haW5GcmFtZSgpOyBmcmFtZTsgZnJhbWUgPSBmcmFtZS0+dHJlZSgpLT50cmF2ZXJz ZU5leHQoKSkKKyAgICAgICAgICAgIGZyYW1lLT5kb2N1bWVudCgpLT5jbGVhclBhZ2VHcm91cFVz ZXJTaGVldHMoKTsKKyAgICB9CisjZW5kaWYKK30KKwogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQpk aWZmIC0tZ2l0IGEvV2ViQ29yZS9wYWdlL1BhZ2VHcm91cC5oIGIvV2ViQ29yZS9wYWdlL1BhZ2VH cm91cC5oCmluZGV4IDU0NWRmNzg3MTNiNWNjZTU1ZTNmMTJkZDNkNjFmZWU2NThhMmNjMTEuLjc3 YWEyODFkZmU2NDcxMGRlNzBlNGYzNjcyNDU1ZjM1MWJlNWM3YTQgMTAwNjQ0Ci0tLSBhL1dlYkNv cmUvcGFnZS9QYWdlR3JvdXAuaAorKysgYi9XZWJDb3JlL3BhZ2UvUGFnZUdyb3VwLmgKQEAgLTk0 LDcgKzk0LDggQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogCiAgICAgcHJpdmF0ZToKICAgICAgICAg dm9pZCBhZGRWaXNpdGVkTGluayhMaW5rSGFzaCBzdHJpbmdIYXNoKTsKLQorICAgICAgICB2b2lk IHJlc2V0VXNlclN0eWxlQ2FjaGVJbkFsbEZyYW1lcygpOworICAKICAgICAgICAgU3RyaW5nIG1f bmFtZTsKIAogICAgICAgICBIYXNoU2V0PFBhZ2UqPiBtX3BhZ2VzOwo=