41991 2010-07-09 14:40:35 -0700 HTML5 tree builder should pass some LayoutTests 2010-07-09 20:48:12 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 41123 1 abarth abarth commit-queue eric jamesr oldest_to_newest 249288 0 abarth 2010-07-09 14:40:35 -0700 HTML5 tree builder should pass some LayoutTests 249292 1 61101 abarth 2010-07-09 14:43:02 -0700 Created attachment 61101 Patch 249298 2 61101 eric 2010-07-09 14:46:56 -0700 Comment on attachment 61101 Patch WebCore/html/HTMLConstructionSite.cpp:103 + RefPtr<Node> child = prpChild; This causes us to end up taking an extra reference. We should steal a raw pointer for our ASSERTs. parserAddChild can never fail. Why do we need to be attaching text nodes? Is something wrong in the lazy attach codepath? Does DRT need to be calling some layout method that it's not? 249301 3 61101 eric 2010-07-09 14:48:37 -0700 Comment on attachment 61101 Patch You need to at least add a FIXME about the extra ref problem. But it seems silly/lazy to not just fix it now. :p CC'd James R. about understanding the Text node lazy-attach failure problem. 249307 4 61105 abarth 2010-07-09 14:53:04 -0700 Created attachment 61105 Patch for landing 249459 5 61105 commit-queue 2010-07-09 20:48:07 -0700 Comment on attachment 61105 Patch for landing Clearing flags on attachment: 61105 Committed r63037: <http://trac.webkit.org/changeset/63037> 249460 6 commit-queue 2010-07-09 20:48:12 -0700 All reviewed patches have been landed. Closing bug. 61101 2010-07-09 14:43:02 -0700 2010-07-09 14:52:41 -0700 Patch bug-41991-20100709144255.patch text/plain 2661 abarth ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YWE3YjA3ZWYxMGVhNTEzOTMzNDA1MWVlZTdlNTJhMzA3NjY4MmEzOS4uOWJjYTQzZjcwMmFkM2Vm MWYzMTAwOGExNzNmYjBmYzc3MTNlZWIxZSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxMC0wNy0wOSAgQWRh bSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEhUTUw1IHRyZWUgYnVpbGRlciBzaG91bGQgcGFzcyBzb21l IExheW91dFRlc3RzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD00MTk5MQorCisgICAgICAgIEJlZm9yZSB0aGlzIHBhdGNoLCB3ZSB3ZXJlbid0IGF0dGFj aGluZyB0ZXh0IG5vZGVzIHRvIHRoZSByZW5kZXIgdHJlZSwKKyAgICAgICAgd2hpY2ggdHVybnMg b3V0IHRvIGJlIGltcG9ydGFudC4gIDopCisKKyAgICAgICAgVGhpcyBwYXRjaCBmaXhlcyBtb3Jl IHRoYW4gMTAsMDAwIExheW91dFRlc3RzLgorCisgICAgICAgICogaHRtbC9IVE1MQ29uc3RydWN0 aW9uU2l0ZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpIVE1MQ29uc3RydWN0aW9uU2l0ZTo6YXR0 YWNoKToKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxDb25zdHJ1Y3Rpb25TaXRlOjphdHRhY2hBdFNp dGUpOgorCiAyMDEwLTA3LTA5ICBEdW1pdHJ1IERhbmlsaXVjICA8ZHVtaUBjaHJvbWl1bS5vcmc+ CiAKICAgICAgICAgVW5yZXZpZXdlZCwgYnV0IHByZS1hcHByb3ZlZCBieSBFcmljIFNlaWRlbC4K ZGlmZiAtLWdpdCBhL1dlYkNvcmUvaHRtbC9IVE1MQ29uc3RydWN0aW9uU2l0ZS5jcHAgYi9XZWJD b3JlL2h0bWwvSFRNTENvbnN0cnVjdGlvblNpdGUuY3BwCmluZGV4IGU0YWQ0MGExNmIxNGQ5ODM2 M2FhOTg2ZDVlZmViNDE4MGZmMmY0MDUuLjBkMGUzYWJiOThkZjRjODVjMWE1OTM5NjlmYzEwMDQy MDE3MTUxZjcgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvaHRtbC9IVE1MQ29uc3RydWN0aW9uU2l0ZS5j cHAKKysrIGIvV2ViQ29yZS9odG1sL0hUTUxDb25zdHJ1Y3Rpb25TaXRlLmNwcApAQCAtODIsNiAr ODIsNyBAQCBQYXNzUmVmUHRyPENoaWxkVHlwZT4gSFRNTENvbnN0cnVjdGlvblNpdGU6OmF0dGFj aChOb2RlKiBwYXJlbnQsIFBhc3NSZWZQdHI8Q2hpbAogICAgIC8vIGRvZXNuJ3QuICBJdCBmZWVs cyBsaWtlIHdlJ3JlIG1pc3NpbmcgYSBjb25jZXB0IHNvbWVob3cuCiAgICAgaWYgKG1fcmVkaXJl Y3RBdHRhY2hUb0Zvc3RlclBhcmVudCkgewogICAgICAgICBmb3N0ZXJQYXJlbnQoY2hpbGQuZ2V0 KCkpOworICAgICAgICBBU1NFUlQoY2hpbGQtPmF0dGFjaGVkKCkpOwogICAgICAgICByZXR1cm4g Y2hpbGQucmVsZWFzZSgpOwogICAgIH0KIApAQCAtOTEsMjEgKzkyLDMxIEBAIFBhc3NSZWZQdHI8 Q2hpbGRUeXBlPiBIVE1MQ29uc3RydWN0aW9uU2l0ZTo6YXR0YWNoKE5vZGUqIHBhcmVudCwgUGFz c1JlZlB0cjxDaGlsCiAgICAgLy8gfHBhcmVudHwgdG8gaG9sZCBhIHJlZiBhdCB0aGlzIHBvaW50 LiAgSW4gdGhlIGNvbW1vbiBjYXNlIChhdCBsZWFzdAogICAgIC8vIGZvciBlbGVtZW50cyksIGhv d2V2ZXIsIHdlJ2xsIGdldCB0byB1c2UgdGhpcyByZWYgaW4gdGhlIHN0YWNrIG9mCiAgICAgLy8g b3BlbiBlbGVtZW50cy4KKyAgICBBU1NFUlQocGFyZW50LT5hdHRhY2hlZCgpKTsKKyAgICBBU1NF UlQoIWNoaWxkLT5hdHRhY2hlZCgpKTsKICAgICBjaGlsZC0+YXR0YWNoKCk7CiAgICAgcmV0dXJu IGNoaWxkLnJlbGVhc2UoKTsKIH0KIAotdm9pZCBIVE1MQ29uc3RydWN0aW9uU2l0ZTo6YXR0YWNo QXRTaXRlKGNvbnN0IEF0dGFjaG1lbnRTaXRlJiBzaXRlLCBQYXNzUmVmUHRyPE5vZGU+IGNoaWxk KQordm9pZCBIVE1MQ29uc3RydWN0aW9uU2l0ZTo6YXR0YWNoQXRTaXRlKGNvbnN0IEF0dGFjaG1l bnRTaXRlJiBzaXRlLCBQYXNzUmVmUHRyPE5vZGU+IHBycENoaWxkKQogeworICAgIFJlZlB0cjxO b2RlPiBjaGlsZCA9IHBycENoaWxkOworCiAgICAgaWYgKHNpdGUubmV4dENoaWxkKSB7CiAgICAg ICAgIC8vIEZJWE1FOiBXZSBuZWVkIGFuIGluc2VydEVsZW1lbnQgd2hpY2ggZG9lcyBub3Qgc2Vu ZCBtdXRhdGlvbiBldmVudHMuCiAgICAgICAgIEV4Y2VwdGlvbkNvZGUgZWMgPSAwOwogICAgICAg ICBzaXRlLnBhcmVudC0+aW5zZXJ0QmVmb3JlKGNoaWxkLCBzaXRlLm5leHRDaGlsZCwgZWMpOwog ICAgICAgICAvLyBGSVhNRTogRG8gd2UgbmVlZCB0byBjYWxsIGF0dGFjaCgpPwogICAgICAgICBB U1NFUlQoIWVjKTsKKyAgICAgICAgQVNTRVJUKHNpdGUucGFyZW50LT5hdHRhY2hlZCgpKTsKKyAg ICAgICAgaWYgKCFjaGlsZC0+YXR0YWNoZWQoKSkKKyAgICAgICAgICAgIGNoaWxkLT5hdHRhY2go KTsKICAgICAgICAgcmV0dXJuOwogICAgIH0KICAgICBzaXRlLnBhcmVudC0+cGFyc2VyQWRkQ2hp bGQoY2hpbGQpOworICAgIEFTU0VSVChzaXRlLnBhcmVudC0+YXR0YWNoZWQoKSk7CisgICAgaWYg KCFjaGlsZC0+YXR0YWNoZWQoKSkKKyAgICAgICAgY2hpbGQtPmF0dGFjaCgpOwogICAgIC8vIEZJ WE1FOiBEbyB3ZSBuZWVkIHRvIGNhbGwgYXR0YWNoKCk/CiB9CiAK 61105 2010-07-09 14:53:04 -0700 2010-07-09 20:48:07 -0700 Patch for landing bug-41991-20100709145257.patch text/plain 2975 abarth ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YWE3YjA3ZWYxMGVhNTEzOTMzNDA1MWVlZTdlNTJhMzA3NjY4MmEzOS4uNDkxYTczZWZkZjhhMDE0 MDUxMWNhMmY4YzUwNDY2MGZiOWFlMTI1MyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxMC0wNy0wOSAgQWRh bSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IEVyaWMg U2VpZGVsLgorCisgICAgICAgIEhUTUw1IHRyZWUgYnVpbGRlciBzaG91bGQgcGFzcyBzb21lIExh eW91dFRlc3RzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD00MTk5MQorCisgICAgICAgIEJlZm9yZSB0aGlzIHBhdGNoLCB3ZSB3ZXJlbid0IGF0dGFjaGlu ZyB0ZXh0IG5vZGVzIHRvIHRoZSByZW5kZXIgdHJlZSwKKyAgICAgICAgd2hpY2ggdHVybnMgb3V0 IHRvIGJlIGltcG9ydGFudC4gIDopCisKKyAgICAgICAgVGhpcyBwYXRjaCBmaXhlcyBtb3JlIHRo YW4gMTAsMDAwIExheW91dFRlc3RzLgorCisgICAgICAgICogaHRtbC9IVE1MQ29uc3RydWN0aW9u U2l0ZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpIVE1MQ29uc3RydWN0aW9uU2l0ZTo6YXR0YWNo KToKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxDb25zdHJ1Y3Rpb25TaXRlOjphdHRhY2hBdFNpdGUp OgorCiAyMDEwLTA3LTA5ICBEdW1pdHJ1IERhbmlsaXVjICA8ZHVtaUBjaHJvbWl1bS5vcmc+CiAK ICAgICAgICAgVW5yZXZpZXdlZCwgYnV0IHByZS1hcHByb3ZlZCBieSBFcmljIFNlaWRlbC4KZGlm ZiAtLWdpdCBhL1dlYkNvcmUvaHRtbC9IVE1MQ29uc3RydWN0aW9uU2l0ZS5jcHAgYi9XZWJDb3Jl L2h0bWwvSFRNTENvbnN0cnVjdGlvblNpdGUuY3BwCmluZGV4IGU0YWQ0MGExNmIxNGQ5ODM2M2Fh OTg2ZDVlZmViNDE4MGZmMmY0MDUuLjU3NDU2MjVmNGE3ZjkyZDY2NzY4ODBjZWM1M2E1NzdjYTk0 YmM1ZjMgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvaHRtbC9IVE1MQ29uc3RydWN0aW9uU2l0ZS5jcHAK KysrIGIvV2ViQ29yZS9odG1sL0hUTUxDb25zdHJ1Y3Rpb25TaXRlLmNwcApAQCAtODIsNiArODIs NyBAQCBQYXNzUmVmUHRyPENoaWxkVHlwZT4gSFRNTENvbnN0cnVjdGlvblNpdGU6OmF0dGFjaChO b2RlKiBwYXJlbnQsIFBhc3NSZWZQdHI8Q2hpbAogICAgIC8vIGRvZXNuJ3QuICBJdCBmZWVscyBs aWtlIHdlJ3JlIG1pc3NpbmcgYSBjb25jZXB0IHNvbWVob3cuCiAgICAgaWYgKG1fcmVkaXJlY3RB dHRhY2hUb0Zvc3RlclBhcmVudCkgewogICAgICAgICBmb3N0ZXJQYXJlbnQoY2hpbGQuZ2V0KCkp OworICAgICAgICBBU1NFUlQoY2hpbGQtPmF0dGFjaGVkKCkpOwogICAgICAgICByZXR1cm4gY2hp bGQucmVsZWFzZSgpOwogICAgIH0KIApAQCAtOTEsMjIgKzkyLDMzIEBAIFBhc3NSZWZQdHI8Q2hp bGRUeXBlPiBIVE1MQ29uc3RydWN0aW9uU2l0ZTo6YXR0YWNoKE5vZGUqIHBhcmVudCwgUGFzc1Jl ZlB0cjxDaGlsCiAgICAgLy8gfHBhcmVudHwgdG8gaG9sZCBhIHJlZiBhdCB0aGlzIHBvaW50LiAg SW4gdGhlIGNvbW1vbiBjYXNlIChhdCBsZWFzdAogICAgIC8vIGZvciBlbGVtZW50cyksIGhvd2V2 ZXIsIHdlJ2xsIGdldCB0byB1c2UgdGhpcyByZWYgaW4gdGhlIHN0YWNrIG9mCiAgICAgLy8gb3Bl biBlbGVtZW50cy4KKyAgICBBU1NFUlQocGFyZW50LT5hdHRhY2hlZCgpKTsKKyAgICBBU1NFUlQo IWNoaWxkLT5hdHRhY2hlZCgpKTsKICAgICBjaGlsZC0+YXR0YWNoKCk7CiAgICAgcmV0dXJuIGNo aWxkLnJlbGVhc2UoKTsKIH0KIAotdm9pZCBIVE1MQ29uc3RydWN0aW9uU2l0ZTo6YXR0YWNoQXRT aXRlKGNvbnN0IEF0dGFjaG1lbnRTaXRlJiBzaXRlLCBQYXNzUmVmUHRyPE5vZGU+IGNoaWxkKQor dm9pZCBIVE1MQ29uc3RydWN0aW9uU2l0ZTo6YXR0YWNoQXRTaXRlKGNvbnN0IEF0dGFjaG1lbnRT aXRlJiBzaXRlLCBQYXNzUmVmUHRyPE5vZGU+IHBycENoaWxkKQogeworICAgIFJlZlB0cjxOb2Rl PiBjaGlsZCA9IHBycENoaWxkOworCiAgICAgaWYgKHNpdGUubmV4dENoaWxkKSB7CiAgICAgICAg IC8vIEZJWE1FOiBXZSBuZWVkIGFuIGluc2VydEVsZW1lbnQgd2hpY2ggZG9lcyBub3Qgc2VuZCBt dXRhdGlvbiBldmVudHMuCiAgICAgICAgIEV4Y2VwdGlvbkNvZGUgZWMgPSAwOwogICAgICAgICBz aXRlLnBhcmVudC0+aW5zZXJ0QmVmb3JlKGNoaWxkLCBzaXRlLm5leHRDaGlsZCwgZWMpOwotICAg ICAgICAvLyBGSVhNRTogRG8gd2UgbmVlZCB0byBjYWxsIGF0dGFjaCgpPwogICAgICAgICBBU1NF UlQoIWVjKTsKKyAgICAgICAgQVNTRVJUKHNpdGUucGFyZW50LT5hdHRhY2hlZCgpKTsKKyAgICAg ICAgaWYgKCFjaGlsZC0+YXR0YWNoZWQoKSkKKyAgICAgICAgICAgIGNoaWxkLT5hdHRhY2goKTsK ICAgICAgICAgcmV0dXJuOwogICAgIH0KICAgICBzaXRlLnBhcmVudC0+cGFyc2VyQWRkQ2hpbGQo Y2hpbGQpOwotICAgIC8vIEZJWE1FOiBEbyB3ZSBuZWVkIHRvIGNhbGwgYXR0YWNoKCk/CisgICAg Ly8gSXQncyBzbGlnaHRseSB1bmZvcnR1bmF0ZSB0aGF0IHdlIG5lZWQgdG8gaG9sZCBhIHJlZmVy ZW5jZSB0byBjaGlsZAorICAgIC8vIGhlcmUgdG8gY2FsbCBhdHRhY2goKS4gIFdlIHNob3VsZCBp bnZlc3RpZ2F0ZSB3aGV0aGVyIHdlIGNhbiByZWx5IG9uCisgICAgLy8gfHNpdGUucGFyZW50fCB0 byBob2xkIGEgcmVmIGF0IHRoaXMgcG9pbnQuCisgICAgQVNTRVJUKHNpdGUucGFyZW50LT5hdHRh Y2hlZCgpKTsKKyAgICBpZiAoIWNoaWxkLT5hdHRhY2hlZCgpKQorICAgICAgICBjaGlsZC0+YXR0 YWNoKCk7CiB9CiAKIEhUTUxDb25zdHJ1Y3Rpb25TaXRlOjpIVE1MQ29uc3RydWN0aW9uU2l0ZShE b2N1bWVudCogZG9jdW1lbnQsIEZyYWdtZW50U2NyaXB0aW5nUGVybWlzc2lvbiBzY3JpcHRpbmdQ ZXJtaXNzaW9uKQo=