41958 2010-07-09 07:19:45 -0700 [Chromium] Crash when stepping on a breakpoint while debugging Web Inspector 2010-07-12 07:09:28 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 apavlov apavlov pfeldman yurys oldest_to_newest 248990 0 apavlov 2010-07-09 07:19:45 -0700 An empty page group gets in the way in this case, which results into a crash. 249012 1 61045 apavlov 2010-07-09 07:46:02 -0700 Created attachment 61045 [PATCH] Suggested solution 249016 2 61045 yurys 2010-07-09 08:01:30 -0700 Comment on attachment 61045 [PATCH] Suggested solution WebKit/chromium/src/WebViewImpl.cpp:193 + pageGroupLoadDeferrer = new PageGroupLoadDeferrer(pageGroupLoadDeferrer); I'd rather use a regular stack of PageGroupLoadDeferrers and push 0 when page group is empty. 249783 3 61213 apavlov 2010-07-12 05:47:05 -0700 Created attachment 61213 [PATCH] Comments addressed 249788 4 61213 yurys 2010-07-12 06:09:27 -0700 Comment on attachment 61213 [PATCH] Comments addressed WebKit/chromium/src/WebViewImpl.cpp:144 + static std::stack<PageGroupLoadDeferrer*> pageGroupLoadDeferrerStack; "WTF container classes should be used in the implementation of this[chromium/src] API." 249800 5 61220 apavlov 2010-07-12 06:30:51 -0700 Created attachment 61220 [PATCH] Use Vector instead of std::stack 249801 6 61220 yurys 2010-07-12 06:34:19 -0700 Comment on attachment 61220 [PATCH] Use Vector instead of std::stack WebKit/chromium/src/WebViewImpl.cpp:194 + pageGroupLoadDeferrerStack.append(static_cast<PageGroupLoadDeferrer*>(0)); This cast is weird. WebKit/chromium/src/WebViewImpl.cpp:206 + if (pageGroupLoadDeferrer) You don't need this check. 249815 7 apavlov 2010-07-12 07:07:42 -0700 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/page/PageGroupLoadDeferrer.cpp M WebCore/page/PageGroupLoadDeferrer.h M WebKit/chromium/ChangeLog M WebKit/chromium/src/WebViewImpl.cpp Committed r63080 249816 8 apavlov 2010-07-12 07:09:28 -0700 (In reply to comment #6) > (From update of attachment 61220 [details]) > WebKit/chromium/src/WebViewImpl.cpp:194 > + pageGroupLoadDeferrerStack.append(static_cast<PageGroupLoadDeferrer*>(0)); > This cast is weird. Otherwise I get a compile error. > WebKit/chromium/src/WebViewImpl.cpp:206 > + if (pageGroupLoadDeferrer) > You don't need this check. Fixed. 61045 2010-07-09 07:46:02 -0700 2010-07-12 05:47:05 -0700 [PATCH] Suggested solution fixpagegroup.patch text/plain 3230 apavlov ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NjE4MWRkYS4uYmNjMTRjYyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMC0wNy0wOSAgQWxleGFuZGVyIFBh dmxvdiAgPGFwYXZsb3ZAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFtDaHJvbWl1bV0gQ3Jhc2ggd2hlbiBzdGVwcGluZyBvbiBh IGJyZWFrcG9pbnQgd2hpbGUgZGVidWdnaW5nIFdlYiBJbnNwZWN0b3IKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQxOTU4CisKKyAgICAgICAgKiBwYWdl L1BhZ2VHcm91cExvYWREZWZlcnJlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpQYWdlR3JvdXBM b2FkRGVmZXJyZXI6OlBhZ2VHcm91cExvYWREZWZlcnJlcik6CisgICAgICAgICogcGFnZS9QYWdl R3JvdXBMb2FkRGVmZXJyZXIuaDoKKwogMjAxMC0wNy0wOSAgUGF2ZWwgRmVsZG1hbiAgPHBmZWxk bWFuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBZdXJ5IFNlbWlraGF0c2t5 LgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wYWdlL1BhZ2VHcm91cExvYWREZWZlcnJlci5jcHAgYi9X ZWJDb3JlL3BhZ2UvUGFnZUdyb3VwTG9hZERlZmVycmVyLmNwcAppbmRleCA4NmYwN2ZhLi5iZDVk ODY2IDEwMDY0NAotLS0gYS9XZWJDb3JlL3BhZ2UvUGFnZUdyb3VwTG9hZERlZmVycmVyLmNwcAor KysgYi9XZWJDb3JlL3BhZ2UvUGFnZUdyb3VwTG9hZERlZmVycmVyLmNwcApAQCAtMzAsNiArMzAs MTEgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogCiB1c2luZyBuYW1lc3BhY2Ugc3RkOwogCitQYWdl R3JvdXBMb2FkRGVmZXJyZXI6OlBhZ2VHcm91cExvYWREZWZlcnJlcihQYWdlR3JvdXBMb2FkRGVm ZXJyZXIqIG5leHREZWZlcnJlcikKKyAgICA6IG1fbmV4dERlZmVycmVyKG5leHREZWZlcnJlcikK K3sKK30KKwogUGFnZUdyb3VwTG9hZERlZmVycmVyOjpQYWdlR3JvdXBMb2FkRGVmZXJyZXIoUGFn ZSogcGFnZSwgYm9vbCBkZWZlclNlbGYsIFBhZ2VHcm91cExvYWREZWZlcnJlciogbmV4dERlZmVy cmVyKQogICAgIDogbV9uZXh0RGVmZXJyZXIobmV4dERlZmVycmVyKQogewpkaWZmIC0tZ2l0IGEv V2ViQ29yZS9wYWdlL1BhZ2VHcm91cExvYWREZWZlcnJlci5oIGIvV2ViQ29yZS9wYWdlL1BhZ2VH cm91cExvYWREZWZlcnJlci5oCmluZGV4IGRkN2NmNGQuLmZhNzJmN2QgMTAwNjQ0Ci0tLSBhL1dl YkNvcmUvcGFnZS9QYWdlR3JvdXBMb2FkRGVmZXJyZXIuaAorKysgYi9XZWJDb3JlL3BhZ2UvUGFn ZUdyb3VwTG9hZERlZmVycmVyLmgKQEAgLTMwLDYgKzMwLDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUg ewogCiAgICAgY2xhc3MgUGFnZUdyb3VwTG9hZERlZmVycmVyIDogcHVibGljIE5vbmNvcHlhYmxl IHsKICAgICBwdWJsaWM6CisgICAgICAgIFBhZ2VHcm91cExvYWREZWZlcnJlcihQYWdlR3JvdXBM b2FkRGVmZXJyZXIqIG5leHREZWZlcnJlcik7CiAgICAgICAgIFBhZ2VHcm91cExvYWREZWZlcnJl cihQYWdlKiwgYm9vbCBkZWZlclNlbGYsIFBhZ2VHcm91cExvYWREZWZlcnJlciogbmV4dERlZmVy cmVyID0gMCk7CiAgICAgICAgIH5QYWdlR3JvdXBMb2FkRGVmZXJyZXIoKTsKICAgICAgICAgUGFn ZUdyb3VwTG9hZERlZmVycmVyKiBuZXh0RGVmZXJyZXIoKSB7IHJldHVybiBtX25leHREZWZlcnJl cjsgfQpkaWZmIC0tZ2l0IGEvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZyBiL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKaW5kZXggZGE0NWVlOS4uNTNjNjE4YyAxMDA2NDQKLS0tIGEvV2ViS2l0 L2Nocm9taXVtL0NoYW5nZUxvZworKysgYi9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTMgQEAKKzIwMTAtMDctMDkgIEFsZXhhbmRlciBQYXZsb3YgIDxhcGF2bG92QGNocm9t aXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBbQ2hyb21pdW1dIENyYXNoIHdoZW4gc3RlcHBpbmcgb24gYSBicmVha3BvaW50IHdoaWxlIGRl YnVnZ2luZyBXZWIgSW5zcGVjdG9yCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD00MTk1OAorCisgICAgICAgICogc3JjL1dlYlZpZXdJbXBsLmNwcDoKKyAg ICAgICAgKFdlYktpdDo6V2ViVmlldzo6d2lsbEVudGVyTW9kYWxMb29wKToKKwogMjAxMC0wNy0w OSAgRGF2aWQgSG9sbG93YXkgIDxkaG9sbG93YUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2 aWV3ZWQgYnkgRGltaXRyaSBHbGF6a292LgpkaWZmIC0tZ2l0IGEvV2ViS2l0L2Nocm9taXVtL3Ny Yy9XZWJWaWV3SW1wbC5jcHAgYi9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmNwcApp bmRleCA1ODk3ZGVmLi40NWM5OTQ5IDEwMDY0NAotLS0gYS9XZWJLaXQvY2hyb21pdW0vc3JjL1dl YlZpZXdJbXBsLmNwcAorKysgYi9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmNwcApA QCAtMTkwLDEwICsxOTAsMTEgQEAgdm9pZCBXZWJWaWV3Ojp3aWxsRW50ZXJNb2RhbExvb3AoKQog ICAgIEFTU0VSVChwYWdlR3JvdXApOwogCiAgICAgaWYgKHBhZ2VHcm91cC0+cGFnZXMoKS5pc0Vt cHR5KCkpCi0gICAgICAgIHJldHVybjsKLQotICAgIC8vIFBpY2sgYW55IHBhZ2UgaW4gdGhlIHBh Z2UgZ3JvdXAgc2luY2Ugd2UgYXJlIGRlZmVycmluZyBhbGwgcGFnZXMuCi0gICAgcGFnZUdyb3Vw TG9hZERlZmVycmVyID0gbmV3IFBhZ2VHcm91cExvYWREZWZlcnJlcigqcGFnZUdyb3VwLT5wYWdl cygpLmJlZ2luKCksIHRydWUsIHBhZ2VHcm91cExvYWREZWZlcnJlcik7CisgICAgICAgIHBhZ2VH cm91cExvYWREZWZlcnJlciA9IG5ldyBQYWdlR3JvdXBMb2FkRGVmZXJyZXIocGFnZUdyb3VwTG9h ZERlZmVycmVyKTsKKyAgICBlbHNlIHsKKyAgICAgICAgLy8gUGljayBhbnkgcGFnZSBpbiB0aGUg cGFnZSBncm91cCBzaW5jZSB3ZSBhcmUgZGVmZXJyaW5nIGFsbCBwYWdlcy4KKyAgICAgICAgcGFn ZUdyb3VwTG9hZERlZmVycmVyID0gbmV3IFBhZ2VHcm91cExvYWREZWZlcnJlcigqcGFnZUdyb3Vw LT5wYWdlcygpLmJlZ2luKCksIHRydWUsIHBhZ2VHcm91cExvYWREZWZlcnJlcik7CisgICAgfQog fQogCiB2b2lkIFdlYlZpZXc6OmRpZEV4aXRNb2RhbExvb3AoKQo= 61213 2010-07-12 05:47:05 -0700 2010-07-12 06:30:51 -0700 [PATCH] Comments addressed fixpagegroup.patch text/plain 4570 apavlov ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NjE4MWRkYS4uZjUwNmQxZiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMC0wNy0xMiAgQWxleGFuZGVyIFBh dmxvdiAgPGFwYXZsb3ZAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFtDaHJvbWl1bV0gQ3Jhc2ggd2hlbiBzdGVwcGluZyBvbiBh IGJyZWFrcG9pbnQgd2hpbGUgZGVidWdnaW5nIFdlYiBJbnNwZWN0b3IKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQxOTU4CisKKyAgICAgICAgKiBwYWdl L1BhZ2VHcm91cExvYWREZWZlcnJlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpQYWdlR3JvdXBM b2FkRGVmZXJyZXI6OlBhZ2VHcm91cExvYWREZWZlcnJlcik6CisgICAgICAgICogcGFnZS9QYWdl R3JvdXBMb2FkRGVmZXJyZXIuaDoKKwogMjAxMC0wNy0wOSAgUGF2ZWwgRmVsZG1hbiAgPHBmZWxk bWFuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBZdXJ5IFNlbWlraGF0c2t5 LgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wYWdlL1BhZ2VHcm91cExvYWREZWZlcnJlci5jcHAgYi9X ZWJDb3JlL3BhZ2UvUGFnZUdyb3VwTG9hZERlZmVycmVyLmNwcAppbmRleCA4NmYwN2ZhLi5jZWQ4 ZjM2IDEwMDY0NAotLS0gYS9XZWJDb3JlL3BhZ2UvUGFnZUdyb3VwTG9hZERlZmVycmVyLmNwcAor KysgYi9XZWJDb3JlL3BhZ2UvUGFnZUdyb3VwTG9hZERlZmVycmVyLmNwcApAQCAtMzAsOCArMzAs NyBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKIHVzaW5nIG5hbWVzcGFjZSBzdGQ7CiAKLVBhZ2VH cm91cExvYWREZWZlcnJlcjo6UGFnZUdyb3VwTG9hZERlZmVycmVyKFBhZ2UqIHBhZ2UsIGJvb2wg ZGVmZXJTZWxmLCBQYWdlR3JvdXBMb2FkRGVmZXJyZXIqIG5leHREZWZlcnJlcikKLSAgICA6IG1f bmV4dERlZmVycmVyKG5leHREZWZlcnJlcikKK1BhZ2VHcm91cExvYWREZWZlcnJlcjo6UGFnZUdy b3VwTG9hZERlZmVycmVyKFBhZ2UqIHBhZ2UsIGJvb2wgZGVmZXJTZWxmKQogewogICAgIGNvbnN0 IEhhc2hTZXQ8UGFnZSo+JiBwYWdlcyA9IHBhZ2UtPmdyb3VwKCkucGFnZXMoKTsKIApkaWZmIC0t Z2l0IGEvV2ViQ29yZS9wYWdlL1BhZ2VHcm91cExvYWREZWZlcnJlci5oIGIvV2ViQ29yZS9wYWdl L1BhZ2VHcm91cExvYWREZWZlcnJlci5oCmluZGV4IGRkN2NmNGQuLmQ0NDNlYmQgMTAwNjQ0Ci0t LSBhL1dlYkNvcmUvcGFnZS9QYWdlR3JvdXBMb2FkRGVmZXJyZXIuaAorKysgYi9XZWJDb3JlL3Bh Z2UvUGFnZUdyb3VwTG9hZERlZmVycmVyLmgKQEAgLTMwLDEzICszMCwxMSBAQCBuYW1lc3BhY2Ug V2ViQ29yZSB7CiAKICAgICBjbGFzcyBQYWdlR3JvdXBMb2FkRGVmZXJyZXIgOiBwdWJsaWMgTm9u Y29weWFibGUgewogICAgIHB1YmxpYzoKLSAgICAgICAgUGFnZUdyb3VwTG9hZERlZmVycmVyKFBh Z2UqLCBib29sIGRlZmVyU2VsZiwgUGFnZUdyb3VwTG9hZERlZmVycmVyKiBuZXh0RGVmZXJyZXIg PSAwKTsKKyAgICAgICAgUGFnZUdyb3VwTG9hZERlZmVycmVyKFBhZ2UqLCBib29sIGRlZmVyU2Vs Zik7CiAgICAgICAgIH5QYWdlR3JvdXBMb2FkRGVmZXJyZXIoKTsKLSAgICAgICAgUGFnZUdyb3Vw TG9hZERlZmVycmVyKiBuZXh0RGVmZXJyZXIoKSB7IHJldHVybiBtX25leHREZWZlcnJlcjsgfQog CiAgICAgcHJpdmF0ZToKICAgICAgICAgVmVjdG9yPFJlZlB0cjxGcmFtZT4sIDE2PiBtX2RlZmVy cmVkRnJhbWVzOwotICAgICAgICBQYWdlR3JvdXBMb2FkRGVmZXJyZXIqIG1fbmV4dERlZmVycmVy OwogICAgIH07CiB9CiAKZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9X ZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4IGRhNDVlZTkuLmIzN2Q1ZGYgMTAwNjQ0Ci0t LSBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5n ZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEwLTA3LTEyICBBbGV4YW5kZXIgUGF2bG92ICA8YXBh dmxvdkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgW0Nocm9taXVtXSBDcmFzaCB3aGVuIHN0ZXBwaW5nIG9uIGEgYnJlYWtwb2lu dCB3aGlsZSBkZWJ1Z2dpbmcgV2ViIEluc3BlY3RvcgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDE5NTgKKworICAgICAgICAqIHNyYy9XZWJWaWV3SW1w bC5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlZpZXc6OndpbGxFbnRlck1vZGFsTG9vcCk6Cisg ICAgICAgIChXZWJLaXQ6OldlYlZpZXc6OmRpZEV4aXRNb2RhbExvb3ApOgorCiAyMDEwLTA3LTA5 ICBEYXZpZCBIb2xsb3dheSAgPGRob2xsb3dhQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZp ZXdlZCBieSBEaW1pdHJpIEdsYXprb3YuCmRpZmYgLS1naXQgYS9XZWJLaXQvY2hyb21pdW0vc3Jj L1dlYlZpZXdJbXBsLmNwcCBiL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuY3BwCmlu ZGV4IDU4OTdkZWYuLmE0MzM5MTEgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJvbWl1bS9zcmMvV2Vi Vmlld0ltcGwuY3BwCisrKyBiL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuY3BwCkBA IC0xMTksNiArMTE5LDcgQEAKIC8vIEdldCByaWQgb2YgV1RGJ3MgcG93IGRlZmluZSBzbyB3ZSBj YW4gdXNlIHN0ZDo6cG93LgogI3VuZGVmIHBvdwogI2luY2x1ZGUgPGNtYXRoPiAvLyBmb3Igc3Rk Ojpwb3cKKyNpbmNsdWRlIDxzdGFjaz4KIAogdXNpbmcgbmFtZXNwYWNlIFdlYkNvcmU7CiAKQEAg LTEzOSw4ICsxNDAsOCBAQCBzdGF0aWMgY29uc3QgZG91YmxlIG1heFRleHRTaXplTXVsdGlwbGll ciA9IDMuMDsKIGNvbnN0IGNoYXIqIHBhZ2VHcm91cE5hbWUgPSAiZGVmYXVsdCI7CiAKIC8vIFVz ZWQgdG8gZGVmZXIgYWxsIHBhZ2UgYWN0aXZpdHkgaW4gY2FzZXMgd2hlcmUgdGhlIGVtYmVkZGVy IHdpc2hlcyB0byBydW4KLS8vIGEgbmVzdGVkIGV2ZW50IGxvb3AuCi1zdGF0aWMgUGFnZUdyb3Vw TG9hZERlZmVycmVyKiBwYWdlR3JvdXBMb2FkRGVmZXJyZXI7CisvLyBhIG5lc3RlZCBldmVudCBs b29wLiBVc2luZyBhIHN0YWNrIGVuYWJsZXMgbmVzdGluZyBvZiBtZXNzYWdlIGxvb3AgaW52b2Nh dGlvbnMuCitzdGF0aWMgc3RkOjpzdGFjazxQYWdlR3JvdXBMb2FkRGVmZXJyZXIqPiBwYWdlR3Jv dXBMb2FkRGVmZXJyZXJTdGFjazsKIAogLy8gRW5zdXJlIHRoYXQgdGhlIFdlYkRyYWdPcGVyYXRp b24gZW51bSB2YWx1ZXMgc3RheSBpbiBzeW5jIHdpdGggdGhlIG9yaWdpbmFsCiAvLyBEcmFnT3Bl cmF0aW9uIGNvbnN0YW50cy4KQEAgLTE5MCwxOSArMTkxLDIxIEBAIHZvaWQgV2ViVmlldzo6d2ls bEVudGVyTW9kYWxMb29wKCkKICAgICBBU1NFUlQocGFnZUdyb3VwKTsKIAogICAgIGlmIChwYWdl R3JvdXAtPnBhZ2VzKCkuaXNFbXB0eSgpKQotICAgICAgICByZXR1cm47Ci0KLSAgICAvLyBQaWNr IGFueSBwYWdlIGluIHRoZSBwYWdlIGdyb3VwIHNpbmNlIHdlIGFyZSBkZWZlcnJpbmcgYWxsIHBh Z2VzLgotICAgIHBhZ2VHcm91cExvYWREZWZlcnJlciA9IG5ldyBQYWdlR3JvdXBMb2FkRGVmZXJy ZXIoKnBhZ2VHcm91cC0+cGFnZXMoKS5iZWdpbigpLCB0cnVlLCBwYWdlR3JvdXBMb2FkRGVmZXJy ZXIpOworICAgICAgICBwYWdlR3JvdXBMb2FkRGVmZXJyZXJTdGFjay5wdXNoKDApOworICAgIGVs c2UgeworICAgICAgICAvLyBQaWNrIGFueSBwYWdlIGluIHRoZSBwYWdlIGdyb3VwIHNpbmNlIHdl IGFyZSBkZWZlcnJpbmcgYWxsIHBhZ2VzLgorICAgICAgICBwYWdlR3JvdXBMb2FkRGVmZXJyZXJT dGFjay5wdXNoKG5ldyBQYWdlR3JvdXBMb2FkRGVmZXJyZXIoKnBhZ2VHcm91cC0+cGFnZXMoKS5i ZWdpbigpLCB0cnVlKSk7CisgICAgfQogfQogCiB2b2lkIFdlYlZpZXc6OmRpZEV4aXRNb2RhbExv b3AoKQogewotICAgIEFTU0VSVChwYWdlR3JvdXBMb2FkRGVmZXJyZXIpOwotICAgIFBhZ2VHcm91 cExvYWREZWZlcnJlciogbmV4dERlZmVycmVyID0gcGFnZUdyb3VwTG9hZERlZmVycmVyLT5uZXh0 RGVmZXJyZXIoKTsKKyAgICBBU1NFUlQocGFnZUdyb3VwTG9hZERlZmVycmVyU3RhY2suc2l6ZSgp KTsKIAotICAgIGRlbGV0ZSBwYWdlR3JvdXBMb2FkRGVmZXJyZXI7Ci0gICAgcGFnZUdyb3VwTG9h ZERlZmVycmVyID0gbmV4dERlZmVycmVyOworICAgIFBhZ2VHcm91cExvYWREZWZlcnJlciogcGFn ZUdyb3VwTG9hZERlZmVycmVyID0gcGFnZUdyb3VwTG9hZERlZmVycmVyU3RhY2sudG9wKCk7Cisg ICAgaWYgKHBhZ2VHcm91cExvYWREZWZlcnJlcikKKyAgICAgICAgZGVsZXRlIHBhZ2VHcm91cExv YWREZWZlcnJlcjsKKyAgICBwYWdlR3JvdXBMb2FkRGVmZXJyZXJTdGFjay5wb3AoKTsKIH0KIAog dm9pZCBXZWJWaWV3SW1wbDo6aW5pdGlhbGl6ZU1haW5GcmFtZShXZWJGcmFtZUNsaWVudCogZnJh bWVDbGllbnQpCg== 61220 2010-07-12 06:30:51 -0700 2010-07-12 06:34:19 -0700 [PATCH] Use Vector instead of std::stack fixpagegroup.patch text/plain 4665 apavlov ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NjE4MWRkYS4uZjUwNmQxZiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMC0wNy0xMiAgQWxleGFuZGVyIFBh dmxvdiAgPGFwYXZsb3ZAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFtDaHJvbWl1bV0gQ3Jhc2ggd2hlbiBzdGVwcGluZyBvbiBh IGJyZWFrcG9pbnQgd2hpbGUgZGVidWdnaW5nIFdlYiBJbnNwZWN0b3IKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQxOTU4CisKKyAgICAgICAgKiBwYWdl L1BhZ2VHcm91cExvYWREZWZlcnJlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpQYWdlR3JvdXBM b2FkRGVmZXJyZXI6OlBhZ2VHcm91cExvYWREZWZlcnJlcik6CisgICAgICAgICogcGFnZS9QYWdl R3JvdXBMb2FkRGVmZXJyZXIuaDoKKwogMjAxMC0wNy0wOSAgUGF2ZWwgRmVsZG1hbiAgPHBmZWxk bWFuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBZdXJ5IFNlbWlraGF0c2t5 LgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wYWdlL1BhZ2VHcm91cExvYWREZWZlcnJlci5jcHAgYi9X ZWJDb3JlL3BhZ2UvUGFnZUdyb3VwTG9hZERlZmVycmVyLmNwcAppbmRleCA4NmYwN2ZhLi5jZWQ4 ZjM2IDEwMDY0NAotLS0gYS9XZWJDb3JlL3BhZ2UvUGFnZUdyb3VwTG9hZERlZmVycmVyLmNwcAor KysgYi9XZWJDb3JlL3BhZ2UvUGFnZUdyb3VwTG9hZERlZmVycmVyLmNwcApAQCAtMzAsOCArMzAs NyBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKIHVzaW5nIG5hbWVzcGFjZSBzdGQ7CiAKLVBhZ2VH cm91cExvYWREZWZlcnJlcjo6UGFnZUdyb3VwTG9hZERlZmVycmVyKFBhZ2UqIHBhZ2UsIGJvb2wg ZGVmZXJTZWxmLCBQYWdlR3JvdXBMb2FkRGVmZXJyZXIqIG5leHREZWZlcnJlcikKLSAgICA6IG1f bmV4dERlZmVycmVyKG5leHREZWZlcnJlcikKK1BhZ2VHcm91cExvYWREZWZlcnJlcjo6UGFnZUdy b3VwTG9hZERlZmVycmVyKFBhZ2UqIHBhZ2UsIGJvb2wgZGVmZXJTZWxmKQogewogICAgIGNvbnN0 IEhhc2hTZXQ8UGFnZSo+JiBwYWdlcyA9IHBhZ2UtPmdyb3VwKCkucGFnZXMoKTsKIApkaWZmIC0t Z2l0IGEvV2ViQ29yZS9wYWdlL1BhZ2VHcm91cExvYWREZWZlcnJlci5oIGIvV2ViQ29yZS9wYWdl L1BhZ2VHcm91cExvYWREZWZlcnJlci5oCmluZGV4IGRkN2NmNGQuLmQ0NDNlYmQgMTAwNjQ0Ci0t LSBhL1dlYkNvcmUvcGFnZS9QYWdlR3JvdXBMb2FkRGVmZXJyZXIuaAorKysgYi9XZWJDb3JlL3Bh Z2UvUGFnZUdyb3VwTG9hZERlZmVycmVyLmgKQEAgLTMwLDEzICszMCwxMSBAQCBuYW1lc3BhY2Ug V2ViQ29yZSB7CiAKICAgICBjbGFzcyBQYWdlR3JvdXBMb2FkRGVmZXJyZXIgOiBwdWJsaWMgTm9u Y29weWFibGUgewogICAgIHB1YmxpYzoKLSAgICAgICAgUGFnZUdyb3VwTG9hZERlZmVycmVyKFBh Z2UqLCBib29sIGRlZmVyU2VsZiwgUGFnZUdyb3VwTG9hZERlZmVycmVyKiBuZXh0RGVmZXJyZXIg PSAwKTsKKyAgICAgICAgUGFnZUdyb3VwTG9hZERlZmVycmVyKFBhZ2UqLCBib29sIGRlZmVyU2Vs Zik7CiAgICAgICAgIH5QYWdlR3JvdXBMb2FkRGVmZXJyZXIoKTsKLSAgICAgICAgUGFnZUdyb3Vw TG9hZERlZmVycmVyKiBuZXh0RGVmZXJyZXIoKSB7IHJldHVybiBtX25leHREZWZlcnJlcjsgfQog CiAgICAgcHJpdmF0ZToKICAgICAgICAgVmVjdG9yPFJlZlB0cjxGcmFtZT4sIDE2PiBtX2RlZmVy cmVkRnJhbWVzOwotICAgICAgICBQYWdlR3JvdXBMb2FkRGVmZXJyZXIqIG1fbmV4dERlZmVycmVy OwogICAgIH07CiB9CiAKZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9X ZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4IGRhNDVlZTkuLmIzN2Q1ZGYgMTAwNjQ0Ci0t LSBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5n ZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEwLTA3LTEyICBBbGV4YW5kZXIgUGF2bG92ICA8YXBh dmxvdkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgW0Nocm9taXVtXSBDcmFzaCB3aGVuIHN0ZXBwaW5nIG9uIGEgYnJlYWtwb2lu dCB3aGlsZSBkZWJ1Z2dpbmcgV2ViIEluc3BlY3RvcgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDE5NTgKKworICAgICAgICAqIHNyYy9XZWJWaWV3SW1w bC5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlZpZXc6OndpbGxFbnRlck1vZGFsTG9vcCk6Cisg ICAgICAgIChXZWJLaXQ6OldlYlZpZXc6OmRpZEV4aXRNb2RhbExvb3ApOgorCiAyMDEwLTA3LTA5 ICBEYXZpZCBIb2xsb3dheSAgPGRob2xsb3dhQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZp ZXdlZCBieSBEaW1pdHJpIEdsYXprb3YuCmRpZmYgLS1naXQgYS9XZWJLaXQvY2hyb21pdW0vc3Jj L1dlYlZpZXdJbXBsLmNwcCBiL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuY3BwCmlu ZGV4IDU4OTdkZWYuLjRkOTgyNjEgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJvbWl1bS9zcmMvV2Vi Vmlld0ltcGwuY3BwCisrKyBiL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuY3BwCkBA IC04NCw2ICs4NCw3IEBACiAjaW5jbHVkZSAiU2V0dGluZ3MuaCIKICNpbmNsdWRlICJUaW1lci5o IgogI2luY2x1ZGUgIlR5cGluZ0NvbW1hbmQuaCIKKyNpbmNsdWRlICJWZWN0b3IuaCIKICNpbmNs dWRlICJXZWJBY2Nlc3NpYmlsaXR5T2JqZWN0LmgiCiAjaW5jbHVkZSAiV2ViRGV2VG9vbHNBZ2Vu dFByaXZhdGUuaCIKICNpbmNsdWRlICJXZWJEZXZUb29sc0FnZW50SW1wbC5oIgpAQCAtMTM5LDgg KzE0MCw4IEBAIHN0YXRpYyBjb25zdCBkb3VibGUgbWF4VGV4dFNpemVNdWx0aXBsaWVyID0gMy4w OwogY29uc3QgY2hhciogcGFnZUdyb3VwTmFtZSA9ICJkZWZhdWx0IjsKIAogLy8gVXNlZCB0byBk ZWZlciBhbGwgcGFnZSBhY3Rpdml0eSBpbiBjYXNlcyB3aGVyZSB0aGUgZW1iZWRkZXIgd2lzaGVz IHRvIHJ1bgotLy8gYSBuZXN0ZWQgZXZlbnQgbG9vcC4KLXN0YXRpYyBQYWdlR3JvdXBMb2FkRGVm ZXJyZXIqIHBhZ2VHcm91cExvYWREZWZlcnJlcjsKKy8vIGEgbmVzdGVkIGV2ZW50IGxvb3AuIFVz aW5nIGEgc3RhY2sgZW5hYmxlcyBuZXN0aW5nIG9mIG1lc3NhZ2UgbG9vcCBpbnZvY2F0aW9ucy4K K3N0YXRpYyBWZWN0b3I8UGFnZUdyb3VwTG9hZERlZmVycmVyKj4gcGFnZUdyb3VwTG9hZERlZmVy cmVyU3RhY2s7CiAKIC8vIEVuc3VyZSB0aGF0IHRoZSBXZWJEcmFnT3BlcmF0aW9uIGVudW0gdmFs dWVzIHN0YXkgaW4gc3luYyB3aXRoIHRoZSBvcmlnaW5hbAogLy8gRHJhZ09wZXJhdGlvbiBjb25z dGFudHMuCkBAIC0xOTAsMTkgKzE5MSwyMSBAQCB2b2lkIFdlYlZpZXc6OndpbGxFbnRlck1vZGFs TG9vcCgpCiAgICAgQVNTRVJUKHBhZ2VHcm91cCk7CiAKICAgICBpZiAocGFnZUdyb3VwLT5wYWdl cygpLmlzRW1wdHkoKSkKLSAgICAgICAgcmV0dXJuOwotCi0gICAgLy8gUGljayBhbnkgcGFnZSBp biB0aGUgcGFnZSBncm91cCBzaW5jZSB3ZSBhcmUgZGVmZXJyaW5nIGFsbCBwYWdlcy4KLSAgICBw YWdlR3JvdXBMb2FkRGVmZXJyZXIgPSBuZXcgUGFnZUdyb3VwTG9hZERlZmVycmVyKCpwYWdlR3Jv dXAtPnBhZ2VzKCkuYmVnaW4oKSwgdHJ1ZSwgcGFnZUdyb3VwTG9hZERlZmVycmVyKTsKKyAgICAg ICAgcGFnZUdyb3VwTG9hZERlZmVycmVyU3RhY2suYXBwZW5kKHN0YXRpY19jYXN0PFBhZ2VHcm91 cExvYWREZWZlcnJlcio+KDApKTsKKyAgICBlbHNlIHsKKyAgICAgICAgLy8gUGljayBhbnkgcGFn ZSBpbiB0aGUgcGFnZSBncm91cCBzaW5jZSB3ZSBhcmUgZGVmZXJyaW5nIGFsbCBwYWdlcy4KKyAg ICAgICAgcGFnZUdyb3VwTG9hZERlZmVycmVyU3RhY2suYXBwZW5kKG5ldyBQYWdlR3JvdXBMb2Fk RGVmZXJyZXIoKnBhZ2VHcm91cC0+cGFnZXMoKS5iZWdpbigpLCB0cnVlKSk7CisgICAgfQogfQog CiB2b2lkIFdlYlZpZXc6OmRpZEV4aXRNb2RhbExvb3AoKQogewotICAgIEFTU0VSVChwYWdlR3Jv dXBMb2FkRGVmZXJyZXIpOwotICAgIFBhZ2VHcm91cExvYWREZWZlcnJlciogbmV4dERlZmVycmVy ID0gcGFnZUdyb3VwTG9hZERlZmVycmVyLT5uZXh0RGVmZXJyZXIoKTsKKyAgICBBU1NFUlQocGFn ZUdyb3VwTG9hZERlZmVycmVyU3RhY2suc2l6ZSgpKTsKIAotICAgIGRlbGV0ZSBwYWdlR3JvdXBM b2FkRGVmZXJyZXI7Ci0gICAgcGFnZUdyb3VwTG9hZERlZmVycmVyID0gbmV4dERlZmVycmVyOwor ICAgIFBhZ2VHcm91cExvYWREZWZlcnJlciogcGFnZUdyb3VwTG9hZERlZmVycmVyID0gcGFnZUdy b3VwTG9hZERlZmVycmVyU3RhY2subGFzdCgpOworICAgIGlmIChwYWdlR3JvdXBMb2FkRGVmZXJy ZXIpCisgICAgICAgIGRlbGV0ZSBwYWdlR3JvdXBMb2FkRGVmZXJyZXI7CisgICAgcGFnZUdyb3Vw TG9hZERlZmVycmVyU3RhY2sucmVtb3ZlTGFzdCgpOwogfQogCiB2b2lkIFdlYlZpZXdJbXBsOjpp bml0aWFsaXplTWFpbkZyYW1lKFdlYkZyYW1lQ2xpZW50KiBmcmFtZUNsaWVudCkK