41957 2010-07-09 06:30:21 -0700 Web Inspector: do not show default tooltip when detailed network info is available. 2010-07-09 07:17:43 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 pfeldman webkit-unassigned yurys oldest_to_newest 248957 0 pfeldman 2010-07-09 06:30:21 -0700 Also aligns values to the right. Patch to follow. 248968 1 61043 pfeldman 2010-07-09 07:10:07 -0700 Created attachment 61043 [PATCH] Proposed fix. 248971 2 61043 yurys 2010-07-09 07:13:38 -0700 Comment on attachment 61043 [PATCH] Proposed fix. WebCore/inspector/front-end/ResourcesPanel.js:755 + WebInspector.UIString("Proxy"), resource.timing.proxyDuration == -1 ? "(none)" : Number.secondsToString(resource.timing.proxyDuration), Default values should be localized, please call WebInspector.UIString for them. 248980 3 pfeldman 2010-07-09 07:17:43 -0700 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/English.lproj/localizedStrings.js M WebCore/inspector/front-end/ResourcesPanel.js Committed r62949 61043 2010-07-09 07:10:07 -0700 2010-07-09 07:13:38 -0700 [PATCH] Proposed fix. align_labels text/plain 5635 pfeldman ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZTQ3ZWQ0NS4uODRmOTE0NyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMCBAQAorMjAxMC0wNy0wOSAgUGF2ZWwgRmVsZG1h biAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBkbyBub3Qgc2hvdyBkZWZhdWx0IHRv b2x0aXAgd2hlbiBkZXRhaWxlZCBuZXR3b3JrIGluZm8gaXMgYXZhaWxhYmxlLgorCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MTk1NworCisgICAgICAg ICogRW5nbGlzaC5scHJvai9sb2NhbGl6ZWRTdHJpbmdzLmpzOgorICAgICAgICAqIGluc3BlY3Rv ci9mcm9udC1lbmQvUmVzb3VyY2VzUGFuZWwuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuUmVz b3VyY2VzUGFuZWwpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlJlc291cmNlc1BhbmVsLnByb3Rv dHlwZS5yZXNldCk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuUmVzb3VyY2VzUGFuZWwucHJvdG90 eXBlLnNob3dSZXNvdXJjZSk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuUmVzb3VyY2VzUGFuZWwu cHJvdG90eXBlLl9nZXRQb3BvdmVyQW5jaG9yKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5SZXNv dXJjZXNQYW5lbC5wcm90b3R5cGUuX3Nob3dQb3BvdmVyKToKKyAgICAgICAgKFdlYkluc3BlY3Rv ci5SZXNvdXJjZVRpbWVDYWxjdWxhdG9yLnByb3RvdHlwZS5jb21wdXRlQmFyR3JhcGhMYWJlbHMp OgorCiAyMDEwLTA3LTA5ICBZYWVsIEFoYXJvbiAgPHlhZWwuYWhhcm9uQG5va2lhLmNvbT4KIAog ICAgICAgICBSZXZpZXdlZCBieSBMYXN6bG8gR29tYm9zLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9F bmdsaXNoLmxwcm9qL2xvY2FsaXplZFN0cmluZ3MuanMgYi9XZWJDb3JlL0VuZ2xpc2gubHByb2ov bG9jYWxpemVkU3RyaW5ncy5qcwppbmRleCA5MjgxMzMwLi5lNjI0YjE2IDEwMDY0NApCaW5hcnkg ZmlsZXMgYS9XZWJDb3JlL0VuZ2xpc2gubHByb2ovbG9jYWxpemVkU3RyaW5ncy5qcyBhbmQgYi9X ZWJDb3JlL0VuZ2xpc2gubHByb2ovbG9jYWxpemVkU3RyaW5ncy5qcyBkaWZmZXIKZGlmZiAtLWdp dCBhL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9SZXNvdXJjZXNQYW5lbC5qcyBiL1dlYkNv cmUvaW5zcGVjdG9yL2Zyb250LWVuZC9SZXNvdXJjZXNQYW5lbC5qcwppbmRleCBiMTE3ZDU3Li5i ZGFhMGFkIDEwMDY0NAotLS0gYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvUmVzb3VyY2Vz UGFuZWwuanMKKysrIGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1Jlc291cmNlc1BhbmVs LmpzCkBAIC00MSwxMyArNDEsMTIgQEAgV2ViSW5zcGVjdG9yLlJlc291cmNlc1BhbmVsID0gZnVu Y3Rpb24oKQogICAgIHRoaXMuY3JlYXRlSW50ZXJmYWNlKCk7CiAKICAgICB0aGlzLl9jcmVhdGVT dGF0dXNiYXJCdXR0b25zKCk7CisgICAgdGhpcy5fcG9wb3ZlckhlbHBlciA9IG5ldyBXZWJJbnNw ZWN0b3IuUG9wb3ZlckhlbHBlcih0aGlzLmVsZW1lbnQsIHRoaXMuX2dldFBvcG92ZXJBbmNob3Iu YmluZCh0aGlzKSwgdGhpcy5fc2hvd1BvcG92ZXIuYmluZCh0aGlzKSwgdHJ1ZSk7CiAKICAgICB0 aGlzLnJlc2V0KCk7CiAgICAgdGhpcy5maWx0ZXIodGhpcy5maWx0ZXJBbGxFbGVtZW50LCBmYWxz ZSk7CiAgICAgdGhpcy5ncmFwaHNUcmVlRWxlbWVudC5jaGlsZHJlblswXS5zZWxlY3QoKTsKICAg ICB0aGlzLl9yZXNvdXJjZVRyYWNraW5nRW5hYmxlZCA9IGZhbHNlOwotCi0gICAgdGhpcy5fcG9w b3ZlckhlbHBlciA9IG5ldyBXZWJJbnNwZWN0b3IuUG9wb3ZlckhlbHBlcih0aGlzLmVsZW1lbnQs IHRoaXMuX2dldFBvcG92ZXJBbmNob3IuYmluZCh0aGlzKSwgdGhpcy5fc2hvd1BvcG92ZXIuYmlu ZCh0aGlzKSwgdHJ1ZSk7CiB9CiAKIFdlYkluc3BlY3Rvci5SZXNvdXJjZXNQYW5lbC5wcm90b3R5 cGUgPSB7CkBAIC0zMjgsNiArMzI3LDcgQEAgV2ViSW5zcGVjdG9yLlJlc291cmNlc1BhbmVsLnBy b3RvdHlwZSA9IHsKIAogICAgIHJlc2V0OiBmdW5jdGlvbigpCiAgICAgeworICAgICAgICB0aGlz Ll9wb3BvdmVySGVscGVyLmhpZGVQb3B1cCgpOwogICAgICAgICB0aGlzLmNsb3NlVmlzaWJsZVJl c291cmNlKCk7CiAKICAgICAgICAgZGVsZXRlIHRoaXMuY3VycmVudFF1ZXJ5OwpAQCAtNDc2LDYg KzQ3Niw4IEBAIFdlYkluc3BlY3Rvci5SZXNvdXJjZXNQYW5lbC5wcm90b3R5cGUgPSB7CiAgICAg ICAgIGlmICghcmVzb3VyY2UpCiAgICAgICAgICAgICByZXR1cm47CiAKKyAgICAgICAgdGhpcy5f cG9wb3ZlckhlbHBlci5oaWRlUG9wdXAoKTsKKwogICAgICAgICB0aGlzLmNvbnRhaW5lckVsZW1l bnQuYWRkU3R5bGVDbGFzcygidmlld2luZy1yZXNvdXJjZSIpOwogCiAgICAgICAgIGlmICh0aGlz LnZpc2libGVSZXNvdXJjZSAmJiB0aGlzLnZpc2libGVSZXNvdXJjZS5fcmVzb3VyY2VzVmlldykK QEAgLTczOCwyMSArNzQwLDIxIEBAIFdlYkluc3BlY3Rvci5SZXNvdXJjZXNQYW5lbC5wcm90b3R5 cGUgPSB7CiAKICAgICBfZ2V0UG9wb3ZlckFuY2hvcjogZnVuY3Rpb24oZWxlbWVudCkKICAgICB7 Ci0gICAgICAgIHZhciBhbmNob3IgPSBlbGVtZW50LmVuY2xvc2luZ05vZGVPclNlbGZXaXRoQ2xh c3MoInJlc291cmNlcy1ncmFwaC1iYXItYXJlYSIpOworICAgICAgICB2YXIgYW5jaG9yID0gZWxl bWVudC5lbmNsb3NpbmdOb2RlT3JTZWxmV2l0aENsYXNzKCJyZXNvdXJjZXMtZ3JhcGgtYmFyIikg fHwgZWxlbWVudC5lbmNsb3NpbmdOb2RlT3JTZWxmV2l0aENsYXNzKCJyZXNvdXJjZXMtZ3JhcGgt bGFiZWwiKTsKICAgICAgICAgaWYgKCFhbmNob3IpCiAgICAgICAgICAgICByZXR1cm4gbnVsbDsK LSAgICAgICAgdmFyIHJlc291cmNlID0gYW5jaG9yLnJlc291cmNlOwotICAgICAgICByZXR1cm4g cmVzb3VyY2UudGltaW5nID8gYW5jaG9yIDogbnVsbDsKKyAgICAgICAgdmFyIHJlc291cmNlID0g YW5jaG9yLnBhcmVudEVsZW1lbnQucmVzb3VyY2U7CisgICAgICAgIHJldHVybiByZXNvdXJjZSAm JiByZXNvdXJjZS50aW1pbmcgPyBhbmNob3IgOiBudWxsOwogICAgIH0sCiAKICAgICBfc2hvd1Bv cG92ZXI6IGZ1bmN0aW9uKGFuY2hvcikKICAgICB7CiAgICAgICAgIHZhciB0YWJsZUVsZW1lbnQg PSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJ0YWJsZSIpOwotICAgICAgICB2YXIgcmVzb3VyY2Ug PSBhbmNob3IucmVzb3VyY2U7CisgICAgICAgIHZhciByZXNvdXJjZSA9IGFuY2hvci5wYXJlbnRF bGVtZW50LnJlc291cmNlOwogICAgICAgICB2YXIgZGF0YSA9IFtXZWJJbnNwZWN0b3IuVUlTdHJp bmcoIkJsb2NraW5nIiksIHJlc291cmNlLnRpbWluZy5yZXF1ZXN0VGltZSA9PT0gMCA/ICI/IiA6 IE51bWJlci5zZWNvbmRzVG9TdHJpbmcoTWF0aC5tYXgocmVzb3VyY2UudGltaW5nLnJlcXVlc3RU aW1lIC0gcmVzb3VyY2Uuc3RhcnRUaW1lLCAwKSksCi0gICAgICAgICAgICAgICAgICAgIFdlYklu c3BlY3Rvci5VSVN0cmluZygiUHJveHkiKSwgcmVzb3VyY2UudGltaW5nLnByb3h5RHVyYXRpb24g PT0gLTEgPyAibm9uZSIgOiBOdW1iZXIuc2Vjb25kc1RvU3RyaW5nKHJlc291cmNlLnRpbWluZy5w cm94eUR1cmF0aW9uKSwKLSAgICAgICAgICAgICAgICAgICAgV2ViSW5zcGVjdG9yLlVJU3RyaW5n KCJETlMgTG9va3VwIiksIHJlc291cmNlLnRpbWluZy5kbnNEdXJhdGlvbiA9PSAtMSA/ICJyZXVz ZWQiIDogTnVtYmVyLnNlY29uZHNUb1N0cmluZyhyZXNvdXJjZS50aW1pbmcuZG5zRHVyYXRpb24p LAotICAgICAgICAgICAgICAgICAgICBXZWJJbnNwZWN0b3IuVUlTdHJpbmcoIkNvbm5lY3Rpbmci KSwgcmVzb3VyY2UudGltaW5nLmNvbm5lY3REdXJhdGlvbiA9PSAtMSA/ICJyZXVzZWQiIDogTnVt YmVyLnNlY29uZHNUb1N0cmluZyhyZXNvdXJjZS50aW1pbmcuY29ubmVjdER1cmF0aW9uKSwKKyAg ICAgICAgICAgICAgICAgICAgV2ViSW5zcGVjdG9yLlVJU3RyaW5nKCJQcm94eSIpLCByZXNvdXJj ZS50aW1pbmcucHJveHlEdXJhdGlvbiA9PSAtMSA/ICIobm9uZSkiIDogTnVtYmVyLnNlY29uZHNU b1N0cmluZyhyZXNvdXJjZS50aW1pbmcucHJveHlEdXJhdGlvbiksCisgICAgICAgICAgICAgICAg ICAgIFdlYkluc3BlY3Rvci5VSVN0cmluZygiRE5TIExvb2t1cCIpLCByZXNvdXJjZS50aW1pbmcu ZG5zRHVyYXRpb24gPT0gLTEgPyAiKHJldXNlZCkiIDogTnVtYmVyLnNlY29uZHNUb1N0cmluZyhy ZXNvdXJjZS50aW1pbmcuZG5zRHVyYXRpb24pLAorICAgICAgICAgICAgICAgICAgICBXZWJJbnNw ZWN0b3IuVUlTdHJpbmcoIkNvbm5lY3RpbmciKSwgcmVzb3VyY2UudGltaW5nLmNvbm5lY3REdXJh dGlvbiA9PSAtMSA/ICIocmV1c2VkKSIgOiBOdW1iZXIuc2Vjb25kc1RvU3RyaW5nKHJlc291cmNl LnRpbWluZy5jb25uZWN0RHVyYXRpb24pLAogICAgICAgICAgICAgICAgICAgICBXZWJJbnNwZWN0 b3IuVUlTdHJpbmcoIlNlbmRpbmciKSwgTnVtYmVyLnNlY29uZHNUb1N0cmluZyhyZXNvdXJjZS50 aW1pbmcuc2VuZER1cmF0aW9uKSwKICAgICAgICAgICAgICAgICAgICAgV2ViSW5zcGVjdG9yLlVJ U3RyaW5nKCJXYWl0aW5nIiksIE51bWJlci5zZWNvbmRzVG9TdHJpbmcocmVzb3VyY2UudGltaW5n LnJlY2VpdmVIZWFkZXJzRHVyYXRpb24pLAogICAgICAgICAgICAgICAgICAgICBXZWJJbnNwZWN0 b3IuVUlTdHJpbmcoIlJlY2VpdmluZyIpLCBOdW1iZXIuc2Vjb25kc1RvU3RyaW5nKHJlc291cmNl LmVuZFRpbWUgLSByZXNvdXJjZS5yZXNwb25zZVJlY2VpdmVkVGltZSldOwpAQCAtNzY2LDEyICs3 NjgsMTMgQEAgV2ViSW5zcGVjdG9yLlJlc291cmNlc1BhbmVsLnByb3RvdHlwZSA9IHsKICAgICAg ICAgICAgIHRyLmFwcGVuZENoaWxkKHRkKTsKIAogICAgICAgICAgICAgdGQgPSBkb2N1bWVudC5j cmVhdGVFbGVtZW50KCJ0ZCIpOworICAgICAgICAgICAgdGQuYWxpZ24gPSAicmlnaHQiOwogICAg ICAgICAgICAgdGQudGV4dENvbnRlbnQgPSBkYXRhW2kgKyAxXTsKICAgICAgICAgICAgIHRyLmFw cGVuZENoaWxkKHRkKTsKICAgICAgICAgfQogCiAgICAgICAgIHZhciBwb3BvdmVyID0gbmV3IFdl Ykluc3BlY3Rvci5Qb3BvdmVyKHRhYmxlRWxlbWVudCk7Ci0gICAgICAgIHBvcG92ZXIuc2hvdyhh bmNob3IuZmlyc3RDaGlsZC5uZXh0U2libGluZyk7CisgICAgICAgIHBvcG92ZXIuc2hvdyhhbmNo b3IpOwogICAgICAgICByZXR1cm4gcG9wb3ZlcjsKICAgICB9LAogCkBAIC05MDIsNyArOTA1LDcg QEAgV2ViSW5zcGVjdG9yLlJlc291cmNlVGltZUNhbGN1bGF0b3IucHJvdG90eXBlID0gewogICAg ICAgICBlbHNlCiAgICAgICAgICAgICB2YXIgbGVmdExhYmVsID0gcmlnaHRMYWJlbDsKIAotICAg ICAgICBpZiAocmVzb3VyY2UuY29ubmVjdGlvbklEKQorICAgICAgICBpZiAocmVzb3VyY2UudGlt aW5nKQogICAgICAgICAgICAgcmV0dXJuIHtsZWZ0OiBsZWZ0TGFiZWwsIHJpZ2h0OiByaWdodExh YmVsfTsKIAogICAgICAgICBpZiAoaGFzTGF0ZW5jeSAmJiByaWdodExhYmVsKSB7Cg==