41953 2010-07-09 04:57:32 -0700 build fails - MathExtras.h on Solaris 2013-01-02 07:32:34 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) PC Other RESOLVED FIXED Qt, QtTriaged P3 Normal --- 0 tropikhajma webkit-unassigned benjamin bentaylor.solx86 commit-queue eric pierre.rossi richard t.hirsch oldest_to_newest 248924 0 61034 tropikhajma 2010-07-09 04:57:32 -0700 Created attachment 61034 patch building qt 4.7 beta2 fails with ... "./wtf/MathExtras.h", line 194: Error: isfinite is not a member of std. "./wtf/MathExtras.h", line 195: Error: isinf is not a member of std. "./wtf/MathExtras.h", line 196: Error: isnan is not a member of std. "./wtf/MathExtras.h", line 197: Error: signbit is not a member of std. the attached patch fixes that by adding Solaris to the ifdef already provided for MSVC and Android this is on OpenSolaris b134 using the Sun Studio 12u1 compiler 329223 1 t.hirsch 2011-01-04 14:36:03 -0800 I can confirm this bug. Please apply Pavel's patch! It's working fine. 329232 2 t.hirsch 2011-01-04 14:42:30 -0800 Actually I think that the code in trunk should also work: #if !COMPILER(MSVC) && !COMPILER(WINSCW) && !(COMPILER(RVCT) && (OS(SYMBIAN) || PLATFORM(BREWMP))) Here's how it was before and what is still being used in Qt 4.7: #if !COMPILER(MSVC) && !COMPILER(RVCT) && !OS(ANDROID) && !COMPILER(WINSCW) I'll tell the Nokia guys to update their webkit... Looks like this bug can be closed. Pavel, do you agree? 329247 3 tropikhajma 2011-01-04 15:05:04 -0800 (In reply to comment #2) > Looks like this bug can be closed. Pavel, do you agree? it certainly does not look like anybody from webkit cares about buildability on solaris, so for me it does not make any sense to spend time on development versions. I'll tell when the next Qt version is out. 329318 4 ap 2011-01-04 17:25:34 -0800 For the record, we gladly accept build fixes, but please don't disregard <http://webkit.org/coding/contributing.html>. 329320 5 ap 2011-01-04 17:26:47 -0800 In particular, patches that are not marked r? likely won't be noticed, and patches without ChangeLogs will be not accepted. 330717 6 benjamin 2011-01-07 03:16:24 -0800 (In reply to comment #3) > it certainly does not look like anybody from webkit cares about buildability on solaris, so for me it does not make any sense to spend time on development versions. I'll tell when the next Qt version is out. We don't have a buildbot for solaris but it is certainly supported. We accept patches for sure. The problem here is that nobody saw you patch until now. I just learned about it because a colleague triaged this http://bugreports.qt.nokia.com/browse/QTBUG-16448 There are two problems in this bug report that made it invisible for us: First, you have not used the template to report this bug. Since the keyword "Qt" is missing, this bug was never triaged by us. See http://trac.webkit.org/wiki/QtWebKitBugs for more info. Second, your patch was missing the changelog and was not marked for review. Such a patch does not appear in the review list. See http://trac.webkit.org/wiki/QtWebKitContrib for more info. Finally, if a patch is ignored, you can always write on the WebKit mailing list (webkit-qt and webkit). We welcome contribution, you were just unlucky and nobody from Qt saw the bug. (In reply to comment #2) > Looks like this bug can be closed. Pavel, do you agree? Closing the bug then. 374939 7 bentaylor.solx86 2011-03-28 18:34:57 -0700 Reopen this bug. The #if line from comment #2 fails to compile on Solaris 10 with Sun Studio 12, and add "&& !OS(SOLARIS)" fixes the problem. I will submit a new patch 374970 8 87253 bentaylor.solx86 2011-03-28 20:15:59 -0700 Created attachment 87253 Patch to fix compile issue on Solaris 10/Sun Studio 12 CC in JavaScriptCore/wtf/MathExtras.h The comment in #2 surely doesn't fix the issue on Solaris 10/Sun Studio 12 CC, as compiled with the qt-4.7.2. Adding the patch completed the compile. 375215 9 benjamin 2011-03-29 05:45:08 -0700 (In reply to comment #7) > Reopen this bug. The #if line from comment #2 fails to compile on Solaris 10 with Sun Studio 12, and add "&& !OS(SOLARIS)" fixes the problem. > > I will submit a new patch 375218 10 benjamin 2011-03-29 05:53:36 -0700 Pierre does that make sense to you? The change looks good to me but I would like a confirmation that the STL is always broken on Solaris. What about the GNU tools on Solaris? 375234 11 pierre.rossi 2011-03-29 06:15:15 -0700 (In reply to comment #10) > Pierre does that make sense to you? > > The change looks good to me but I would like a confirmation that the STL is always broken on Solaris. What about the GNU tools on Solaris? Yup, that looks good to me to, my general rule of thumb when it comes to dealing with Solaris is to really lower your expectations, that's what this patch does, so definitely thumbs up ! :) 375242 12 87253 benjamin 2011-03-29 06:20:02 -0700 Comment on attachment 87253 Patch to fix compile issue on Solaris 10/Sun Studio 12 CC in JavaScriptCore/wtf/MathExtras.h Look sane and Pierre says ok. 375364 13 87253 commit-queue 2011-03-29 08:26:12 -0700 Comment on attachment 87253 Patch to fix compile issue on Solaris 10/Sun Studio 12 CC in JavaScriptCore/wtf/MathExtras.h Clearing flags on attachment: 87253 Committed r82254: <http://trac.webkit.org/changeset/82254> 375365 14 commit-queue 2011-03-29 08:26:18 -0700 All reviewed patches have been landed. Closing bug. 798626 15 richard 2013-01-02 04:39:45 -0800 I believe this latest patch is inappropriate for solaris if GCC is being used. Perhaps it could better be done by changing: && !OS(SOLARIS) to && !( OS(SOLARIS) && defined(__SUNPRO_CC) ) or something of this nature. 798661 16 eric 2013-01-02 07:32:34 -0800 Please open a new patch and upload a new bug. We have very very few solaris users, so if you don't fix it, no one will. :) 61034 2010-07-09 04:57:32 -0700 2010-07-09 04:58:32 -0700 patch qt-MathExtras.diff text/plain 571 tropikhajma LS0tIHNyYy8zcmRwYXJ0eS93ZWJraXQvSmF2YVNjcmlwdENvcmUvd3RmL01hdGhFeHRyYXMuaC5v cmlnCTIwMTAtMDctMDkgMTM6MjM6NTEuODE3NDk2OTI4ICswMjAwCisrKyBzcmMvM3JkcGFydHkv d2Via2l0L0phdmFTY3JpcHRDb3JlL3d0Zi9NYXRoRXh0cmFzLmgJMjAxMC0wNy0wOSAxMzoyNjo0 MC40MzY2NjI3NjUgKzAyMDAKQEAgLTE5MCw3ICsxOTAsNyBAQAogaW5saW5lIGZsb2F0IHJhZDJn cmFkKGZsb2F0IHIpIHsgcmV0dXJuIHIgKiAyMDAuMGYgLyBwaUZsb2F0OyB9CiBpbmxpbmUgZmxv YXQgZ3JhZDJyYWQoZmxvYXQgZykgeyByZXR1cm4gZyAqIHBpRmxvYXQgLyAyMDAuMGY7IH0KIAot I2lmICFDT01QSUxFUihNU1ZDKSAmJiAhQ09NUElMRVIoUlZDVCkgJiYgIU9TKEFORFJPSUQpICYm ICFDT01QSUxFUihXSU5TQ1cpCisjaWYgIUNPTVBJTEVSKE1TVkMpICYmICFDT01QSUxFUihSVkNU KSAmJiAhT1MoQU5EUk9JRCkgJiYgIUNPTVBJTEVSKFdJTlNDVykgJiYgIU9TKFNPTEFSSVMpCiB1 c2luZyBzdGQ6OmlzZmluaXRlOwogdXNpbmcgc3RkOjppc2luZjsKIHVzaW5nIHN0ZDo6aXNuYW47 Cg== 87253 2011-03-28 20:15:59 -0700 2011-03-29 08:26:12 -0700 Patch to fix compile issue on Solaris 10/Sun Studio 12 CC in JavaScriptCore/wtf/MathExtras.h webkit-bug-41953-Solaris10-MathExtras.h-fix.diff text/plain 1260 bentaylor.solx86 SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gODIxODUpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAK KzIwMTEtMDMtMjggIEJlbiBUYXlsb3IgIDxiZW50YXlsb3Iuc29seDg2QGdtYWlsLmNvbT4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDE5NTMKKworICAgICAgICBGaXggY29tcGls ZSBlcnJvciBvbiBTb2xhcmlzIDEwL1N1biBTdHVkaW8gMTIgQ0MgZW1hbmF0aW5nIGZyb20gTWF0 aEV4dHJhcy5oCisKKyAgICAgICAgKiB3dGYvTWF0aEV4dHJhcy5oOgorCiAyMDExLTAzLTI4ICBP bGl2ZXIgSHVudCAgPG9saXZlckBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgR2Vv ZmZyZXkgR2FyZW4uCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL01hdGhFeHRyYXMu aAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL01hdGhFeHRyYXMuaAko cmV2aXNpb24gODIxODIpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL01hdGhFeHRyYXMu aAkod29ya2luZyBjb3B5KQpAQCAtMjM4LDcgKzIzOCw3IEBAIGlubGluZSBpbnQgY2xhbXBUb0lu dGVnZXIodW5zaWduZWQgdmFsdWUKICAgICByZXR1cm4gc3RhdGljX2Nhc3Q8aW50PihzdGQ6Om1p bih2YWx1ZSwgc3RhdGljX2Nhc3Q8dW5zaWduZWQ+KHN0ZDo6bnVtZXJpY19saW1pdHM8aW50Pjo6 bWF4KCkpKSk7CiB9CiAKLSNpZiAhQ09NUElMRVIoTVNWQykgJiYgIUNPTVBJTEVSKFdJTlNDVykg JiYgIShDT01QSUxFUihSVkNUKSAmJiAoT1MoU1lNQklBTikgfHwgUExBVEZPUk0oQlJFV01QKSkp CisjaWYgIUNPTVBJTEVSKE1TVkMpICYmICFDT01QSUxFUihXSU5TQ1cpICYmICEoQ09NUElMRVIo UlZDVCkgJiYgKE9TKFNZTUJJQU4pIHx8IFBMQVRGT1JNKEJSRVdNUCkpKSAmJiAhT1MoU09MQVJJ UykKIHVzaW5nIHN0ZDo6aXNmaW5pdGU7CiB1c2luZyBzdGQ6OmlzaW5mOwogdXNpbmcgc3RkOjpp c25hbjsK