41944 2010-07-09 02:16:33 -0700 commit-queue should merge to TOT when checkout needs update 2010-07-09 02:40:37 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 abarth abarth eric webkit.review.bot oldest_to_newest 248847 0 abarth 2010-07-09 02:16:33 -0700 commit-queue should merge to TOT when checkout needs update 248851 1 61022 abarth 2010-07-09 02:23:18 -0700 Created attachment 61022 Patch 248852 2 webkit.review.bot 2010-07-09 02:24:23 -0700 Attachment 61022 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 WebKitTools/Scripts/webkitpy/tool/commands/stepsequence.py:44: deprecated form of raising exception [pep8/W602] [5] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style. 248856 3 61022 eric 2010-07-09 02:31:07 -0700 Comment on attachment 61022 Patch Looks fine. RetryCommand is kinda a funny name. Makes me think it's a "Command" subclass. 248860 4 abarth 2010-07-09 02:40:37 -0700 Committed r62923: <http://trac.webkit.org/changeset/62923> 61022 2010-07-09 02:23:18 -0700 2010-07-09 02:31:07 -0700 Patch bug-41944-20100709022317.patch text/plain 7108 abarth SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDYyOTE5KQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMjQgQEAKKzIwMTAtMDctMDkgIEFkYW0gQmFydGggIDxhYmFy dGhAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBjb21taXQtcXVldWUgc2hvdWxkIG1lcmdlIHRvIFRPVCB3aGVuIGNoZWNrb3V0IG5l ZWRzIHVwZGF0ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NDE5NDQKKworICAgICAgICBUaGVyZSBhcmUgYSBidW5jaCBvZiBkaWZmZXJlbnQgZGVzaWdu cyB0aGF0IGFyZSBwb3NzaWJsZSBoZXJlLiAgVGhpcworICAgICAgICBvbmUgbWVyZ2VzIHRvIHRv cCBvZiB0cmVlIGJ5IGNsZWFuaW5nIG91dCB0aGUgd29ya2luZyBjb3B5IGFuZAorICAgICAgICBy ZS1hcHBseWluZyB0aGUgcGF0Y2guICBPbmNlIHlvdSBkZWNpZGUgdG8gbWVyZ2UgdGhhdCB3YXks IHlvdSBuZWVkIHRvCisgICAgICAgIGRlY2lkZSB3aG8ncyBnb2luZyB0byByZXRyeS4gIEluIHRo aXMgcGF0Y2gsIHdlIHJldHJ5IGluIHRoZSBjaGlsZAorICAgICAgICBwcm9jZXNzIGluc3RlYWQg b2YgcGx1bWJpbmcgdGhlIGZhaWx1cmUgcmVhc29uIHRvIHRoZSBtYXN0ZXIgcHJvY2Vzcy4KKwor ICAgICAgICBUaGlzIHBhdGNoIGlzIGRpZmZpY3VsdCB0byB0ZXN0IGVuZC10by1lbmQsIGJ1dCBo b3BlZnVsbHkgaXQgd2lsbCB3b3JrLgorICAgICAgICA6KQorCisgICAgICAgICogU2NyaXB0cy93 ZWJraXRweS90b29sL2NvbW1hbmRzL3F1ZXVlcy5weToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtp dHB5L3Rvb2wvY29tbWFuZHMvc3RlcHNlcXVlbmNlLnB5OgorICAgICAgICAqIFNjcmlwdHMvd2Vi a2l0cHkvdG9vbC9tdWx0aWNvbW1hbmR0b29sLnB5OgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0 cHkvdG9vbC9tdWx0aWNvbW1hbmR0b29sX3VuaXR0ZXN0LnB5OgorCiAyMDEwLTA3LTA5ICBEdW1p dHJ1IERhbmlsaXVjICA8ZHVtaUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg RGFyaW4gQWRsZXIuCkluZGV4OiBXZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvbXVs dGljb21tYW5kdG9vbC5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9TY3JpcHRzL3dlYmtp dHB5L3Rvb2wvbXVsdGljb21tYW5kdG9vbC5weQkocmV2aXNpb24gNjI5MTYpCisrKyBXZWJLaXRU b29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvbXVsdGljb21tYW5kdG9vbC5weQkod29ya2luZyBj b3B5KQpAQCAtMzksNiArMzksMTAgQEAgZnJvbSB3ZWJraXRweS50b29sLmdyYW1tYXIgaW1wb3J0 IHBsdXJhbAogZnJvbSB3ZWJraXRweS5jb21tb24uc3lzdGVtLmRlcHJlY2F0ZWRfbG9nZ2luZyBp bXBvcnQgbG9nCiAKIAorY2xhc3MgUmV0cnlDb21tYW5kKEV4Y2VwdGlvbik6CisgICAgcGFzcwor CisKIGNsYXNzIENvbW1hbmQob2JqZWN0KToKICAgICBuYW1lID0gTm9uZQogICAgIHNob3dfaW5f bWFpbl9oZWxwID0gRmFsc2UKQEAgLTI5OSw2ICszMDMsMTIgQEAgY2xhc3MgTXVsdGlDb21tYW5k VG9vbChvYmplY3QpOgogICAgICAgICAgICAgbG9nKGZhaWx1cmVfcmVhc29uKQogICAgICAgICAg ICAgcmV0dXJuIDAgIyBGSVhNRTogU2hvdWxkIHRoaXMgcmVhbGx5IGJlIDA/CiAKLSAgICAgICAg cmVzdWx0ID0gY29tbWFuZC5jaGVja19hcmd1bWVudHNfYW5kX2V4ZWN1dGUob3B0aW9ucywgYXJn cywgc2VsZikKKyAgICAgICAgd2hpbGUgVHJ1ZToKKyAgICAgICAgICAgIHRyeToKKyAgICAgICAg ICAgICAgICByZXN1bHQgPSBjb21tYW5kLmNoZWNrX2FyZ3VtZW50c19hbmRfZXhlY3V0ZShvcHRp b25zLCBhcmdzLCBzZWxmKQorICAgICAgICAgICAgICAgIGJyZWFrCisgICAgICAgICAgICBleGNl cHQgUmV0cnlDb21tYW5kLCBlOgorICAgICAgICAgICAgICAgIHBhc3MKKwogICAgICAgICBzZWxm LmNvbW1hbmRfY29tcGxldGVkKCkKICAgICAgICAgcmV0dXJuIHJlc3VsdApJbmRleDogV2ViS2l0 VG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL211bHRpY29tbWFuZHRvb2xfdW5pdHRlc3QucHkK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL211bHRpY29t bWFuZHRvb2xfdW5pdHRlc3QucHkJKHJldmlzaW9uIDYyOTE2KQorKysgV2ViS2l0VG9vbHMvU2Ny aXB0cy93ZWJraXRweS90b29sL211bHRpY29tbWFuZHRvb2xfdW5pdHRlc3QucHkJKHdvcmtpbmcg Y29weSkKQEAgLTMyLDcgKzMyLDcgQEAgaW1wb3J0IHVuaXR0ZXN0CiBmcm9tIG9wdHBhcnNlIGlt cG9ydCBtYWtlX29wdGlvbgogCiBmcm9tIHdlYmtpdHB5LmNvbW1vbi5zeXN0ZW0ub3V0cHV0Y2Fw dHVyZSBpbXBvcnQgT3V0cHV0Q2FwdHVyZQotZnJvbSB3ZWJraXRweS50b29sLm11bHRpY29tbWFu ZHRvb2wgaW1wb3J0IE11bHRpQ29tbWFuZFRvb2wsIENvbW1hbmQKK2Zyb20gd2Via2l0cHkudG9v bC5tdWx0aWNvbW1hbmR0b29sIGltcG9ydCBNdWx0aUNvbW1hbmRUb29sLCBDb21tYW5kLCBSZXRy eUNvbW1hbmQKIAogCiBjbGFzcyBUcml2aWFsQ29tbWFuZChDb21tYW5kKToKQEAgLTQ0LDEwICs0 NCwyNiBAQCBjbGFzcyBUcml2aWFsQ29tbWFuZChDb21tYW5kKToKICAgICBkZWYgZXhlY3V0ZShz ZWxmLCBvcHRpb25zLCBhcmdzLCB0b29sKToKICAgICAgICAgcGFzcwogCisKIGNsYXNzIFVuY29t bW9uQ29tbWFuZChUcml2aWFsQ29tbWFuZCk6CiAgICAgbmFtZSA9ICJ1bmNvbW1vbiIKICAgICBz aG93X2luX21haW5faGVscCA9IEZhbHNlCiAKKworY2xhc3MgTGlrZXNUb1JldHJ5KENvbW1hbmQp OgorICAgIG5hbWUgPSAibGlrZXMtdG8tcmV0cnkiCisgICAgc2hvd19pbl9tYWluX2hlbHAgPSBU cnVlCisKKyAgICBkZWYgX19pbml0X18oc2VsZiwgKiprd2FyZ3MpOgorICAgICAgICBDb21tYW5k Ll9faW5pdF9fKHNlbGYsICJoZWxwIHRleHQiLCAqKmt3YXJncykKKyAgICAgICAgc2VsZi5leGVj dXRlX2NvdW50ID0gMAorCisgICAgZGVmIGV4ZWN1dGUoc2VsZiwgb3B0aW9ucywgYXJncywgdG9v bCk6CisgICAgICAgIHNlbGYuZXhlY3V0ZV9jb3VudCArPSAxCisgICAgICAgIGlmIHNlbGYuZXhl Y3V0ZV9jb3VudCA8IDI6CisgICAgICAgICAgICByYWlzZSBSZXRyeUNvbW1hbmQoKQorCisKIGNs YXNzIENvbW1hbmRUZXN0KHVuaXR0ZXN0LlRlc3RDYXNlKToKICAgICBkZWYgdGVzdF9uYW1lX3dp dGhfYXJndW1lbnRzKHNlbGYpOgogICAgICAgICBjb21tYW5kX3dpdGhfYXJncyA9IFRyaXZpYWxD b21tYW5kKGFyZ3VtZW50X25hbWVzPSJBUkcxIEFSRzIiKQpAQCAtMTA5LDYgKzEyNSwxMiBAQCBj bGFzcyBNdWx0aUNvbW1hbmRUb29sVGVzdCh1bml0dGVzdC5UZXN0CiAgICAgICAgIGV4aXRfY29k ZSA9IE91dHB1dENhcHR1cmUoKS5hc3NlcnRfb3V0cHV0cyhzZWxmLCB0b29sLm1haW4sIFttYWlu X2FyZ3NdLCBleHBlY3RlZF9zdGRvdXQ9ZXhwZWN0ZWRfc3Rkb3V0LCBleHBlY3RlZF9zdGRlcnI9 ZXhwZWN0ZWRfc3RkZXJyKQogICAgICAgICBzZWxmLmFzc2VydEVxdWFsKGV4aXRfY29kZSwgZXhw ZWN0ZWRfZXhpdF9jb2RlKQogCisgICAgZGVmIHRlc3RfcmV0cnkoc2VsZik6CisgICAgICAgIGxp a2VzX3RvX3JldHJ5ID0gTGlrZXNUb1JldHJ5KCkKKyAgICAgICAgdG9vbCA9IFRyaXZpYWxUb29s KGNvbW1hbmRzPVtsaWtlc190b19yZXRyeV0pCisgICAgICAgIHRvb2wubWFpbihbInRvb2wiLCAi bGlrZXMtdG8tcmV0cnkiXSkKKyAgICAgICAgc2VsZi5hc3NlcnRFcXVhbChsaWtlc190b19yZXRy eS5leGVjdXRlX2NvdW50LCAyKQorCiAgICAgZGVmIHRlc3RfZ2xvYmFsX2hlbHAoc2VsZik6CiAg ICAgICAgIHRvb2wgPSBUcml2aWFsVG9vbChjb21tYW5kcz1bVHJpdmlhbENvbW1hbmQoKSwgVW5j b21tb25Db21tYW5kKCldKQogICAgICAgICBleHBlY3RlZF9jb21tb25fY29tbWFuZHNfaGVscCA9 ICIiIlVzYWdlOiB0cml2aWFsLXRvb2wgW29wdGlvbnNdIENPTU1BTkQgW0FSR1NdCkluZGV4OiBX ZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvcXVldWVzLnB5Cj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFdlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9xdWV1 ZXMucHkJKHJldmlzaW9uIDYyOTE2KQorKysgV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS90 b29sL2NvbW1hbmRzL3F1ZXVlcy5weQkod29ya2luZyBjb3B5KQpAQCAtNDIsNyArNDIsNyBAQCBm cm9tIHdlYmtpdHB5LnRvb2wuY29tbWFuZHMuc3RlcHNlcXVlbmNlCiBmcm9tIHdlYmtpdHB5LnRv b2wuYm90LnBhdGNoY29sbGVjdGlvbiBpbXBvcnQgUGVyc2lzdGVudFBhdGNoQ29sbGVjdGlvbiwg UGVyc2lzdGVudFBhdGNoQ29sbGVjdGlvbkRlbGVnYXRlCiBmcm9tIHdlYmtpdHB5LnRvb2wuYm90 LnF1ZXVlZW5naW5lIGltcG9ydCBRdWV1ZUVuZ2luZSwgUXVldWVFbmdpbmVEZWxlZ2F0ZQogZnJv bSB3ZWJraXRweS50b29sLmdyYW1tYXIgaW1wb3J0IHBsdXJhbGl6ZQotZnJvbSB3ZWJraXRweS50 b29sLm11bHRpY29tbWFuZHRvb2wgaW1wb3J0IENvbW1hbmQKK2Zyb20gd2Via2l0cHkudG9vbC5t dWx0aWNvbW1hbmR0b29sIGltcG9ydCBDb21tYW5kLCBSZXRyeUNvbW1hbmQKIAogY2xhc3MgQWJz dHJhY3RRdWV1ZShDb21tYW5kLCBRdWV1ZUVuZ2luZURlbGVnYXRlKToKICAgICB3YXRjaGVycyA9 IFsKQEAgLTI3OSw2ICsyNzksMTcgQEAgY2xhc3MgQ29tbWl0UXVldWUoQWJzdHJhY3RQYXRjaFF1 ZXVlLCBTdAogICAgICAgICB2YWxpZGF0b3IgPSBDb21taXR0ZXJWYWxpZGF0b3IodG9vbC5idWdz KQogICAgICAgICB2YWxpZGF0b3IucmVqZWN0X3BhdGNoX2Zyb21fY29tbWl0X3F1ZXVlKHN0YXRl WyJwYXRjaCJdLmlkKCksIGNscy5fZXJyb3JfbWVzc2FnZV9mb3JfYnVnKHRvb2wsIHN0YXR1c19p ZCwgc2NyaXB0X2Vycm9yKSkKIAorICAgIEBjbGFzc21ldGhvZAorICAgIGRlZiBoYW5kbGVfY2hl Y2tvdXRfbmVlZHNfdXBkYXRlKGNscywgdG9vbCwgc3RhdGUsIG9wdGlvbnMsIGVycm9yKToKKyAg ICAgICAgIyBUaGUgb25seSB0aW1lIHdoZW4gd2UgZmluZCBvdXQgdGhhdCBvdXQgY2hlY2tvdXQg bmVlZHMgdXBkYXRlIGlzCisgICAgICAgICMgd2hlbiB3ZSB3ZXJlIHJlYWR5IHRvIGFjdHVhbGx5 IHB1bGwgdGhlIHRyaWdnZXIgYW5kIGxhbmQgdGhlIHBhdGNoLgorICAgICAgICAjIFJhdGhlciB0 aGFuIHNwaW5uaW5nIGluIHRoZSBtYXN0ZXIgcHJvY2Vzcywgd2UgcmV0cnkgd2l0aG91dAorICAg ICAgICAjIGJ1aWxkaW5nIG9yIHRlc3RpbmcsIHdoaWNoIGlzIG11Y2ggZmFzdGVyLgorICAgICAg ICBvcHRpb25zLmJ1aWxkID0gRmFsc2UKKyAgICAgICAgb3B0aW9ucy50ZXN0ID0gRmFsc2UKKyAg ICAgICAgb3B0aW9ucy51cGRhdGUgPSBUcnVlCisgICAgICAgIHJhaXNlIFJldHJ5Q29tbWFuZCgp CisKIAogY2xhc3MgUmlldHZlbGRVcGxvYWRRdWV1ZShBYnN0cmFjdFBhdGNoUXVldWUsIFN0ZXBT ZXF1ZW5jZUVycm9ySGFuZGxlcik6CiAgICAgbmFtZSA9ICJyaWV0dmVsZC11cGxvYWQtcXVldWUi CkluZGV4OiBXZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvc3RlcHNl cXVlbmNlLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9v bC9jb21tYW5kcy9zdGVwc2VxdWVuY2UucHkJKHJldmlzaW9uIDYyOTE2KQorKysgV2ViS2l0VG9v bHMvU2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL3N0ZXBzZXF1ZW5jZS5weQkod29ya2lu ZyBjb3B5KQpAQCAtMzksNiArMzksMTAgQEAgY2xhc3MgU3RlcFNlcXVlbmNlRXJyb3JIYW5kbGVy KCk6CiAgICAgZGVmIGhhbmRsZV9zY3JpcHRfZXJyb3IoY2xzLCB0b29sLCBwYXRjaCwgc2NyaXB0 X2Vycm9yKToKICAgICAgICAgcmFpc2UgTm90SW1wbGVtZW50ZWRFcnJvciwgInN1YmNsYXNzZXMg bXVzdCBpbXBsZW1lbnQiCiAKKyAgICBAY2xhc3NtZXRob2QKKyAgICBkZWYgaGFuZGxlX2NoZWNr b3V0X25lZWRzX3VwZGF0ZShjbHMsIHRvb2wsIHN0YXRlLCBvcHRpb25zLCBlcnJvcik6CisgICAg ICAgIHJhaXNlIE5vdEltcGxlbWVudGVkRXJyb3IsICJzdWJjbGFzc2VzIG11c3QgaW1wbGVtZW50 IgorCiAKIGNsYXNzIFN0ZXBTZXF1ZW5jZShvYmplY3QpOgogICAgIGRlZiBfX2luaXRfXyhzZWxm LCBzdGVwcyk6CkBAIC02Niw2ICs3MCw5IEBAIGNsYXNzIFN0ZXBTZXF1ZW5jZShvYmplY3QpOgog ICAgICAgICAgICAgc2VsZi5fcnVuKHRvb2wsIG9wdGlvbnMsIHN0YXRlKQogICAgICAgICBleGNl cHQgQ2hlY2tvdXROZWVkc1VwZGF0ZSwgZToKICAgICAgICAgICAgIGxvZygiQ29tbWl0IGZhaWxl ZCBiZWNhdXNlIHRoZSBjaGVja291dCBpcyBvdXQgb2YgZGF0ZS4gIFBsZWFzZSB1cGRhdGUgYW5k IHRyeSBhZ2Fpbi4iKQorICAgICAgICAgICAgaWYgb3B0aW9ucy5wYXJlbnRfY29tbWFuZDoKKyAg ICAgICAgICAgICAgICBjb21tYW5kID0gdG9vbC5jb21tYW5kX2J5X25hbWUob3B0aW9ucy5wYXJl bnRfY29tbWFuZCkKKyAgICAgICAgICAgICAgICBjb21tYW5kLmhhbmRsZV9jaGVja291dF9uZWVk c191cGRhdGUodG9vbCwgc3RhdGUsIG9wdGlvbnMsIGUpCiAgICAgICAgICAgICBRdWV1ZUVuZ2lu ZS5leGl0X2FmdGVyX2hhbmRsZWRfZXJyb3IoZSkKICAgICAgICAgZXhjZXB0IFNjcmlwdEVycm9y LCBlOgogICAgICAgICAgICAgaWYgbm90IG9wdGlvbnMucXVpZXQ6Cg==