41930 2010-07-08 22:34:39 -0700 [Qt] QtWebKit doesn't build in debug on Windows 2010-12-21 05:11:47 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Windows XP RESOLVED FIXED Qt P2 Normal --- 1 maheshk maheshk aroben commit-queue eric hausmann jturcotte kling laszlo.gombos ossy zherczeg oldest_to_newest 248738 0 maheshk 2010-07-08 22:34:39 -0700 qtwebkit on windows for debug version complains with linker errors. Disabling incremental build fixes the issue with msvs 248842 1 61018 maheshk 2010-07-09 02:00:30 -0700 Created attachment 61018 fixes build issue On both win32-msvc2005|win32-msvc2008, qtwebkit doesn't build for debug. Release would anyway have this flag set. This patch proposes to add the flag to debug version as well. 248930 2 kling 2010-07-09 05:20:05 -0700 This is a 32-bit only issue, no? AFAIK incremental linking works just fine on 64-bit. We don't want to turn it off for everyone in that case. Could you paste the error message you're getting from the linker? 249483 3 maheshk 2010-07-10 00:35:56 -0700 (In reply to comment #2) > This is a 32-bit only issue, no? > > AFAIK incremental linking works just fine on 64-bit. We don't want to turn it off for everyone in that case. > > Could you paste the error message you're getting from the linker? Yes mine is 32-bit machine. As per your comments probably this change needs to be done only for 32-bit machines. The error we get on all 32 bit machines here while linking webkit dll, "LINK : fatal error LNK1210: exceeded internal ILK size limit; link with /INCREMENTAL:NO" 249485 4 maheshk 2010-07-10 00:37:58 -0700 (In reply to comment #3) > (In reply to comment #2) > > This is a 32-bit only issue, no? > > > > AFAIK incremental linking works just fine on 64-bit. We don't want to turn it off for everyone in that case. > > > > Could you paste the error message you're getting from the linker? > > Yes mine is 32-bit machine. As per your comments probably this change needs to be done only for 32-bit machines. > > The error we get on all 32 bit machines here while linking webkit dll, > "LINK : fatal error LNK1210: exceeded internal ILK size limit; link with > /INCREMENTAL:NO" opps, the patch does it only for 32-bit windows machines already! 249517 5 kling 2010-07-10 08:34:18 -0700 (In reply to comment #4) > > The error we get on all 32 bit machines here while linking webkit dll, > > "LINK : fatal error LNK1210: exceeded internal ILK size limit; link with > > /INCREMENTAL:NO" > > opps, the patch does it only for 32-bit windows machines already! Ok, this makes sense to me. CC'ing Simon for review. 249593 6 laszlo.gombos 2010-07-10 18:35:28 -0700 I might be wrong but I do not think "win32" is just for 32 bit. To test for 64 bit one should try "contains(QMAKE_HOST.arch, x86_64)". Best is to try/test on 64 bit machine. 249609 7 61018 hausmann 2010-07-11 01:42:35 -0700 Comment on attachment 61018 fixes build issue If you look at mkspecs/win32*/qmake.conf in Qt, then you can see that we use INCREMENTAL:NO for release builds: QMAKE_LFLAGS_RELEASE = /INCREMENTAL:NO I think a cleaner fix would be to use either QMAKE_LFLAGS_DEBUG += or at the very least add a comment in the .pro file what exactly this magic line tries to achieve. For example: # Release builds disable incremental # linking. Disable it also for debug # builds because WebKit is so big # that the linker fails to link # incrementally in debug builds. QMAKE_LFLAGS_DEBUG += /INCREMENTAL:NO 251743 8 61618 maheshk 2010-07-15 02:08:56 -0700 Created attachment 61618 updated comments updated patch as per comments #7 from Simon. 251744 9 maheshk 2010-07-15 02:11:48 -0700 (In reply to comment #6) > I might be wrong but I do not think "win32" is just for 32 bit. To test for 64 bit one should try "contains(QMAKE_HOST.arch, x86_64)". > > Best is to try/test on 64 bit machine. I do not have 64-bit machine to try the latest patch out :( Andreas Kling, would it be able possible for you to test this on your 64-bit machine? 251826 10 jturcotte 2010-07-15 05:32:26 -0700 (In reply to comment #9) I tried contains(QMAKE_HOST.arch, x86_64) but this would disable incremental linking when qmake is compiled as 32bit on a 64bit machine. Something like this might work, the PROCESSOR_ARCHITEW6432 environment variable is only defined when running a 32bit process on a 64bit Windows. ( info: http://blogs.msdn.com/b/david.wang/archive/2006/03/26/howto-detect-process-bitness.aspx ) ARCH = $$(PROCESSOR_ARCHITECTURE) WOW64ARCH = $$(PROCESSOR_ARCHITEW6432) equals(ARCH, x86): isEmpty(WOW64ARCH): QMAKE_LFLAGS_DEBUG += /INCREMENTAL:NO Also please span your comment on less lines (something like 100 chars wide), this would help keeping the scrolling convenint in that file while searching for a specific line. 253299 11 maheshk 2010-07-19 11:30:16 -0700 (In reply to comment #10) > (In reply to comment #9) > > I tried contains(QMAKE_HOST.arch, x86_64) but this would disable incremental linking when qmake is compiled as 32bit on a 64bit machine. > > Something like this might work, the PROCESSOR_ARCHITEW6432 environment variable is only defined when running a 32bit process on a 64bit Windows. > ( info: http://blogs.msdn.com/b/david.wang/archive/2006/03/26/howto-detect-process-bitness.aspx ) > > ARCH = $$(PROCESSOR_ARCHITECTURE) > WOW64ARCH = $$(PROCESSOR_ARCHITEW6432) > equals(ARCH, x86): isEmpty(WOW64ARCH): QMAKE_LFLAGS_DEBUG += /INCREMENTAL:NO > > Also please span your comment on less lines (something like 100 chars wide), this would help keeping the scrolling convenint in that file while searching for a specific line. Jocelyn, we see the same issue even on 32-bit windows OS on 64 bit machine. We tested this again on 64 bit machine, as long as its a 32-bit windows OS, incremental build fails. I will upload the patch again with lesser lines in comments section. Laszlo, any comments on existing fix? 258749 12 jturcotte 2010-08-02 01:35:37 -0700 (In reply to comment #11) > Jocelyn, we see the same issue even on 32-bit windows OS on 64 bit machine. > We tested this again on 64 bit machine, as long as its a 32-bit windows OS, incremental build fails. > > I will upload the patch again with lesser lines in comments section. > > Laszlo, any comments on existing fix? I meant a 64bit OS on a 64bit machine when I wrote "64bit machine", sorry for the confusion. 265486 13 61618 kling 2010-08-17 05:59:27 -0700 Comment on attachment 61618 updated comments >WebCore/WebCore.pro:110 > + win32-msvc2005|win32-msvc2008:{ This will affect both 32-bit and 64-bit Windows. r- because we need to find a solution that doesn't unnecessarily hurt linking time on 64-bit Windows. 312723 14 74634 maheshk 2010-11-23 01:28:13 -0800 Created attachment 74634 patch Jocelyn Turcotte, Thanks. Updated patch as per comment #10 312731 15 74634 kenneth 2010-11-23 02:38:49 -0800 Comment on attachment 74634 patch View in context: https://bugs.webkit.org/attachment.cgi?id=74634&action=review > WebCore/WebCore.pro:131 > + # Disable incremental linking for windows 32bit OS debug build as WebKit so big WebKit so big? Do you mean "WebKit is so big" ? > WebCore/WebCore.pro:132 > + # that linker failes to link incrementally in debug mode You need a dot at the end; that is WebKit comment style. 316905 16 74634 eric 2010-12-03 11:02:46 -0800 Comment on attachment 74634 patch Seems OK besides the above comment comments. Are you going to post a new patch for krc? 324929 17 77098 maheshk 2010-12-21 03:34:54 -0800 Created attachment 77098 patch Changes made as per comment #15. Please review. 324939 18 77098 kling 2010-12-21 04:35:48 -0800 Comment on attachment 77098 patch Much better! r=me :) 324952 19 77098 commit-queue 2010-12-21 05:11:38 -0800 Comment on attachment 77098 patch Clearing flags on attachment: 77098 Committed r74409: <http://trac.webkit.org/changeset/74409> 324953 20 commit-queue 2010-12-21 05:11:47 -0800 All reviewed patches have been landed. Closing bug. 61018 2010-07-09 02:00:30 -0700 2010-07-15 02:08:56 -0700 fixes build issue webkit_build.patch text/plain 972 maheshk SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nDQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQotLS0gV2ViQ29yZS9DaGFuZ2VM b2cJKHJldmlzaW9uIDYyODk0KQ0KKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkp DQpAQCAtMSwzICsxLDE0IEBADQorMjAxMC0wNy0wOSBNYWhlc2ggS3Vsa2FybmkgPG1haGVzaC5r dWxrYXJuaUBub2tpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkK KworICAgICAgICBRdFdlYmtpdCBkb2VzIG5vdCBidWlsZCBmb3IgZGVidWcgdmVyc2lvbiBvbiB3 aW5kb3dzIAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 NDE5MzAKKworICAgICAgICBObyBuZXcgdGVzdHMsIGJ1aWxkIGZpeCBvbmx5LgorCisgICAgICAg ICogV2ViQ29yZS5wcm86CisKIDIwMTAtMDctMDggIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNl ckBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCkluZGV4OiBX ZWJDb3JlL1dlYkNvcmUucHJvDQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQotLS0gV2ViQ29yZS9XZWJDb3JlLnBybwko cmV2aXNpb24gNjI4OTQpDQorKysgV2ViQ29yZS9XZWJDb3JlLnBybwkod29ya2luZyBjb3B5KQ0K QEAgLTEwNiw2ICsxMDYsNyBAQA0KIHdpbjMyLW1zdmMyMDA1fHdpbjMyLW1zdmMyMDA4OnsKICAg ICBRTUFLRV9DRkxBR1NfUkVMRUFTRSAtPSAtR0wKICAgICBRTUFLRV9DWFhGTEFHU19SRUxFQVNF IC09IC1HTAorICAgIFFNQUtFX0xGTEFHUyArPSAvSU5DUkVNRU5UQUw6Tk8KIH0KIAogIyBQaWNr IHVwIDNyZHBhcnR5IGxpYnJhcmllcyBmcm9tIElOQ0xVREUvTElCIGp1c3QgbGlrZSB3aXRoIE1T VkMK 61618 2010-07-15 02:08:56 -0700 2010-11-23 01:28:13 -0800 updated comments buildfix.patch text/plain 1258 maheshk SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2MzQxNikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTAtMDctMTUgIE1haGVzaCBLdWxrYXJuaSAgPG1haGVzaC5rdWxr YXJuaUBub2tpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgW1FUXSBRdFdlYktpdCBkb2Vzbid0IGJ1aWxkIGluIGRlYnVnIG9uIFdpbmRvd3MK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQxOTMwCisK KyAgICAgICAgRGlzYWJsZSBpbmNyZW1lbnRhbCBmb3IgcXR3ZWJraXQtZGVidWcgYnVpbGRzIGZy b20gd2luZG93cy4gCisKKyAgICAgICAgQnVpbGQgZml4IG5vIG5ldyB0ZXN0cworCisgICAgICAg ICogV2ViQ29yZS5wcm86CisKIDIwMTAtMDctMTUgIE5pa29sYXMgWmltbWVybWFubiAgPG56aW1t ZXJtYW5uQHJpbS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwuCkluZGV4 OiBXZWJDb3JlL1dlYkNvcmUucHJvCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvV2ViQ29yZS5wcm8J KHJldmlzaW9uIDYzNDExKQorKysgV2ViQ29yZS9XZWJDb3JlLnBybwkod29ya2luZyBjb3B5KQpA QCAtMTEwLDYgKzExMCwxMyBAQCBERUZJTkVTICs9IEJVSUxEX1dFQktJVAogd2luMzItbXN2YzIw MDV8d2luMzItbXN2YzIwMDg6ewogICAgIFFNQUtFX0NGTEFHU19SRUxFQVNFIC09IC1HTAogICAg IFFNQUtFX0NYWEZMQUdTX1JFTEVBU0UgLT0gLUdMCisKKyAgICAjIFJlbGVhc2UgYnVpbGRzIGRp c2FibGUgaW5jcmVtZW50YWwKKyAgICAjIGxpbmtpbmcuIERpc2FibGUgaXQgYWxzbyBmb3IgZGVi dWcKKyAgICAjIGJ1aWxkcyBiZWNhdXNlIFdlYktpdCBpcyBzbyBiaWcKKyAgICAjIHRoYXQgdGhl IGxpbmtlciBmYWlscyB0byBsaW5rCisgICAgIyBpbmNyZW1lbnRhbGx5IGluIGRlYnVnIGJ1aWxk cy4KKyAgICBRTUFLRV9MRkxBR1NfREVCVUcgKz0gL0lOQ1JFTUVOVEFMOk5PCiB9CiAKICMgUGlj ayB1cCAzcmRwYXJ0eSBsaWJyYXJpZXMgZnJvbSBJTkNMVURFL0xJQiBqdXN0IGxpa2Ugd2l0aCBN U1ZDCg== 74634 2010-11-23 01:28:13 -0800 2010-12-21 03:34:54 -0800 patch 41930.patch text/plain 1396 maheshk SW5kZXg6IFdlYkNvcmUvV2ViQ29yZS5wcm8KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9XZWJDb3Jl LnBybwkocmV2aXNpb24gNzI1ODMpCisrKyBXZWJDb3JlL1dlYkNvcmUucHJvCSh3b3JraW5nIGNv cHkpCkBAIC0xMjcsNiArMTI3LDE0IEBACiB3aW4zMi1tc3ZjMjAwNXx3aW4zMi1tc3ZjMjAwOHx3 aW5jZSo6ewogICAgIFFNQUtFX0NGTEFHU19SRUxFQVNFIC09IC1HTAogICAgIFFNQUtFX0NYWEZM QUdTX1JFTEVBU0UgLT0gLUdMCisKKyAgICAjIERpc2FibGUgaW5jcmVtZW50YWwgbGlua2luZyBm b3Igd2luZG93cyAzMmJpdCBPUyBkZWJ1ZyBidWlsZCBhcyBXZWJLaXQgc28gYmlnCisgICAgIyB0 aGF0IGxpbmtlciBmYWlsZXMgdG8gbGluayBpbmNyZW1lbnRhbGx5IGluIGRlYnVnIG1vZGUKKyAg ICBBUkNIID0gJCQoUFJPQ0VTU09SX0FSQ0hJVEVDVFVSRSkKKyAgICBXT1c2NEFSQ0ggPSAkJChQ Uk9DRVNTT1JfQVJDSElURVc2NDMyKQorICAgIGVxdWFscyhBUkNILCB4ODYpOnsKKyAgICAgICAg aXNFbXB0eShXT1c2NEFSQ0gpOiBRTUFLRV9MRkxBR1NfREVCVUcgKz0gL0lOQ1JFTUVOVEFMOk5P CisgICAgfQogfQogCiAjIFBpY2sgdXAgM3JkcGFydHkgbGlicmFyaWVzIGZyb20gSU5DTFVERS9M SUIganVzdCBsaWtlIHdpdGggTVNWQwpJbmRleDogV2ViQ29yZS9DaGFuZ2VMb2cKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gV2ViQ29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDcyNTkwKQorKysgV2ViQ29yZS9DaGFu Z2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNyBAQAorMjAxMC0xMS0yMyAgTWFoZXNo IEt1bGthcm5pICA8bWFoZXNoLmt1bGthcm5pQG5va2lhLmNvbT4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIFF0V2ViS2l0IGRvZXNuJ3QgYnVp bGQgaW4gZGVidWcgb24gV2luZG93cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NDE5MzAKKworICAgICAgICBEaXNhYmxlIGluY3JlbWVudGFsIGxpbmtp bmcgaW4gd2luZG93cyAzMmJpdCBkZWJ1ZyB2ZXJzaW9uIGFzIHdlYmtpdCBpcyBzbyAKKyAgICAg ICAgYmlnIGl0IGZhaWxzIHRvIGxpbmsgaW5jcmVtZW50YWwuIAorCisgICAgICAgIEJ1aWxkIGZp eC4gTm8gbmV3IHRlc3QgY2FzZXMgYWRkZWQuIAorCisgICAgICAgICogV2ViQ29yZS5wcm86CisK IDIwMTAtMTEtMjIgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+CiAKICAgICAg ICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCg== 77098 2010-12-21 03:34:54 -0800 2010-12-21 05:11:38 -0800 patch 41930.patch text/plain 1360 maheshk ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MmE0NDU0ZS4uNTM1ZWIxZCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMC0xMi0xNyAgTWFoZXNoIEt1bGth cm5pICA8bWFoZXNoLmt1bGthcm5pQG5va2lhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIFF0V2ViS2l0IGRvZXNuJ3QgYnVpbGQgaW4g ZGVidWcgb24gV2luZG93cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NDE5MzAKKworICAgICAgICBEaXNhYmxlIGluY3JlbWVudGFsIGxpbmtpbmcgaW4g d2luZG93cyAzMmJpdCBkZWJ1ZyB2ZXJzaW9uIGFzIHdlYmtpdCBpcyBzbyAKKyAgICAgICAgYmln IGl0IGZhaWxzIHRvIGxpbmsgaW5jcmVtZW50YWwuIAorCisgICAgICAgIEJ1aWxkIGZpeC4gTm8g bmV3IHRlc3QgY2FzZXMgYWRkZWQuIAorCisgICAgICAgICogV2ViQ29yZS5wcm86CisKIDIwMTAt MTItMTcgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAg ICAgIFJldmlld2VkIGJ5IE1hcnRpbiBSb2JpbnNvbi4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvV2Vi Q29yZS5wcm8gYi9XZWJDb3JlL1dlYkNvcmUucHJvCmluZGV4IDU1MTk4ZDAuLjMxYjQyZDAgMTAw NjQ0Ci0tLSBhL1dlYkNvcmUvV2ViQ29yZS5wcm8KKysrIGIvV2ViQ29yZS9XZWJDb3JlLnBybwpA QCAtMTMxLDYgKzEzMSwxNCBAQCBERUZJTkVTICs9IEJVSUxESU5HX1dFQktJVAogd2luMzItbXN2 YzIwMDV8d2luMzItbXN2YzIwMDh8d2luY2UqOnsKICAgICBRTUFLRV9DRkxBR1NfUkVMRUFTRSAt PSAtR0wKICAgICBRTUFLRV9DWFhGTEFHU19SRUxFQVNFIC09IC1HTAorCisgICAgIyBEaXNhYmxl IGluY3JlbWVudGFsIGxpbmtpbmcgZm9yIHdpbmRvd3MgMzJiaXQgT1MgZGVidWcgYnVpbGQgYXMg V2ViS2l0IGlzIHNvIGJpZworICAgICMgdGhhdCBsaW5rZXIgZmFpbGVzIHRvIGxpbmsgaW5jcmVt ZW50YWxseSBpbiBkZWJ1ZyBtb2RlLgorICAgIEFSQ0ggPSAkJChQUk9DRVNTT1JfQVJDSElURUNU VVJFKQorICAgIFdPVzY0QVJDSCA9ICQkKFBST0NFU1NPUl9BUkNISVRFVzY0MzIpCisgICAgZXF1 YWxzKEFSQ0gsIHg4Nik6eworICAgICAgICBpc0VtcHR5KFdPVzY0QVJDSCk6IFFNQUtFX0xGTEFH U19ERUJVRyArPSAvSU5DUkVNRU5UQUw6Tk8KKyAgICB9CiB9CiAKICMgUGljayB1cCAzcmRwYXJ0 eSBsaWJyYXJpZXMgZnJvbSBJTkNMVURFL0xJQiBqdXN0IGxpa2Ugd2l0aCBNU1ZDCg==