41928 2010-07-08 21:27:32 -0700 REGRESSION(r62887): printing/page-rule-selection.html is broken 2010-07-13 11:16:11 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 abarth aa aa oldest_to_newest 248712 0 abarth 2010-07-08 21:27:32 -0700 http://trac.webkit.org/changeset/62876 broke printing/page-rule-selection.html http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(Tests)/r62876%20(13247)/printing/page-rule-selection-pretty-diff.html --- /Volumes/Data/WebKit-BuildSlave/snowleopard-intel-release-tests/build/layout-test-results/printing/page-rule-selection-expected.txt 2010-07-08 18:33:04.000000000 -0700 +++ /Volumes/Data/WebKit-BuildSlave/snowleopard-intel-release-tests/build/layout-test-results/printing/page-rule-selection-actual.txt 2010-07-08 18:33:04.000000000 -0700 @@ -10,11 +10,11 @@ PASS layoutTestController.pageProperty('margin-left', 3) is "auto" PASS layoutTestController.pageProperty('margin-left', 4) is "auto" Set margin to 200px via user style sheet. -PASS layoutTestController.pageProperty('margin-left', 0) is "200" -PASS layoutTestController.pageProperty('margin-left', 1) is "200" -PASS layoutTestController.pageProperty('margin-left', 2) is "200" -PASS layoutTestController.pageProperty('margin-left', 3) is "200" -PASS layoutTestController.pageProperty('margin-left', 4) is "200" +FAIL layoutTestController.pageProperty('margin-left', 0) should be 200. Was auto. +FAIL layoutTestController.pageProperty('margin-left', 1) should be 200. Was auto. +FAIL layoutTestController.pageProperty('margin-left', 2) should be 200. Was auto. +FAIL layoutTestController.pageProperty('margin-left', 3) should be 200. Was auto. +FAIL layoutTestController.pageProperty('margin-left', 4) should be 200. Was auto. Set margin to 100px. PASS layoutTestController.pageProperty('margin-left', 0) is "100" PASS layoutTestController.pageProperty('margin-left', 1) is "100" Hopefully Aaron will fix it before I owe someone a beer. :) 248713 1 abarth 2010-07-08 21:29:05 -0700 I skipped the test in http://trac.webkit.org/changeset/62887 Please remove the test from the skipped list once it passes. 248737 2 aa 2010-07-08 22:34:33 -0700 Thank you, I will fix this first thing tomorrow. 249192 3 61076 aa 2010-07-09 12:53:18 -0700 Created attachment 61076 Patch 250631 4 aa 2010-07-13 11:15:54 -0700 That's weird, I landed this. I don't know why the bug didn't close. 61076 2010-07-09 12:53:18 -0700 2010-07-09 12:57:43 -0700 Patch bug-41928-20100709125317.patch text/plain 2245 aa ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBmNDQ2NzM1OGYwMWFhNDIwOTJjZjM4ZGJhOTliODA4NmZiZGVmNjYxLi40NDhhMmE1 OTVjMTVkNjg4NjE4ZjJkYzRiMTA5MTdiYjUyYmZhNWNjIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAK KzIwMTAtMDctMDkgIEFhcm9uIEJvb2RtYW4gIDxhYUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4IHJlZ3Jlc3Npb24gZnJv bSByNjI4NzYuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD00MTkyOAorCisgICAgICAgICogcGxhdGZvcm0vbWFjL1NraXBwZWQ6CisgICAgICAgICogcHJp bnRpbmcvcGFnZS1ydWxlLXNlbGVjdGlvbi5odG1sOgorCiAyMDEwLTA3LTA5ICBYaWFvbWVpIEpp ICA8eGppQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXZpZCBMZXZpbi4K ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9Ta2lwcGVkIGIvTGF5b3V0VGVz dHMvcGxhdGZvcm0vbWFjL1NraXBwZWQKaW5kZXggZGE4NDg5ZmVmMjU0YWFhMDgwNzgxMjI2Zjkz NDVjMjU5NTNjOTUxYS4uZjAzNDVmOTFjOTBjNTZlNzU2MTBlM2YyY2EwMTQ0N2NiODI1ODE0YyAx MDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL1NraXBwZWQKKysrIGIvTGF5b3V0 VGVzdHMvcGxhdGZvcm0vbWFjL1NraXBwZWQKQEAgLTI5OSw5ICsyOTksMyBAQCBmYXN0L2Zvcm1z L2lucHV0LWFwcGVhcmFuY2Utc3BlZWNoYnV0dG9uLmh0bWwKICMgTmVlZHMgdG8gYmUgZml4ZWQg YXQgaW1hZ2UgZGVjb2RlciBsYXllciBmb3IgU2FmYXJpLgogZmFzdC9pbWFnZXMvbGFyZ2Utc2l6 ZS1pbWFnZS1jcmFzaC5odG1sCiAKLSMgUmVncmVzc2lvbiBmcm9tIGh0dHA6Ly90cmFjLndlYmtp dC5vcmcvY2hhbmdlc2V0LzYyODc2Ci0jIFRoYXQgY2hhbmdlIGlzIHRvbyBuYXJseSB0byByb2xs IG91dCBhbmQgQWFyb24gQm9vZG1hbiBpc24ndCBhcm91bmQgdG8KLSMgZmlndXJlIG91dCB0aGUg Y29ycmVjdCBmaXguICBJZiB0aGlzIGVudHJ5IHN0YXlzIGluIHRoaXMgZmlsZSBmb3IgbW9yZQot IyB0aGFuIHR3byBkYXlzLCB0aGUgZmlyc3Qgb25lIHRvIHBvaW50IGl0IG91dCB0byBBZGFtIEJh cnRoIHdpbGwgcmVjZWl2ZQotIyBhIGZyZWUgYmVlci4KLXByaW50aW5nL3BhZ2UtcnVsZS1zZWxl Y3Rpb24uaHRtbApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcHJpbnRpbmcvcGFnZS1ydWxlLXNl bGVjdGlvbi5odG1sIGIvTGF5b3V0VGVzdHMvcHJpbnRpbmcvcGFnZS1ydWxlLXNlbGVjdGlvbi5o dG1sCmluZGV4IDQ2ZTdiNjZlYWFkNDE1OTg2M2FkY2Y0NGZlYTNhOTEzZTQ1MjUwN2UuLjhmZmEz MzY1YjQ4OTg1ZDIwOTczYjM5YzExZjlhZGVkY2MzZjJjMTQgMTAwNjQ0Ci0tLSBhL0xheW91dFRl c3RzL3ByaW50aW5nL3BhZ2UtcnVsZS1zZWxlY3Rpb24uaHRtbAorKysgYi9MYXlvdXRUZXN0cy9w cmludGluZy9wYWdlLXJ1bGUtc2VsZWN0aW9uLmh0bWwKQEAgLTI4LDcgKzI4LDcgQEAKICAgICAg ICAgc2hvdWxkQmVFcXVhbFRvU3RyaW5nKCJsYXlvdXRUZXN0Q29udHJvbGxlci5wYWdlUHJvcGVy dHkoJ21hcmdpbi1sZWZ0JywgNCkiLCAiYXV0byIpOwogCiAgICAgICAgIGRlYnVnKCJTZXQgbWFy Z2luIHRvIDIwMHB4IHZpYSB1c2VyIHN0eWxlIHNoZWV0LiIpOwotICAgICAgICBsYXlvdXRUZXN0 Q29udHJvbGxlci5hZGRVc2VyU3R5bGVTaGVldCgiQHBhZ2UgeyBtYXJnaW46MjAwcHg7IH0iKTsK KyAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuYWRkVXNlclN0eWxlU2hlZXQoIkBwYWdlIHsg bWFyZ2luOjIwMHB4OyB9IiwgdHJ1ZSk7CiAgICAgICAgIHNob3VsZEJlRXF1YWxUb1N0cmluZygi bGF5b3V0VGVzdENvbnRyb2xsZXIucGFnZVByb3BlcnR5KCdtYXJnaW4tbGVmdCcsIDApIiwgIjIw MCIpOwogICAgICAgICBzaG91bGRCZUVxdWFsVG9TdHJpbmcoImxheW91dFRlc3RDb250cm9sbGVy LnBhZ2VQcm9wZXJ0eSgnbWFyZ2luLWxlZnQnLCAxKSIsICIyMDAiKTsKICAgICAgICAgc2hvdWxk QmVFcXVhbFRvU3RyaW5nKCJsYXlvdXRUZXN0Q29udHJvbGxlci5wYWdlUHJvcGVydHkoJ21hcmdp bi1sZWZ0JywgMikiLCAiMjAwIik7Cg==