41911 2010-07-08 15:34:03 -0700 Remove useless PlatformScrollBar 2010-07-22 16:16:53 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) PC Windows XP RESOLVED FIXED P2 Normal --- 0 paroga webkit-unassigned commit-queue oldest_to_newest 248590 0 paroga 2010-07-08 15:34:03 -0700 I didn't find any usage of PlatformScrollBar.h and PlatformScrollBarWin.cpp. 248592 1 60971 paroga 2010-07-08 15:36:06 -0700 Created attachment 60971 Patch 254998 2 60971 ojan 2010-07-22 14:51:17 -0700 Comment on attachment 60971 Patch As best I can tell, you're right that it's not used anywhere and it did pass the EWS bots. 255043 3 60971 commit-queue 2010-07-22 16:16:49 -0700 Comment on attachment 60971 Patch Clearing flags on attachment: 60971 Committed r63919: <http://trac.webkit.org/changeset/63919> 255044 4 commit-queue 2010-07-22 16:16:53 -0700 All reviewed patches have been landed. Closing bug. 60971 2010-07-08 15:36:06 -0700 2010-07-22 16:16:49 -0700 Patch bug-41911.patch text/plain 5642 paroga SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nDQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQotLS0gV2ViQ29yZS9DaGFuZ2VM b2cJKHJldmlzaW9uIDYyODU2KQ0KKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkp DQpAQCAtMSwzICsxLDE0IEBADQorMjAxMC0wNy0wOCAgUGF0cmljayBHYW5zdGVyZXIgIDxwYXJv Z2FAcGFyb2dhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBSZW1vdmUgdXNlbGVzcyBQbGF0Zm9ybVNjcm9sbEJhcgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDE5MTEKKworICAgICAgICAqIFdlYkNv cmUuZ3lwaToKKyAgICAgICAgKiBwbGF0Zm9ybS93aW4vUGxhdGZvcm1TY3JvbGxCYXIuaDogUmVt b3ZlZC4KKyAgICAgICAgKiBwbGF0Zm9ybS93aW4vUGxhdGZvcm1TY3JvbGxCYXJXaW4uY3BwOiBS ZW1vdmVkLgorCiAyMDEwLTA3LTA4ICBKb24gSG9uZXljdXR0ICA8amhvbmV5Y3V0dEBhcHBsZS5j b20+CiAKICAgICAgICAgTWlzc2luZyBwbHVnLWlucyBtYXkgY2F1c2UgYW4gYXNzZXJ0aW9uIGZh aWx1cmUuCkluZGV4OiBXZWJDb3JlL3BsYXRmb3JtL3dpbi9QbGF0Zm9ybVNjcm9sbEJhci5oDQo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09DQotLS0gV2ViQ29yZS9wbGF0Zm9ybS93aW4vUGxhdGZvcm1TY3JvbGxCYXIuaAko cmV2aXNpb24gNjI1NDcpDQorKysgV2ViQ29yZS9wbGF0Zm9ybS93aW4vUGxhdGZvcm1TY3JvbGxC YXIuaAkod29ya2luZyBjb3B5KQ0KQEAgLTEsNTAgKzAsMCBAQA0KLS8qCi0gKiBDb3B5cmlnaHQg KEMpIDIwMDQsIDIwMDUsIDIwMDYsIDIwMDcsIDIwMDggQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJl c2VydmVkLgotICoKLSAqIFJlZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5h cnkgZm9ybXMsIHdpdGggb3Igd2l0aG91dAotICogbW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0dGVk IHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25kaXRpb25zCi0gKiBhcmUgbWV0OgotICog MS4gUmVkaXN0cmlidXRpb25zIG9mIHNvdXJjZSBjb2RlIG11c3QgcmV0YWluIHRoZSBhYm92ZSBj b3B5cmlnaHQKLSAqICAgIG5vdGljZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBm b2xsb3dpbmcgZGlzY2xhaW1lci4KLSAqIDIuIFJlZGlzdHJpYnV0aW9ucyBpbiBiaW5hcnkgZm9y bSBtdXN0IHJlcHJvZHVjZSB0aGUgYWJvdmUgY29weXJpZ2h0Ci0gKiAgICBub3RpY2UsIHRoaXMg bGlzdCBvZiBjb25kaXRpb25zIGFuZCB0aGUgZm9sbG93aW5nIGRpc2NsYWltZXIgaW4gdGhlCi0g KiAgICBkb2N1bWVudGF0aW9uIGFuZC9vciBvdGhlciBtYXRlcmlhbHMgcHJvdmlkZWQgd2l0aCB0 aGUgZGlzdHJpYnV0aW9uLgotICoKLSAqIFRISVMgU09GVFdBUkUgSVMgUFJPVklERUQgQlkgQVBQ TEUgQ09NUFVURVIsIElOQy4gYGBBUyBJUycnIEFORCBBTlkKLSAqIEVYUFJFU1MgT1IgSU1QTElF RCBXQVJSQU5USUVTLCBJTkNMVURJTkcsIEJVVCBOT1QgTElNSVRFRCBUTywgVEhFCi0gKiBJTVBM SUVEIFdBUlJBTlRJRVMgT0YgTUVSQ0hBTlRBQklMSVRZIEFORCBGSVRORVNTIEZPUiBBIFBBUlRJ Q1VMQVIKLSAqIFBVUlBPU0UgQVJFIERJU0NMQUlNRUQuICBJTiBOTyBFVkVOVCBTSEFMTCBBUFBM RSBDT01QVVRFUiwgSU5DLiBPUgotICogQ09OVFJJQlVUT1JTIEJFIExJQUJMRSBGT1IgQU5ZIERJ UkVDVCwgSU5ESVJFQ1QsIElOQ0lERU5UQUwsIFNQRUNJQUwsCi0gKiBFWEVNUExBUlksIE9SIENP TlNFUVVFTlRJQUwgREFNQUdFUyAoSU5DTFVESU5HLCBCVVQgTk9UIExJTUlURUQgVE8sCi0gKiBQ Uk9DVVJFTUVOVCBPRiBTVUJTVElUVVRFIEdPT0RTIE9SIFNFUlZJQ0VTOyBMT1NTIE9GIFVTRSwg REFUQSwgT1IKLSAqIFBST0ZJVFM7IE9SIEJVU0lORVNTIElOVEVSUlVQVElPTikgSE9XRVZFUiBD QVVTRUQgQU5EIE9OIEFOWSBUSEVPUlkKLSAqIE9GIExJQUJJTElUWSwgV0hFVEhFUiBJTiBDT05U UkFDVCwgU1RSSUNUIExJQUJJTElUWSwgT1IgVE9SVAotICogKElOQ0xVRElORyBORUdMSUdFTkNF IE9SIE9USEVSV0lTRSkgQVJJU0lORyBJTiBBTlkgV0FZIE9VVCBPRiBUSEUgVVNFCi0gKiBPRiBU SElTIFNPRlRXQVJFLCBFVkVOIElGIEFEVklTRUQgT0YgVEhFIFBPU1NJQklMSVRZIE9GIFNVQ0gg REFNQUdFLiAKLSAqLwotCi0jaWZuZGVmIFBsYXRmb3JtU2Nyb2xsQmFyX2gKLSNkZWZpbmUgUGxh dGZvcm1TY3JvbGxCYXJfaAotCi0jaW5jbHVkZSAiU2Nyb2xsYmFyLmgiCi0jaW5jbHVkZSAiVGlt ZXIuaCIKLSNpbmNsdWRlIDx3dGYvUGFzc1JlZlB0ci5oPgotCi10eXBlZGVmIHN0cnVjdCBIRENf XyogSERDOwotCi1uYW1lc3BhY2UgV2ViQ29yZSB7Ci0KLWNsYXNzIFBsYXRmb3JtU2Nyb2xsYmFy IDogcHVibGljIFNjcm9sbGJhciB7Ci1wdWJsaWM6Ci0gICAgc3RhdGljIFBhc3NSZWZQdHI8UGxh dGZvcm1TY3JvbGxiYXI+IGNyZWF0ZShTY3JvbGxiYXJDbGllbnQqIGNsaWVudCwgU2Nyb2xsYmFy T3JpZW50YXRpb24gb3JpZW50YXRpb24sIFNjcm9sbGJhckNvbnRyb2xTaXplIHNpemUpCi0gICAg ewotICAgICAgICByZXR1cm4gYWRvcHRSZWYobmV3IFBsYXRmb3JtU2Nyb2xsYmFyKGNsaWVudCwg b3JpZW50YXRpb24sIHNpemUpKTsKLSAgICB9Ci0gICAgCi0gICAgUGxhdGZvcm1TY3JvbGxiYXIo U2Nyb2xsYmFyQ2xpZW50KiwgU2Nyb2xsYmFyT3JpZW50YXRpb24sIFNjcm9sbGJhckNvbnRyb2xT aXplLCBTY3JvbGxiYXJUaGVtZSogPSAwKTsKLX07Ci0KLX0KLQotI2VuZGlmIC8vIFBsYXRmb3Jt U2Nyb2xsQmFyX2gKLQpJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS93aW4vUGxhdGZvcm1TY3JvbGxC YXJXaW4uY3BwDQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09DQotLS0gV2ViQ29yZS9wbGF0Zm9ybS93aW4vUGxhdGZvcm1T Y3JvbGxCYXJXaW4uY3BwCShyZXZpc2lvbiA2MjU0NykNCisrKyBXZWJDb3JlL3BsYXRmb3JtL3dp bi9QbGF0Zm9ybVNjcm9sbEJhcldpbi5jcHAJKHdvcmtpbmcgY29weSkNCkBAIC0xLDQzICswLDAg QEANCi0vKgotICogQ29weXJpZ2h0IChDKSAyMDA3LCAyMDA4IEFwcGxlIEluYy4gIEFsbCByaWdo dHMgcmVzZXJ2ZWQuCi0gKiBDb3B5cmlnaHQgKEMpIDIwMDggQnJlbnQgRnVsZ2hhbQotICoKLSAq IFJlZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGgg b3Igd2l0aG91dAotICogbW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0dGVkIHByb3ZpZGVkIHRoYXQg dGhlIGZvbGxvd2luZyBjb25kaXRpb25zCi0gKiBhcmUgbWV0OgotICogMS4gUmVkaXN0cmlidXRp b25zIG9mIHNvdXJjZSBjb2RlIG11c3QgcmV0YWluIHRoZSBhYm92ZSBjb3B5cmlnaHQKLSAqICAg IG5vdGljZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlzY2xh aW1lci4KLSAqIDIuIFJlZGlzdHJpYnV0aW9ucyBpbiBiaW5hcnkgZm9ybSBtdXN0IHJlcHJvZHVj ZSB0aGUgYWJvdmUgY29weXJpZ2h0Ci0gKiAgICBub3RpY2UsIHRoaXMgbGlzdCBvZiBjb25kaXRp b25zIGFuZCB0aGUgZm9sbG93aW5nIGRpc2NsYWltZXIgaW4gdGhlCi0gKiAgICBkb2N1bWVudGF0 aW9uIGFuZC9vciBvdGhlciBtYXRlcmlhbHMgcHJvdmlkZWQgd2l0aCB0aGUgZGlzdHJpYnV0aW9u LgotICoKLSAqIFRISVMgU09GVFdBUkUgSVMgUFJPVklERUQgQlkgQVBQTEUgQ09NUFVURVIsIElO Qy4gYGBBUyBJUycnIEFORCBBTlkKLSAqIEVYUFJFU1MgT1IgSU1QTElFRCBXQVJSQU5USUVTLCBJ TkNMVURJTkcsIEJVVCBOT1QgTElNSVRFRCBUTywgVEhFCi0gKiBJTVBMSUVEIFdBUlJBTlRJRVMg T0YgTUVSQ0hBTlRBQklMSVRZIEFORCBGSVRORVNTIEZPUiBBIFBBUlRJQ1VMQVIKLSAqIFBVUlBP U0UgQVJFIERJU0NMQUlNRUQuICBJTiBOTyBFVkVOVCBTSEFMTCBBUFBMRSBDT01QVVRFUiwgSU5D LiBPUgotICogQ09OVFJJQlVUT1JTIEJFIExJQUJMRSBGT1IgQU5ZIERJUkVDVCwgSU5ESVJFQ1Qs IElOQ0lERU5UQUwsIFNQRUNJQUwsCi0gKiBFWEVNUExBUlksIE9SIENPTlNFUVVFTlRJQUwgREFN QUdFUyAoSU5DTFVESU5HLCBCVVQgTk9UIExJTUlURUQgVE8sCi0gKiBQUk9DVVJFTUVOVCBPRiBT VUJTVElUVVRFIEdPT0RTIE9SIFNFUlZJQ0VTOyBMT1NTIE9GIFVTRSwgREFUQSwgT1IKLSAqIFBS T0ZJVFM7IE9SIEJVU0lORVNTIElOVEVSUlVQVElPTikgSE9XRVZFUiBDQVVTRUQgQU5EIE9OIEFO WSBUSEVPUlkKLSAqIE9GIExJQUJJTElUWSwgV0hFVEhFUiBJTiBDT05UUkFDVCwgU1RSSUNUIExJ QUJJTElUWSwgT1IgVE9SVAotICogKElOQ0xVRElORyBORUdMSUdFTkNFIE9SIE9USEVSV0lTRSkg QVJJU0lORyBJTiBBTlkgV0FZIE9VVCBPRiBUSEUgVVNFCi0gKiBPRiBUSElTIFNPRlRXQVJFLCBF VkVOIElGIEFEVklTRUQgT0YgVEhFIFBPU1NJQklMSVRZIE9GIFNVQ0ggREFNQUdFLgotICovCi0K LSNpbmNsdWRlICJjb25maWcuaCIKLSNpbmNsdWRlICJQbGF0Zm9ybVNjcm9sbEJhci5oIgotCi0j aW5jbHVkZSAiRnJhbWVWaWV3LmgiCi0jaW5jbHVkZSAiU2Nyb2xsYmFyQ2xpZW50LmgiCi0jaW5j bHVkZSAiU2Nyb2xsYmFyVGhlbWUuaCIKLQotbmFtZXNwYWNlIFdlYkNvcmUgewotCi1QbGF0Zm9y bVNjcm9sbGJhcjo6UGxhdGZvcm1TY3JvbGxiYXIoU2Nyb2xsYmFyQ2xpZW50KiBjbGllbnQsIFNj cm9sbGJhck9yaWVudGF0aW9uIG9yaWVudGF0aW9uLCBTY3JvbGxiYXJDb250cm9sU2l6ZSBzaXpl LAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFNjcm9sbGJhclRoZW1lKiB0 aGVtZSkKLSAgICA6IFNjcm9sbGJhcihjbGllbnQsIG9yaWVudGF0aW9uLCBzaXplLCB0aGVtZSkK LXsKLX0KLQotfQotCkluZGV4OiBXZWJDb3JlL1dlYkNvcmUuZ3lwaQ0KPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KLS0t IFdlYkNvcmUvV2ViQ29yZS5neXBpCShyZXZpc2lvbiA2MjU0NykNCisrKyBXZWJDb3JlL1dlYkNv cmUuZ3lwaQkod29ya2luZyBjb3B5KQ0KQEAgLTI4NzgsOCArMjg3OCw2IEBADQogICAgICAgICAg ICAgJ3BsYXRmb3JtL3dpbi9QYXN0ZWJvYXJkV2luLmNwcCcsCiAgICAgICAgICAgICAncGxhdGZv cm0vd2luL1BsYXRmb3JtTW91c2VFdmVudFdpbi5jcHAnLAogICAgICAgICAgICAgJ3BsYXRmb3Jt L3dpbi9QbGF0Zm9ybVNjcmVlbldpbi5jcHAnLAotICAgICAgICAgICAgJ3BsYXRmb3JtL3dpbi9Q bGF0Zm9ybVNjcm9sbEJhci5oJywKLSAgICAgICAgICAgICdwbGF0Zm9ybS93aW4vUGxhdGZvcm1T Y3JvbGxCYXJXaW4uY3BwJywKICAgICAgICAgICAgICdwbGF0Zm9ybS93aW4vUG9wdXBNZW51V2lu LmNwcCcsCiAgICAgICAgICAgICAncGxhdGZvcm0vd2luL1Njcm9sbGJhclRoZW1lU2FmYXJpLmNw cCcsCiAgICAgICAgICAgICAncGxhdGZvcm0vd2luL1Njcm9sbGJhclRoZW1lU2FmYXJpLmgnLAo=