41883 2010-07-08 11:41:45 -0700 [chromium] Fix deletion has begun assertion in TestImage destructor. 2010-12-20 22:39:37 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 vitalyr vitalyr commit-queue eric pfeldman oldest_to_newest 248382 0 vitalyr 2010-07-08 11:41:45 -0700 [chromium] Fix deletion has begun assertion in TestImage destructor. 248383 1 60918 vitalyr 2010-07-08 11:43:04 -0700 Created attachment 60918 patch 263129 2 60918 commit-queue 2010-08-11 02:20:07 -0700 Comment on attachment 60918 patch Rejecting patch 60918 from commit-queue. Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Pavel Feldman', u'--force']" exit_code: 1 Parsed 2 diffs from patch file(s). patching file WebKit/chromium/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file WebKit/chromium/tests/DragImageTest.cpp Hunk #1 succeeded at 48 with fuzz 2 (offset 5 lines). Hunk #2 FAILED at 118. Hunk #3 FAILED at 139. 2 out of 3 hunks FAILED -- saving rejects to file WebKit/chromium/tests/DragImageTest.cpp.rej Full output: http://queues.webkit.org/results/3776045 293600 3 eric 2010-10-13 12:25:15 -0700 Attachment 60918 was posted by a committer and has review+, assigning to Vitaly Repeshko for commit. 324811 4 eric 2010-12-20 22:39:37 -0800 r62812. Please use webkit-patch land so that bugs get closed when you land changes. 60918 2010-07-08 11:43:04 -0700 2010-08-11 02:20:07 -0700 patch fix_dtor.patch text/plain 2878 vitalyr ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IGU1MGRjOGQuLmYxYTQ5M2UgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpAQCAtMSw1ICsx LDE4IEBACiAyMDEwLTA3LTA4ICBWaXRhbHkgUmVwZXNoa28gIDx2aXRhbHlyQGNocm9taXVtLm9y Zz4KIAorICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXgg ZGVsZXRpb24gaGFzIGJlZ3VuIGFzc2VydGlvbiBpbiBUZXN0SW1hZ2UgZGVzdHJ1Y3Rvci4KKwor ICAgICAgICBbY2hyb21pdW1dIEZpeCBkZWxldGlvbiBoYXMgYmVndW4gYXNzZXJ0aW9uIGluIFRl c3RJbWFnZSBkZXN0cnVjdG9yLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NDE4ODMKKworICAgICAgICAqIHRlc3RzL0RyYWdJbWFnZVRlc3QuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6VGVzdEltYWdlOjpjcmVhdGUpOgorICAgICAgICAoV2ViQ29yZTo6 VEVTVCk6CisKKzIwMTAtMDctMDggIFZpdGFseSBSZXBlc2hrbyAgPHZpdGFseXJAY2hyb21pdW0u b3JnPgorCiAgICAgICAgIFJldmlld2VkIGJ5IFBhdmVsIEZlbGRtYW4uCiAKICAgICAgICAgRml4 IGFkb3B0UmVmIHVzYWdlIHZpb2xhdGlvbnMgKG1vc3RseSBpbiBjaHJvbWl1bSkKZGlmZiAtLWdp dCBhL1dlYktpdC9jaHJvbWl1bS90ZXN0cy9EcmFnSW1hZ2VUZXN0LmNwcCBiL1dlYktpdC9jaHJv bWl1bS90ZXN0cy9EcmFnSW1hZ2VUZXN0LmNwcAppbmRleCA3YjdkNGVlLi44Y2U2ZmUyIDEwMDY0 NAotLS0gYS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvRHJhZ0ltYWdlVGVzdC5jcHAKKysrIGIvV2Vi S2l0L2Nocm9taXVtL3Rlc3RzL0RyYWdJbWFnZVRlc3QuY3BwCkBAIC00Myw2ICs0MywxMSBAQCBu YW1lc3BhY2UgewogY2xhc3MgVGVzdEltYWdlIDogcHVibGljIEltYWdlIHsKIHB1YmxpYzoKIAor ICAgIHN0YXRpYyBQYXNzUmVmUHRyPFRlc3RJbWFnZT4gY3JlYXRlKGNvbnN0IEludFNpemUmIHNp emUpCisgICAgeworICAgICAgICByZXR1cm4gYWRvcHRSZWYobmV3IFRlc3RJbWFnZShzaXplKSk7 CisgICAgfQorCiAgICAgZXhwbGljaXQgVGVzdEltYWdlKGNvbnN0IEludFNpemUmIHNpemUpCiAg ICAgICAgIDogSW1hZ2UoMCkKICAgICAgICAgLCBtX3NpemUoc2l6ZSkKQEAgLTEwOCw4ICsxMTMs OCBAQCBURVNUKERyYWdJbWFnZVRlc3QsIE51bGxIYW5kbGluZykKIAogVEVTVChEcmFnSW1hZ2VU ZXN0LCBOb25OdWxsSGFuZGxpbmcpCiB7Ci0gICAgVGVzdEltYWdlIHRlc3RJbWFnZShJbnRTaXpl KDIsIDIpKTsKLSAgICBEcmFnSW1hZ2VSZWYgZHJhZ0ltYWdlID0gY3JlYXRlRHJhZ0ltYWdlRnJv bUltYWdlKCZ0ZXN0SW1hZ2UpOworICAgIFJlZlB0cjxUZXN0SW1hZ2U+IHRlc3RJbWFnZShUZXN0 SW1hZ2U6OmNyZWF0ZShJbnRTaXplKDIsIDIpKSk7CisgICAgRHJhZ0ltYWdlUmVmIGRyYWdJbWFn ZSA9IGNyZWF0ZURyYWdJbWFnZUZyb21JbWFnZSh0ZXN0SW1hZ2UuZ2V0KCkpOwogICAgIEFTU0VS VF9UUlVFKGRyYWdJbWFnZSk7CiAKICAgICBkcmFnSW1hZ2UgPSBzY2FsZURyYWdJbWFnZShkcmFn SW1hZ2UsIEZsb2F0U2l6ZSgwLjUsIDAuNSkpOwpAQCAtMTI5LDE3ICsxMzQsMTcgQEAgVEVTVChE cmFnSW1hZ2VUZXN0LCBDcmVhdGVEcmFnSW1hZ2UpCiAgICAgewogICAgICAgICAvLyBUZXN0cyB0 aGF0IHRoZSBEcmFnZUltYWdlIGltcGxlbWVudGF0aW9uIGRvZXNuJ3QgY2hva2Ugb24gbnVsbCB2 YWx1ZXMKICAgICAgICAgLy8gb2YgbmF0aXZlSW1hZ2VGb3JDdXJyZW50RnJhbWUoKS4KLSAgICAg ICAgVGVzdEltYWdlIHRlc3RJbWFnZSgoSW50U2l6ZSgpKSk7Ci0gICAgICAgIEVYUEVDVF9GQUxT RShjcmVhdGVEcmFnSW1hZ2VGcm9tSW1hZ2UoJnRlc3RJbWFnZSkpOworICAgICAgICBSZWZQdHI8 VGVzdEltYWdlPiB0ZXN0SW1hZ2UoVGVzdEltYWdlOjpjcmVhdGUoSW50U2l6ZSgpKSk7CisgICAg ICAgIEVYUEVDVF9GQUxTRShjcmVhdGVEcmFnSW1hZ2VGcm9tSW1hZ2UodGVzdEltYWdlLmdldCgp KSk7CiAgICAgfQogCiAgICAgewogICAgICAgICAvLyBUZXN0cyB0aGF0IHRoZSBkcmFnIGltYWdl IGlzIGEgZGVlcCBjb3B5LgotICAgICAgICBUZXN0SW1hZ2UgdGVzdEltYWdlKEludFNpemUoMSwg MSkpOwotICAgICAgICBEcmFnSW1hZ2VSZWYgZHJhZ0ltYWdlID0gY3JlYXRlRHJhZ0ltYWdlRnJv bUltYWdlKCZ0ZXN0SW1hZ2UpOworICAgICAgICBSZWZQdHI8VGVzdEltYWdlPiB0ZXN0SW1hZ2Uo VGVzdEltYWdlOjpjcmVhdGUoSW50U2l6ZSgxLCAxKSkpOworICAgICAgICBEcmFnSW1hZ2VSZWYg ZHJhZ0ltYWdlID0gY3JlYXRlRHJhZ0ltYWdlRnJvbUltYWdlKHRlc3RJbWFnZS5nZXQoKSk7CiAg ICAgICAgIEFTU0VSVF9UUlVFKGRyYWdJbWFnZSk7Ci0gICAgICAgIFNrQXV0b0xvY2tQaXhlbHMg bG9jazEoKmRyYWdJbWFnZSksIGxvY2syKCp0ZXN0SW1hZ2UubmF0aXZlSW1hZ2VGb3JDdXJyZW50 RnJhbWUoKSk7Ci0gICAgICAgIEVYUEVDVF9ORShkcmFnSW1hZ2UtPmdldFBpeGVscygpLCB0ZXN0 SW1hZ2UubmF0aXZlSW1hZ2VGb3JDdXJyZW50RnJhbWUoKS0+Z2V0UGl4ZWxzKCkpOworICAgICAg ICBTa0F1dG9Mb2NrUGl4ZWxzIGxvY2sxKCpkcmFnSW1hZ2UpLCBsb2NrMigqKHRlc3RJbWFnZS0+ bmF0aXZlSW1hZ2VGb3JDdXJyZW50RnJhbWUoKSkpOworICAgICAgICBFWFBFQ1RfTkUoZHJhZ0lt YWdlLT5nZXRQaXhlbHMoKSwgdGVzdEltYWdlLT5uYXRpdmVJbWFnZUZvckN1cnJlbnRGcmFtZSgp LT5nZXRQaXhlbHMoKSk7CiAgICAgfQogfQogCg==