<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>41880</bug_id>
          
          <creation_ts>2010-07-08 11:26:53 -0700</creation_ts>
          <short_desc>[Qt] [WebKit2] Make QWKPage call _q_webActionTriggered as a private slot</short_desc>
          <delta_ts>2010-07-09 09:31:06 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit2</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>Qt</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Diego Gonzalez">diegohcg</reporter>
          <assigned_to name="Diego Gonzalez">diegohcg</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>kenneth</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>248365</commentid>
    <comment_count>0</comment_count>
    <who name="Diego Gonzalez">diegohcg</who>
    <bug_when>2010-07-08 11:26:53 -0700</bug_when>
    <thetext>Make possible to handle the slots for web actions</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>248391</commentid>
    <comment_count>1</comment_count>
      <attachid>60919</attachid>
    <who name="Diego Gonzalez">diegohcg</who>
    <bug_when>2010-07-08 11:52:27 -0700</bug_when>
    <thetext>Created attachment 60919
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>249019</commentid>
    <comment_count>2</comment_count>
      <attachid>60919</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2010-07-09 08:14:05 -0700</bug_when>
    <thetext>Comment on attachment 60919
Patch

Rejecting patch 60919 from commit-queue.

Failed to run &quot;[u&apos;/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply&apos;, u&apos;--reviewer&apos;, u&apos;Kenneth Rohde Christiansen&apos;, u&apos;--force&apos;]&quot; exit_code: 1
Parsed 3 diffs from patch file(s).
patching file WebKit2/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file WebKit2/UIProcess/API/qt/qwkpage.cpp
patching file WebKit2/UIProcess/API/qt/qwkpage.h
Hunk #1 FAILED at 65.
1 out of 1 hunk FAILED -- saving rejects to file WebKit2/UIProcess/API/qt/qwkpage.h.rej

Full output: http://webkit-commit-queue.appspot.com/results/3433053</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>249046</commentid>
    <comment_count>3</comment_count>
    <who name="Diego Gonzalez">diegohcg</who>
    <bug_when>2010-07-09 09:31:06 -0700</bug_when>
    <thetext>Landed manually at r62959 https://trac.webkit.org/changeset/62959</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>60919</attachid>
            <date>2010-07-08 11:52:27 -0700</date>
            <delta_ts>2010-07-09 08:14:05 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>0001-Make-QWKPage-call-_q_webActionTriggered-as-a-private-.diff</filename>
            <type>text/plain</type>
            <size>2040</size>
            <attacher name="Diego Gonzalez">diegohcg</attacher>
            
              <data encoding="base64">RnJvbSAzMzgxN2Y5ZTIyZTM5YmMwMjRmMjIxYTY4NGM3NTM0YmY5NTE5YTc3IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBEaWVnbyBHb256YWxleiA8ZGllZ29oY2dAd2Via2l0Lm9yZz4K
RGF0ZTogVGh1LCA4IEp1bCAyMDEwIDE0OjI5OjAzIC0wNDAwClN1YmplY3Q6IFtQQVRDSF0gTWFr
ZSBRV0tQYWdlIGNhbGwgX3Ffd2ViQWN0aW9uVHJpZ2dlcmVkIGFzIGEgcHJpdmF0ZSBzbG90IGh0
dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MTg4MAoKUmV2aWV3ZWQgYnkg
Tk9CT0RZIChPT1BTISkuCgoqIFVJUHJvY2Vzcy9BUEkvcXQvcXdrcGFnZS5jcHA6CiogVUlQcm9j
ZXNzL0FQSS9xdC9xd2twYWdlLmg6Ci0tLQogV2ViS2l0Mi9DaGFuZ2VMb2cgICAgICAgICAgICAg
ICAgICAgIHwgICAxMCArKysrKysrKysrCiBXZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXdrcGFn
ZS5jcHAgfCAgICAyICsrCiBXZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXdrcGFnZS5oICAgfCAg
ICA2ICsrKysrLQogMyBmaWxlcyBjaGFuZ2VkLCAxNyBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9u
cygtKQoKZGlmZiAtLWdpdCBhL1dlYktpdDIvQ2hhbmdlTG9nIGIvV2ViS2l0Mi9DaGFuZ2VMb2cK
aW5kZXggMTA3NTE0Ni4uN2M1YzNkNyAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9DaGFuZ2VMb2cKKysr
IGIvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0wNy0wOCAgRGllZ28g
R29uemFsZXogIDxkaWVnb2hjZ0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P
Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gW1dlYktpdDJdIE1ha2UgUVdLUGFnZSBjYWxs
IF9xX3dlYkFjdGlvblRyaWdnZXJlZCBhcyBhIHByaXZhdGUgc2xvdAorICAgICAgICBodHRwczov
L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDE4ODAKKworICAgICAgICAqIFVJUHJv
Y2Vzcy9BUEkvcXQvcXdrcGFnZS5jcHA6CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9xdC9xd2tw
YWdlLmg6CisKIDIwMTAtMDctMDggIFNhbSBXZWluaWcgIDxzYW1Ad2Via2l0Lm9yZz4KIAogICAg
ICAgICBSZXZpZXdlZCBieSBBbmRlcnMgQ2FybHNzb24uCmRpZmYgLS1naXQgYS9XZWJLaXQyL1VJ
UHJvY2Vzcy9BUEkvcXQvcXdrcGFnZS5jcHAgYi9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXdr
cGFnZS5jcHAKaW5kZXggYzFmNWE5YS4uZmJkMjNkNiAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9VSVBy
b2Nlc3MvQVBJL3F0L3F3a3BhZ2UuY3BwCisrKyBiL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9x
d2twYWdlLmNwcApAQCAtMzU0LDMgKzM1NCw1IEBAIFFBY3Rpb24qIFFXS1BhZ2U6OmFjdGlvbihX
ZWJBY3Rpb24gYWN0aW9uKSBjb25zdAogICAgIHJldHVybiBhOwogfQogI2VuZGlmIC8vIFFUX05P
X0FDVElPTgorCisjaW5jbHVkZSAibW9jX3F3a3BhZ2UuY3BwIgpkaWZmIC0tZ2l0IGEvV2ViS2l0
Mi9VSVByb2Nlc3MvQVBJL3F0L3F3a3BhZ2UuaCBiL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9x
d2twYWdlLmgKaW5kZXggOGM5MmUzMS4uMDE0YTI2MiAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9VSVBy
b2Nlc3MvQVBJL3F0L3F3a3BhZ2UuaAorKysgYi9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXdr
cGFnZS5oCkBAIC02NSwxMCArNjUsMTQgQEAgcHJvdGVjdGVkOgogICAgIHZvaWQgdGltZXJFdmVu
dChRVGltZXJFdmVudCopOwogCiBwcml2YXRlOgorI2lmbmRlZiBRVF9OT19BQ1RJT04KKyAgICBR
X1BSSVZBVEVfU0xPVChkLCB2b2lkIF9xX3dlYkFjdGlvblRyaWdnZXJlZChib29sIGNoZWNrZWQp
KTsKKyNlbmRpZgorICAgIFFXS1BhZ2VQcml2YXRlKiBkOworCiAgICAgZnJpZW5kIGNsYXNzIFFH
cmFwaGljc1dLVmlldzsKICAgICBmcmllbmQgY2xhc3MgUUdyYXBoaWNzV0tWaWV3dFByaXZhdGU7
CiAgICAgZnJpZW5kIGNsYXNzIFFXS1BhZ2VQcml2YXRlOwotICAgIFFXS1BhZ2VQcml2YXRlKiBk
OwogfTsKIAogI2VuZGlmIC8qIHF3a3BhZ2VfaCAqLwotLSAKMS43LjAuNAoK
</data>
<flag name="review"
          id="48755"
          type_id="1"
          status="+"
          setter="kenneth"
    />
    <flag name="commit-queue"
          id="48770"
          type_id="3"
          status="-"
          setter="commit-queue"
    />
          </attachment>
      

    </bug>

</bugzilla>