41858 2010-07-08 08:07:54 -0700 Web Inspector: hide AppCache until implemented. 2010-07-16 08:34:09 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 41965 1 pfeldman pfeldman abarth bweinstein commit-queue eric joepeck keishi pfeldman pmuellr rik timothy webkit.review.bot yurys oldest_to_newest 248209 0 pfeldman 2010-07-08 08:07:54 -0700 Patch to follow. 248210 1 60884 pfeldman 2010-07-08 08:10:08 -0700 Created attachment 60884 [PATCH] Proposed change. 248212 2 60884 yurys 2010-07-08 08:16:45 -0700 Comment on attachment 60884 [PATCH] Proposed change. WebCore/inspector/front-end/StoragePanel.js:52 + // TODO: uncomment when AppCache is implemented. Please put bug number after the TODO. 248216 3 60884 pfeldman 2010-07-08 08:24:13 -0700 Comment on attachment 60884 [PATCH] Proposed change. (In reply to comment #2) > (From update of attachment 60884 [details]) > WebCore/inspector/front-end/StoragePanel.js:52 > + // TODO: uncomment when AppCache is implemented. > Please put bug number after the TODO. There is no particular bug yet. But this is a live topic, so I expect this todo to vanish shortly. 248961 4 60884 commit-queue 2010-07-09 06:45:59 -0700 Comment on attachment 60884 [PATCH] Proposed change. Clearing flags on attachment: 60884 Committed r62946: <http://trac.webkit.org/changeset/62946> 248962 5 commit-queue 2010-07-09 06:46:04 -0700 All reviewed patches have been landed. Closing bug. 248988 6 webkit.review.bot 2010-07-09 07:19:41 -0700 http://trac.webkit.org/changeset/62946 might have broken SnowLeopard Intel Release (Tests) 249059 7 timothy 2010-07-09 09:46:19 -0700 FWIW, it is working enough on Safari/WebKit to having it enabled. Please change it so it stays enabled in WebKit, and Chrome disables it. 249060 8 joepeck 2010-07-09 09:49:42 -0700 Checking a global variable or preference would work nicer. Something like in inspector.js: // TODO: eventually enable application cache WebInspector.applicationCacheEnabled = false; And then instead of commenting out the code, you just wrap it in a block around this variable. This means that when we want to enable the feature locally, adding new features and enhancements we only have to change this variable to true and revert it to false when making a patch. With this patch we have to uncomment a lot of code in different places (and comment it back when making patches). When finally enabling the feature we would just delete the variable and its checks (easily searchable). 249062 9 pfeldman 2010-07-09 09:54:31 -0700 (In reply to comment #7) > FWIW, it is working enough on Safari/WebKit to having it enabled. Please change it so it stays enabled in WebKit, and Chrome disables it. Timothy, I'd appreciate if we used the same process as while implementing Timeline. We make it work and then agree on enabling it. Michael was pointing out the problems that make the feature look incomplete. Like - start the app - go to Storage - click on appcache icon - click on localStore icon appcache page is not hidden. So the thing is really broken to be enabled. 249064 10 joepeck 2010-07-09 09:59:20 -0700 (In reply to comment #9) > Like > - start the app > - go to Storage > - click on appcache icon > - click on localStore icon > > appcache page is not hidden. So the thing is really broken to be enabled. I have never encountered this problem. It works in Safari. If I saw this I would certainly have fixed it. Does an error get thrown in the inspector's inspector for Chrome? Maybe a check I missed if there was no data yet? 249065 11 pfeldman 2010-07-09 10:02:34 -0700 (In reply to comment #10) > (In reply to comment #9) > > Like > > - start the app > > - go to Storage > > - click on appcache icon > > - click on localStore icon > > > > appcache page is not hidden. So the thing is really broken to be enabled. > > I have never encountered this problem. It works in Safari. If I saw this I would > certainly have fixed it. Does an error get thrown in the inspector's inspector > for Chrome? Maybe a check I missed if there was no data yet? I tried it in Chromium, did not try in Safari. That is not the main point though. 249068 12 timothy 2010-07-09 10:05:26 -0700 (In reply to comment #9) > (In reply to comment #7) > > FWIW, it is working enough on Safari/WebKit to having it enabled. Please change it so it stays enabled in WebKit, and Chrome disables it. > > Timothy, I'd appreciate if we used the same process as while implementing Timeline. We make it work and then agree on enabling it. Michael was pointing out the problems that make the feature look incomplete. > > Like > - start the app > - go to Storage > - click on appcache icon > - click on localStore icon > > appcache page is not hidden. So the thing is really broken to be enabled. Was that in WebKit/Safari? I agree the feature should be hidden in Chrome is it isn't ready. Timeline panel was different, sicne it was a large new feature and could easily be hidden by removing the panel. This was multiple lines of code that got commented out and prevents easy developemt as Joe pointed out. I think this patch needs to be reverted or changed to check a global variable. And preferibly enabled in WebKit/Safari and disabled in Chrome until it is ready. 249075 13 timothy 2010-07-09 10:08:41 -0700 Also we don't normally land commented out code. We either remove it or hide it being a flag. So this patch should have not landed. 249077 14 pfeldman 2010-07-09 10:11:12 -0700 (In reply to comment #13) > Also we don't normally land commented out code. We either remove it or hide it being a flag. So this patch should have not landed. k, I am happy to hide it behind the preference flag. Will that be fine by you? I am actually a bit surprised seeing the reaction. My perception was that I am hiding it for you. As I understand this is change was copying Kavita's code, reworking it and landing it enabled without her permission / talking to her. 249083 15 timothy 2010-07-09 10:16:29 -0700 I guess the problem was on our end, we should have made sure it was disabled in Chrome when it got added to the UI. Similar to how V8 only features are done. 249084 16 timothy 2010-07-09 10:17:16 -0700 Yes a preference flag is fine, if it is true in TOT WebKit for Safari. 252523 17 61807 pfeldman 2010-07-16 08:25:54 -0700 Created attachment 61807 [PATCH] Take 2. Disabled in Chromium, enabled in WebKit. 252529 18 pfeldman 2010-07-16 08:34:09 -0700 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/front-end/Settings.js M WebCore/inspector/front-end/StoragePanel.js M WebKit/chromium/ChangeLog M WebKit/chromium/src/js/DevTools.js Committed r63549 60884 2010-07-08 08:10:08 -0700 2010-07-16 08:25:54 -0700 [PATCH] Proposed change. hide_appcache text/plain 2933 pfeldman ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg Y2Q3ZmZiYy4uYzkyYWI5YyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTIsNiArMiwxOSBAQAogCiAgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgogCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IGhpZGUgQXBwQ2FjaGUgdW50 aWwgaW1wbGVtZW50ZWQuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTQxODU4CisKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL1N0b3JhZ2VQ YW5lbC5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5TdG9yYWdlUGFuZWwpOgorICAgICAgICAo V2ViSW5zcGVjdG9yLlN0b3JhZ2VQYW5lbC5wcm90b3R5cGUucmVzZXQpOgorICAgICAgICAoV2Vi SW5zcGVjdG9yLlN0b3JhZ2VQYW5lbC5wcm90b3R5cGUuYWRkQXBwbGljYXRpb25DYWNoZSk6CisK KzIwMTAtMDctMDggIFBhdmVsIEZlbGRtYW4gIDxwZmVsZG1hbkBjaHJvbWl1bS5vcmc+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKICAgICAgICAgV2ViIEluc3BlY3Rv cjogUHJvdmlkZSBkZXRhaWxlZCBuZXR3b3JrIGluZm8gaW4gdGhlIHJlc291cmNlcyBwYW5lbC4K IAogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDAyMjcK ZGlmZiAtLWdpdCBhL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9TdG9yYWdlUGFuZWwuanMg Yi9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvU3RvcmFnZVBhbmVsLmpzCmluZGV4IGIzN2Qw MjkuLmI1MTUzNWEgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9TdG9y YWdlUGFuZWwuanMKKysrIGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1N0b3JhZ2VQYW5l bC5qcwpAQCAtNDksOSArNDksMTAgQEAgV2ViSW5zcGVjdG9yLlN0b3JhZ2VQYW5lbCA9IGZ1bmN0 aW9uKGRhdGFiYXNlKQogICAgIHRoaXMuc2lkZWJhclRyZWUuYXBwZW5kQ2hpbGQodGhpcy5jb29r aWVMaXN0VHJlZUVsZW1lbnQpOwogICAgIHRoaXMuY29va2llTGlzdFRyZWVFbGVtZW50LmV4cGFu ZCgpOwogCi0gICAgdGhpcy5hcHBsaWNhdGlvbkNhY2hlTGlzdFRyZWVFbGVtZW50ID0gbmV3IFdl Ykluc3BlY3Rvci5TaWRlYmFyU2VjdGlvblRyZWVFbGVtZW50KFdlYkluc3BlY3Rvci5VSVN0cmlu ZygiQVBQTElDQVRJT04gQ0FDSEUiKSwge30sIHRydWUpOwotICAgIHRoaXMuc2lkZWJhclRyZWUu YXBwZW5kQ2hpbGQodGhpcy5hcHBsaWNhdGlvbkNhY2hlTGlzdFRyZWVFbGVtZW50KTsKLSAgICB0 aGlzLmFwcGxpY2F0aW9uQ2FjaGVMaXN0VHJlZUVsZW1lbnQuZXhwYW5kKCk7CisgICAgLy8gVE9E TzogdW5jb21tZW50IHdoZW4gQXBwQ2FjaGUgaXMgaW1wbGVtZW50ZWQuCisgICAgLy8gdGhpcy5h cHBsaWNhdGlvbkNhY2hlTGlzdFRyZWVFbGVtZW50ID0gbmV3IFdlYkluc3BlY3Rvci5TaWRlYmFy U2VjdGlvblRyZWVFbGVtZW50KFdlYkluc3BlY3Rvci5VSVN0cmluZygiQVBQTElDQVRJT04gQ0FD SEUiKSwge30sIHRydWUpOworICAgIC8vIHRoaXMuc2lkZWJhclRyZWUuYXBwZW5kQ2hpbGQodGhp cy5hcHBsaWNhdGlvbkNhY2hlTGlzdFRyZWVFbGVtZW50KTsKKyAgICAvLyB0aGlzLmFwcGxpY2F0 aW9uQ2FjaGVMaXN0VHJlZUVsZW1lbnQuZXhwYW5kKCk7CiAKICAgICB0aGlzLnN0b3JhZ2VWaWV3 cyA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoImRpdiIpOwogICAgIHRoaXMuc3RvcmFnZVZpZXdz LmlkID0gInN0b3JhZ2Utdmlld3MiOwpAQCAtMTEwLDcgKzExMSw4IEBAIFdlYkluc3BlY3Rvci5T dG9yYWdlUGFuZWwucHJvdG90eXBlID0gewogICAgICAgICB0aGlzLmxvY2FsU3RvcmFnZUxpc3RU cmVlRWxlbWVudC5yZW1vdmVDaGlsZHJlbigpOwogICAgICAgICB0aGlzLnNlc3Npb25TdG9yYWdl TGlzdFRyZWVFbGVtZW50LnJlbW92ZUNoaWxkcmVuKCk7CiAgICAgICAgIHRoaXMuY29va2llTGlz dFRyZWVFbGVtZW50LnJlbW92ZUNoaWxkcmVuKCk7Ci0gICAgICAgIHRoaXMuYXBwbGljYXRpb25D YWNoZUxpc3RUcmVlRWxlbWVudC5yZW1vdmVDaGlsZHJlbigpOworICAgICAgICAvLyBUT0RPOiB1 bmNvbW1lbnQgd2hlbiBBcHBDYWNoZSBpcyBpbXBsZW1lbnRlZC4KKyAgICAgICAgLy8gdGhpcy5h cHBsaWNhdGlvbkNhY2hlTGlzdFRyZWVFbGVtZW50LnJlbW92ZUNoaWxkcmVuKCk7CiAKICAgICAg ICAgdGhpcy5zdG9yYWdlVmlld3MucmVtb3ZlQ2hpbGRyZW4oKTsKIApAQCAtMTQ4LDggKzE1MCw5 IEBAIFdlYkluc3BlY3Rvci5TdG9yYWdlUGFuZWwucHJvdG90eXBlID0gewogCiAgICAgYWRkQXBw bGljYXRpb25DYWNoZTogZnVuY3Rpb24oZG9tYWluKQogICAgIHsKLSAgICAgICAgdmFyIGFwcGxp Y2F0aW9uQ2FjaGVUcmVlRWxlbWVudCA9IG5ldyBXZWJJbnNwZWN0b3IuQXBwbGljYXRpb25DYWNo ZVNpZGViYXJUcmVlRWxlbWVudChkb21haW4pOwotICAgICAgICB0aGlzLmFwcGxpY2F0aW9uQ2Fj aGVMaXN0VHJlZUVsZW1lbnQuYXBwZW5kQ2hpbGQoYXBwbGljYXRpb25DYWNoZVRyZWVFbGVtZW50 KTsKKyAgICAgICAgLy8gVE9ETzogdW5jb21tZW50IHdoZW4gQXBwQ2FjaGUgaXMgaW1wbGVtZW50 ZWQuCisgICAgICAgIC8vIHZhciBhcHBsaWNhdGlvbkNhY2hlVHJlZUVsZW1lbnQgPSBuZXcgV2Vi SW5zcGVjdG9yLkFwcGxpY2F0aW9uQ2FjaGVTaWRlYmFyVHJlZUVsZW1lbnQoZG9tYWluKTsKKyAg ICAgICAgLy8gdGhpcy5hcHBsaWNhdGlvbkNhY2hlTGlzdFRyZWVFbGVtZW50LmFwcGVuZENoaWxk KGFwcGxpY2F0aW9uQ2FjaGVUcmVlRWxlbWVudCk7CiAgICAgfSwKIAogICAgIHNlbGVjdERhdGFi YXNlOiBmdW5jdGlvbihkYXRhYmFzZUlkKQo= 61807 2010-07-16 08:25:54 -0700 2010-07-16 08:28:59 -0700 [PATCH] Take 2. Disabled in Chromium, enabled in WebKit. hide_appcache text/plain 4158 pfeldman ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YjgzYzcwZC4uMTNlNzAwYiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMC0wNy0xNiAgUGF2ZWwgRmVsZG1h biAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBkaXNhYmxlIEFwcENhY2hlIGluIGNo cm9taXVtLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD00MTg1OAorCisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9TZXR0aW5ncy5qczoKKyAg ICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL1N0b3JhZ2VQYW5lbC5qczoKKyAgICAgICAgKFdl Ykluc3BlY3Rvci5TdG9yYWdlUGFuZWwpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlN0b3JhZ2VQ YW5lbC5wcm90b3R5cGUucmVzZXQpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlN0b3JhZ2VQYW5l bC5wcm90b3R5cGUuYWRkQXBwbGljYXRpb25DYWNoZSk6CisKIDIwMTAtMDctMTYgIE5pa29sYXMg WmltbWVybWFubiAgPG56aW1tZXJtYW5uQHJpbS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg RGlyayBTY2h1bHplLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1Nl dHRpbmdzLmpzIGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1NldHRpbmdzLmpzCmluZGV4 IDExZjQ1NmMuLjM5YzFlMWUgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVu ZC9TZXR0aW5ncy5qcworKysgYi9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvU2V0dGluZ3Mu anMKQEAgLTQyLDcgKzQyLDggQEAgdmFyIFByZWZlcmVuY2VzID0gewogICAgIHNob3dDb2xvck5p Y2tuYW1lczogdHJ1ZSwKICAgICBkZWJ1Z2dlckFsd2F5c0VuYWJsZWQ6IGZhbHNlLAogICAgIHBy b2ZpbGVyQWx3YXlzRW5hYmxlZDogZmFsc2UsCi0gICAgYXVkaXRzUGFuZWxFbmFibGVkOiB0cnVl CisgICAgYXVkaXRzUGFuZWxFbmFibGVkOiB0cnVlLAorICAgIGFwcENhY2hlRW5hYmxlZDogdHJ1 ZQogfQogCiBXZWJJbnNwZWN0b3IucG9wdWxhdGVBcHBsaWNhdGlvblNldHRpbmdzID0gZnVuY3Rp b24oc2V0dGluZ3NTdHJpbmcpCmRpZmYgLS1naXQgYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1l bmQvU3RvcmFnZVBhbmVsLmpzIGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1N0b3JhZ2VQ YW5lbC5qcwppbmRleCAyNzMzOTA3Li4wM2EwOTlmIDEwMDY0NAotLS0gYS9XZWJDb3JlL2luc3Bl Y3Rvci9mcm9udC1lbmQvU3RvcmFnZVBhbmVsLmpzCisrKyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zy b250LWVuZC9TdG9yYWdlUGFuZWwuanMKQEAgLTQ5LDkgKzQ5LDExIEBAIFdlYkluc3BlY3Rvci5T dG9yYWdlUGFuZWwgPSBmdW5jdGlvbihkYXRhYmFzZSkKICAgICB0aGlzLnNpZGViYXJUcmVlLmFw cGVuZENoaWxkKHRoaXMuY29va2llTGlzdFRyZWVFbGVtZW50KTsKICAgICB0aGlzLmNvb2tpZUxp c3RUcmVlRWxlbWVudC5leHBhbmQoKTsKIAotICAgIHRoaXMuYXBwbGljYXRpb25DYWNoZUxpc3RU cmVlRWxlbWVudCA9IG5ldyBXZWJJbnNwZWN0b3IuU2lkZWJhclNlY3Rpb25UcmVlRWxlbWVudChX ZWJJbnNwZWN0b3IuVUlTdHJpbmcoIkFQUExJQ0FUSU9OIENBQ0hFIiksIHt9LCB0cnVlKTsKLSAg ICB0aGlzLnNpZGViYXJUcmVlLmFwcGVuZENoaWxkKHRoaXMuYXBwbGljYXRpb25DYWNoZUxpc3RU cmVlRWxlbWVudCk7Ci0gICAgdGhpcy5hcHBsaWNhdGlvbkNhY2hlTGlzdFRyZWVFbGVtZW50LmV4 cGFuZCgpOworICAgIGlmIChQcmVmZXJlbmNlcy5hcHBDYWNoZUVuYWJsZWQpIHsKKyAgICAgICAg dGhpcy5hcHBsaWNhdGlvbkNhY2hlTGlzdFRyZWVFbGVtZW50ID0gbmV3IFdlYkluc3BlY3Rvci5T aWRlYmFyU2VjdGlvblRyZWVFbGVtZW50KFdlYkluc3BlY3Rvci5VSVN0cmluZygiQVBQTElDQVRJ T04gQ0FDSEUiKSwge30sIHRydWUpOworICAgICAgICB0aGlzLnNpZGViYXJUcmVlLmFwcGVuZENo aWxkKHRoaXMuYXBwbGljYXRpb25DYWNoZUxpc3RUcmVlRWxlbWVudCk7CisgICAgICAgIHRoaXMu YXBwbGljYXRpb25DYWNoZUxpc3RUcmVlRWxlbWVudC5leHBhbmQoKTsKKyAgICB9CiAKICAgICB0 aGlzLnN0b3JhZ2VWaWV3cyA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoImRpdiIpOwogICAgIHRo aXMuc3RvcmFnZVZpZXdzLmlkID0gInN0b3JhZ2Utdmlld3MiOwpAQCAtMTA4LDcgKzExMCw5IEBA IFdlYkluc3BlY3Rvci5TdG9yYWdlUGFuZWwucHJvdG90eXBlID0gewogICAgICAgICB0aGlzLmxv Y2FsU3RvcmFnZUxpc3RUcmVlRWxlbWVudC5yZW1vdmVDaGlsZHJlbigpOwogICAgICAgICB0aGlz LnNlc3Npb25TdG9yYWdlTGlzdFRyZWVFbGVtZW50LnJlbW92ZUNoaWxkcmVuKCk7CiAgICAgICAg IHRoaXMuY29va2llTGlzdFRyZWVFbGVtZW50LnJlbW92ZUNoaWxkcmVuKCk7Ci0gICAgICAgIHRo aXMuYXBwbGljYXRpb25DYWNoZUxpc3RUcmVlRWxlbWVudC5yZW1vdmVDaGlsZHJlbigpOworCisg ICAgICAgIGlmIChQcmVmZXJlbmNlcy5hcHBDYWNoZUVuYWJsZWQpCisgICAgICAgICAgICB0aGlz LmFwcGxpY2F0aW9uQ2FjaGVMaXN0VHJlZUVsZW1lbnQucmVtb3ZlQ2hpbGRyZW4oKTsKIAogICAg ICAgICB0aGlzLnN0b3JhZ2VWaWV3cy5yZW1vdmVDaGlsZHJlbigpOwogCkBAIC0xNDYsNiArMTUw LDggQEAgV2ViSW5zcGVjdG9yLlN0b3JhZ2VQYW5lbC5wcm90b3R5cGUgPSB7CiAKICAgICBhZGRB cHBsaWNhdGlvbkNhY2hlOiBmdW5jdGlvbihkb21haW4pCiAgICAgeworICAgICAgICBpZiAoIVBy ZWZlcmVuY2VzLmFwcENhY2hlRW5hYmxlZCkKKyAgICAgICAgICAgIHJldHVybjsKICAgICAgICAg dmFyIGFwcGxpY2F0aW9uQ2FjaGVUcmVlRWxlbWVudCA9IG5ldyBXZWJJbnNwZWN0b3IuQXBwbGlj YXRpb25DYWNoZVNpZGViYXJUcmVlRWxlbWVudChkb21haW4pOwogICAgICAgICB0aGlzLmFwcGxp Y2F0aW9uQ2FjaGVMaXN0VHJlZUVsZW1lbnQuYXBwZW5kQ2hpbGQoYXBwbGljYXRpb25DYWNoZVRy ZWVFbGVtZW50KTsKICAgICB9LApkaWZmIC0tZ2l0IGEvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxv ZyBiL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXggZjI1OGMyYS4uODM0NzhlNCAxMDA2 NDQKLS0tIGEvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZworKysgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDctMTYgIFBhdmVsIEZlbGRtYW4gIDxw ZmVsZG1hbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogZGlzYWJsZSBBcHBDYWNoZSBpbiBjaHJvbWl1 bS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDE4 NTgKKworICAgICAgICAqIHNyYy9qcy9EZXZUb29scy5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rv ci5sb2FkZWQpOgorCiAyMDEwLTA3LTE2ICBNaWtoYWlsIE5hZ2Fub3YgIDxtbmFnYW5vdkBjaHJv bWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgUGF2ZWwgRmVsZG1hbi4KZGlmZiAtLWdp dCBhL1dlYktpdC9jaHJvbWl1bS9zcmMvanMvRGV2VG9vbHMuanMgYi9XZWJLaXQvY2hyb21pdW0v c3JjL2pzL0RldlRvb2xzLmpzCmluZGV4IGY0NTMwOTQuLjM1Y2NhMmYgMTAwNjQ0Ci0tLSBhL1dl YktpdC9jaHJvbWl1bS9zcmMvanMvRGV2VG9vbHMuanMKKysrIGIvV2ViS2l0L2Nocm9taXVtL3Ny Yy9qcy9EZXZUb29scy5qcwpAQCAtMTQzLDYgKzE0Myw3IEBAIFdlYkluc3BlY3Rvci5sb2FkZWQg PSBmdW5jdGlvbigpCiAgICAgUHJlZmVyZW5jZXMuZGVidWdnZXJBbHdheXNFbmFibGVkID0gdHJ1 ZTsKICAgICBQcmVmZXJlbmNlcy5wcm9maWxlckFsd2F5c0VuYWJsZWQgPSB0cnVlOwogICAgIFBy ZWZlcmVuY2VzLmNhbkVkaXRTY3JpcHRTb3VyY2UgPSB0cnVlOworICAgIFByZWZlcmVuY2VzLmFw cENhY2hlRW5hYmxlZCA9IGZhbHNlOwogCiAgICAgb2xkTG9hZGVkLmNhbGwodGhpcyk7CiAK