41830 2010-07-07 20:49:24 -0700 [EFL] fix cmake build for EWebLauncher 2010-07-08 22:42:50 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 joone webkit-unassigned antognolli+webkit commit-queue gyuyoung.kim leandro lucas.de.marchi oldest_to_newest 247978 0 joone 2010-07-07 20:49:24 -0700 -- Generating done -- Build files have been written to: /home/joone/git/WebKit/WebKitBuild/Debug_Efl [ 2%] Built target wtf [ 9%] Built target javascriptcore [ 9%] Built target jsc [100%] Built target webcore [100%] Built target ewebkit Linking CXX executable ../Programs/EWebLauncher libewebkit.so: undefined reference to `soup_message_get_first_party' libewebkit.so: undefined reference to `soup_message_set_first_party' libewebkit.so: undefined reference to `soup_session_prepare_for_uri' libewebkit.so: undefined reference to `soup_cookie_jar_set_accept_policy' libewebkit.so: undefined reference to `soup_cookie_jar_set_cookie_with_first_party' collect2: ld returned 1 exit status make[2]: *** [WebKit/../Programs/EWebLauncher] Error 1 make[1]: *** [WebKit/CMakeFiles/../Programs/EWebLauncher.dir/all] Error 2 make: *** [all] Error Building EWebLauncher has a link error. 247986 1 60833 joone 2010-07-07 21:21:21 -0700 Created attachment 60833 Proposed patch CMakeListsEfl.txt: add ${LIBSOUP24_LDFLAGS} for link flags 247988 2 lucas.de.marchi 2010-07-07 21:31:41 -0700 (In reply to comment #1) > Created an attachment (id=60833) [details] > Proposed patch > > CMakeListsEfl.txt: add ${LIBSOUP24_LDFLAGS} for link flags This was a recent change to fix cross compile on some environments. I'm CC'ing who did this. 248199 3 antognolli+webkit 2010-07-08 08:00:21 -0700 The patch is correct. I didn't notice this because my other patch in bug 41770 also includes this fix. But this one should get in first, then I'll update that one. 248678 4 60833 tonikitoo 2010-07-08 19:05:15 -0700 Comment on attachment 60833 Proposed patch Ok. 248746 5 60833 commit-queue 2010-07-08 22:42:45 -0700 Comment on attachment 60833 Proposed patch Clearing flags on attachment: 60833 Committed r62895: <http://trac.webkit.org/changeset/62895> 248747 6 commit-queue 2010-07-08 22:42:50 -0700 All reviewed patches have been landed. Closing bug. 60833 2010-07-07 21:21:21 -0700 2010-07-08 22:42:45 -0700 Proposed patch patch.diff text/plain 854 joone ZGlmZiAtLWdpdCBhL1dlYktpdC9DaGFuZ2VMb2cgYi9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDEx N2YwNjguLjhiN2EzYzUgMTAwNjQ0Ci0tLSBhL1dlYktpdC9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0 L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDEwLTA3LTA3ICBKb29uZSBIdXIgIDxqb29u ZUBrbGRwLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBbRUZMXSBmaXggY21ha2UgYnVpbGQgZm9yIEVXZWJMYXVuY2hlcgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDE4MzAKKworICAgICAgICAqIENN YWtlTGlzdHNFZmwudHh0OiBhZGQgJHtMSUJTT1VQMjRfTERGTEFHU30gZm9yIGxpbmsgZmxhZ3MK KwogMjAxMC0wNy0wNyAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCiAg ICAgICAgIFJldmlld2VkIGJ5IFNhbSBXZWluaWcuCgpkaWZmIC0tZ2l0IGEvV2ViS2l0L0NNYWtl TGlzdHNFZmwudHh0IGIvV2ViS2l0L0NNYWtlTGlzdHNFZmwudHh0CmluZGV4IDg2ZDAzMjcuLjJm Yzk2NGIgMTAwNjQ0Ci0tLSBhL1dlYktpdC9DTWFrZUxpc3RzRWZsLnR4dAorKysgYi9XZWJLaXQv Q01ha2VMaXN0c0VmbC50eHQKQEAgLTkwLDYgKzkwLDcgQEAgU0VUKEVXZWJMYXVuY2hlcl9MSU5L X0ZMQUdTCiAgICAgJHtFREpFX0xERkxBR1N9CiAgICAgJHtFRkxERVBTX0xERkxBR1N9CiAgICAg JHtFVkFTX0xERkxBR1N9CisgICAgJHtMSUJTT1VQMjRfTERGTEFHU30KICkKIAogQUREX0VYRUNV VEFCTEUoLi4vUHJvZ3JhbXMvRVdlYkxhdW5jaGVyICR7RVdlYkxhdW5jaGVyX1NPVVJDRVN9KQo=